pub_sub_model_sync 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec006984fe2bf9c33e9992facdd25aa9fdaa3494b6bcaf656592593829429017
-  data.tar.gz: 8ca60de929eb7465c95ff819682af73a9094c60294661e5c823394aeb02ed6a9
+  metadata.gz: 86dd60cd72d095630d44b3d1d6bb0004f0d7ce35326f5613127815047376530a
+  data.tar.gz: ef7c8edd08a315adcbad4a4314a467e1564a8dcc2233764ef53d09985a41eaf3
 SHA512:
-  metadata.gz: d799e1e27c071e18d5d7e15460a7d481b9991b469599356e23c86669fd8de95046b236d4596a5fbc22e93d278548d2b17255262e4f5c67eece7a4f6898ff03ca
-  data.tar.gz: 89f6e95f040919994a0f0397b61b09ac83567b69472ce41aa722b240dba66e8a66d4e7a60cedb0de5f59d671525c4d7ad38b02255e558728f8e34e71e227e1e1
+  metadata.gz: 690ca42fe8d463cabdaa4e0e557ee1fa19ffa0e1c9a4ad19ee1a1195a7a78faab458ebcd0b0581c39b917ac73c9dc01f408bf1c9ae7f25445b7d20afba2592fe
+  data.tar.gz: 72d3e0a10a8879f670e65a6f50dbc71e0351893ac1b57dc6fe1796373f7a38d55ecc7a6508c86eba7256dab03c903a42b59f9a0b7a881f6c4c28086b59584049

data/CHANGELOG.md

@@ -1,10 +1,13 @@
 # Change Log
 
+# 1.2.1 (October 28, 2021)
+chore: improve logs
+
 # 1.2.0 (October 28, 2021)
 - feat: rename Payload `:key` into `:internal_key` to avoid confusions while debugging
 
 # 1.1.1 (October 25, 2021)
-- feat: include `ordering_key topic_name` when delivering a notification for debugging purposes
+- feat: do not exclude `ordering_key topic_name` when delivering a notification (required when debugging)
 - doc: improve docs
 
 # 1.1.0 (October 25, 2021)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pub_sub_model_sync (1.2.0)
+    pub_sub_model_sync (1.2.1)
       rails
 
 GEM

data/README.md

@@ -557,6 +557,7 @@ config.debug = true
     Note2: Only notifications from the buffer can be rollbacked if the current transaction has failed.     
 
 ## **TODO**
+- add the ability to raise SKIP_ACKNOWLEDGE to auto retry by PubSub
 - Auto publish update only if payload has changed (see ways to compare previous payload vs new payload)
 - Improve transactions to exclude similar notifications by klass and action. Sample:
     ```PubSubModelSync::MessagePublisher.transaction(key, { same_keys: :use_last_as_first|:use_last|:use_first_as_last|:keep*, same_data: :use_last_as_first*|:use_last|:use_first_as_last|:keep })```
@@ -568,6 +569,7 @@ config.debug = true
 - Add if/unless to ps_after_action
 - Add subscription liveness checker using thread without db connection to check periodically pending notifications from google pubsub
 - Unify .stop() and 'Listener stopped' 
+- TODO: Publish new version 1.2.1 (improve logs)
 
 ## **Q&A**
 - I'm getting error "could not obtain a connection from the pool within 5.000 seconds"... what does this mean?

data/lib/pub_sub_model_sync/service_google.rb

@@ -77,7 +77,7 @@ module PubSubModelSync
       }.merge(PUBLISH_SETTINGS)
     end
 
-    # @return [Subscriber]
+    # @return [Array<Subscriber>]
     def subscribe_to_topics
       topics.map do |key, topic|
         subs_name = "#{config.subscription_key}_#{key}"

data/lib/pub_sub_model_sync/transaction.rb

@@ -19,10 +19,11 @@ module PubSubModelSync
     # @param payload (Payload)
     def add_payload(payload)
       payloads << payload
-      log("Payload added to current transaction: #{payload.inspect}") if config.debug
+      print_log = config.debug && max_buffer > 1
+      log("Payload added to current transaction: #{payload.inspect}") if print_log
       return unless payloads.count >= max_buffer
 
-      log("Payloads buffer was filled, delivering current payloads: #{payloads.count}")
+      log("Payloads buffer was filled, delivering current payloads: #{payloads.count}") if print_log
       deliver_payloads
     end
 
@@ -60,14 +61,14 @@ module PubSubModelSync
     private
 
     def deliver_payloads
-      payloads.each do |payload|
-        begin # rubocop:disable Style/RedundantBegin (ruby 2.4 support)
-          PUBLISHER_KLASS.connector_publish(payload)
-        rescue => e
-          PUBLISHER_KLASS.send(:notify_error, e, payload)
-        end
-      end
+      payloads.each(&method(:deliver_payload))
       self.payloads = []
     end
+
+    def deliver_payload(payload)
+      PUBLISHER_KLASS.connector_publish(payload)
+    rescue => e
+      PUBLISHER_KLASS.send(:notify_error, e, payload)
+    end
   end
 end

data/lib/pub_sub_model_sync/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PubSubModelSync
-  VERSION = '1.2.0'
+  VERSION = '1.2.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pub_sub_model_sync
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Owen