RubyGems - pt-osc - Versions diffs - 0.0.1 - Mend

pt-osc 0.0.1

Files changed (50) hide show

data/.gitignore +22 -0
data/Gemfile +4 -0
data/README.md +35 -0
data/Rakefile +20 -0
data/lib/active_record/connection_adapters/pt_osc_adapter.rb +134 -0
data/lib/active_record/pt_osc_migration.rb +150 -0
data/lib/pt-osc.rb +3 -0
data/lib/pt-osc/version.rb +5 -0
data/pt-osc.gemspec +32 -0
data/test/config/database.yml +6 -0
data/test/dummy/.gitignore +1 -0
data/test/dummy/README.rdoc +261 -0
data/test/dummy/Rakefile +7 -0
data/test/dummy/app/assets/javascripts/application.js +15 -0
data/test/dummy/app/assets/stylesheets/application.css +13 -0
data/test/dummy/app/controllers/application_controller.rb +3 -0
data/test/dummy/app/helpers/application_helper.rb +2 -0
data/test/dummy/app/mailers/.gitkeep +0 -0
data/test/dummy/app/models/.gitkeep +0 -0
data/test/dummy/app/views/layouts/application.html.erb +14 -0
data/test/dummy/config.ru +4 -0
data/test/dummy/config/application.rb +59 -0
data/test/dummy/config/boot.rb +10 -0
data/test/dummy/config/database.yml +16 -0
data/test/dummy/config/environment.rb +5 -0
data/test/dummy/config/environments/development.rb +37 -0
data/test/dummy/config/environments/production.rb +67 -0
data/test/dummy/config/environments/test.rb +37 -0
data/test/dummy/config/initializers/backtrace_silencers.rb +7 -0
data/test/dummy/config/initializers/inflections.rb +15 -0
data/test/dummy/config/initializers/mime_types.rb +5 -0
data/test/dummy/config/initializers/secret_token.rb +7 -0
data/test/dummy/config/initializers/session_store.rb +8 -0
data/test/dummy/config/initializers/wrap_parameters.rb +14 -0
data/test/dummy/config/locales/en.yml +5 -0
data/test/dummy/config/routes.rb +58 -0
data/test/dummy/db/development.sqlite3 +0 -0
data/test/dummy/db/test.sqlite3 +0 -0
data/test/dummy/lib/assets/.gitkeep +0 -0
data/test/dummy/public/404.html +26 -0
data/test/dummy/public/422.html +26 -0
data/test/dummy/public/500.html +25 -0
data/test/dummy/public/favicon.ico +0 -0
data/test/dummy/script/rails +6 -0
data/test/functional/pt_osc_adapter_test.rb +16 -0
data/test/functional/pt_osc_migration_functional_test.rb +99 -0
data/test/test_helper.rb +49 -0
data/test/unit/pt_osc_adapter_test.rb +209 -0
data/test/unit/pt_osc_migration_unit_test.rb +39 -0
metadata +281 -0

data/test/dummy/db/development.sqlite3 ADDED

File without changes

data/test/dummy/db/test.sqlite3 ADDED

File without changes

data/test/dummy/lib/assets/.gitkeep ADDED

File without changes

data/test/dummy/public/404.html ADDED

@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>The page you were looking for doesn't exist (404)</title>
+  <style type="text/css">
+    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
+    div.dialog {
+      width: 25em;
+      padding: 0 4em;
+      margin: 4em auto 0 auto;
+      border: 1px solid #ccc;
+      border-right-color: #999;
+      border-bottom-color: #999;
+    }
+    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  </style>
+</head>
+<body>
+  <!-- This file lives in public/404.html -->
+  <div class="dialog">
+    <h1>The page you were looking for doesn't exist.</h1>
+    <p>You may have mistyped the address or the page may have moved.</p>
+  </div>
+</body>
+</html>

data/test/dummy/public/422.html ADDED

@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>The change you wanted was rejected (422)</title>
+  <style type="text/css">
+    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
+    div.dialog {
+      width: 25em;
+      padding: 0 4em;
+      margin: 4em auto 0 auto;
+      border: 1px solid #ccc;
+      border-right-color: #999;
+      border-bottom-color: #999;
+    }
+    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  </style>
+</head>
+<body>
+  <!-- This file lives in public/422.html -->
+  <div class="dialog">
+    <h1>The change you wanted was rejected.</h1>
+    <p>Maybe you tried to change something you didn't have access to.</p>
+  </div>
+</body>
+</html>

data/test/dummy/public/500.html ADDED

@@ -0,0 +1,25 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>We're sorry, but something went wrong (500)</title>
+  <style type="text/css">
+    body { background-color: #fff; color: #666; text-align: center; font-family: arial, sans-serif; }
+    div.dialog {
+      width: 25em;
+      padding: 0 4em;
+      margin: 4em auto 0 auto;
+      border: 1px solid #ccc;
+      border-right-color: #999;
+      border-bottom-color: #999;
+    }
+    h1 { font-size: 100%; color: #f00; line-height: 1.5em; }
+  </style>
+</head>
+<body>
+  <!-- This file lives in public/500.html -->
+  <div class="dialog">
+    <h1>We're sorry, but something went wrong.</h1>
+  </div>
+</body>
+</html>

data/test/dummy/public/favicon.ico ADDED

File without changes

data/test/dummy/script/rails ADDED

@@ -0,0 +1,6 @@
+#!/usr/bin/env ruby
+# This command will automatically be run when you run "rails" with Rails 3 gems installed from the root of your application.
+APP_PATH = File.expand_path('../../config/application',  __FILE__)
+require File.expand_path('../../config/boot',  __FILE__)
+require 'rails/commands'

data/test/functional/pt_osc_adapter_test.rb ADDED

@@ -0,0 +1,16 @@
+require 'test_helper'
+require 'yaml'
+class PtOscAdapterTest < Test::Unit::TestCase
+  class TestConnection < ActiveRecord::Base; end
+  def test_connection
+    # Test that we can open a connection with the pt_osc adapter
+    spec = test_spec
+    spec.delete('database') # We don't care whether the database exists
+    assert_nothing_raised { TestConnection.establish_connection(spec) }
+    assert_equal true, TestConnection.connection.in_use
+    assert_kind_of ActiveRecord::ConnectionAdapters::PtOscAdapter, TestConnection.connection
+  end
+end

data/test/functional/pt_osc_migration_functional_test.rb ADDED

@@ -0,0 +1,99 @@
+require 'test_helper'
+class PtOscMigrationFunctionalTest < ActiveRecord::TestCase
+  class TestMigration < ActiveRecord::PtOscMigration; end
+  context 'a migration connected to a pt-osc database' do
+    setup do
+      ActiveRecord::Base.establish_connection(test_spec)
+      @migration = TestMigration.new
+      @migration.instance_variable_set(:@connection, ActiveRecord::Base.connection)
+    end
+    context 'on an existing table with an existing column' do
+      setup do
+        @table_name = Faker::Lorem.word
+        @column_name = Faker::Lorem.word
+        @index_name = Faker::Lorem.words.join('_')
+        @index_name_2 = "#{@index_name}_2"
+        ActiveRecord::Base.connection.execute "DROP TABLE IF EXISTS `#{@table_name}`;"
+        ActiveRecord::Base.connection.execute <<-SQL
+          CREATE TABLE `#{@table_name}` (
+            `#{@column_name}` varchar(255) DEFAULT NULL,
+            KEY `#{@index_name}` (`#{@column_name}`)
+          );
+        SQL
+      end
+      teardown do
+        ActiveRecord::Base.connection.execute "DROP TABLE IF EXISTS `#{@table_name}`;"
+      end
+      context 'a migration with only ALTER statements' do
+        setup do
+          TestMigration.class_eval <<-EVAL
+            def change
+              rename_table  :#{@table_name}, :#{Faker::Lorem.word}
+              add_column    :#{@table_name}, :#{Faker::Lorem.word}, :integer
+              change_column :#{@table_name}, :#{@column_name}, :varchar, default: 'newthing'
+              rename_column :#{@table_name}, :#{@column_name}, :#{Faker::Lorem.word}
+              remove_column :#{@table_name}, :#{@column_name}
+              add_index     :#{@table_name}, :#{@column_name}, name: :#{@index_name_2}
+              remove_index  :#{@table_name}, name: :#{@index_name}
+            end
+          EVAL
+        end
+        teardown do
+          TestMigration.send(:remove_method, :change)
+        end
+        context 'ignoring schema lookups' do
+          setup do
+            # Kind of a hacky way to do this
+            ignored_sql = ActiveRecord::SQLCounter.ignored_sql + [
+              /^SHOW FULL FIELDS FROM/,
+              /^SHOW COLUMNS FROM/,
+              /^SHOW KEYS FROM/,
+            ]
+            ActiveRecord::SQLCounter.any_instance.stubs(:ignore).returns(ignored_sql)
+          end
+          teardown do
+            ActiveRecord::SQLCounter.any_instance.unstub(:ignore)
+          end
+          context 'with suppressed output' do
+            setup do
+              @migration.stubs(:write)
+              @migration.stubs(:announce)
+            end
+            teardown do
+              @migration.unstub(:write, :announce)
+            end
+            should 'not execute any queries immediately' do
+              assert_no_queries { @migration.change }
+            end
+            context 'with a working pt-online-schema-change' do
+              setup do
+                Kernel.expects(:system).with(regexp_matches(/^pt-online-schema-change/)).twice.returns(true)
+              end
+              teardown do
+                Kernel.unstub(:system)
+              end
+              should 'not directly execute any queries when migrating' do
+                assert_no_queries { @migration.migrate(:up) }
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/test/test_helper.rb ADDED

@@ -0,0 +1,49 @@
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
+require File.expand_path('../dummy/config/environment.rb',  __FILE__)
+require 'test/unit'
+require 'shoulda'
+require 'faker'
+require 'mocha'
+Rails.backtrace_cleaner.remove_silencers!
+def test_spec
+  test_spec = YAML.load_file(Rails.root.join(*%w(.. config database.yml)))['test']
+  test_spec['adapter'] = 'pt_osc'
+  test_spec
+end
+# SQLCounter is part of ActiveRecord but is not distributed with the gem (used for internal tests only)
+# see https://github.com/rails/rails/blob/3-2-stable/activerecord/test/cases/helper.rb#L59
+module ActiveRecord
+  class SQLCounter
+    cattr_accessor :ignored_sql
+    self.ignored_sql = [/^PRAGMA (?!(table_info))/, /^SELECT currval/, /^SELECT CAST/, /^SELECT @@IDENTITY/, /^SELECT @@ROWCOUNT/, /^SAVEPOINT/, /^ROLLBACK TO SAVEPOINT/, /^RELEASE SAVEPOINT/, /^SHOW max_identifier_length/, /^BEGIN/, /^COMMIT/]
+    # FIXME: this needs to be refactored so specific database can add their own
+    # ignored SQL.  This ignored SQL is for Oracle.
+    ignored_sql.concat [/^select .*nextval/i, /^SAVEPOINT/, /^ROLLBACK TO/, /^\s*select .* from all_triggers/im]
+    cattr_accessor :log
+    self.log = []
+    attr_reader :ignore
+    def initialize(ignore = self.class.ignored_sql)
+      @ignore   = ignore
+    end
+    def call(name, start, finish, message_id, values)
+      sql = values[:sql]
+      # FIXME: this seems bad. we should probably have a better way to indicate
+      # the query was cached
+      return if 'CACHE' == values[:name] || ignore.any? { |x| x =~ sql }
+      self.class.log << sql
+    end
+  end
+  ActiveSupport::Notifications.subscribe('sql.active_record', SQLCounter.new)
+end

data/test/unit/pt_osc_adapter_test.rb ADDED

@@ -0,0 +1,209 @@
+require 'test_helper'
+class PtOscAdapterTest < Test::Unit::TestCase
+  class TestConnection < ActiveRecord::Base; end
+  context 'a pt-osc adapter' do
+    setup do
+      TestConnection.establish_connection(test_spec)
+      @adapter = TestConnection.connection
+    end
+    context '#rename_table' do
+      context 'with no existing commands' do
+        setup do
+          @adapter.instance_variable_set(:@osc_commands, nil)
+        end
+        should 'add a RENAME TO command to the commands hash' do
+          table_name = Faker::Lorem.word
+          new_table_name = Faker::Lorem.word
+          @adapter.rename_table(table_name, new_table_name)
+          assert_equal "RENAME TO `#{new_table_name}`", @adapter.send(:get_commands, table_name).first
+        end
+      end
+    end
+    context '#add_column' do
+      context 'with no existing commands' do
+        setup do
+          @adapter.instance_variable_set(:@osc_commands, nil)
+        end
+        should 'add an ADD command to the commands hash' do
+          table_name = Faker::Lorem.word
+          column_name = Faker::Lorem.word
+          @adapter.add_column(table_name, column_name, :string, default: 0, null: false)
+          assert_equal "ADD `#{column_name}` varchar(255) DEFAULT 0 NOT NULL", @adapter.send(:get_commands, table_name).first
+        end
+      end
+    end
+    context '#change_column' do
+      context 'with no existing commands' do
+        setup do
+          @adapter.instance_variable_set(:@osc_commands, nil)
+        end
+        context 'with an existing table and column' do
+          setup do
+            @table_name = Faker::Lorem.word
+            @column_name = Faker::Lorem.word
+            @adapter.create_table @table_name, force: true do |t|
+              t.string @column_name
+            end
+          end
+          should 'add a CHANGE command to the commands hash' do
+            @adapter.change_column(@table_name, @column_name, :string, default: 0, null: false)
+            assert_equal "CHANGE `#{@column_name}` `#{@column_name}` varchar(255) DEFAULT 0 NOT NULL", @adapter.send(:get_commands, @table_name).first
+          end
+        end
+      end
+    end
+    context '#rename_column' do
+      context 'with no existing commands' do
+        setup do
+          @adapter.instance_variable_set(:@osc_commands, nil)
+        end
+        context 'with an existing table and column' do
+          setup do
+            @table_name = Faker::Lorem.word
+            @column_name = Faker::Lorem.word
+            @adapter.create_table @table_name, force: true do |t|
+              t.string @column_name, default: nil
+            end
+          end
+          should 'add a CHANGE command to the commands hash' do
+            new_column_name = Faker::Lorem.word
+            @adapter.rename_column(@table_name, @column_name, new_column_name)
+            assert_equal "CHANGE `#{@column_name}` `#{new_column_name}` varchar(255) DEFAULT NULL", @adapter.send(:get_commands, @table_name).first
+          end
+        end
+      end
+    end
+    context '#remove_column' do
+      context 'with no existing commands' do
+        setup do
+          @adapter.instance_variable_set(:@osc_commands, nil)
+        end
+        should 'add a DROP COLUMN command to the commands hash' do
+          table_name = Faker::Lorem.word
+          column_name = Faker::Lorem.word
+          @adapter.remove_column(table_name, column_name)
+          assert_equal "DROP COLUMN `#{column_name}`", @adapter.send(:get_commands, table_name).first
+        end
+        should 'add multiple DROP COLUMN commands to the commands hash' do
+          table_name = Faker::Lorem.word
+          column_names = 3.times.map { Faker::Lorem.word }
+          @adapter.remove_column(table_name, *column_names)
+          commands = @adapter.send(:get_commands, table_name)
+          column_names.each_with_index do |column_name, index|
+            assert_equal "DROP COLUMN `#{column_name}`", commands[index]
+          end
+        end
+      end
+    end
+    context '#add_index' do
+      context 'with no existing commands' do
+        setup do
+          @adapter.instance_variable_set(:@osc_commands, nil)
+        end
+        context 'with an existing table and columns' do
+          setup do
+            @table_name = Faker::Lorem.word
+            @column_names = Faker::Lorem.words
+            @adapter.create_table @table_name, force: true do |t|
+              @column_names.each do |column_name|
+                t.string(column_name, default: nil)
+              end
+            end
+          end
+          should 'add an ADD INDEX command for one column to the commands hash' do
+            index_name = Faker::Lorem.words.join('_')
+            @adapter.add_index(@table_name, @column_names.first, name: index_name)
+            assert_equal "ADD  INDEX `#{index_name}` (`#{@column_names.first}`)", @adapter.send(:get_commands, @table_name).first
+          end
+          should 'add an ADD UNIQUE INDEX command for one column to the commands hash' do
+            index_name = Faker::Lorem.words.join('_')
+            @adapter.add_index(@table_name, @column_names.first, unique: true, name: index_name)
+            assert_equal "ADD UNIQUE INDEX `#{index_name}` (`#{@column_names.first}`)", @adapter.send(:get_commands, @table_name).first
+          end
+          should 'add an ADD INDEX command for multiple columns to the commands hash' do
+            index_name = Faker::Lorem.words.join('_')
+            @adapter.add_index(@table_name, @column_names, name: index_name)
+            assert_equal "ADD  INDEX `#{index_name}` (`#{@column_names.join('`, `')}`)", @adapter.send(:get_commands, @table_name).first
+          end
+        end
+      end
+    end
+    context '#remove_index!' do
+      context 'with no existing commands' do
+        setup do
+          @adapter.instance_variable_set(:@osc_commands, nil)
+        end
+        should 'add a DROP COLUMN command to the commands hash' do
+          table_name = Faker::Lorem.word
+          index_name = Faker::Lorem.word
+          @adapter.remove_index!(table_name, index_name)
+          assert_equal "DROP INDEX `#{index_name}`", @adapter.send(:get_commands, table_name).first
+        end
+      end
+    end
+    context '#add_command' do
+      context 'with no existing commands' do
+        setup do
+          @adapter.instance_variable_set(:@osc_commands, nil)
+        end
+        should 'add a command without initializing the array' do
+          table_name = Faker::Lorem.word
+          @adapter.send(:add_command, table_name, 'foo')
+          assert_kind_of Array, @adapter.send(:get_commands, table_name)
+          assert_equal 1, @adapter.send(:get_commands, table_name).size
+          assert_equal 'foo', @adapter.send(:get_commands, table_name).first
+        end
+      end
+    end
+    context '#get_commands' do
+      context 'with no existing commands' do
+        setup do
+          @adapter.instance_variable_set(:@osc_commands, nil)
+        end
+        should "return nil for a table that doesn't exist" do
+          table_name = Faker::Lorem.word
+          assert_nil @adapter.send(:get_commands, table_name)
+        end
+      end
+    end
+    context '#get_commands_string' do
+      context 'with no existing commands' do
+        setup do
+          @adapter.instance_variable_set(:@osc_commands, nil)
+        end
+        should "return an empty string for a table that doesn't exist" do
+          table_name = Faker::Lorem.word
+          assert_equal '', @adapter.send(:get_commands_string, table_name)
+        end
+      end
+    end
+  end
+end