psu_identity 0.1.2 → 0.2.0

data/lib/{penn_state → psu_identity}/search_service/person.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module PennState::SearchService
+module PsuIdentity::SearchService
   class Person
     attr_reader :data
 
@@ -55,7 +55,7 @@ module PennState::SearchService
     end
 
     def active?
-      data['active'] == 'true'
+      data['active'].is_a?(TrueClass) || data['active'] == 'true'
     end
 
     def conf_hold?

data/lib/psu_identity/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PsuIdentity
-  VERSION = "0.1.0"
+  VERSION = '0.2.0'
 end

data/lib/psu_identity.rb

@@ -1,7 +1,14 @@
-require "psu_identity/version"
+# frozen_string_literal: true
+
+require 'faraday'
+require 'json'
+require 'ostruct'
 
 module PsuIdentity
   class Error < StandardError; end
 
-  require 'penn_state'
+  require 'psu_identity/search_service/atomic_link'
+  require 'psu_identity/search_service/client'
+  require 'psu_identity/search_service/person'
+  require 'psu_identity/version'
 end

data/psu_identity.gemspec

@@ -1,23 +1,39 @@
+# frozen_string_literal: true
+
 require_relative 'lib/psu_identity/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "psu_identity"
-  spec.version       = "0.1.2"
-  spec.authors       = ["Alex Kiessling"]
-  spec.email         = ["ajkiessl@gmail.com"]
+  spec.name          = 'psu_identity'
+  spec.version       = PsuIdentity::VERSION
+  spec.authors       = ['Alex Kiessling']
+  spec.email         = ['ajkiessl@gmail.com']
 
-  spec.summary       = %q{Gem for interfacing with psu's search-service}
-  spec.description   = %q{Gem for interfacing with psu's search-service}
+  spec.summary       = "Gem for interfacing with psu's search-service"
+  spec.description   = "Gem for interfacing with psu's search-service"
   spec.homepage      = 'https://github.com/psu-libraries/psu_identity'
-  spec.license       = "MIT"
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
+  spec.license       = 'MIT'
+  spec.required_ruby_version = Gem::Requirement.new('>= 2.6.3')
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
+
+  spec.add_dependency 'faraday', '~> 1.0'
+  spec.add_dependency 'json'
+  spec.add_dependency 'rake', '>= 12.0'
+
+  spec.add_development_dependency 'pry-byebug'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rspec-its'
+  spec.add_development_dependency 'rubocop', '~> 1.22'
+  spec.add_development_dependency 'rubocop-performance', '~> 1.11'
+  spec.add_development_dependency 'rubocop-rspec', '~> 2.5'
+  spec.add_development_dependency 'simplecov', '=0.17'
+  spec.add_development_dependency 'vcr'
+  spec.add_development_dependency 'webmock'
 end

metadata

@@ -1,15 +1,183 @@
 --- !ruby/object:Gem::Specification
 name: psu_identity
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Alex Kiessling
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-06-04 00:00:00.000000000 Z
-dependencies: []
+date: 2021-10-21 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: faraday
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: json
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '12.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '12.0'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.22'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.22'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.11'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.11'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: '0.17'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: '0.17'
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Gem for interfacing with psu's search-service
 email:
 - ajkiessl@gmail.com
@@ -19,7 +187,17 @@ extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".gitignore"
+- ".niftany/layout.yml"
+- ".niftany/lint.yml"
+- ".niftany/metrics.yml"
+- ".niftany/naming.yml"
+- ".niftany/niftany_rubocop_rspec.yml"
+- ".niftany/performance.yml"
+- ".niftany/style.yml"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".ruby-version"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
@@ -28,19 +206,17 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
-- lib/penn_state.rb
-- lib/penn_state/search_service.rb
-- lib/penn_state/search_service/atomic_link.rb
-- lib/penn_state/search_service/client.rb
-- lib/penn_state/search_service/person.rb
 - lib/psu_identity.rb
+- lib/psu_identity/search_service/atomic_link.rb
+- lib/psu_identity/search_service/client.rb
+- lib/psu_identity/search_service/person.rb
 - lib/psu_identity/version.rb
 - psu_identity.gemspec
 homepage: https://github.com/psu-libraries/psu_identity
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -48,15 +224,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.6.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.2.28
+signing_key:
 specification_version: 4
 summary: Gem for interfacing with psu's search-service
 test_files: []

data/lib/penn_state/search_service/client.rb

@@ -1,60 +0,0 @@
-# frozen_string_literal: true
-require 'faraday'
-require 'json'
-
-# @abstract Client for querying Penn State's identity API: https://identity.apps.psu.edu/search-service/resources
-module PennState::SearchService
-  class Client
-    class Error < StandardError; end
-
-    attr_reader :base_url
-
-    # @param [String] base_url
-    def initialize(base_url: '/search-service/resources')
-      @base_url = base_url
-    end
-
-    # @param [Hash] args of options to pass to the endpoint
-    # @option args [String] :text to search for
-    def search(**args)
-      process_response connection.get("#{base_url}/people", args)
-    end
-
-    # @param [Hash] args of options to pass to the endpoint
-    # @option args [String] :userid of the person
-    def userid(userid)
-      process_userid_response connection.get("#{base_url}/people/userid/#{userid}")
-    end
-
-    private
-
-    # @return Array<PennState::SearchService::Person>
-    def process_response(response)
-      raise Error.new(response.body) unless response.success?
-
-      JSON.parse(response.body).map { |result| Person.new(result) }
-    rescue JSON::ParserError
-      []
-    end
-
-    # @return [PennState::SearchService::Person, nil]
-    def process_userid_response(response)
-      return if response.status == 404
-
-      raise Error.new(response.body) unless response.success?
-
-      Person.new(JSON.parse(response.body))
-    rescue JSON::ParserError
-    end
-
-    def connection
-      @connection ||= Faraday.new(url: endpoint) do |conn|
-        conn.adapter :net_http
-      end
-    end
-
-    def endpoint
-      @endpoint ||= ENV.fetch('IDENTITY_ENDPOINT', 'https://identity.apps.psu.edu')
-    end
-  end
-end

data/lib/penn_state/search_service.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-require 'penn_state'
-
-module PennState::SearchService
-  require 'penn_state/search_service/client'
-  require 'penn_state/search_service/person'
-  require 'penn_state/search_service/atomic_link'
-end

data/lib/penn_state.rb

@@ -1,4 +0,0 @@
-# frozen_string_literal: true
-
-module PennState
-end