pry 0.14.1 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d3d394fb61f0a41511177954f810a8aa4ab0c390baa89e538878121806a28c08
-  data.tar.gz: d36e350eb1e8ff448e088dab7233f6c9f28849f6ae94d3eed0b9ad4768ade770
+  metadata.gz: e614551c579377a965416df68c4e2a90f0e0e6731d78010f7a570d4b730cfb2a
+  data.tar.gz: 86ed82a2dc55f826d38ae2a20f22929dbbf11b7f5d79dcfc0740a20f6779ca01
 SHA512:
-  metadata.gz: fe3608e5e7046c474a6e8b077dded9bfc091bfdeaa44d178bb69e66bbeaafaca2a3447fac31dd6d5d5bab8ecc10cbb2e2de327f3c4f55393d4024a45f6407b55
-  data.tar.gz: 1596aef2f91334198c2705f79fa6c93e324cd89071a1f6c04c60c471a5c168864c8a3bb991c1d362b5fd5e040782c4a680e7b1eb3cbf4324258c11379d8019f0
+  metadata.gz: 902a35c83b2b00518504054939ab688f883ecf78f2358f90462a6b06290a80de7c52735d4d71e40e27e1d47914fd7bac6b537bdf916a322d7da35483b21afef9
+  data.tar.gz: b03f296f12ed93fb92e7b6f7243f250cc4ada6c08b70e52a5b8df81c6707aa9c3124d60b03e0e922b5626b543c59059c7300e626858b59706140df7cd19d9fb8

data/CHANGELOG.md

@@ -1,4 +1,70 @@
-### master
+### [v0.15.0][v0.15.0] (November 15, 2024)
+
+#### Features
+
+* Added support for Reline
+  ([#2298](https://github.com/pry/pry/pull/2298))
+* Added support for Ruby 3.3
+  ([#2295](https://github.com/pry/pry/pull/2295))
+* Added Pry::Input::SimpleStdio for dumb terminals when Reline is in use
+  ([#2304](https://github.com/pry/pry/pull/2304))
+* Remove OpenStruct usage
+  ([#2307](https://github.com/pry/pry/pull/2307))
+  ([#2309](https://github.com/pry/pry/pull/2309))
+* Disable coloring of output when NO_COLOR is set.
+  ([#2323])(https://github.com/pry/pry/pull/2323))
+* Add `pry --no-multiline` flag to keep single line prompt.
+  ([#2327](https://github.com/pry/pry/pull/2327))
+
+#### Bug Fixes
+
+* Fix typos on docs and and comments
+  ([#2300](https://github.com/pry/pry/pull/2300))
+  ([#2301](https://github.com/pry/pry/pull/2301))
+* Fix 'calling clear method' on user code when defined in pry context.
+  ([#2291](https://github.com/pry/pry/pull/2291))
+* Fix arguments WatchExpression#add_expression
+  ([#2278](https://github.com/pry/pry/pull/2278))
+
+### Breaking changes
+
+* Remove support for deprecated `Pry.config.prompt = [proc {}, proc {}]`
+  Use Pry::Prompt API instead
+  ([#2308](https://github.com/pry/pry/pull/2308))
+* Remove deprecated `Pry.config.exception_whitelist`.
+  Use `Pry.config.unrescued_exceptions` instead.
+  ([#2326](https://github.com/pry/pry/pull/2326))
+
+### [v0.14.2][v0.14.2] (January 9, 2023)
+
+#### Features
+
+* Configure `code` as a supported editor on Pry::Editor
+  ([#2236](https://github.com/pry/pry/pull/2236))
+* Added support for Ruby 3.2
+  ([#2263](https://github.com/pry/pry/pull/2263))
+* Added support for Ruby 3.1
+  ([#2228](https://github.com/pry/pry/pull/2228))
+
+#### Bug fixes
+
+* Short circuit eval regexes in finding module definition
+  ([#2253](https://github.com/pry/pry/pull/2253))
+* Revert "Escape non-printing characters"
+  ([#2235](https://github.com/pry/pry/pull/2235))
+* Fixed bug where WeirdMethodLocator would fail to find the source of a method breaking whereami
+  ([#2244](https://github.com/pry/pry/pull/2244))
+* Fixed bug where pry would throw an FrozenError when dealing with incomplete tokens
+  ([#2136](https://github.com/pry/pry/pull/2136))
+* Restore --no-history CLI flag functionality
+  ([#2196](https://github.com/pry/pry/pull/2196))
+* Fixed bug where reading from the `_out_` sticky local variable could return
+  wrong results ([#2201](https://github.com/pry/pry/pull/2201))
+
+#### Breaking Changes
+
+* Remove support for Ruby 1.9 and JRuby < 9.0
+  ([#2239](https://github.com/pry/pry/pull/2239))
 
 ### [v0.14.1][v0.14.1] (April 12, 2021)
 
@@ -946,7 +1012,7 @@ complete CHANGELOG:
 * _pry_ now passed as 3rd parameter to :before_session hook
 * ls colors now configurable via Pry.config.ls.local_var_color = :bright_red etc
 * ls separator configurable via, e.g Pry.config.ls.separator = "  "
-* Pry.view_clip() now only calls inspect on a few immediates, otherwise uses the #<> syntax, which has been truncated further to exclude teh mem address, again related to #245
+* Pry.view_clip() now only calls inspect on a few immediates, otherwise uses the #<> syntax, which has been truncated further to exclude the mem address, again related to #245
 
 ### 0.9.3 (2011/7/27)
 * cat --ex (cats 5 lines above and below line in file where exception was raised)

data/README.md

@@ -1,7 +1,7 @@
 Pry
 ===
 
-[![Circle Build Status](https://circleci.com/gh/pry/pry.svg?style=shield)](https://circleci.com/gh/pry/pry)
+[![Pry Build Status](https://github.com/pry/pry/workflows/pry/badge.svg)](https://github.com/pry/pry/actions)
 [![Code Climate](https://codeclimate.com/github/pry/pry.svg)](https://codeclimate.com/github/pry/pry)
 [![Gem Version](https://badge.fury.io/rb/pry.svg)](https://badge.fury.io/rb/pry)
 [![Documentation Status](https://inch-ci.org/github/pry/pry.svg?branch=master)](https://inch-ci.org/github/pry/pry)
@@ -21,7 +21,7 @@ Pry
 
 **Links:**
 
-* https://pry.github.com/
+* https://pry.github.io/
 * [YARD API documentation](https://www.rubydoc.info/gems/pry)
 * [Wiki](https://github.com/pry/pry/wiki)
 
@@ -38,7 +38,6 @@ Table of Contents
    * [Command Shell Integration](#command-shell-integration)
    * [Code Browsing](#code-browsing)
    * [Documentation Browsing](#documentation-browsing)
-   * [Gist integration](#gist-integration)
    * [Edit methods](#edit-methods)
    * [Live Help System](#live-help-system)
    * [Use Pry as your Rails Console](#use-pry-as-your-rails-console)
@@ -82,7 +81,7 @@ Installation
 ### Bundler
 
 ```ruby
-gem 'pry', '~> 0.13.1'
+gem 'pry', '~> 0.15.0'
 ```
 
 ### Manual
@@ -208,7 +207,7 @@ hello world!
 pry(main)> def a.goodbye
 pry(main)*   puts "goodbye cruel world!"
 pry(main)* end
-=> nil
+=> :goodbye
 pry(main)> a.goodbye
 goodbye cruel world!
 => nil
@@ -266,23 +265,26 @@ syntax and also simply the name of a method that's in scope. You can optionally
 pass the `-l` option to `show-source` to include line numbers in the output.
 
 In the following example we will enter the `Pry` class, list the instance
-methods beginning with 're' and display the source code for the `rep` method:
+methods beginning with 'se' and display the source code for the `set_last_result` method:
 
 ```ruby
 pry(main)> cd Pry
-pry(Pry):1> ls -M --grep re
-Pry#methods: re  readline  refresh  rep  repl  repl_epilogue  repl_prologue  retrieve_line
-pry(Pry):1> show-source rep -l
-
-From: /home/john/ruby/projects/pry/lib/pry/pry_instance.rb:143
+pry(Pry):1> ls -M --grep se
+Pry#methods: raise_up  raise_up!  raise_up_common  reset_eval_string  select_prompt  set_last_result
+pry(Pry):1> show-source set_last_result -l
+
+From: /home/john/ruby/projects/pry/lib/pry/pry_instance.rb:405:
+Owner: Pry
+Visibility: public
+Signature: set_last_result(result, code=?)
 Number of lines: 6
 
-143: def rep(target=TOPLEVEL_BINDING)
-144:   target = Pry.binding_for(target)
-145:   result = re(target)
-146:
-147:   show_result(result) if should_print?
-148: end
+405: def set_last_result(result, code = "")
+406:   @last_result_is_exception = false
+407:   @output_ring << result
+408:
+409:   self.last_result = result unless code =~ /\A\s*\z/
+410: end
 ```
 
 Note that we can also view C methods (from Ruby Core) using the
@@ -317,7 +319,7 @@ rb_ary_select(VALUE ary)
 One use-case for Pry is to explore a program at run-time by `cd`-ing in and out
 of objects and viewing and invoking methods. In the course of exploring it may
 be useful to read the documentation for a specific method that you come
-across. Like `show-source` the `show-doc` command supports two syntaxes - the
+across. `show-source` command supports two syntaxes - the
 normal `ri` syntax as well as accepting the name of any method that is currently
 in scope.
 
@@ -339,14 +341,26 @@ In our example we will enter the `Gem` class and view the documentation for the
 
 ```ruby
 pry(main)> cd Gem
-pry(Gem):1> show-doc try_activate
+pry(Gem):1> show-source try_activate -d
 
-From: /Users/john/.rvm/rubies/ruby-1.9.2-p180/lib/ruby/site_ruby/1.9.1/rubygems.rb:201
-Number of lines: 3
+From: /Users/john/rbenv/versions/2.7.1/lib/ruby/2.7.0/rubygems.rb:194:
+Owner: #<Class:Gem>
+Visibility: public
+Signature: try_activate(path)
+Number of lines: 28
 
 Try to activate a gem containing path. Returns true if
 activation succeeded or wasn't needed because it was already
 activated. Returns false if it can't find the path in a gem.
+
+def self.try_activate(path)
+  # finds the _latest_ version... regardless of loaded specs and their deps
+  # if another gem had a requirement that would mean we shouldn't
+  # activate the latest version, then either it would already be activated
+  # or if it was ambiguous (and thus unresolved) the code in our custom
+  # require will try to activate the more specific version.
+
+  spec = Gem::Specification.find_by_path path
 pry(Gem):1>
 ```
 
@@ -399,18 +413,21 @@ description if the `--help` option is available.
 
 ### Use Pry as your Rails Console
 
-The recommended way to use Pry as your Rails console is to add [the `pry-rails`
-gem](https://github.com/rweng/pry-rails) to your Gemfile. This replaces the
-default console with Pry, in addition to loading the Rails console helpers and
-adding some useful Rails-specific commands.
-
-If you don't want to change your Gemfile, you can still run a Pry console in
-your app's environment using Pry's `-r` flag:
+You can run a Pry console in your app's environment using Pry's `-r` flag:
 
 ```sh
 pry -r ./config/environment
 ```
 
+Or start the rails console (`bin/rails console`) and then type `pry`.
+
+It's also possible to use Pry as your Rails console by adding [the pry-rails
+gem](https://github.com/pry/pry-rails) to your Gemfile. This replaces the
+default console with Pry, in addition to loading the Rails console helpers and
+adding some useful Rails-specific commands.
+
+**Note that `pry-rails` is not currently maintained.**
+
 Also check out the
 [wiki](https://github.com/pry/pry/wiki/Setting-up-Rails-or-Heroku-to-use-Pry)
 for more information about integrating Pry with Rails.
@@ -427,8 +444,8 @@ putting the line `Pry.color = false` in your `pryrc` file.
 Supported Rubies
 ----------------
 
-* CRuby >= 1.9.3
-* JRuby >= 1.7
+* CRuby >= 2.0.0
+* JRuby >= 9.0
 
 Contact
 -------

data/lib/pry/basic_object.rb

@@ -2,7 +2,7 @@
 
 class Pry
   class BasicObject < BasicObject
-    [:Kernel, :File, :Dir, :LoadError, :ENV, :Pry].each do |constant|
+    %i[Kernel File Dir LoadError ENV Pry].each do |constant|
       const_set constant, ::Object.const_get(constant)
     end
     include Kernel

data/lib/pry/class_command.rb

@@ -137,7 +137,7 @@ class Pry
     #     end
     #   end
     #
-    # @example Define the invokation block anywhere you want
+    # @example Define the invocation block anywhere you want
     #   def subcommands(cmd)
     #     cmd.command :download do |opt|
     #       description 'Downloads a content from a server'
@@ -172,7 +172,7 @@ class Pry
 
     # The actual body of your command should go here.
     #
-    # The `opts` mehod can be called to get the options that Pry::Slop has passed,
+    # The `opts` method can be called to get the options that Pry::Slop has passed,
     # and `args` gives the remaining, unparsed arguments.
     #
     # The return value of this method is discarded unless the command was

data/lib/pry/cli.rb

@@ -122,7 +122,7 @@ Pry::CLI.add_options do
   banner(
     "Usage: pry [OPTIONS]\n" \
     "Start a Pry session.\n" \
-    "See http://pryrepl.org/ for more information.\n" \
+    "See http://pry.github.io/ for more information.\n" \
     "Copyright (c) 2016 John Mair (banisterfiend)" \
   )
 
@@ -138,13 +138,17 @@ Pry::CLI.add_options do
   end
 
   on "no-history", "Disable history loading" do
-    Pry.config.history.should_load = false
+    Pry.config.history_load = false
   end
 
   on "no-color", "Disable syntax highlighting for session" do
     Pry.config.color = false
   end
 
+  on "no-multiline", "Disables multiline (defaults to true with Reline)" do
+    Pry.config.multiline = false
+  end
+
   on :f, "Suppress loading of pryrc" do
     Pry.config.should_load_rc = false
     Pry.config.should_load_local_rc = false

data/lib/pry/code.rb

@@ -346,14 +346,6 @@ class Pry
       ''.respond_to?(method_name, include_private) || super
     end
 
-    if RUBY_VERSION.start_with?('1.9')
-      # @todo This is needed for Ruby 1.9 support where `lines` return an
-      #   Enumerator. Newer Rubies return an Array
-      def lines
-        super.to_a
-      end
-    end
-
     protected
 
     # An abstraction of the `dup.instance_eval` pattern used throughout this

data/lib/pry/code_object.rb

@@ -11,7 +11,7 @@ class Pry
   # object the user wants (applying precedence rules in doing so -- i.e methods
   # get precedence over commands with the same name) and 2. Returning
   # the appropriate object. If the user fails to provide a string
-  # identifer for the object (i.e they pass in `nil` or "") then the
+  # identifier for the object (i.e they pass in `nil` or "") then the
   # object looked up will be the 'current method' or 'current class'
   # associated with the Binding.
   #
@@ -97,7 +97,7 @@ class Pry
       nil
     end
 
-    # when no paramter is given (i.e CodeObject.lookup(nil)), then we
+    # when no parameter is given (i.e CodeObject.lookup(nil)), then we
     # lookup the 'current object' from the binding.
     def empty_lookup
       return nil if str && !str.empty?

data/lib/pry/command.rb

@@ -200,7 +200,7 @@ class Pry
       end
 
       def state
-        Pry::CommandState.default.state_for(match)
+        Pry::CommandState.default.state_for(self)
       end
     end
 

data/lib/pry/command_set.rb

@@ -145,7 +145,7 @@ class Pry
     # Imports all the commands from one or more sets.
     # @param [Array<CommandSet>] sets Command sets, all of the commands of which
     #   will be imported.
-    # @return [Pry::CommandSet] Returns the reciever (a command set).
+    # @return [Pry::CommandSet] Returns the receiver (a command set).
     def import(*sets)
       sets.each do |set|
         @commands.merge! set.to_hash
@@ -157,7 +157,7 @@ class Pry
     # Imports some commands from a set
     # @param [CommandSet] set Set to import commands from
     # @param [Array<String>] matches Commands to import
-    # @return [Pry::CommandSet] Returns the reciever (a command set).
+    # @return [Pry::CommandSet] Returns the receiver (a command set).
     def import_from(set, *matches)
       helper_module.send :include, set.helper_module
       matches.each do |match|

data/lib/pry/command_state.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'ostruct'
-
 class Pry
   # CommandState is a data structure to hold per-command state.
   #
@@ -20,12 +18,19 @@ class Pry
       @command_state = {}
     end
 
-    def state_for(command_name)
-      @command_state[command_name] ||= OpenStruct.new
+    def state_for(command_class)
+      @command_state[command_class] ||= command_struct(command_class)
+    end
+
+    def reset(command_class)
+      @command_state[command_class] = command_struct(command_class)
     end
 
-    def reset(command_name)
-      @command_state[command_name] = OpenStruct.new
+    private
+
+    def command_struct(command_class)
+      Struct.new(:command, *command_class.command_options[:state])
+        .new(command: command_class)
     end
   end
 end

data/lib/pry/commands/amend_line.rb

@@ -76,7 +76,7 @@ class Pry
 
       # Takes two numbers that are 1-indexed, and returns a range (or
       # number) that is 0-indexed. 1-indexed means the first element is
-      # indentified by 1 rather than by 0 (as is the case for Ruby arrays).
+      # identified by 1 rather than by 0 (as is the case for Ruby arrays).
       # @param [Fixnum] start_line_number One-indexed number.
       # @param [Fixnum] end_line_number One-indexed number.
       # @return [Range] The zero-indexed range.

data/lib/pry/commands/cd.rb

@@ -22,6 +22,8 @@ class Pry
         https://github.com/pry/pry/wiki/State-navigation#wiki-Changing_scope
       BANNER
 
+      command_options state: %i[old_stack]
+
       def process
         state.old_stack ||= []
 

data/lib/pry/commands/edit.rb

@@ -22,6 +22,8 @@ class Pry
         https://github.com/pry/pry/wiki/Editor-integration#wiki-Edit_command
       BANNER
 
+      command_options state: %i[dynamical_ex_file]
+
       def options(opt)
         opt.on :e, :ex, "Open the file that raised the most recent exception " \
                         "(_ex_.file)",

data/lib/pry/commands/find_method.rb

@@ -128,7 +128,7 @@ class Pry
           next if klass.autoload?(name)
 
           begin
-            const = klass.const_get(name)
+            const = Pry::Method.singleton_class_of(klass.const_get(name))
           rescue RescuableException # rubocop:disable Lint/HandleExceptions
             # constant loading is an inexact science at the best of times,
             # this often happens when a constant was .autoload? but someone

data/lib/pry/commands/ls/config.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+class Pry
+  class Command
+    class Ls < Pry::ClassCommand
+      class Config
+        attr_accessor :heading_color,
+                      :public_method_color,
+                      :private_method_color,
+                      :protected_method_color,
+                      :method_missing_color,
+                      :local_var_color,
+                      :pry_var_color,            # e.g. _, pry_instance, _file_
+                      :instance_var_color,       # e.g. @foo
+                      :class_var_color,          # e.g. @@foo
+                      :global_var_color,         # e.g. $CODERAY_DEBUG, $foo
+                      :builtin_global_color,     # e.g. $stdin, $-w, $PID
+                      :pseudo_global_color,      # e.g. $~, $1..$9, $LAST_MATCH_INFO
+                      :constant_color,           # e.g. VERSION, ARGF
+                      :class_constant_color,     # e.g. Object, Kernel
+                      :exception_constant_color, # e.g. Exception, RuntimeError
+                      :unloaded_constant_color,  # Constant that is still in .autoload?
+                      :separator,
+                      :ceiling
+
+        def self.default
+          config = new
+          config.heading_color = :bright_blue
+          config.public_method_color = :default
+          config.private_method_color = :blue
+          config.protected_method_color = :blue
+          config.method_missing_color = :bright_red
+          config.local_var_color = :yellow
+          config.pry_var_color = :default
+          config.instance_var_color = :blue
+          config.class_var_color = :bright_blue
+          config.global_var_color = :default
+          config.builtin_global_color = :cyan
+          config.pseudo_global_color = :cyan
+          config.constant_color = :default
+          config.class_constant_color = :blue
+          config.exception_constant_color = :magenta
+          config.unloaded_constant_color = :yellow
+          config.separator = "  "
+          config.ceiling = [Object, Module, Class]
+          config
+        end
+      end
+    end
+  end
+end

data/lib/pry/commands/ls/constants.rb

@@ -4,8 +4,8 @@ class Pry
   class Command
     class Ls < Pry::ClassCommand
       class Constants < Pry::Command::Ls::Formatter
-        DEPRECATED_CONSTANTS = [
-          :Data, :Fixnum, :Bignum, :TimeoutError, :NIL, :FALSE, :TRUE
+        DEPRECATED_CONSTANTS = %i[
+          Data Fixnum Bignum TimeoutError NIL FALSE TRUE
         ].tap do |constants|
           constants << :JavaPackageModuleTemplate if Helpers::Platform.jruby?
         end

data/lib/pry/commands/ls.rb

@@ -3,27 +3,6 @@
 class Pry
   class Command
     class Ls < Pry::ClassCommand
-      DEFAULT_OPTIONS = {
-        heading_color: :bright_blue,
-        public_method_color: :default,
-        private_method_color: :blue,
-        protected_method_color: :blue,
-        method_missing_color: :bright_red,
-        local_var_color: :yellow,
-        pry_var_color: :default, # e.g. _, pry_instance, _file_
-        instance_var_color: :blue, # e.g. @foo
-        class_var_color: :bright_blue, # e.g. @@foo
-        global_var_color: :default, # e.g. $CODERAY_DEBUG, $eventmachine_library
-        builtin_global_color: :cyan, # e.g. $stdin, $-w, $PID
-        pseudo_global_color: :cyan, # e.g. $~, $1..$9, $LAST_MATCH_INFO
-        constant_color: :default, # e.g. VERSION, ARGF
-        class_constant_color: :blue, # e.g. Object, Kernel
-        exception_constant_color: :magenta, # e.g. Exception, RuntimeError
-        unloaded_constant_color: :yellow, # Any constant that is still in .autoload? state
-        separator: "  ",
-        ceiling: [Object, Module, Class]
-      }.freeze
-
       match 'ls'
       group 'Context'
       description 'Show the list of vars and methods in the current scope.'

data/lib/pry/commands/raise_up.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Pry
-  # N.B. using a regular expresion here so that "raise-up 'foo'" does the right thing.
+  # N.B. using a regular expression here so that "raise-up 'foo'" does the right thing.
   class Command
     class RaiseUp < Pry::ClassCommand
       match(/raise-up(!?\b.*)/)

data/lib/pry/commands/ri.rb

@@ -57,7 +57,7 @@ class Pry
           RDoc::RI.const_set :PryDriver, subclass # hook it up!
         end
 
-        # Spin-up an RI insance.
+        # Spin-up an RI instance.
         ri = RDoc::RI::PryDriver.new(
           pry_instance.pager, use_stdout: true, interactive: false
         )

data/lib/pry/commands/shell_command.rb

@@ -7,7 +7,7 @@ class Pry
       group 'Input and Output'
       description "All text following a '.' is forwarded to the shell."
       command_options listing: '.<shell command>', use_prefix: false,
-                      takes_block: true
+                      takes_block: true, state: %i[old_pwd]
 
       banner <<-'BANNER'
         Usage: .COMMAND_NAME

data/lib/pry/commands/shell_mode.rb

@@ -6,6 +6,7 @@ class Pry
       match 'shell-mode'
       group 'Input and Output'
       description 'Toggle shell mode. Bring in pwd prompt and file completion.'
+      command_options state: %i[disabled prev_prompt]
 
       banner <<-'BANNER'
         Toggle shell mode. Bring in pwd prompt and file completion.

data/lib/pry/commands/watch_expression/expression.rb

@@ -23,7 +23,7 @@ class Pry
 
         # Has the value of the expression changed?
         #
-        # We use the pretty-printed string represenation to detect differences
+        # We use the pretty-printed string representation to detect differences
         # as this avoids problems with dup (causes too many differences) and ==
         # (causes too few)
         def changed?

data/lib/pry/commands/watch_expression.rb

@@ -7,7 +7,7 @@ class Pry
       group 'Context'
       description 'Watch the value of an expression and print a notification ' \
                   'whenever it changes.'
-      command_options use_prefix: false
+      command_options use_prefix: false, state: %i[watch_expressions]
 
       banner <<-'BANNER'
         Usage: watch [EXPRESSION]
@@ -46,7 +46,7 @@ class Pry
           list
         else
           add_hook
-          add_expression(args)
+          add_expression
         end
       end
 
@@ -88,15 +88,13 @@ class Pry
         end
       end
 
-      # TODO: fix arguments.
-      # https://github.com/pry/pry/commit/b031df2f2f5850ee6e9018f33d35f3485a9b0423
-      def add_expression(_arguments)
+      def add_expression
         expressions << Expression.new(pry_instance, target, arg_string)
         output.puts "Watching #{Code.new(arg_string).highlighted}"
       end
 
       def add_hook
-        hook = [:after_eval, :watch_expression]
+        hook = %i[after_eval watch_expression]
         return if pry_instance.hooks.hook_exists?(*hook)
 
         pry_instance.hooks.add_hook(*hook) do |_, pry_instance|