prubybility 0.0.12 → 0.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9cc5ff2604249dd3ecfabe8f849b55091cad37903665342c48c60bb5672490c
-  data.tar.gz: 327f49d644ee8c009ca7ae20a290f0a43aaa1cb19779cbc29ca14ecd3ed691e7
+  metadata.gz: 1bbbe8171683ce2fd73afc9b30b52f62af59b70135bf7aa8306eb829d6d80b1c
+  data.tar.gz: 7f5d6a013cf1644885fb6ec32429de5af5bb4cba5f52f747b981c67082d8fd66
 SHA512:
-  metadata.gz: aee3015f5fabe80c7ef6dc81a9fbba5e4544527d3475d2623b272f58ca0342537551c9ea5bf4998394e957c07ca7ef2a3bc8b874cc89621dd4bfd777384f767e
-  data.tar.gz: 0b63040f893f861912d0f53cb45716b53755d52262c80d18e9d2c1696173b1c16423a9572f49f4eb80ab5ef753e5f601bf6cb66daad2a415d9ada641af5f6cb7
+  metadata.gz: d18db739299deaae19611265bff16eaec0c140df5ca8a852f48208e7ceb17a32f86544ebd9871eb41792db43cf46ce28a994540d3d350b880bf9966261eff6e8
+  data.tar.gz: 50b7fe673335ad374cdc05faf9c927af7d3bc0d2e9062b56481397951ec2d2f1bf55f66aec95e1830cd960b37366e97197d058628f76c30822121f51392eada5

data/lib/prubybility/bernoulli.rb

@@ -10,9 +10,17 @@ module Prubybility
     end
 
     def p(var)
-      return if var != 0 && var != 1
+      return unless valid_value?(var)
 
       (theta**var) * (1 - theta)**(1 - var)
     end
+
+    private
+
+    def valid_value?(var)
+      return false unless var.is_a? Integer
+      return false unless var == 0 || var == 1
+      true
+    end
   end
 end

data/lib/prubybility/binomial.rb

@@ -16,8 +16,9 @@ module Prubybility
       @variance = @n * @theta * (1 - @theta)
     end
 
-    def p(var)
-      choose(var) * (theta**var) * ((1 - theta)**(n - var))
+    def p(number_of_successes)
+      return unless valid_value?(number_of_successes)
+      choose(number_of_successes) * (theta**number_of_successes) * ((1 - theta)**(n - number_of_successes))
     end
 
     private
@@ -26,6 +27,12 @@ module Prubybility
       Prubybility::Combinations.choose(n, var)
     end
 
+    def valid_value?(var)
+      return unless var.is_a? Integer
+      return unless var > 0 && var <= n
+      true
+    end
+
     attr_writer :n, :theta, :expected_value, :variance
   end
 end

data/lib/prubybility/negative_binomial.rb

@@ -19,11 +19,15 @@ module Prubybility
     end
 
     def p(var)
-      choose(var - 1, k - 1) * (theta**k) * ((1 - theta)**(var - k))
+      choose(var) * (theta**k) * ((1 - theta)**(var - k))
     end
 
     private
 
-    attr_writer :n, :theta, :expected_value, :variance
+    def choose(var)
+      Prubybility::Combinations.choose(var -1, k - 1)
+    end
+
+    attr_writer :k, :theta, :expected_value, :variance
   end
 end

data/lib/prubybility/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Prubybility
-  VERSION = '0.0.12'
+  VERSION = '0.0.13'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: prubybility
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.13
 platform: ruby
 authors:
 - Jacob Lee