proxy_tester 0.1.1 → 0.1.2

data/Gemfile

@@ -14,6 +14,7 @@ group :test do
   gem 'factory_girl'
   gem 'database_cleaner'
   gem 'coveralls'
+  gem 'webmock', require: 'webmock/rspec'
 end
 
 group :development do

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    proxy_tester (0.1.0)
+    proxy_tester (0.1.1)
       activerecord (~> 4.0)
       activesupport (~> 4.0)
       addressable
@@ -64,6 +64,8 @@ GEM
       simplecov (>= 0.7)
       term-ansicolor
       thor
+    crack (0.4.2)
+      safe_yaml (~> 1.0.0)
     crypt_keeper (0.13.1)
       activerecord (>= 3.0)
       activesupport (>= 3.0)
@@ -162,6 +164,7 @@ GEM
     rspec-mocks (2.14.6)
     ruby-progressbar (1.4.2)
     rugged (0.19.0)
+    safe_yaml (1.0.2)
     sequel (4.9.0)
     simplecov (0.8.2)
       docile (~> 1.1.0)
@@ -189,6 +192,9 @@ GEM
     tzinfo (0.3.39)
     versionomy (0.4.4)
       blockenspiel (>= 0.4.5)
+    webmock (1.17.4)
+      addressable (>= 2.2.7)
+      crack (>= 0.3.2)
     websocket-driver (0.3.2)
     xpath (2.0.0)
       nokogiri (~> 1.3)
@@ -227,4 +233,5 @@ DEPENDENCIES
   sinatra
   tmrb
   versionomy
+  webmock
   yard

data/lib/proxy_tester/capybara_proxy_pac.rb

@@ -30,14 +30,14 @@ module ProxyTester
     end
 
     def pac_file=(source)
-      @pac_file = source
-
       uri = Addressable::URI.heuristic_parse(source)
 
       if uri.host.blank?
-        @content = File.read(source)
+        @content = File.read(uri.path)
+        @pac_file = uri.path
       else
         @content = open(uri, { proxy: false }).string
+        @pac_file = uri.to_s
       end
 
       @content
@@ -49,6 +49,7 @@ module ProxyTester
 
     def result
       return PacResult.new if content.blank?
+      return PacResult.new if url.blank?
 
       env_hash = {}
       env_hash[:client_ip] = client_ip if client_ip

data/lib/proxy_tester/version.rb

@@ -1,4 +1,4 @@
 #main ProxyTester
 module ProxyTester
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/spec/capybara_proxy_pac_spec.rb

@@ -14,6 +14,37 @@ describe CapybaraProxyPac do
       pac = CapybaraProxyPac.new
       expect { pac.pac_file = 'asdf' }.to raise_error Exceptions::PacFileNotFound
     end
+
+    it 'handles missing url' do
+      pac = CapybaraProxyPac.new
+      pac.pac_file = create_file('proxy.pac', valid_pac_file1)
+      expect { pac.host }.not_to raise_error
+    end
+  end
+
+  context '#pac_file' do
+    let(:pac_file) { create_file 'proxy.pac', valid_pac_file1 }
+
+    it 'reads from file' do
+      pac = CapybaraProxyPac.new
+      pac.pac_file = pac_file
+      expect(pac.pac_file).to eq pac_file
+    end
+
+    it 'reads from file url' do
+      pac = CapybaraProxyPac.new
+      pac.pac_file = 'file://' + pac_file
+      expect(pac.pac_file).to eq pac_file
+    end
+
+    it 'reads from url' do
+      url =  'http://pac-host.example.com/proxy.pac'
+      stub_request(:any, url).to_return(body: valid_pac_file1)
+
+      pac = CapybaraProxyPac.new
+      pac.pac_file = url
+      expect(pac.pac_file).to eq url
+    end
   end
 
   context '#host' do

data/spec/matchers/returns_proxy_spec.rb

@@ -18,25 +18,38 @@ describe 'returns proxy matcher' do
     set_offline true
   end
 
-  it 'checks return proxy string' do
-    file = create_file 'proxy.pac', valid_proxy_pac
-    use_proxy :pac, file
+  context 'file' do
+    it 'checks return proxy string' do
+      file = create_file 'proxy.pac', valid_proxy_pac
+      use_proxy :pac, file
 
-    visit 'http://example.com'
-    expect(proxy_pac).to return_proxy('PROXY localhost2:8080')
+      visit 'http://example.com'
+      expect(proxy_pac).to return_proxy('PROXY localhost2:8080')
 
-    visit 'http://otherdomain.com'
-    expect(proxy_pac).to return_proxy('DIRECT')
-  end
+      visit 'http://otherdomain.com'
+      expect(proxy_pac).to return_proxy('DIRECT')
+    end
+
+    it 'checks that a proxy string is not returned' do
+      file = create_file 'proxy.pac', valid_proxy_pac
+      use_proxy :pac, file
 
-  it 'checks that a proxy string is not returned' do
-    file = create_file 'proxy.pac', valid_proxy_pac
-    use_proxy :pac, file
+      visit 'http://example.com'
+      expect(proxy_pac).not_to return_proxy('DIRECT')
+
+      visit 'http://otherdomain.com'
+      expect(proxy_pac).not_to return_proxy('PROXY localhost2:8080')
+    end
+  end
 
-    visit 'http://example.com'
-    expect(proxy_pac).not_to return_proxy('DIRECT')
+  context 'urls' do
+    it 'succeeds for example.com' do
+      url =  'http://pac-host.example.com/proxy.pac'
+      stub_request(:any, url).to_return(body: valid_proxy_pac)
 
-    visit 'http://otherdomain.com'
-    expect(proxy_pac).not_to return_proxy('PROXY localhost2:8080')
+      use_proxy :pac, url
+      visit 'http://example.com'
+      expect(proxy_pac).to return_proxy('PROXY localhost2:8080')
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: proxy_tester
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors: