proxy_pac_rb 2.1.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 05b5cdcd694e4663967cb4fd8b34fac878f6841f
-  data.tar.gz: ae67fc59265d7fa58975e7e9bb2b291038b160c9
+  metadata.gz: 037d43fa0910685b4a38a431bc1bd25a3fa3c299
+  data.tar.gz: 47cf7ce08c6770974784e50eef702424e13f70ad
 SHA512:
-  metadata.gz: 6d3f4e6ecd0e27b76a5ada7e2173e8a3fe6aa374fd2abeec950ae1e6c4d0a53a4c051ec15c6b683360ff1fcccf0d8efc11ed8322eaa67367a07bd99965887811
-  data.tar.gz: 6d5b1e05274da804023f7abaa5487a22ffcb7dfed473d9b3bfa5b45dfebbd804eed9efc0d43843c379a4c4ef90c510a7bd9088729dc199c8757aa2ca81f970b0
+  metadata.gz: a46b7925d4034bbeefcdda66e868042fb15ef9e5c9c2f2c1fc988eb2464d0e273c82368cb93959bd01736931da08303ea9adc041d13081fba6c261f8fb709c2c
+  data.tar.gz: 8cf646fc6d0c88abb7db9433edb3c173ed8e1e7e6741c0920c51d904965ded102ecd9d54802c45df27e76f4c89517417fae40687fbe865a31c5d1104f5e27ea9

data/.rubocop.yml

@@ -1,9 +1,14 @@
+inherit_from: .rubocop_todo.yml
 AllCops:
   Exclude:
     - 'tmp/**/*'
+    - Gemfile
   DisplayCopNames: true
   TargetRubyVersion: 2.3
 
+Style/GuardClause:
+  Enabled: false
+
 Metrics/AbcSize:
   Max: 38
 

data/.rubocop_todo.yml

@@ -0,0 +1,91 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-06-04 19:50:00 +0000 using RuboCop version 0.49.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 82
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterMagicComment:
+  Enabled: false
+
+# Offense count: 87
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: native, lf, crlf
+Layout/EndOfLine:
+  Enabled: false
+
+# Offense count: 27
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
+Layout/IndentHeredoc:
+  Exclude:
+    - 'lib/proxy_pac_rb/cli/init_proxy_pac.rb'
+    - 'lib/proxy_pac_rb/proxy_pac_js.rb'
+    - 'proxy_pac_rb.gemspec'
+    - 'spec/parser_spec.rb'
+    - 'spec/rack/proxy_pac_compressor_spec.rb'
+    - 'spec/rack/proxy_pac_linter_spec.rb'
+    - 'spec/rspec/compare_proxy_pac_files_spec.rb'
+    - 'spec/rspec/parse_proxy_pac_spec.rb'
+    - 'spec/rspec/readability_spec.rb'
+    - 'spec/rspec/validitiy_spec.rb'
+
+# Offense count: 17
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 178
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: compact, expanded
+Style/EmptyMethod:
+  Exclude:
+    - 'lib/proxy_pac_rb/runtime.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: when_needed, always, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'Vagrantfile'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: InverseMethods, InverseBlocks.
+Style/InverseMethods:
+  Exclude:
+    - 'lib/proxy_pac_rb/rspec.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/proxy_pac_rb/cli/shared.rb'
+    - 'lib/proxy_pac_rb/main.rb'
+    - 'lib/proxy_pac_rb/rspec.rb'
+    - 'spec/environment_spec.rb'
+    - 'templates/test_framework/rspec/support/aruba.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize, SupportedStyles.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/YodaCondition:
+  Exclude:
+    - 'lib/proxy_pac_rb/proxy_pac_file.rb'
+    - 'lib/proxy_pac_rb/rack/proxy_pac_compressor.rb'
+    - 'lib/proxy_pac_rb/rack/proxy_pac_linter.rb'
+    - 'lib/proxy_pac_rb/rspec/helpers.rb'

data/Gemfile

@@ -14,7 +14,7 @@ end
 
 group :development, :test do
   gem 'middleman', '~> 4.1', require: false
-  gem 'aruba', '~>0.10.0', require: false
+  gem 'aruba', '~>0.14.2', require: false
   gem 'awesome_print', require: 'ap'
   gem 'bundler', '~> 1.3', require: false
   gem 'command_exec', require: false

data/README.md

@@ -271,7 +271,7 @@ file.find('https://github.com')        # => "DIRECT"
 ```ruby
 require 'proxy_pac_rb'
 
-string = <<-EOS
+string = <<~EOS
 function FindProxyForURL(url, host) {
   if (dateRange("JUL", "SEP")) {
     return "PROXY localhost:8080";                                                                                                          
@@ -379,7 +379,7 @@ RSpec.describe 'proxy.pac', type: :proxy_pac do
 ```ruby
 RSpec.describe 'String', type: :proxy_pac do
   subject do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -439,7 +439,7 @@ require 'proxy_pac_rb/rspec'
 
 RSpec.describe 'proxy.pac', type: :proxy_pac do
   subject do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -490,7 +490,7 @@ require 'proxy_pac_rb/rspec'
 
 RSpec.describe 'proxy.pac', type: :proxy_pac do
   subject do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -503,7 +503,7 @@ RSpec.describe 'proxy.pac', type: :proxy_pac do
 
     context 'when proxy.pac is not valid' do
       subject do
-        <<-EOS.strip_heredoc.chomp
+        <<~EOS.chomp
           function FindProxyForURL(url, host) {
             return adsf;
           }
@@ -524,7 +524,7 @@ the proxy.pac and returns the proxy to be used for a given url.
 require 'proxy_pac_rb/rspec'
 RSpec.describe 'proxy.pac', type: :proxy_pac do
   subject do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         if (dnsDomainIs(host, 'www1.example.com'')) {
           return "PROXY proxy1.example.com:8080";

data/Rakefile

@@ -1,9 +1,19 @@
-#!/usr/bin/env rake
 # frozen_string_literal: true
 
 # require 'bundler'
 # Bundler.require :default, :test, :development
 
+# temp fix for NoMethodError: undefined method `last_comment'
+# remove when fixed in Rake 11.x
+# see http://stackoverflow.com/questions/35893584/nomethoderror-undefined-method-last-comment-after-upgrading-to-rake-11
+module TempFixForRakeLastComment
+  def last_comment
+    last_description
+  end
+end
+Rake::Application.send :include, TempFixForRakeLastComment
+### end of tempfix
+
 require 'filegen'
 require 'fedux_org_stdlib/rake_tasks'
 

data/features/resolve_proxy.feature

@@ -11,7 +11,7 @@ Feature: Resolve proxy
       return 'PROXY localhost:3128';
     }
     """
-    When I successfully run `pprb find proxy -p proxy.pac -u www.example.org`
+    When I successfully run `pprb find proxy -p proxy.pac -u http://www.example.org`
     Then the output should contain:
     """
     PROXY localhost:3128
@@ -22,7 +22,7 @@ Feature: Resolve proxy
     """
     function FindProxyForURL(){return"PROXY localhost:3128"}
     """
-    When I successfully run `pprb find proxy -p proxy.pac -u www.example.org`
+    When I successfully run `pprb find proxy -p proxy.pac -u http://www.example.org`
     Then the output should contain:
     """
     PROXY localhost:3128
@@ -35,7 +35,7 @@ Feature: Resolve proxy
       return 'PROXY localhost:3128';
     }
     """
-    When I successfully run `pprb find proxy -p ./proxy.pac -u www.example.org`
+    When I successfully run `pprb find proxy -p ./proxy.pac -u http://www.example.org`
     Then the output should contain:
     """
     PROXY localhost:3128
@@ -48,14 +48,14 @@ Feature: Resolve proxy
       return 'PROXY localhost:3128';
     }
     """
-    When I successfully run `pprb find proxy -p http://127.0.0.1:65535/proxy.pac -u www.example.org`
+    When I successfully run `pprb find proxy -p http://127.0.0.1:65535/proxy.pac -u http://www.example.org`
     Then the output should contain:
     """
     PROXY localhost:3128
     """
 
   Scenario: Non-Existing proxy.pac
-    When I run `pprb find proxy -p proxy.pac -u www.example.org`
+    When I run `pprb find proxy -p proxy.pac -u http://www.example.org`
     Then the output should contain:
     """
     You need to provide a path to an existing proxy pac file. The file "proxy.pac" does not exist.
@@ -81,7 +81,7 @@ Feature: Resolve proxy
       return 'PROXY localhost:3128';
     }
     """
-    When I run `pprb find proxy -u www.example.org`
+    When I run `pprb find proxy -u http://www.example.org`
     Then the output should contain:
     """
     No value provided for required options '--proxy-pac'
@@ -98,12 +98,12 @@ Feature: Resolve proxy
       }
     }
     """
-    When I successfully run `pprb find proxy -p proxy.pac -c 10.0.0.1 -u www.example.org`
+    When I successfully run `pprb find proxy -p proxy.pac -c 10.0.0.1 -u http://www.example.org`
     Then the output should contain:
     """
     PROXY localhost:3128
     """
-    When I successfully run `pprb find proxy -p proxy.pac -c 192.0.0.1 -u www.example.org`
+    When I successfully run `pprb find proxy -p proxy.pac -c 192.0.0.1 -u http://www.example.org`
     Then the output should contain:
     """
     DIRECT
@@ -120,12 +120,12 @@ Feature: Resolve proxy
       }
     }
     """
-    When I successfully run `pprb find proxy -p proxy.pac -t 2014-04-09 -u www.example.org`
+    When I successfully run `pprb find proxy -p proxy.pac -t 2014-04-09 -u http://www.example.org`
     Then the output should contain:
     """
     PROXY localhost:3128
     """
-    When I successfully run `pprb find proxy -p proxy.pac -t 2014-12-07 -u www.example.org`
+    When I successfully run `pprb find proxy -p proxy.pac -t 2014-12-07 -u http://www.example.org`
     Then the output should contain:
     """
     DIRECT
@@ -164,3 +164,27 @@ Feature: Resolve proxy
     """
     proxy.example.com
     """
+
+  Scenario: Missing scheme in proxy.pac
+    Given a file named "proxy.pac" with:
+    """
+    function FindProxyForURL(url, host) {
+      if (dnsDomainIs(host,"in.example.com")) {
+        return "DIRECT";
+      }
+
+      if (dnsDomainIs(host,"ex.example.com")) return "PROXY localhost:8080";
+
+      return 'PROXY localhost:3128';
+    }
+    """
+    When I successfully run `pprb find proxy -p proxy.pac -u www.in.example.com`
+    Then the output should contain:
+    """
+    DIRECT
+    """
+    When I successfully run `pprb find proxy -p proxy.pac -u www.ex.example.com`
+    Then the output should contain:
+    """
+    PROXY localhost:8080
+    """

data/lib/proxy_pac_rb/cli/init_proxy_pac.rb

@@ -29,7 +29,7 @@ module ProxyPacRb
 
         directory 'test_framework/rspec/', 'spec'
 
-        append_file 'Gemfile', <<-EOS.strip_heredoc
+        append_file 'Gemfile', <<~EOS
         group :development, :test do
           gem 'aruba', require: false
 
@@ -43,7 +43,7 @@ module ProxyPacRb
         end
         EOS
 
-        append_file 'Rakefile', <<-EOS.strip_heredoc
+        append_file 'Rakefile', <<~EOS
         desc 'Run tests'
         task test: 'test:local'
 
@@ -71,12 +71,12 @@ module ProxyPacRb
 
         directory 'build/middleman', './'
 
-        append_file 'Gemfile', <<-EOS.strip_heredoc
+        append_file 'Gemfile', <<~EOS
         gem 'middleman', '~>3.3.10'
         gem 'therubyracer'
         EOS
 
-        append_file 'Rakefile', <<-EOS.strip_heredoc
+        append_file 'Rakefile', <<~EOS
         desc 'Build site'
         task :build do
           sh 'bundle exec middleman build --verbose'

data/lib/proxy_pac_rb/javascript.rb

@@ -13,8 +13,10 @@ module ProxyPacRb
       @context = context
     end
 
+    # rubocop:disable Style/MethodMissing
     def method_missing(*args, &_block)
       context.call(args.shift, *args)
     end
+    # rubocop:enable Style/MethodMissing
   end
 end

data/lib/proxy_pac_rb/proxy_pac_compressor.rb

@@ -53,7 +53,7 @@ module ProxyPacRb
           # pure_funcs: nil,      # List of functions without side-effects. Can safely discard function calls when the result value is not used
           # drop_console: false,  # Drop calls to console.* functions
           # angular: false,       # Process @ngInject annotations
-          # keep_fargs: false,     # Preserve unused function arguments
+          keep_fargs: true # Preserve unused function arguments
           # keep_fnames: true     # Preserve function names
         }
       }.deep_merge options

data/lib/proxy_pac_rb/proxy_pac_dumper.rb

@@ -55,9 +55,9 @@ module ProxyPacRb
 
     def output_path(path)
       if ::File.exist?(path.gsub(/#{in_extension}*$/, '') + in_extension)
-        return path.gsub(/#{in_extension}*$/, '')
+        path.gsub(/#{in_extension}*$/, '')
       elsif ::File.exist? path
-        return path + out_extension
+        path + out_extension
       else
         raise Errno::ENOENT, "Both paths \"#{path.gsub(/#{in_extension}*$/, '') + in_extension}\" and \"#{path}\" do not exist."
       end

data/lib/proxy_pac_rb/proxy_pac_js.rb

@@ -5,7 +5,7 @@ module ProxyPacRb
   class ProxyPacJs
     class << self
       def my_ip_address_template(value)
-        <<-EOS.strip_heredoc
+        <<~EOS
           function myIpAddress() {
             return "#{value}";
           }
@@ -15,7 +15,7 @@ module ProxyPacRb
       # taken from  releases-mozilla-release / netwerk / base / src / ProxyAutoConfig.cpp @ bitbucket.org
       # https://bitbucket.org/mozilla/releases-mozilla-release/raw/dece38633cf1adcab2071d69fea264580d24cc9e/netwerk/base/src/ProxyAutoConfig.cpp
       def time_variables
-        <<-EOS.strip_heredoc
+        <<~EOS
         var wdays = {SUN: 0, MON: 1, TUE: 2, WED: 3, THU: 4, FRI: 5, SAT: 6};
         var months = {JAN: 0, FEB: 1, MAR: 2, APR: 3, MAY: 4, JUN: 5, JUL: 6, AUG: 7, SEP: 8, OCT: 9, NOV: 10, DEC: 11};
         EOS
@@ -24,7 +24,7 @@ module ProxyPacRb
       def week_day_range_template(value = nil)
         value = %("#{value}") if value
 
-        <<-EOS.strip_heredoc
+        <<~EOS
         function getDay(weekday) {
             if (weekday in wdays) {
                 return wdays[weekday];
@@ -55,7 +55,7 @@ module ProxyPacRb
       def date_range_template(value = nil)
         value = %("#{value}") if value
 
-        <<-EOS.strip_heredoc
+        <<~EOS
         function getMonth(name) {
             if (name in months) {
                 return months[name];
@@ -137,7 +137,7 @@ module ProxyPacRb
       def time_range_template(value = nil)
         value = %("#{value}") if value
 
-        <<-EOS.strip_heredoc
+        <<~EOS
         function timeRange() {
             var argc = arguments.length;
             var date = new Date(#{value});

data/lib/proxy_pac_rb/runtimes.rb

@@ -28,7 +28,7 @@ module ProxyPacRb
       end
 
       def names
-        @names ||= constants.reduce({}) { |a, e| a.merge(const_get(e) => e) }.values
+        @names ||= constants.reduce({}) { |acc, elem| acc.merge(const_get(elem) => elem) }.values
       end
 
       def runtimes

data/lib/proxy_pac_rb/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 # ProxyPacRb
 module ProxyPacRb
-  VERSION = '2.1.0'
+  VERSION = '3.0.0'
 end

data/proxy_pac_rb.gemspec

@@ -22,8 +22,8 @@ DESC
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'addressable', '~>2.3'
-  spec.add_runtime_dependency 'activesupport', '~>4.1'
-  spec.add_runtime_dependency 'uglifier', '~> 2.7.1'
+  spec.add_runtime_dependency 'activesupport', '>=4.1', '<5.2'
+  spec.add_runtime_dependency 'uglifier', '>= 2.7.1'
   spec.add_runtime_dependency 'excon', '~> 0.45.3'
   spec.add_runtime_dependency 'contracts', '~> 0.9'
   spec.add_runtime_dependency 'thor', '~> 0.19'

data/script/config.ru

@@ -1,4 +1,3 @@
-#!/usr/bin/env ruby
 # frozen_string_literal: true
 
 require 'bundler'

data/spec/api/proxy_pac_compressor_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe ProxyPacCompressor do
   let(:modified_content) { %(function FindProxyForURL(url, host) {\n    return \"DIRECT\";\n}) }
 
   let(:content) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       // comment
       function FindProxyForURL(url, host) {
         return "DIRECT";

data/spec/api/proxy_pac_dumper_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe ProxyPacDumper, type: :aruba do
   subject(:proxy_pac) { instance_double('ProxyPac::ProxyPacFile') }
 
   let(:content) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -13,7 +13,7 @@ RSpec.describe ProxyPacDumper, type: :aruba do
   end
 
   let(:source) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }

data/spec/api/proxy_pac_file_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe ProxyPacFile do
   subject(:proxy_pac) { ProxyPacFile.new source: source }
 
   let(:source) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }

data/spec/api/proxy_pac_linter_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe ProxyPacLinter do
   subject(:proxy_pac) { instance_double('ProxyPac::ProxyPacFile') }
 
   let(:content) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -13,7 +13,7 @@ RSpec.describe ProxyPacLinter do
   end
 
   let(:source) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -50,7 +50,7 @@ RSpec.describe ProxyPacLinter do
     context 'when is proxy.pac cannot be compiled' do
       let(:result) { false }
       let(:content) do
-        <<-EOS.strip_heredoc.chomp
+        <<~EOS.chomp
           function FindProxyForURL(url, host) {
            asdfasf $$ SDF
           }

data/spec/api/proxy_pac_loader_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe ProxyPacLoader, type: :aruba do
   subject(:proxy_pac) { instance_double('ProxyPac::ProxyPacFile') }
 
   let(:content) do
-    <<-EOS.strip_heredoc
+    <<~EOS
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -13,7 +13,7 @@ RSpec.describe ProxyPacLoader, type: :aruba do
   end
 
   let(:source) do
-    <<-EOS.strip_heredoc
+    <<~EOS
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -51,7 +51,7 @@ RSpec.describe ProxyPacLoader, type: :aruba do
       it_behaves_like 'an un-readable proxy.pac'
     end
 
-    context 'when proxy pac is file' do
+    context 'when proxy pac is file', type: :aruba do
       let(:file) { 'proxy.pac' }
       let(:type) { :file }
       let(:source) { expand_path(file) }

data/spec/api/proxy_pac_parser_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe ProxyPacParser do
   subject(:proxy_pac) { instance_double('ProxyPac::ProxyPacFile') }
 
   let(:content) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -13,7 +13,7 @@ RSpec.describe ProxyPacParser do
   end
 
   let(:source) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -39,7 +39,7 @@ RSpec.describe ProxyPacParser do
 
     context 'when is invalid' do
       let(:content) do
-        <<-EOS.strip_heredoc.chomp
+        <<~EOS.chomp
           function FindProxyForURL(url, host) {
            asdfasf $$ SDF
           }

data/spec/parser_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe ProxyPacRb::Parser, type: :aruba do
   let(:environment) { Environment.new }
 
   let(:content) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -16,7 +16,7 @@ RSpec.describe ProxyPacRb::Parser, type: :aruba do
   end
 
   let(:source) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -27,16 +27,44 @@ RSpec.describe ProxyPacRb::Parser, type: :aruba do
     it { expect(proxy_pac).not_to be_nil }
   end
 
-  context 'when path is given' do
+  context 'when path is given', type: :aruba do
     let(:source) { expand_path('proxy.pac') }
     before(:each) { write_file(source, content) }
 
     it { expect(proxy_pac).not_to be_nil }
   end
 
+  context 'when input is given' do
+    let(:source) do
+      <<~EOS.chomp
+        function FindProxyForURL(url, host) {
+          if (dnsDomainIs(host,"in.example.com")) {
+            return "DIRECT";
+          }
+
+          if (dnsDomainIs(host,"ex.example.com")) return "PROXY localhost:8080";
+
+          return 'PROXY localhost:3128';
+        }
+      EOS
+    end
+
+    context 'when url' do
+      it { expect(proxy_pac.find('http://www.in.example.com')).to eq('DIRECT') }
+      it { expect(proxy_pac.find('http://www.ex.example.com')).to eq('PROXY localhost:8080') }
+      it { expect(proxy_pac.find('http://www.other.example.de')).to eq('PROXY localhost:3128') }
+    end
+
+    context 'when hostname' do
+      it { expect(proxy_pac.find('www.in.example.com')).to eq('DIRECT') }
+      it { expect(proxy_pac.find('www.ex.example.com')).to eq('PROXY localhost:8080') }
+      it { expect(proxy_pac.find('www.other.example.de')).to eq('PROXY localhost:3128') }
+    end
+  end
+
   context 'when ip address is given' do
     let(:source) do
-      <<-EOS
+      <<~EOS
       function FindProxyForURL(url, host) {
         if ( myIpAddress() == '127.0.0.2' ) {
           return "DIRECT";
@@ -60,7 +88,7 @@ RSpec.describe ProxyPacRb::Parser, type: :aruba do
 
   context 'when date is given' do
     let(:source) do
-      <<-EOS
+      <<~EOS
       function FindProxyForURL(url, host) {
         if (weekdayRange("FRI", "SAT")) {
           return "PROXY localhost:8080";
@@ -84,7 +112,7 @@ RSpec.describe ProxyPacRb::Parser, type: :aruba do
 
   context 'when time range is used' do
     let(:source) do
-      <<-EOS
+      <<~EOS
       function FindProxyForURL(url, host) {
         if (timeRange(8, 18)) {
           return "PROXY localhost:8080";
@@ -108,7 +136,7 @@ RSpec.describe ProxyPacRb::Parser, type: :aruba do
 
   context 'when date range is used' do
     let(:source) do
-      <<-EOS
+      <<~EOS
       function FindProxyForURL(url, host) {
         if (dateRange("JUL", "SEP")) {
           return "PROXY localhost:8080";

data/spec/rack/proxy_pac_compressor_spec.rb

@@ -17,7 +17,7 @@ RSpec.describe ProxyPacRb::Rack::ProxyPacCompressor, type: :rack_test do
         end
 
         get '/' do
-          <<-EOS.strip_heredoc.chomp
+          <<~EOS.chomp
           // comment
           function FindProxyForURL(url, host) {
             return "DIRECT";
@@ -46,7 +46,7 @@ RSpec.describe ProxyPacRb::Rack::ProxyPacCompressor, type: :rack_test do
         end
 
         get '/' do
-          <<-EOS.strip_heredoc.chomp
+          <<~EOS.chomp
           function FindProxyForURL(url, host) {
             return $"§$ "DIRECT";
           }

data/spec/rack/proxy_pac_linter_spec.rb

@@ -5,7 +5,7 @@ require 'rack/lint'
 
 RSpec.describe ProxyPacRb::Rack::ProxyPacLinter, type: :rack_test do
   let(:content) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
     function FindProxyForURL(url, host) {
       return "DIRECT";
     }
@@ -23,7 +23,7 @@ RSpec.describe ProxyPacRb::Rack::ProxyPacLinter, type: :rack_test do
         end
 
         get '/' do
-          <<-EOS.strip_heredoc.chomp
+          <<~EOS.chomp
           function FindProxyForURL(url, host) {
             return "DIRECT";
           }
@@ -51,7 +51,7 @@ RSpec.describe ProxyPacRb::Rack::ProxyPacLinter, type: :rack_test do
         end
 
         get '/' do
-          <<-EOS.strip_heredoc.chomp
+          <<~EOS.chomp
           function FindProxyForURL(url, host) {
             return $"§$ "DIRECT";
           }

data/spec/rspec/compare_proxy_pac_files_spec.rb

@@ -4,7 +4,7 @@ require 'proxy_pac_rb/rspec'
 
 RSpec.describe 'Compare to proxy.pac-files', type: :proxy_pac do
   subject do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -12,7 +12,7 @@ RSpec.describe 'Compare to proxy.pac-files', type: :proxy_pac do
   end
 
   let(:file_a) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -20,7 +20,7 @@ RSpec.describe 'Compare to proxy.pac-files', type: :proxy_pac do
   end
 
   let(:file_b) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -53,7 +53,7 @@ RSpec.describe 'Compare to proxy.pac-files', type: :proxy_pac do
 
     context 'when both are not eqal' do
       let(:file_a) do
-        <<-EOS.strip_heredoc.chomp
+        <<~EOS.chomp
         function FindProxyForURL(url, host) {
           return "DIRECT";
         }
@@ -61,7 +61,7 @@ RSpec.describe 'Compare to proxy.pac-files', type: :proxy_pac do
       end
 
       let(:file_b) do
-        <<-EOS.strip_heredoc.chomp
+        <<~EOS.chomp
         function FindProxyForURL(url, host) {
           return "PROXY localhost:8080";
         }

data/spec/rspec/parse_proxy_pac_spec.rb

@@ -5,7 +5,7 @@ require 'proxy_pac_rb/rspec'
 RSpec.describe 'Parse proxy.pac', type: :proxy_pac do
   describe 'Browse url' do
     subject do
-      <<-EOS.strip_heredoc.chomp
+      <<~EOS.chomp
       function FindProxyForURL(url, host) {
         if (dnsDomainIs(host, 'localhost')) {
           return "DIRECT";
@@ -29,7 +29,7 @@ RSpec.describe 'Parse proxy.pac', type: :proxy_pac do
 
   describe 'Change time' do
     subject do
-      <<-EOS.strip_heredoc.chomp
+      <<~EOS.chomp
       function FindProxyForURL(url, host) {
         if (weekdayRange("FRI", "SAT")) {
           return "PROXY localhost:8080";
@@ -59,7 +59,7 @@ RSpec.describe 'Parse proxy.pac', type: :proxy_pac do
 
   describe 'Change client ip' do
     subject do
-      <<-EOS.strip_heredoc.chomp
+      <<~EOS.chomp
       function FindProxyForURL(url, host) {
         if ( myIpAddress() == '127.0.0.2' ) {
           return "PROXY localhost:8080";

data/spec/rspec/readability_spec.rb

@@ -4,14 +4,14 @@ require 'proxy_pac_rb/rspec'
 
 RSpec.describe 'Readability', type: [:proxy_pac, :aruba] do
   let(:content) do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
     EOS
   end
 
-  context 'when is file' do
+  context 'when is file', type: :aruba do
     let(:root_path) { expand_path('.') }
 
     subject { 'proxy.pac' }
@@ -45,7 +45,7 @@ RSpec.describe 'Readability', type: [:proxy_pac, :aruba] do
   context 'when is string' do
     context 'it is always readable' do
       subject do
-        <<-EOS.strip_heredoc.chomp
+        <<~EOS.chomp
         function FindProxyForURL(url, host) {
           return "DIRECT";
         }

data/spec/rspec/validitiy_spec.rb

@@ -4,7 +4,7 @@ require 'proxy_pac_rb/rspec'
 
 RSpec.describe 'Validity', type: :proxy_pac do
   subject do
-    <<-EOS.strip_heredoc.chomp
+    <<~EOS.chomp
       function FindProxyForURL(url, host) {
         return "DIRECT";
       }
@@ -16,7 +16,7 @@ RSpec.describe 'Validity', type: :proxy_pac do
 
     context 'although it makes URI to raise invalid url error' do
       subject do
-        <<-EOS.strip_heredoc.chomp
+        <<~EOS.chomp
         function FindProxyForURL(url, host) {
           // comment
           if ( dnsDomainIs ( host, "example.org") ) {
@@ -39,7 +39,7 @@ RSpec.describe 'Validity', type: :proxy_pac do
 
     context 'when contains gargabe' do
       subject do
-        <<-EOS.strip_heredoc.chomp
+        <<~EOS.chomp
         function FindProxyForURL(url, host) {
           return $§"% "DIRECT";
         }
@@ -51,7 +51,7 @@ RSpec.describe 'Validity', type: :proxy_pac do
 
     context 'when undefined variable is referenced' do
       subject do
-        <<-EOS.strip_heredoc.chomp
+        <<~EOS.chomp
         function FindProxyForURL(url, host) {
           return asdf;
         }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: proxy_pac_rb
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Dennis Günnewig
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-25 00:00:00.000000000 Z
+date: 2017-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -28,28 +28,34 @@ dependencies:
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: uglifier
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.7.1
 - !ruby/object:Gem::Dependency
@@ -113,6 +119,7 @@ files:
 - ".rdebugrc"
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".simplecov"
 - ".travis.yml"
 - ".yardopts"
@@ -260,7 +267,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.3
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: Compress, lint and parse proxy auto-config files from commandline, rack-compatible