proxy_pac_rb 0.3.2 → 0.3.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MDQ0MmUwYzQzNDAwMTMzMmFlOTk0NTc0MDNmNjRmMjE1NTE4MTBlMg==
+    YTczOTMwM2ZkNGNhM2E2YWE1MWJmMDRhNjc2OGNlNTM0ZTAwOWE1NA==
   data.tar.gz: !binary |-
-    NGYxM2QzNGY3ZWE1Nzc3ZmZiYjFjMzY2YWM0NTZmODg5OTg4ZmMwMQ==
+    MTE0Y2JmMWQzNGE3YmUwZjI0MmU0ZGYzMDcxZjE4ZGNkZTQ5MzlmNA==
 SHA512:
   metadata.gz: !binary |-
-    YWRhYzIwMTI2NDdlZmEyY2M1ZGNkYmQ5YTdlODI2MzllYmYwNmU3MjRmMGE5
-    Y2M4NGZkNmJkNGMwNzI3NmYyM2Y2NjgzMGI2MTAxNDBjYTcwMjlhYmQ4M2Q0
-    ZWNlZWYyYjMwN2FlNGUzYjgzNzU0MjZjMmUxODlhMjAyNGNmOTQ=
+    MmJkOTZjZWUwODQ1YzZhYjNhMjc4ZDI5Yjc0MzIzZDY0MDI2YjQ0MGI1M2Ni
+    MzhjMWZmOTk5OTBjMWFmZjU5NDAzZTU3MDRmZTY2YTEwODdmZTEzN2NhNWM1
+    MmFiNTk5YTJmMzNjYzUyNDBiNWE1NDZjZTE3NjhiYTE4ODljM2Q=
   data.tar.gz: !binary |-
-    NTRiZWVlZjFiNzFhYjYwMzczMDJmY2NhZmZjMjFiYjkwNGRiYTlkNTVjYmM1
-    NzlmN2Y4ZDc2OWZjMjNkZjhiMDMzZDNlZDQyZmYwMjY1ZDdlOGMzNjZkZmZl
-    OTZhNDBmYmMzMDNlMmFkOWFkYmQ2NzBiODJjYzE0MmIwNTA1Yjg=
+    ZTFlNDZiNjI0MGM3ZDI4MmY5MDM1ZDEyMDQ2ODhjMGVjMmM4NTM2NmI1ZjQz
+    ZjM5ZWMwMjk0NmIxZDlhMzM5MTRiN2RlMDJjMTdiZDQ2YjVmMDU0Yjg0YTli
+    MDU3YzQ1YzBmM2FiN2IzOTIxZWUxNzAzODQzZTIxZGZiY2UzYzI=

data/features/resolve_proxy.feature

@@ -119,3 +119,20 @@ Feature: Resolve proxy
     """
     DIRECT
     """
+
+  Scenario: Unresolvable hostname
+    Given a file named "proxy.pac" with:
+    """
+    function FindProxyForURL(url, host) {
+      if (isInNet(dnsResolve(host), "8.8.8.8", "255.0.0.0")) {
+        return 'PROXY localhost:3128';
+      } else {
+        return 'DIRECT';
+      }
+    }
+    """
+    When I successfully run `pprb -p proxy.pac unexist.localhost.localdomain`
+    Then the output should contain:
+    """
+    DIRECT
+    """

data/lib/proxy_pac_rb/environment.rb

@@ -58,7 +58,7 @@ module ProxyPacRb
     end
 
     def dnsResolve(host)
-      resolve_host(host)
+      resolve_host(host).to_s
     end
 
     def dnsDomainLevels(host)

data/lib/proxy_pac_rb/version.rb

@@ -1,4 +1,4 @@
 #main ProxyPacRb
 module ProxyPacRb
-  VERSION = '0.3.2'
+  VERSION = '0.3.3'
 end

data/spec/environment_spec.rb

@@ -11,8 +11,8 @@ describe ProxyPacRb::Environment do
       expect(environment.isResolvable("localhost")).to be_true
     end
 
-    it "should return false for awidhaowuhuiuhiuug" do
-      expect(environment.isResolvable('asdfasdfasdfasdf')).to be_false
+    it "should return false for unexist.domain.localdomain" do
+      expect(environment.isResolvable('unexist.domain.localdomain')).to be_false
     end
   end
 
@@ -75,6 +75,11 @@ describe ProxyPacRb::Environment do
       name =  'google-public-dns-a.google.com'
       expect(environment.dnsResolve(name)).to eq(ip)
     end
+
+    it 'return an empty string for a not resolvable host name' do
+      name =  'not.resolvable.localhost.localdomain'
+      expect(environment.dnsResolve(name)).to eq('')
+    end
   end
 
   describe '#dnsDomainLevels' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: proxy_pac_rb
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Dennis Günnewig
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-10 00:00:00.000000000 Z
+date: 2014-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable