protocol-rack 0.11.0 → 0.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 30e960af55f8f9e0c401657bd0e245c448f46315ef97cdd3d25aeeb8f41ef99c
-  data.tar.gz: 1d4f9d858799b04e909776e120f4f376aa54ad4a956bd077e109edc704f3a2ff
+  metadata.gz: ab3e913313df25d3592761df42df6f1926fd901b3363ad7347db464599d1964e
+  data.tar.gz: a4610f7973026ecce482e3c97ee1622466a5f65f969f4b6378108fd6c98a4f33
 SHA512:
-  metadata.gz: c71e270584bfe6e4da54ce6b175664880180ddf5ba2cb5fec1fb4ef3b67aa93af2ef78ecc0d74869f477caed03e5caf4e072758fef7f831fcb8e249ccea60e5f
-  data.tar.gz: 9af0d3f0bbd79784f9f8464a1cffdfc76f55e9d49e386a9c770b43af85da2a2d1a0dfd0bbb624d2465d99f79ae1ef2663848d38195a2816aa57ebb9a9588a926
+  metadata.gz: 0a08d73c2dd4e1621693404a3b74c504981b42cd81a6e1bbaae0f44b1ab1bf7b47515f509d1a700afa4bdaa31edcb9b238007e24e7b5c398ea12cddf01430f79
+  data.tar.gz: 6e948ed04abe9047f51623ffd7a93846050088328696e75fefc2c3f358b5cf4f5333a410963af2f2a8a9e17948baecdd07d7c3c6ea2245557c39f60d35bb3ce5

data/lib/protocol/rack/adapter/generic.rb

@@ -34,9 +34,17 @@ module Protocol
 					Console
 				end
 				
-				# Unwrap raw HTTP headers into the CGI-style expected by Rack middleware.
+				# Unwrap HTTP headers into the CGI-style expected by Rack middleware, and add them to the rack `env`.
 				#
-				# Rack separates multiple headers with the same key, into a single field with multiple lines.
+				# e.g. `accept-encoding` becomes `HTTP_ACCEPT_ENCODING`.
+				#
+				# Headers keys with underscores will generate the same CGI-style header key as headers with dashes.
+				#
+				# e.g `accept_encoding` becomes `HTTP_ACCEPT_ENCODING` too.
+				#
+				# You should not implicitly trust the `HTTP_` headers for security purposes, as they are generated by the client.
+				#
+				# Multiple headers are combined with a comma, with one exception: `HTTP_COOKIE` headers are combined with a semicolon.
 				#
 				# @parameter headers [Protocol::HTTP::Headers] The raw HTTP request headers.
 				# @parameter env [Hash] The rack request `env`.
@@ -66,6 +74,11 @@ module Protocol
 				# @parameter request [Protocol::HTTP::Request] The incoming request.
 				# @parameter env [Hash] The rack `env`.
 				def unwrap_request(request, env)
+					# The request protocol, either from the upgrade header or the HTTP/2 pseudo header of the same name.
+					if protocol = request.protocol
+						env[RACK_PROTOCOL] = protocol
+					end
+					
 					if content_type = request.headers.delete("content-type")
 						env[CGI::CONTENT_TYPE] = content_type
 					end

data/lib/protocol/rack/adapter/rack2.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2022-2024, by Samuel Williams.
+# Copyright, 2022-2025, by Samuel Williams.
+# Copyright, 2025, by Francisco Mejia.
 
 require "console"
 
@@ -37,9 +38,6 @@ module Protocol
 						RACK_ERRORS => $stderr,
 						RACK_LOGGER => self.logger,
 
-						# The request protocol, either from the upgrade header or the HTTP/2 pseudo header of the same name.
-						RACK_PROTOCOL => request.protocol,
-						
 						# The HTTP request method, such as “GET” or “POST”. This cannot ever be an empty string, and so is always required.
 						CGI::REQUEST_METHOD => request.method,
 						
@@ -62,8 +60,12 @@ module Protocol
 						
 						# I'm not sure what sane defaults should be here:
 						CGI::SERVER_NAME => server_name,
-						CGI::SERVER_PORT => server_port,
 					}
+
+					# SERVER_PORT is optional but must not be set if it is not present.
+					if server_port
+						env[CGI::SERVER_PORT] = server_port
+					end
 					
 					self.unwrap_request(request, env)
 					

data/lib/protocol/rack/adapter/rack3.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2022-2024, by Samuel Williams.
+# Copyright, 2022-2025, by Samuel Williams.
+# Copyright, 2025, by Francisco Mejia.
 
 require "console"
 
@@ -30,9 +31,6 @@ module Protocol
 						RACK_ERRORS => $stderr,
 						RACK_LOGGER => self.logger,
 						
-						# The request protocol, either from the upgrade header or the HTTP/2 pseudo header of the same name.
-						RACK_PROTOCOL => request.protocol,
-						
 						# The response finished callbacks:
 						RACK_RESPONSE_FINISHED => [],
 						
@@ -58,8 +56,12 @@ module Protocol
 						
 						# I'm not sure what sane defaults should be here:
 						CGI::SERVER_NAME => server_name,
-						CGI::SERVER_PORT => server_port,
 					}
+
+					# SERVER_PORT is optional but must not be set if it is not present.
+					if server_port
+						env[CGI::SERVER_PORT] = server_port
+					end
 					
 					self.unwrap_request(request, env)
 					

data/lib/protocol/rack/adapter/rack31.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2022-2024, by Samuel Williams.
+# Copyright, 2024-2025, by Samuel Williams.
+# Copyright, 2025, by Francisco Mejia.
 
 require "console"
 
@@ -21,9 +22,6 @@ module Protocol
 						RACK_ERRORS => $stderr,
 						RACK_LOGGER => self.logger,
 						
-						# The request protocol, either from the upgrade header or the HTTP/2 pseudo header of the same name.
-						RACK_PROTOCOL => request.protocol,
-						
 						# The response finished callbacks:
 						RACK_RESPONSE_FINISHED => [],
 						
@@ -49,8 +47,17 @@ module Protocol
 						
 						# I'm not sure what sane defaults should be here:
 						CGI::SERVER_NAME => server_name,
-						CGI::SERVER_PORT => server_port,
 					}
+
+					# SERVER_PORT is optional but must not be set if it is not present.
+					if server_port
+						env[CGI::SERVER_PORT] = server_port
+					end
+					
+					# The request protocol, either from the upgrade header or the HTTP/2 pseudo header of the same name.
+					if protocol = request.protocol
+						env[RACK_PROTOCOL] = protocol
+					end
 					
 					if body = request.body
 						if body.empty?

data/lib/protocol/rack/version.rb

@@ -5,6 +5,6 @@
 
 module Protocol
 	module Rack
-		VERSION = "0.11.0"
+		VERSION = "0.11.2"
 	end
 end

data/license.md

@@ -1,7 +1,8 @@
 # MIT License
 
-Copyright, 2022-2024, by Samuel Williams.  
+Copyright, 2022-2025, by Samuel Williams.  
 Copyright, 2023, by Genki Takiuchi.  
+Copyright, 2025, by Francisco Mejia.  
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/readme.md

@@ -11,6 +11,8 @@ Provides abstractions for working with the Rack specification on top of [`Protoc
 
 ## Usage
 
+Please see the [project documentation](https://socketry.github.io/protocol-rack/) for more details.
+
 ### Application Adapter
 
 Given a rack application, you can adapt it for use on `async-http`:
@@ -61,6 +63,14 @@ run proc{|env|
 }
 ```
 
+## Releases
+
+Please see the [project releases](https://socketry.github.io/protocol-rack/releases/index) for all releases.
+
+### v0.11.2
+
+  - Stop setting `env["SERVER_PORT"]` to `nil` if not present.
+
 ## Contributing
 
 We welcome contributions to this project.

data/releases.md

@@ -0,0 +1,5 @@
+# Releases
+
+## v0.11.2
+
+  - Stop setting `env["SERVER_PORT"]` to `nil` if not present.

metadata

@@ -1,12 +1,12 @@
 --- !ruby/object:Gem::Specification
 name: protocol-rack
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.2
 platform: ruby
 authors:
 - Samuel Williams
+- Francisco Mejia
 - Genki Takiuchi
-autorequire:
 bindir: bin
 cert_chain:
 - |
@@ -38,7 +38,7 @@ cert_chain:
   Q2K9NVun/S785AP05vKkXZEFYxqG6EW012U4oLcFl5MySFajYXRYbuUpH6AY+HP8
   voD0MPg1DssDLKwXyt1eKD/+Fq0bFWhwVM/1XiAXL7lyYUyOq24KHgQ2Csg=
   -----END CERTIFICATE-----
-date: 2024-11-09 00:00:00.000000000 Z
+date: 2025-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: protocol-http
@@ -68,8 +68,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
-description:
-email:
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -92,13 +90,13 @@ files:
 - lib/protocol/rack/version.rb
 - license.md
 - readme.md
+- releases.md
 homepage: https://github.com/socketry/protocol-rack
 licenses:
 - MIT
 metadata:
   documentation_uri: https://socketry.github.io/protocol-rack/
   source_code_uri: https://github.com/socketry/protocol-rack.git
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -113,8 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: An implementation of the Rack protocol/specification.
 test_files: []