protocol-http1 0.37.0 → 0.37.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b8ed289fdd31ce464d53ec0d87533f948cb000c05a966a53280f0d666a3f61e8
-  data.tar.gz: 88b8c7cd528012574849c4a221a6040139f884355affeebb8e1b9fd1666b69a2
+  metadata.gz: 97a6f38e50bdc78455b7f57895ef25df4dde6492142c2c60c40373b632c3db3b
+  data.tar.gz: 0fb9af13fd1beeb21082c7d1860604b1bc947d343598c6347387d99707990894
 SHA512:
-  metadata.gz: d21bc4fbd87fcb529f4eb367ce740fa31389f352dc7c9e5739e07be8b75c0233f97efdd28f8f9dffaa58c9fb482625c4c176eaae7b61ca1d38e665212a709128
-  data.tar.gz: 6d2784704a5e2a54f0ab742daf0514c14989bedd9578226d7ac74c6416deefa30c59e8bf7e0e715275c340ff6c7bd92275d9444918a21f799c4e899b695c844c
+  metadata.gz: b3cb82192723452081180be601e36491fe2a5d2b5f05fcc3556080a9311c846bdf2844c499981ac52338170cefdd097584ba8b53c52153af54cc29fbb4a405d9
+  data.tar.gz: a4013c3278818c2a632d3f41e46a6625c286f59391990819bda5b29c3c5d4fd82c328acae59107a4abeb5268deebc16bf91e3d3584a3b1be42ab3105a941a352

data/lib/protocol/http1/connection.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2019-2025, by Samuel Williams.
+# Copyright, 2019-2026, by Samuel Williams.
 # Copyright, 2019, by Brian Morearty.
 # Copyright, 2020, by Bruno Sutic.
 # Copyright, 2023-2024, by Thomas Morgan.
@@ -614,32 +614,34 @@ module Protocol
 				
 				if head
 					@stream.flush
+				else
+					@stream.flush unless body.ready?
 					
-					body.close
+					chunk_length = 0
+					# Use a manual read loop (not body.each) so that body.close runs after the response is fully written and flushed. This ensures completion callbacks (e.g. rack.response_finished) don't delay the client.
+					while chunk = body.read
+						chunk_length += chunk.bytesize
+						
+						if chunk_length > length
+							raise ContentLengthError, "Trying to write #{chunk_length} bytes, but content length was #{length} bytes!"
+						end
+						
+						@stream.write(chunk)
+						@stream.flush unless body.ready?
+					end
 					
-					return
-				end
-				
-				@stream.flush unless body.ready?
-				
-				chunk_length = 0
-				body.each do |chunk|
-					chunk_length += chunk.bytesize
+					@stream.flush
 					
-					if chunk_length > length
-						raise ContentLengthError, "Trying to write #{chunk_length} bytes, but content length was #{length} bytes!"
+					if chunk_length != length
+						raise ContentLengthError, "Wrote #{chunk_length} bytes, but content length was #{length} bytes!"
 					end
-					
-					@stream.write(chunk)
-					@stream.flush unless body.ready?
-				end
-				
-				@stream.flush
-				
-				if chunk_length != length
-					raise ContentLengthError, "Wrote #{chunk_length} bytes, but content length was #{length} bytes!"
 				end
+			rescue => error
+				raise
 			ensure
+				# Close the body after the response is fully flushed, so that completion callbacks run after the client has received the response:
+				body.close(error)
+				
 				self.send_end_stream!
 			end
 			
@@ -657,34 +659,36 @@ module Protocol
 				
 				if head
 					@stream.flush
+				else
+					@stream.flush unless body.ready?
 					
-					body.close
-					
-					return
-				end
-				
-				@stream.flush unless body.ready?
-				
-				body.each do |chunk|
-					next if chunk.size == 0
+					# Use a manual read loop (not body.each) so that body.close runs after the terminal chunk is written. With body.each, the ensure { close } fires before the terminal "0\r\n\r\n" is sent, delaying the client.
+					while chunk = body.read
+						next if chunk.size == 0
+						
+						@stream.write("#{chunk.bytesize.to_s(16).upcase}\r\n")
+						@stream.write(chunk)
+						@stream.write(CRLF)
+						
+						@stream.flush unless body.ready?
+					end
 					
-					@stream.write("#{chunk.bytesize.to_s(16).upcase}\r\n")
-					@stream.write(chunk)
-					@stream.write(CRLF)
+					if trailer&.any?
+						@stream.write("0\r\n")
+						write_headers(trailer)
+						@stream.write("\r\n")
+					else
+						@stream.write("0\r\n\r\n")
+					end
 					
-					@stream.flush unless body.ready?
-				end
-				
-				if trailer&.any?
-					@stream.write("0\r\n")
-					write_headers(trailer)
-					@stream.write("\r\n")
-				else
-					@stream.write("0\r\n\r\n")
+					@stream.flush
 				end
-				
-				@stream.flush
+			rescue => error
+				raise
 			ensure
+				# Close the body after the complete chunked response (including terminal chunk) is flushed, so that completion callbacks don't block the client from seeing the response as complete:
+				body.close(error)
+				
 				self.send_end_stream!
 			end
 			
@@ -697,12 +701,11 @@ module Protocol
 				@persistent = false
 				
 				@stream.write("\r\n")
-				@stream.flush unless body.ready?
 				
-				if head
-					body.close
-				else
-					body.each do |chunk|
+				unless head
+					@stream.flush unless body.ready?
+					
+					while chunk = body.read
 						@stream.write(chunk)
 						
 						@stream.flush unless body.ready?
@@ -711,7 +714,12 @@ module Protocol
 				
 				@stream.flush
 				@stream.close_write
+			rescue => error
+				raise
 			ensure
+				# Close the body after the stream is fully written and half-closed, so that completion callbacks run after the client has received the full response:
+				body.close(error)
+				
 				self.send_end_stream!
 			end
 			

data/lib/protocol/http1/error.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2019-2025, by Samuel Williams.
+# Copyright, 2019-2026, by Samuel Williams.
 
 require "protocol/http/error"
 

data/lib/protocol/http1/version.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
 # Released under the MIT License.
-# Copyright, 2019-2025, by Samuel Williams.
+# Copyright, 2019-2026, by Samuel Williams.
 
 module Protocol
 	module HTTP1
-		VERSION = "0.37.0"
+		VERSION = "0.37.1"
 	end
 end

data/readme.md

@@ -30,6 +30,10 @@ Please see the [project documentation](https://socketry.github.io/protocol-http1
 
 Please see the [project releases](https://socketry.github.io/protocol-http1/releases/index) for all releases.
 
+### v0.37.1
+
+  - Defer `body.close` in `write_chunked_body`, `write_fixed_length_body`, and `write_body_and_close` until after the response is fully written and flushed. Previously, `body.each` called `close` in its `ensure` block before the terminal chunk (chunked encoding) or final flush was written, causing `rack.response_finished` callbacks to delay the client-visible response completion.
+
 ### v0.37.0
 
   - `Protocol::HTTP1::BadRequest` now includes `Protocol::HTTP::BadRequest` for better interoperability and handling of bad request errors across different HTTP protocol implementations.
@@ -69,10 +73,6 @@ Please see the [project releases](https://socketry.github.io/protocol-http1/rele
 
   - Enforce one-way transition for persistent connections to prevent invalid state changes.
 
-### v0.30.0
-
-  - Make `authority` header optional in HTTP requests for improved flexibility.
-
 ## Contributing
 
 We welcome contributions to this project.

data/releases.md

@@ -1,5 +1,9 @@
 # Releases
 
+## v0.37.1
+
+  - Defer `body.close` in `write_chunked_body`, `write_fixed_length_body`, and `write_body_and_close` until after the response is fully written and flushed. Previously, `body.each` called `close` in its `ensure` block before the terminal chunk (chunked encoding) or final flush was written, causing `rack.response_finished` callbacks to delay the client-visible response completion.
+
 ## v0.37.0
 
   - `Protocol::HTTP1::BadRequest` now includes `Protocol::HTTP::BadRequest` for better interoperability and handling of bad request errors across different HTTP protocol implementations.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: protocol-http1
 version: !ruby/object:Gem::Version
-  version: 0.37.0
+  version: 0.37.1
 platform: ruby
 authors:
 - Samuel Williams
@@ -90,14 +90,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.2'
+      version: '3.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 4.0.6
 specification_version: 4
 summary: A low level implementation of the HTTP/1 protocol.
 test_files: []