protocol-http 0.23.11 → 0.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9545141abc2607b219662d4bac1bfda0fe878948e043efd1352422ffd36f53f3
-  data.tar.gz: 1ae4a8438b15dc1507134ff403089fb4512f4d69b1505fc2a0d8d94f1ae6fb68
+  metadata.gz: 9090658dcddc6852ae0af81355da65f40b615ca912fa2886cab18664e7a65b73
+  data.tar.gz: c853953e6e736c2c31b37211c42c7080de71926f2bf5d7eedf5457c1872a2777
 SHA512:
-  metadata.gz: ed6aba47c9faa13bc6350b4d8b3132f7ca19c162675e91621fd64c1215e6986d817cf65959ec0e68fca3a63b8101e8110a57045b4544af42a7165f9a04a0b463
-  data.tar.gz: 95b109acf30ac7b93c3abe0cfa02d40bffba865be594efcbfe86fadd97efadf5b04586fc4c9b214a880ebf6e870cb734d97627e812b4f5ed7cc74b13a9f1a7df
+  metadata.gz: db77e79eac214ede13bdc19cfb19c1b6cca8d3b0473f4414049cfa2ad7fb84bfdf888a1ce0169a97a3966f7a5d3b0d7a9e194a79e6466ae52b4deb266870bd73
+  data.tar.gz: b44a52164ac2d7ea6fd89746757d524651a07b10eaf509db734b23dc9af5a5d11d7295fe46669c000aa31a935792632ccd2acc2b2b7a3d8c6413bd89fab1d686

data/design.md

@@ -0,0 +1,167 @@
+# Middleware Design
+
+`Body::Writable` is a queue of String chunks.
+
+## Request Response Model
+
+~~~ruby
+class Request
+	attr :verb
+	attr :target
+	attr :body
+end
+
+class Response
+	attr :status
+	attr :headers
+	attr :body
+end
+
+def call(request)
+	return response
+end
+
+def call(request)
+	return @app.call(request)
+end
+~~~
+
+## Stream Model
+
+~~~ruby
+class Stream
+	attr :verb
+	attr :target
+	
+	def respond(status, headers) = ...
+	
+	attr_accessor :input
+	attr_accessor :output
+end
+
+class Response
+	def initialize(verb, target)
+		@input = Body::Writable.new
+		@output = Body::Writable.new
+	end
+	
+	def request(verb, target)
+		# Create a request stream suitable for writing into the buffered response:
+		Stream.new(verb, target, @input, @output)
+	end
+	
+	def write(...)
+		@input.write(...)
+	end
+	
+	def read
+		@output.read
+	end
+end
+
+def call(stream)
+	# nothing. maybe error
+end
+
+def call(stream)
+	@app.call(stream)
+end
+~~~
+
+# Client Design
+
+## Request Response Model
+
+~~~ruby
+request = Request.new("GET", url)
+response = call(request)
+
+response.headers
+response.read
+~~~
+
+## Stream Model
+
+~~~ruby
+response = Response.new
+call(response.request("GET", url))
+
+response.headers
+response.read
+~~~
+
+## Differences
+
+The request/response model has a symmetrical design which naturally uses the return value for the result of executing the request. The result encapsulates the behaviour of how to read the response status, headers and body. Because of that, streaming input and output becomes a function of the result object itself. As in:
+
+~~~ruby
+def call(request)
+	body = Body::Writable.new
+	
+	Fiber.schedule do
+		while chunk = request.input.read
+			body.write(chunk.reverse)
+		end
+	end
+	
+	return Response[200, [], body]
+end
+
+input = Body::Writable.new
+response = call(... body ...)
+
+input.write("Hello World")
+input.close
+response.read -> "dlroW olleH"
+~~~
+
+The streaming model does not have the same symmetry, and instead opts for a uni-directional flow of information.
+
+~~~ruby
+def call(stream)
+	Fiber.schedule do
+		while chunk = stream.read
+			stream.write(chunk.reverse)
+		end
+	end
+end
+
+input = Body::Writable.new
+response = Response.new(...input...)
+call(response.stream)
+
+input.write("Hello World")
+input.close
+response.read -> "dlroW olleH"
+~~~
+
+The value of this uni-directional flow is that it is natural for the stream to be taken out of the scope imposed by the nested `call(request)` model. However, the user must explicitly close the stream, since it's no longer scoped to the client and/or server.
+
+## Connection Upgrade
+
+### HTTP/1
+
+```
+GET /path/to/websocket HTTP/1.1
+connection: upgrade
+upgrade: websocket
+```
+
+Request.new(GET, ..., protocol = websocket)
+-> Response.new(101, ..., protocol = websocket)
+
+```
+101 Switching Protocols
+upgrade: websocket
+```
+
+### HTTP/2
+
+```
+:method CONNECT
+:path /path/to/websocket
+:protocol websocket
+```
+
+Request.new(CONNECT, ..., protocol = websocket)
+-> Response.new(200, ..., protocol = websocket)

data/lib/protocol/http/accept_encoding.rb

@@ -1,24 +1,7 @@
 # frozen_string_literal: true
 
-# Copyright, 2017, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
+# Released under the MIT License.
+# Copyright, 2019-2023, by Samuel Williams.
 
 require_relative 'middleware'
 
@@ -34,7 +17,9 @@ module Protocol
 			
 			DEFAULT_WRAPPERS = {
 				'gzip' => Body::Inflate.method(:for),
-				'identity' => ->(body){body},
+				
+				# There is no point including this:
+				# 'identity' => ->(body){body},
 			}
 			
 			def initialize(app, wrappers = DEFAULT_WRAPPERS)

data/lib/protocol/http/body/buffered.rb

@@ -1,24 +1,8 @@
 # frozen_string_literal: true
 
-# Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
+# Released under the MIT License.
+# Copyright, 2019-2023, by Samuel Williams.
+# Copyright, 2020, by Bryan Powell.
 
 require_relative 'readable'
 

data/lib/protocol/http/body/completable.rb

@@ -1,24 +1,7 @@
 # frozen_string_literal: true
 
-# Copyright, 2020, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
+# Released under the MIT License.
+# Copyright, 2019-2023, by Samuel Williams.
 
 require_relative 'wrapper'
 

data/lib/protocol/http/body/deflate.rb

@@ -1,24 +1,7 @@
 # frozen_string_literal: true
 
-# Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
+# Released under the MIT License.
+# Copyright, 2019-2023, by Samuel Williams.
 
 require_relative 'wrapper'
 
@@ -38,16 +21,6 @@ module Protocol
 					'gzip' => GZIP,
 				}
 				
-				def self.encoding_name(window_size)
-					if window_size <= -8
-						return 'deflate'
-					elsif window_size >= 16
-						return 'gzip'
-					else
-						return 'compress'
-					end
-				end
-				
 				def initialize(body, stream)
 					super(body)
 					
@@ -89,6 +62,12 @@ module Protocol
 					self.new(body, Zlib::Deflate.new(level, window_size))
 				end
 				
+				def stream?
+					# We might want to revisit this design choice.
+					# We could wrap the streaming body in a Deflate stream, but that would require an extra stream wrapper which we don't have right now. See also `Digestable#stream?`.
+					false
+				end
+				
 				def read
 					return if @stream.finished?
 					
@@ -112,4 +91,4 @@ module Protocol
 			end
 		end
 	end
-end
+end

data/lib/protocol/http/body/digestable.rb

@@ -1,24 +1,7 @@
 # frozen_string_literal: true
 
-# Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
+# Released under the MIT License.
+# Copyright, 2020-2023, by Samuel Williams.
 
 require_relative 'wrapper'
 
@@ -35,6 +18,7 @@ module Protocol
 					end
 				end
 				
+				# @parameter callback [Block] The callback is invoked when the digest is complete.
 				def initialize(body, digest = Digest::SHA256.new, callback = nil)
 					super(body)
 					
@@ -46,8 +30,16 @@ module Protocol
 					@digest
 				end
 				
-				def etag
-					@digest.hexdigest.dump
+				def etag(weak: false)
+					if weak
+						"W/\"#{digest.hexdigest}\""
+					else
+						"\"#{digest.hexdigest}\""
+					end
+				end
+				
+				def stream?
+					false
 				end
 				
 				def read

data/lib/protocol/http/body/file.rb

@@ -1,33 +1,15 @@
 # frozen_string_literal: true
 
-# Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
+# Released under the MIT License.
+# Copyright, 2019-2023, by Samuel Williams.
 
 require_relative 'readable'
-require 'async/io/stream'
 
 module Protocol
 	module HTTP
 		module Body
 			class File < Readable
-				BLOCK_SIZE = Async::IO::BLOCK_SIZE
+				BLOCK_SIZE = 4096
 				MODE = ::File::RDONLY | ::File::BINARY
 				
 				def self.open(path, *arguments, **options)
@@ -71,6 +53,11 @@ module Protocol
 				
 				def rewind
 					@file.seek(@offset)
+					@remaining = @length
+				end
+				
+				def stream?
+					false
 				end
 				
 				def read

data/lib/protocol/http/body/head.rb

@@ -1,24 +1,7 @@
 # frozen_string_literal: true
 
-# Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
+# Released under the MIT License.
+# Copyright, 2020-2023, by Samuel Williams.
 
 require_relative 'readable'
 
@@ -52,4 +35,4 @@ module Protocol
 			end
 		end
 	end
-end
+end

data/lib/protocol/http/body/inflate.rb

@@ -1,24 +1,7 @@
 # frozen_string_literal: true
 
-# Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
+# Released under the MIT License.
+# Copyright, 2019-2023, by Samuel Williams.
 
 require 'zlib'
 
@@ -32,20 +15,27 @@ module Protocol
 					self.new(body, Zlib::Inflate.new(encoding))
 				end
 				
+				def stream?
+					false
+				end
+				
 				def read
 					return if @stream.finished?
 					
 					# The stream might have been closed while waiting for the chunk to come in.
-					if chunk = super
+					while chunk = super
 						@input_length += chunk.bytesize
 						
 						# It's possible this triggers the stream to finish.
 						chunk = @stream.inflate(chunk)
 						
+						break unless chunk&.empty?
+					end
+					
+					if chunk
 						@output_length += chunk.bytesize
 					elsif !@stream.closed?
 						chunk = @stream.finish
-						
 						@output_length += chunk.bytesize
 					end
 					
@@ -58,4 +48,4 @@ module Protocol
 			end
 		end
 	end
-end
+end

data/lib/protocol/http/body/readable.rb

@@ -1,26 +1,7 @@
 # frozen_string_literal: true
 
-# Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
-
-require 'async/io/buffer'
+# Released under the MIT License.
+# Copyright, 2019-2023, by Samuel Williams.
 
 module Protocol
 	module HTTP
@@ -39,12 +20,14 @@ module Protocol
 				def close(error = nil)
 				end
 				
-				# Will read return any data?
+				# Optimistically determine whether read (may) return any data.
+				# If this returns true, then calling read will definitely return nil.
+				# If this returns false, then calling read may return nil.
 				def empty?
 					false
 				end
 				
-				# Whether calling read will block.
+				# Whether calling read will return a chunk of data without blocking.
 				# We prefer pessimistic implementation, and thus default to `false`.
 				# @return [Boolean]
 				def ready?

data/lib/protocol/http/body/reader.rb

@@ -1,24 +1,8 @@
 # frozen_string_literal: true
 
-# Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
+# Released under the MIT License.
+# Copyright, 2019-2023, by Samuel Williams.
+# Copyright, 2022, by Dan Olson.
 
 module Protocol
 	module HTTP
@@ -57,9 +41,9 @@ module Protocol
 				end
 				
 				# Write the body of the response to the given file path.
-				def save(path, mode = ::File::WRONLY|::File::CREAT, *args)
+				def save(path, mode = ::File::WRONLY|::File::CREAT, **options)
 					if @body
-						::File.open(path, mode, *args) do |file|
+						::File.open(path, mode, **options) do |file|
 							self.each do |chunk|
 								file.write(chunk)
 							end

data/lib/protocol/http/body/rewindable.rb

@@ -1,24 +1,7 @@
 # frozen_string_literal: true
 
-# Copyright, 2018, by Samuel G. D. Williams. <http://www.codeotaku.com>
-# 
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-# 
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-# 
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
+# Released under the MIT License.
+# Copyright, 2019-2023, by Samuel Williams.
 
 require_relative 'wrapper'
 require_relative 'buffered'
@@ -48,6 +31,10 @@ module Protocol
 					Buffered.new(@chunks)
 				end
 				
+				def stream?
+					false
+				end
+				
 				def read
 					if @index < @chunks.size
 						chunk = @chunks[@index]