protobuf 3.10.9 → 3.10.10

data/spec/lib/protobuf/railtie_spec.rb

@@ -0,0 +1,86 @@
+require 'spec_helper'
+require 'protobuf/railtie'
+
+RSpec.describe Protobuf::Railtie do
+  let(:config) do
+    double('config', :protobuf => ::ActiveSupport::OrderedOptions.new)
+  end
+
+  let(:app) { double('app', :config => config, :root => Pathname.new('/srv/app')) }
+
+  describe '.services_path' do
+    it 'is nil when not configured (opt-in)' do
+      expect(described_class.services_path(app)).to be_nil
+    end
+
+    it 'is nil when configured as an empty string' do
+      config.protobuf.services_path = ''
+      expect(described_class.services_path(app)).to be_nil
+    end
+
+    it 'honors an absolute path' do
+      config.protobuf.services_path = '/custom/services'
+      expect(described_class.services_path(app)).to eq('/custom/services')
+    end
+
+    it 'resolves a relative path against the app root' do
+      config.protobuf.services_path = 'app/services/rpc'
+      expect(described_class.services_path(app)).to eq('/srv/app/app/services/rpc')
+    end
+
+    it 'accepts a Pathname' do
+      config.protobuf.services_path = Pathname.new('/custom/services')
+      expect(described_class.services_path(app)).to eq('/custom/services')
+    end
+  end
+
+  describe '.load_services' do
+    let(:loader) { double('autoloader') }
+
+    before do
+      allow(described_class).to receive(:services_path).and_return('/svc')
+      allow(::File).to receive(:directory?).and_call_original
+      allow(::File).to receive(:directory?).with('/svc').and_return(true)
+      stub_const('Rails', double('Rails', :autoloaders => double(:main => loader)))
+    end
+
+    it 'does nothing when no path is configured' do
+      allow(described_class).to receive(:services_path).and_return(nil)
+      expect(::Protobuf::ServiceLoader).not_to receive(:load_services)
+      described_class.load_services(app)
+    end
+
+    it 'does nothing when the directory is missing' do
+      allow(::File).to receive(:directory?).with('/svc').and_return(false)
+      expect(::Protobuf::ServiceLoader).not_to receive(:load_services)
+      described_class.load_services(app)
+    end
+
+    it 'eager-loads through the autoloader when eager_load_dir is available' do
+      allow(loader).to receive(:respond_to?).with(:eager_load_dir).and_return(true)
+      expect(loader).to receive(:eager_load_dir).with('/svc')
+      expect(::Protobuf::ServiceLoader).not_to receive(:load_services)
+      described_class.load_services(app)
+    end
+
+    it 'falls back to ServiceLoader when eager_load_dir is unavailable' do
+      allow(loader).to receive(:respond_to?).with(:eager_load_dir).and_return(false)
+      expect(::Protobuf::ServiceLoader).to receive(:load_services).with('/svc')
+      described_class.load_services(app)
+    end
+
+    it 'falls back to ServiceLoader with the classic autoloader (no main loader)' do
+      stub_const('Rails', double('Rails', :autoloaders => double(:main => nil)))
+      expect(::Protobuf::ServiceLoader).to receive(:load_services).with('/svc')
+      described_class.load_services(app)
+    end
+
+    it 'falls back to ServiceLoader when the path is not autoloader-managed' do
+      stub_const('Zeitwerk::Error', Class.new(StandardError))
+      allow(loader).to receive(:respond_to?).with(:eager_load_dir).and_return(true)
+      allow(loader).to receive(:eager_load_dir).and_raise(::Zeitwerk::Error)
+      expect(::Protobuf::ServiceLoader).to receive(:load_services).with('/svc')
+      described_class.load_services(app)
+    end
+  end
+end

data/spec/lib/protobuf/rpc/application_service_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+require SUPPORT_PATH.join('resource_service')
+
+RSpec.describe Protobuf::Rpc::ApplicationService do
+  it 'is a subclass of Protobuf::Rpc::Service' do
+    expect(described_class.ancestors).to include(Protobuf::Rpc::Service)
+  end
+
+  it 'inherits Service class methods (host, port, configure)' do
+    expect(described_class).to respond_to(:host, :port, :configure, :rpc, :rpcs)
+  end
+
+  describe 'integration with implemented_services' do
+    let!(:app_subclass) do
+      Class.new(described_class) do
+        def self.name
+          'ImplementedAppSubclassService'
+        end
+
+        rpc :find, Test::ResourceFindRequest, Test::Resource
+        def find; end
+      end
+    end
+
+    let!(:abstract_subclass) do
+      Class.new(described_class) do
+        def self.name
+          'AbstractAppSubclassService'
+        end
+
+        rpc :find, Test::ResourceFindRequest, Test::Resource
+        # no #find method defined -> not "implemented"
+      end
+    end
+
+    after do
+      # `descendants` holds these classes until GC, which can run late. Remove
+      # the rpc method so other specs do not see this class as implemented.
+      app_subclass.send(:remove_method, :find)
+    end
+
+    it 'is discovered by Service.implemented_services (descendants traversal)' do
+      names = Protobuf::Rpc::Service.implemented_services
+      expect(names).to include('ImplementedAppSubclassService')
+    end
+
+    it 'omits subclasses with no implemented rpc methods' do
+      names = Protobuf::Rpc::Service.implemented_services
+      expect(names).not_to include('AbstractAppSubclassService')
+    end
+
+    it 'does not list the ApplicationService base itself' do
+      names = Protobuf::Rpc::Service.implemented_services
+      expect(names).not_to include(described_class.name)
+    end
+  end
+end

data/spec/lib/protobuf/rpc/service_filters_inheritance_spec.rb

@@ -0,0 +1,105 @@
+require 'spec_helper'
+
+RSpec.describe 'Protobuf::Rpc::ServiceFilters inheritance' do
+  let(:parent) do
+    Class.new do
+      include Protobuf::Rpc::ServiceFilters
+    end
+  end
+
+  def callables(klass, type)
+    klass.filters[type].map { |filter| filter[:callable] }
+  end
+
+  it 'copies the parent filters to a new subclass' do
+    parent.before_filter :authenticate
+    parent.around_filter :instrument
+    child = Class.new(parent)
+
+    expect(callables(child, :before)).to eq([:authenticate])
+    expect(callables(child, :around)).to eq([:instrument])
+  end
+
+  it 'does not add subclass filters to the parent' do
+    child = Class.new(parent)
+    child.before_filter :child_only
+
+    expect(callables(parent, :before)).to eq([])
+  end
+
+  it 'adds a filter that the parent defines later to existing subclasses' do
+    child = Class.new(parent)
+    grandchild = Class.new(child)
+    child.before_filter :child_only
+    parent.before_filter :shared
+
+    expect(callables(child, :before)).to eq([:child_only, :shared])
+    expect(callables(grandchild, :before)).to eq([:child_only, :shared])
+  end
+
+  it 'does not add the same filter two times to a subclass' do
+    parent.before_filter :authenticate
+    child = Class.new(parent)
+    child.before_filter :authenticate
+    parent.before_filter :authenticate
+
+    expect(callables(child, :before)).to eq([:authenticate])
+  end
+
+  describe 'rescue_from' do
+    let(:parent_handler) { ->(_service, _ex) {} }
+    let(:child_handler) { ->(_service, _ex) {} }
+
+    it 'copies the parent rescue filters to a new subclass' do
+      parent.rescue_from(ArgumentError, :with => parent_handler)
+      child = Class.new(parent)
+
+      expect(child.rescue_filters).to eq(ArgumentError => parent_handler)
+    end
+
+    it 'adds a rescue filter that the parent defines later to existing subclasses' do
+      child = Class.new(parent)
+      parent.rescue_from(ArgumentError, :with => parent_handler)
+
+      expect(child.rescue_filters).to eq(ArgumentError => parent_handler)
+    end
+
+    it 'keeps a handler that the subclass defined for the same exception class' do
+      child = Class.new(parent)
+      child.rescue_from(ArgumentError, :with => child_handler)
+      parent.rescue_from(ArgumentError, :with => parent_handler)
+
+      expect(child.rescue_filters[ArgumentError]).to eq(child_handler)
+    end
+
+    it 'replaces an inherited handler when the parent changes it' do
+      parent.rescue_from(ArgumentError, :with => child_handler)
+      child = Class.new(parent)
+      parent.rescue_from(ArgumentError, :with => parent_handler)
+
+      expect(child.rescue_filters[ArgumentError]).to eq(parent_handler)
+    end
+  end
+
+  it 'runs filters from Protobuf::Rpc::ApplicationService on a subclass' do
+    base = Class.new(Protobuf::Rpc::ApplicationService) do
+      before_filter :mark
+
+      def mark
+        @marked = true
+      end
+    end
+    service = Class.new(base) do
+      def marked?
+        @marked
+      end
+
+      def endpoint; end
+    end
+
+    instance = service.allocate
+    instance.__send__(:run_filters, :endpoint)
+
+    expect(instance).to be_marked
+  end
+end

data/spec/lib/protobuf/service_loader_spec.rb

@@ -0,0 +1,88 @@
+require 'spec_helper'
+require 'tmpdir'
+require 'fileutils'
+require 'protobuf/service_loader'
+
+RSpec.describe Protobuf::ServiceLoader do
+  describe '.load_services' do
+    around do |example|
+      Dir.mktmpdir do |dir|
+        @services_dir = dir
+        example.run
+      end
+    end
+
+    let(:tracker) { [] }
+
+    before do
+      # Expose the tracker globally so the required files can reach it.
+      $service_loader_spec_tracker = tracker # rubocop:disable Style/GlobalVars
+    end
+
+    after do
+      $service_loader_spec_tracker = nil # rubocop:disable Style/GlobalVars
+    end
+
+    def write_service(relative_path, marker)
+      full = File.join(@services_dir, relative_path)
+      FileUtils.mkdir_p(File.dirname(full))
+      File.write(full, "$service_loader_spec_tracker << #{marker.inspect}\n")
+      full
+    end
+
+    it 'returns an empty array when path is nil' do
+      expect(described_class.load_services(nil)).to eq([])
+    end
+
+    it 'returns an empty array when directory does not exist' do
+      expect(described_class.load_services('/no/such/dir/here')).to eq([])
+    end
+
+    it 'loads every .rb file under the path' do
+      write_service('foo_service.rb', 'foo')
+      write_service('nested/bar_service.rb', 'bar')
+      write_service('helper.rb', 'helper')
+      write_service('notes.txt', 'nope')
+
+      described_class.load_services(@services_dir)
+
+      expect(tracker).to contain_exactly('foo', 'bar', 'helper')
+    end
+
+    it 'loads files in deterministic (sorted) order' do
+      write_service('b_service.rb', 'b')
+      write_service('a_service.rb', 'a')
+      write_service('c_service.rb', 'c')
+
+      described_class.load_services(@services_dir)
+
+      expect(tracker).to eq(%w[a b c])
+    end
+
+    it 'does not execute a file a second time on later calls' do
+      write_service('once_service.rb', 'one')
+
+      described_class.load_services(@services_dir)
+      described_class.load_services(@services_dir)
+
+      expect(tracker).to eq(%w[one])
+    end
+
+    it 'accepts a Pathname for the path' do
+      write_service('path_service.rb', 'path')
+
+      described_class.load_services(Pathname.new(@services_dir))
+
+      expect(tracker).to eq(['path'])
+    end
+
+    it 'honors a custom glob' do
+      write_service('foo_handler.rb', 'handler')
+      write_service('bar_service.rb', 'service')
+
+      described_class.load_services(@services_dir, '**/*_handler.rb')
+
+      expect(tracker).to eq(['handler'])
+    end
+  end
+end

metadata

@@ -1,17 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: protobuf
 version: !ruby/object:Gem::Version
-  version: 3.10.9
+  version: 3.10.10
 platform: ruby
 authors:
 - BJ Neilsen
 - Brandon Dewitt
 - Devin Christensen
 - Adam Hutchison
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-12 00:00:00.000000000 Z
+date: 2026-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -19,14 +18,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: middleware
   requirement: !ruby/object:Gem::Requirement
@@ -69,6 +68,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: benchmark
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
   requirement: !ruby/object:Gem::Requirement
@@ -97,6 +110,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: railties
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '6.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -258,6 +285,8 @@ files:
 - lib/protobuf/message/fields.rb
 - lib/protobuf/message/serialization.rb
 - lib/protobuf/optionable.rb
+- lib/protobuf/railtie.rb
+- lib/protobuf/rpc/application_service.rb
 - lib/protobuf/rpc/buffer.rb
 - lib/protobuf/rpc/client.rb
 - lib/protobuf/rpc/connectors/base.rb
@@ -291,6 +320,7 @@ files:
 - lib/protobuf/rpc/service_dispatcher.rb
 - lib/protobuf/rpc/service_filters.rb
 - lib/protobuf/rpc/stat.rb
+- lib/protobuf/service_loader.rb
 - lib/protobuf/socket.rb
 - lib/protobuf/tasks.rb
 - lib/protobuf/tasks/compile.rake
@@ -309,8 +339,11 @@ files:
 - spec/bin/protoc-gen-ruby_spec.rb
 - spec/encoding/all_types_spec.rb
 - spec/encoding/extreme_values_spec.rb
+- spec/encoding/packed_decoding_spec.rb
+- spec/encoding/wire_compat_decoding_spec.rb
 - spec/functional/class_inheritance_spec.rb
 - spec/functional/code_generator_spec.rb
+- spec/functional/railtie_boot_spec.rb
 - spec/functional/socket_server_spec.rb
 - spec/functional/zmq_server_spec.rb
 - spec/lib/protobuf/cli_spec.rb
@@ -345,6 +378,8 @@ files:
 - spec/lib/protobuf/lifecycle_spec.rb
 - spec/lib/protobuf/message_spec.rb
 - spec/lib/protobuf/optionable_spec.rb
+- spec/lib/protobuf/railtie_spec.rb
+- spec/lib/protobuf/rpc/application_service_spec.rb
 - spec/lib/protobuf/rpc/client_spec.rb
 - spec/lib/protobuf/rpc/connectors/base_spec.rb
 - spec/lib/protobuf/rpc/connectors/ping_spec.rb
@@ -360,9 +395,11 @@ files:
 - spec/lib/protobuf/rpc/servers/zmq/worker_spec.rb
 - spec/lib/protobuf/rpc/service_directory_spec.rb
 - spec/lib/protobuf/rpc/service_dispatcher_spec.rb
+- spec/lib/protobuf/rpc/service_filters_inheritance_spec.rb
 - spec/lib/protobuf/rpc/service_filters_spec.rb
 - spec/lib/protobuf/rpc/service_spec.rb
 - spec/lib/protobuf/rpc/stat_spec.rb
+- spec/lib/protobuf/service_loader_spec.rb
 - spec/lib/protobuf/varint_spec.rb
 - spec/lib/protobuf_spec.rb
 - spec/spec_helper.rb
@@ -401,7 +438,6 @@ homepage: https://github.com/localshred/protobuf
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -409,15 +445,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Google Protocol Buffers serialization and RPC implementation for Ruby.
 test_files:
@@ -425,8 +460,11 @@ test_files:
 - spec/bin/protoc-gen-ruby_spec.rb
 - spec/encoding/all_types_spec.rb
 - spec/encoding/extreme_values_spec.rb
+- spec/encoding/packed_decoding_spec.rb
+- spec/encoding/wire_compat_decoding_spec.rb
 - spec/functional/class_inheritance_spec.rb
 - spec/functional/code_generator_spec.rb
+- spec/functional/railtie_boot_spec.rb
 - spec/functional/socket_server_spec.rb
 - spec/functional/zmq_server_spec.rb
 - spec/lib/protobuf/cli_spec.rb
@@ -461,6 +499,8 @@ test_files:
 - spec/lib/protobuf/lifecycle_spec.rb
 - spec/lib/protobuf/message_spec.rb
 - spec/lib/protobuf/optionable_spec.rb
+- spec/lib/protobuf/railtie_spec.rb
+- spec/lib/protobuf/rpc/application_service_spec.rb
 - spec/lib/protobuf/rpc/client_spec.rb
 - spec/lib/protobuf/rpc/connectors/base_spec.rb
 - spec/lib/protobuf/rpc/connectors/ping_spec.rb
@@ -476,9 +516,11 @@ test_files:
 - spec/lib/protobuf/rpc/servers/zmq/worker_spec.rb
 - spec/lib/protobuf/rpc/service_directory_spec.rb
 - spec/lib/protobuf/rpc/service_dispatcher_spec.rb
+- spec/lib/protobuf/rpc/service_filters_inheritance_spec.rb
 - spec/lib/protobuf/rpc/service_filters_spec.rb
 - spec/lib/protobuf/rpc/service_spec.rb
 - spec/lib/protobuf/rpc/stat_spec.rb
+- spec/lib/protobuf/service_loader_spec.rb
 - spec/lib/protobuf/varint_spec.rb
 - spec/lib/protobuf_spec.rb
 - spec/spec_helper.rb