protobuf 3.0.3 → 3.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a25179bb7b98c63e8ef320ebbed6b649244897af
-  data.tar.gz: 3df0b7a26092c7e5ac79c75893ec965f4fefd150
+  metadata.gz: dd448f24362b0e9378d3281d77291538d862d4d1
+  data.tar.gz: 592b16f0af1c48b7c8336ea32f35a646f3947a9c
 SHA512:
-  metadata.gz: 876507d1ac360749d4cb83c029ecf14632c0a452ce8005e8503f33a1f44d65bf1f6a690566e5d3eb4a2411b1450141200c61109e94dee9a56c18f87b83a1d583
-  data.tar.gz: 0b83772263222d04aadaf02f1ef82d3cfaf5363fb45e30615b791cce632beb43ab1c6be5124c3d78ff18083a29032965a96b1b3af31278b3da2830f7a66464d8
+  metadata.gz: a73428f4308d156ea94d9737e792b16db2455013a976ef6c5e22f2ca7f59ab156e43323816d1c30099934131fdde704d3741becf909decf76cf590b36d0fd75c
+  data.tar.gz: 9e66f6d8762f9c62c2d1ce01c34fc1ef841ebd32c05bc8630d0008f05572e7c9644e197e9e66d74bee08cc77b81a20c3f8c4300c64524ef8839dc8bea44ab2cc

data/CHANGES.md

@@ -1,5 +1,12 @@
 # Stable (3.x)
 
+3.0.4
+--------
+
+- Raise specific MethodNotFound when service class doesn't respond to (publicly implement)
+    the rpc method called from the client. Stop rescuing all NoMethodError's thrown
+    by service implementations. [#193, @liveh2o]
+
 3.0.3
 ---------
 
@@ -100,6 +107,11 @@ __!! NOTE: These deprecated methods will be removed in v3.1. !!__
    as an env variable to the client process to ensure the client asks the server
    if it is alive (able to server requests to clients). [#183, @abrandoned]
 
+2.8.13
+---------
+
+- Backport #190 to 2.8 stable series. [#192]
+
 2.8.12
 ---------
 

data/lib/protobuf/rpc/service_dispatcher.rb

@@ -26,10 +26,12 @@ module Protobuf
 
       # Call the given service method.
       def dispatch_rpc_request
+        unless rpc_service.respond_to?(method_name)
+          raise MethodNotFound.new("#{service_name}##{method_name} is not a publicly defined method.")
+        end
+
         rpc_service.callable_rpc_method(method_name).call
         rpc_service.response
-      rescue NoMethodError
-        raise MethodNotFound.new("#{service_name}##{method_name} is not implemented.")
       end
 
       def method_name

data/lib/protobuf/version.rb

@@ -1,3 +1,3 @@
 module Protobuf
-  VERSION = '3.0.3'
+  VERSION = '3.0.4'
 end

data/spec/lib/protobuf/rpc/service_dispatcher_spec.rb

@@ -6,13 +6,17 @@ describe Protobuf::Rpc::ServiceDispatcher do
   let(:env) {
     Protobuf::Rpc::Env.new(
       'method_name' => method_name,
+      'request' => request,
       'rpc_service' => service_class,
       'service_name' => service_name,
     )
   }
   let(:method_name) { :find }
+  let(:request) { request_type.new(:name => 'required') }
+  let(:request_type) { service_class.rpcs[method_name].request_type }
   let(:response) { response_type.new(:name => 'required') }
   let(:response_type) { service_class.rpcs[method_name].response_type }
+
   let(:rpc_service) { service_class.new(env) }
   let(:service_class) { Test::ResourceService }
   let(:service_name) { service_class.to_s }
@@ -22,7 +26,6 @@ describe Protobuf::Rpc::ServiceDispatcher do
   before { subject.stub(:rpc_service).and_return(rpc_service) }
 
   describe '#call' do
-    before { rpc_service.stub(:callable_rpc_method).and_return(lambda {}) }
     before { rpc_service.stub(:response).and_return(response) }
 
     it "dispatches the request" do
@@ -31,11 +34,19 @@ describe Protobuf::Rpc::ServiceDispatcher do
     end
 
     context "when the given RPC method is not implemented" do
-      before { rpc_service.stub(:callable_rpc_method).and_return(lambda { rpc_service.__send__(:foo) }) }
+      let(:method_name) { :find_not_implemented }
 
       it "raises a method not found exception" do
         expect { subject.call(env) }.to raise_exception(Protobuf::Rpc::MethodNotFound)
       end
     end
+
+    context "when the given RPC method is implemented and a NoMethodError is raised" do
+      before { rpc_service.stub(:callable_rpc_method).and_return(lambda { rpc_service.__send__(:foo) }) }
+
+      it "raises the exeception" do
+        expect { subject.call(env) }.to raise_exception(NoMethodError)
+      end
+    end
   end
 end

data/spec/support/test/resource.pb.rb

@@ -110,6 +110,7 @@ module Test
     rpc :find, ::Test::ResourceFindRequest, ::Test::Resource
     rpc :find_with_rpc_failed, ::Test::ResourceFindRequest, ::Test::Resource
     rpc :find_with_sleep, ::Test::ResourceSleepRequest, ::Test::Resource
+    rpc :find_not_implemented, ::Test::ResourceFindRequest, ::Test::Resource
   end
 
 end

data/spec/support/test/resource.proto

@@ -90,4 +90,5 @@ service ResourceService {
   rpc Find (ResourceFindRequest) returns (Resource);
   rpc FindWithRpcFailed (ResourceFindRequest) returns (Resource);
   rpc FindWithSleep (ResourceSleepRequest) returns (Resource);
+  rpc FindNotImplemented (ResourceFindRequest) returns (Resource);
 }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: protobuf
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.4
 platform: ruby
 authors:
 - BJ Neilsen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-13 00:00:00.000000000 Z
+date: 2014-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport