protobuf-nats 0.3.4 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c6b22f7e27f41e71956989fb94334264e91da969
-  data.tar.gz: 70c69bc20f8b8ece563d225c4d1a687522006c6e
+  metadata.gz: 65e149ee1d61cda8f1984475564f0c38cf4b8947
+  data.tar.gz: 0dc0a8f81ca8b27c3e0d56ad13e2a743c20d945f
 SHA512:
-  metadata.gz: c80227d5578dc0100f6136a4ac6a087a9b1c7c0c39cfe7e1354f994ddbc6f1f290240470b66cc3a63fee1a6d004661541ec5d573ad414c08a50fb0a3db4f3739
-  data.tar.gz: f2e1659906c582c1b3d297e37e5a9cf660cacb7a2031f6aaebb4f69b5b1b9792764fd3d97e75e1424d46d86b16c43e040f5bba87ca2da155625a51ee13569963
+  metadata.gz: 888441cbebd59eb546e47a575bfb930a893f5749c17d41edcd9e3a47eb3a6c9f02d00638b3bd630bf9d21ce77f4cfeded33ec60bf4e7e7efc9822546a3efb298
+  data.tar.gz: 117a06f644f92cea8073fd53566f3274f797a391c316f68cd678eb84697134e0048bff05faebbb2100ef7291053e5d342abfcdba8c856f491410e4b8473db86d

data/README.md

@@ -25,15 +25,21 @@ Or install it yourself as:
 
 You can also use the following environment variables to tune parameters:
 
-`PB_NATS_SERVER_MAX_QUEUE_SIZE` - The size of the queue in front of your thread pool (default: thread count passed to CLI)
+`PB_NATS_SERVER_MAX_QUEUE_SIZE` - The size of the queue in front of your thread pool (default: thread count passed to CLI).
 
-`PB_NATS_CLIENT_ACK_TIMEOUT` - Seconds to wait for an ACK from the rpc server (default: 5 seconds)
+`PB_NATS_SERVER_SLOW_START_DELAY` - Seconds to wait before adding another round of subscriptions (default 10).
 
-`PB_NATS_CLIENT_RESPONSE_TIMEOUT` - Seconds to wait for a non-ACK response from the rpc server (default: 60 seconds)
+`PB_NATS_SERVER_SUBSCRIPTIONS_PER_RPC_ENDPOINT` - Number of subscriptions to create for each rpc endpoint. This number is
+used to allow JVM based servers to warm-up slowly to prevent jolts in runtime performance across your RPC network
+(default: 10).
 
-`PB_NATS_CLIENT_RECONNECT_DELAY` - If we detect a reconnect delay, we will wait this many seconds (default: the ACK timeout)
+`PB_NATS_CLIENT_ACK_TIMEOUT` - Seconds to wait for an ACK from the rpc server (default: 5 seconds).
 
-`PROTOBUF_NATS_CONFIG_PATH` - Custom path to the config yaml (default: "config/protobuf_nats.yml")
+`PB_NATS_CLIENT_RESPONSE_TIMEOUT` - Seconds to wait for a non-ACK response from the rpc server (default: 60 seconds).
+
+`PB_NATS_CLIENT_RECONNECT_DELAY` - If we detect a reconnect delay, we will wait this many seconds (default: the ACK timeout).
+
+`PROTOBUF_NATS_CONFIG_PATH` - Custom path to the config yaml (default: "config/protobuf_nats.yml").
 
 ### YAML Config
 

data/lib/protobuf/nats/server.rb

@@ -26,11 +26,15 @@ module Protobuf
       end
 
       def max_queue_size
-        if ::ENV.key?("PB_NATS_SERVER_MAX_QUEUE_SIZE")
-          ::ENV["PB_NATS_SERVER_MAX_QUEUE_SIZE"].to_i
-        else
-          @options[:threads]
-        end
+        ::ENV.fetch("PB_NATS_SERVER_MAX_QUEUE_SIZE", @options[:threads]).to_i
+      end
+
+      def slow_start_delay
+        @slow_start_delay ||= ::ENV.fetch("PB_NATS_SERVER_SLOW_START_DELAY", 10).to_i
+      end
+
+      def subscriptions_per_rpc_endpoint
+        @subscriptions_per_rpc_endpoint ||= ::ENV.fetch("PB_NATS_SERVER_SUBSCRIPTIONS_PER_RPC_ENDPOINT", 10).to_i
       end
 
       def service_klasses
@@ -55,26 +59,56 @@ module Protobuf
         was_enqueued
       end
 
-      def subscribe_to_services
+      def print_subscription_keys
         logger.info "Creating subscriptions:"
 
+        with_each_subscription_key do |subscription_key|
+          logger.info "  - #{subscription_key}"
+        end
+      end
+
+      def subscribe_to_services
+        with_each_subscription_key do |subscription_key_and_queue|
+          subscriptions << nats.subscribe(subscription_key_and_queue, :queue => subscription_key_and_queue) do |request_data, reply_id, _subject|
+            unless enqueue_request(request_data, reply_id)
+              logger.error { "Thread pool is full! Dropping message for: #{subscription_key_and_queue}" }
+            end
+          end
+        end
+      end
+
+      def with_each_subscription_key
+        fail ::ArgumentError unless block_given?
+
         service_klasses.each do |service_klass|
           service_klass.rpcs.each do |service_method, _|
             # Skip services that are not implemented.
             next unless service_klass.method_defined? service_method
 
-            subscription_key_and_queue = ::Protobuf::Nats.subscription_key(service_klass, service_method)
-            logger.info "  - #{subscription_key_and_queue}"
-
-            subscriptions << nats.subscribe(subscription_key_and_queue, :queue => subscription_key_and_queue) do |request_data, reply_id, _subject|
-              unless enqueue_request(request_data, reply_id)
-                logger.error { "Thread pool is full! Dropping message for: #{subscription_key_and_queue}" }
-              end
-            end
+            yield ::Protobuf::Nats.subscription_key(service_klass, service_method)
           end
         end
       end
 
+      # Slow start subscriptions by adding X rounds of subz every
+      # Y seconds, where X is subscriptions_per_rpc_endpoint and Y is
+      # slow_start_delay.
+      def finish_slow_start
+        logger.info "Slow start has started..."
+        completed = 1
+
+        # We have (X - 1) here because we always subscribe at least once.
+        (subscriptions_per_rpc_endpoint - 1).times do
+          next unless @running
+          completed += 1
+          sleep slow_start_delay
+          subscribe_to_services
+          logger.info "Slow start adding another round of subscriptions (#{completed}/#{subscriptions_per_rpc_endpoint})..."
+        end
+
+        logger.info "Slow start finished."
+      end
+
       def run
         nats.on_reconnect do
           logger.warn "Server NATS connection was reconnected"
@@ -92,9 +126,10 @@ module Protobuf
           logger.warn "Server NATS connection was closed"
         end
 
+        print_subscription_keys
         subscribe_to_services
-
         yield if block_given?
+        finish_slow_start
 
         loop do
           break unless @running

data/lib/protobuf/nats/version.rb

@@ -1,5 +1,5 @@
 module Protobuf
   module Nats
-    VERSION = "0.3.4"
+    VERSION = "0.4.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: protobuf-nats
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.4.0
 platform: ruby
 authors:
 - Brandon Dewitt
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-05-15 00:00:00.000000000 Z
+date: 2017-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: protobuf
@@ -171,7 +171,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: ruby-protobuf client/server for nats