protobuf-activerecord 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a3d7459c7c110bd97134b19fcb6e03c50d703cf0
-  data.tar.gz: a9f5db72facad0d01bf4ef55ed1fd21a80f35ac0
+  metadata.gz: 9447a65d47084decc7ffdf256ca74e0fd75769a5
+  data.tar.gz: 81d3ea3553ddf7822a45201f95222052a5489870
 SHA512:
-  metadata.gz: 9fadf115d0f333b94d6bee3940f23b1938ae0fa74ff16c3d1edda12acfcbac70f6c39717de88b716fbf3e51cbe2586ce98812c9a26c5a44abdaf241170a1e9d9
-  data.tar.gz: dfb1883e308d92f1b34cd1e038fbfeebf3b9594f1b35e2ba4a7a5130153c877a892e1d8d48bf9d77d8fb20e880d32e12b42b40e8fe283d6e4242e6c7fb7d2e04
+  metadata.gz: 632140c448d6c4aba6ea2b633b65edf6165808b449303010160d84321167e8ab5a899d2825d74190ff9170684c43057e77fee34857cab2d3403e11cad50b84f4
+  data.tar.gz: 8be6c87c0e15dcd912317de22cac86bad107dc3c3c80b91ca4611c970c7eb80921483dd73b5067ace2a8d24bdab4b354ee0dd3d7f17995dd9f767e60e22a3ee2

data/lib/protobuf/active_record/transformation.rb

@@ -33,6 +33,7 @@ module Protobuf
           end
 
           filtered_attributes = _filtered_attributes + _protobuf_nested_attributes
+          filtered_attributes += _protobuf_attribute_transformers.keys
 
           attribute_fields = filtered_attributes.inject({}) do |hash, column_name|
             symbolized_column = column_name.to_sym

data/lib/protobuf/active_record/version.rb

@@ -1,5 +1,5 @@
 module Protobuf
   module ActiveRecord
-    VERSION = "3.0.0"
+    VERSION = "3.0.1"
   end
 end

data/spec/protobuf/active_record/serialization_spec.rb

@@ -134,20 +134,20 @@ describe Protobuf::ActiveRecord::Serialization do
       context "when options has :except" do
         it "returns all except the given field(s)" do
           fields = user._filter_field_attributes(:except => :name).should
-          fields.should eq [ :guid, :email, :email_domain ]
+          fields.should eq [ :guid, :email, :email_domain, :password ]
         end
       end
     end
 
     describe "#_filtered_fields" do
       it "returns protobuf fields" do
-        user._filtered_fields.should eq [ :guid, :name, :email, :email_domain ]
+        user._filtered_fields.should eq [ :guid, :name, :email, :email_domain, :password ]
       end
 
       context "given :deprecated => false" do
         it "filters all deprecated fields" do
           fields = user._filtered_fields(:deprecated => false).should
-          fields.should eq [ :guid, :name, :email ]
+          fields.should eq [ :guid, :name, :email, :password ]
         end
       end
     end
@@ -204,7 +204,7 @@ describe Protobuf::ActiveRecord::Serialization do
       }
 
       context "when a transformer is defined for the field" do
-        let(:fields_from_record) { { :guid => user.guid, :name => user.name, :email => user.email, :email_domain => 'test.co' } }
+        let(:fields_from_record) { { :guid => user.guid, :name => user.name, :email => user.email, :email_domain => 'test.co', :password => nil } }
         let(:transformer) { { :email_domain => lambda { |record| record.email.split('@').last } } }
 
         before {
@@ -217,7 +217,7 @@ describe Protobuf::ActiveRecord::Serialization do
       end
 
       context "when a transformer is not defined for the field" do
-        let(:fields_from_record) { { :guid => user.guid, :name => user.name, :email => user.email, :email_domain => nil } }
+        let(:fields_from_record) { { :guid => user.guid, :name => user.name, :email => user.email, :email_domain => nil, :password => nil } }
 
         it "returns a hash of protobuf fields that this object has getters for" do
           user.fields_from_record.should eq fields_from_record

data/spec/protobuf/active_record/transformation_spec.rb

@@ -22,8 +22,13 @@ describe Protobuf::ActiveRecord::Transformation do
       attribute_fields = User._filter_attribute_fields(proto)
       attribute_fields.has_key?(:account_id).should be_true
     end
+
+    it "includes fields that aren't attributes, but have attribute transformers" do
+      attribute_fields = User._filter_attribute_fields(proto)
+      attribute_fields.has_key?(:password).should be_true
+    end
   end
-  
+
   describe "._protobuf_convert_fields_to_attributes" do
     context "when the given field's corresponding column type is :date" do
       let(:date) { Date.current }
@@ -171,7 +176,7 @@ describe Protobuf::ActiveRecord::Transformation do
       end
     end
   end
-  
+
   describe ".convert_int64_to_date" do
     let(:date) { Date.current }
     let(:int64) { date.to_time.to_i }
@@ -206,7 +211,7 @@ describe Protobuf::ActiveRecord::Transformation do
       end
     end
   end
-  
+
   describe "#attributes_from_proto" do
     it "gets attributes from the given protobuf message" do
       User.should_receive(:attributes_from_proto).with(proto)

data/spec/support/definitions/user.proto

@@ -3,6 +3,7 @@ message UserMessage {
   optional string name         = 2;
   optional string email        = 3;
   optional string email_domain = 4 [deprecated = true];
+  optional string password     = 5;
 }
 
 message UserSearchMessage {

data/spec/support/models/user.rb

@@ -1,11 +1,14 @@
 class User < ActiveRecord::Base
   include Protobuf::ActiveRecord::Model
 
+  attr_accessor :password
+
   scope :by_guid, lambda { |*guids| where(:guid => guids) }
   scope :by_email, lambda { |*emails| where(:email => emails) }
 
   attribute_from_proto :first_name, :extract_first_name
   attribute_from_proto :last_name, :extract_last_name
+  attribute_from_proto :password, lambda { |proto| proto.password! }
 
   def self.extract_first_name(proto)
     if proto.has_field?(:name)

data/spec/support/protobuf/user.pb.rb

@@ -10,6 +10,7 @@ require 'protobuf/message'
 class UserMessage < ::Protobuf::Message; end
 class UserSearchMessage < ::Protobuf::Message; end
 
+
 ##
 # Message Fields
 #
@@ -18,6 +19,7 @@ class UserMessage
   optional ::Protobuf::Field::StringField, :name, 2
   optional ::Protobuf::Field::StringField, :email, 3
   optional ::Protobuf::Field::StringField, :email_domain, 4, :deprecated => true
+  optional ::Protobuf::Field::StringField, :password, 5
 end
 
 class UserSearchMessage

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: protobuf-activerecord
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-19 00:00:00.000000000 Z
+date: 2013-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -228,7 +228,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.1.10
 signing_key: 
 specification_version: 4
 summary: Google Protocol Buffers integration for Active Record