protip 0.32.2 → 0.35.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0e1fbe6b7ee1d780392ae6ff7db663082ea2eb2b
-  data.tar.gz: 28855eb50758306090c18f4d571e4a26959fcbcb
+SHA256:
+  metadata.gz: a8dc5147627d4163ebde05751c7bdfd92b1e788f9490830490346c1c83f95e7f
+  data.tar.gz: 7c837443f9502742f7204d6f7e58185c8f1c64f4480753562ba2364fa014d932
 SHA512:
-  metadata.gz: 33f8f0288db23882f142d42ba7a016c95f06c59bac2930b2252d84f8e4db176c4c614b76162959ba65cdc95cdfe6756a5dec3c4598861b1100c3046cab4d1f5e
-  data.tar.gz: 4be1f1959ba2dbdd030ee2fbc79b5e641299f10dc686d483f69a85da199985229f044d8e5738bb340c1a8eea8d30626ce01e269af39a36f1c5104a8d0b6d897e
+  metadata.gz: 26ae868d09d7989bcacd3362323ea99b31e36dc4cacca293199b11e60be4104f7a4b8156d4f49724bd906c5ad541e665bef5026aa2ed0c1097aa5bd145a34540
+  data.tar.gz: 321ecd9a0fd8785475b55f27bf0a495b7056ff64bc7a8d3a2f9841c500ae424b344f13147ca43014cdaf2c5424fcb134b160a208ed1e95e13283f4633332718d

data/lib/protip.rb

@@ -1,3 +1,4 @@
+require 'protip/version'
 require 'protip/client'
 require 'protip/resource'
 

data/lib/protip/client.rb

@@ -69,27 +69,9 @@ module Protip
     # @param request [Net::HTTPGenericRequest] the raw request object to send
     # @return [Net::HTTPResponse] the response for the given request
     def execute_request(request)
-      http = nil
       uri = request.uri
-      retries = 0
-      max_retries = 3
-
-      begin
-        unless http
-          http = Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https', read_timeout: 120)
-        end
+      Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https', read_timeout: 600) do |http|
         http.request request
-      rescue Net::OpenTimeout, Net::ReadTimeout
-        if (retries += 1) <= max_retries
-          sleep(retries)
-          retry
-        else
-          raise
-        end
-      ensure
-        if http
-          http.finish
-        end
       end
     end
   end

data/lib/protip/decorator.rb

@@ -281,7 +281,7 @@ module Protip
 
     def method_missing_query(name, *args)
       field = message.class.descriptor.lookup(name[0, name.length - 1])
-      raise NoMethodError unless field
+      raise NoMethodError.new("No query method found for: #{name}") unless field
 
       if nil != Protip::Decorator.enum_for_field(field) && args.length == 1
         matches?(field, args[0])

data/lib/protip/resource.rb

@@ -19,7 +19,6 @@ require 'active_model/dirty'
 
 require 'forwardable'
 
-require 'protip'
 require 'protip/client'
 require 'protip/error'
 require 'protip/decorator'
@@ -78,14 +77,14 @@ module Protip
       end
 
       def transformer
-        @transformer || ::Protip.default_transformer
+        defined?(@transformer) ? @transformer : ::Protip.default_transformer
       end
 
       private
 
       # Primary entry point for defining resourceful behavior.
       def resource(actions:, message:, query: nil, nested_resources: {})
-        raise RuntimeError.new('Only one call to `resource` is allowed') if @message
+        raise RuntimeError.new('Only one call to `resource` is allowed') if defined?(@message) && @message
         validate_actions!(actions)
         validate_nested_resources!(nested_resources)
 
@@ -338,6 +337,18 @@ module Protip
       success
     end
 
+    class RecordInvalid < StandardError
+    end
+
+    def save!
+      success = save
+      if !success
+        error_messages = errors.full_messages.join(", ")
+        raise RecordInvalid.new("Validation failed: #{error_messages}")
+      end
+      success
+    end
+
     def persisted?
       id != nil
     end
@@ -353,12 +364,5 @@ module Protip
     def errors
       @errors ||= ActiveModel::Errors.new(self)
     end
-
-    private
-    # needed for ActiveModel::Dirty in earlier ActiveModel versions
-    def changes_applied
-      @previously_changed = changes
-      @changed_attributes.clear
-    end
   end
 end

data/lib/protip/tasks/compile.rake

@@ -1,4 +1,6 @@
 require 'shellwords'
+require 'bundler/setup'
+
 namespace :protip do
   desc 'compile a single .proto file to Ruby'
   task :compile, [:filename, :proto_path, :ruby_path] do |t, args|
@@ -9,7 +11,7 @@ namespace :protip do
 
     filename = args[:filename] || raise(ArgumentError.new 'filename argument is required')
 
-    command = "grpc_tools_ruby_protoc #{proto_path.map{|p| "--proto_path=#{Shellwords.escape p}"}.join ' '} --ruby_out=#{Shellwords.escape ruby_path} #{Shellwords.escape filename}"
+    command = "bundle exec grpc_tools_ruby_protoc #{proto_path.map{|p| "--proto_path=#{Shellwords.escape p}"}.join ' '} --ruby_out=#{Shellwords.escape ruby_path} #{Shellwords.escape filename}"
     puts command
     system command
 

data/lib/protip/transformers/active_support/time_with_zone_transformer.rb

@@ -22,7 +22,7 @@ module Protip
           if !value.is_a?(::ActiveSupport::TimeWithZone) && (value.is_a?(Time) || value.is_a?(DateTime))
             value = ::ActiveSupport::TimeWithZone.new(value.to_time.utc, ::ActiveSupport::TimeZone.new('UTC'))
           end
-          raise ArgumentError unless value.is_a?(::ActiveSupport::TimeWithZone)
+          raise ArgumentError.new("Expected ActiveSupport::TimeWithZone, received #{value.class.name}") unless value.is_a?(::ActiveSupport::TimeWithZone)
 
           message_class.new(
             utc_timestamp: value.to_i,
@@ -32,4 +32,4 @@ module Protip
       end
     end
   end
-end
+end

data/lib/protip/transformers/big_decimal_transformer.rb

@@ -16,7 +16,7 @@ module Protip
             end
 
             def to_message(object, field)
-              object = BigDecimal.new(object)
+              object = BigDecimal(object)
               rational = object.to_r
               field.subtype.msgclass.new(
                 numerator: rational.numerator,
@@ -28,4 +28,4 @@ module Protip
       end
     end
   end
-end
+end

data/lib/protip/transformers/decorating_transformer.rb

@@ -25,7 +25,7 @@ module Protip
           decorator.assign_attributes(object)
           decorator.message
         else
-          raise ArgumentError
+          raise ArgumentError.new("#to_message expected a Hash or an already decorated object, received #{object.class.name} for #{field.type} #{field.name}")
         end
       end
     end

data/lib/protip/transformers/delegating_transformer.rb

@@ -1,5 +1,6 @@
 require 'protip/transformer'
 require 'protip/transformers/abstract_transformer'
+require 'forwardable'
 
 module Protip
   module Transformers

data/lib/protip/transformers/deprecated_transformer.rb

@@ -50,7 +50,7 @@ module Protip
           ::Date.new(message.year, message.month, message.day)
         end
         def to_message(object, field)
-          raise ArgumentError unless object.is_a?(::Date)
+          raise ArgumentError.new("Field #{field.name} expected a date, #{object.class.name} given") unless object.is_a?(::Date)
           field.subtype.msgclass.new(year: object.year, month: object.month, day: object.day)
         end
       end
@@ -77,7 +77,7 @@ module Protip
           if !object.is_a?(::ActiveSupport::TimeWithZone) && (object.is_a?(Time) || object.is_a?(DateTime))
             object = ::ActiveSupport::TimeWithZone.new(object.to_time.utc, ::ActiveSupport::TimeZone.new('UTC'))
           end
-          raise ArgumentError unless object.is_a?(::ActiveSupport::TimeWithZone)
+          raise ArgumentError.new("Expected ActiveSupport::TimeWithZone, received #{object.class.name}") unless object.is_a?(::ActiveSupport::TimeWithZone)
 
           field.subtype.msgclass.new(
             utc_timestamp: object.to_i,

data/lib/protip/version.rb

@@ -0,0 +1,3 @@
+module Protip
+  VERSION = '0.35.3'
+end

data/test/test_helper.rb

@@ -1,6 +1,7 @@
 require 'minitest/autorun'
-require 'mocha/mini_test'
+require 'mocha/minitest'
 require 'webmock/minitest'
 require 'minitest/stub/const'
-
 require 'minitest/pride'
+require 'pry-byebug'
+require 'protip'

data/test/unit/protip/resource/associations/belongs_to_polymorphic_association_test.rb

@@ -46,7 +46,7 @@ describe Protip::Resource::Associations::BelongsToPolymorphicAssociation do
         Protip::Resource::Associations::BelongsToPolymorphicAssociation.new resource_class,
           :reference, [rick_ross_association]
       end
-      assert_match /requires an association to be defined/, error.message
+      assert_match(/requires an association to be defined/, error.message)
     end
 
     it 'raises an error if a belongs-to association is provided for a field outside the oneof' do
@@ -54,7 +54,7 @@ describe Protip::Resource::Associations::BelongsToPolymorphicAssociation do
         Protip::Resource::Associations::BelongsToPolymorphicAssociation.new resource_class,
           :reference, [rick_ross_association, other_association]
       end
-      assert_match /requires an association to be defined/, error.message
+      assert_match(/requires an association to be defined/, error.message)
     end
 
     it 'raises an error if a duplicate belongs-to association is provided' do
@@ -62,7 +62,7 @@ describe Protip::Resource::Associations::BelongsToPolymorphicAssociation do
         Protip::Resource::Associations::BelongsToPolymorphicAssociation.new resource_class,
           :reference, [rick_ross_association, rick_ross_association, fetty_wap_association]
       end
-      assert_match /Duplicate association/, error.message
+      assert_match(/Duplicate association/, error.message)
     end
 
     it 'allows the oneof ID field to be specified' do
@@ -147,4 +147,4 @@ describe Protip::Resource::Associations::BelongsToPolymorphicAssociation do
       end
     end
   end
-end
+end

data/test/unit/protip/resource_test.rb

@@ -1043,7 +1043,7 @@ module Protip::ResourceTest # Namespace for internal constants
               send method, :association_name, bad_option: 'bad', &block
             end
           end
-          assert_match /bad_option/, error.message
+          assert_match(/bad_option/, error.message)
         end
       end
     end

data/test/unit/protip/transformers/big_decimal_transformer_test.rb

@@ -27,14 +27,14 @@ describe Protip::Transformers::BigDecimalTransformer do
       end
     end
     describe 'for BigDecimal arguments' do
-      it_transforms 'integer', BigDecimal.new(104, 1)
-      it_transforms 'fractions', BigDecimal.new(100.5, 5)
-      it_transforms 'rational numbers', BigDecimal.new(Rational(2, 3), 3)
+      it_transforms 'integer', BigDecimal(104, 1)
+      it_transforms 'fractions', BigDecimal(100.5, 5)
+      it_transforms 'rational numbers', BigDecimal(Rational(2, 3), 3)
     end
 
     describe 'for non-BigDecimal arguments' do
-      it_transforms 'integer', 3, BigDecimal.new(3, 1)
-      it_transforms 'string', '3.3', BigDecimal.new(3.3, 2)
+      it_transforms 'integer', 3, BigDecimal(3, 1)
+      it_transforms 'string', '3.3', BigDecimal(3.3, 2)
 
       # Match standard BigDecimal behavior for floats
       it 'raises an argument error for floats' do
@@ -45,4 +45,4 @@ describe Protip::Transformers::BigDecimalTransformer do
       end
     end
   end
-end
+end

data/test/unit/protip/transformers/default_transformer_test.rb

@@ -5,7 +5,7 @@ require 'protip/transformers/default_transformer'
 describe Protip::Transformers::DefaultTransformer do
   describe '#initialize' do
     it 'initializes without errors' do
-      transformer = Protip::Transformers::DefaultTransformer.new
+      Protip::Transformers::DefaultTransformer.new
     end
   end
-end
+end

data/test/unit/protip/transformers/primitives_transformer_test.rb

@@ -129,7 +129,7 @@ describe ::Protip::Transformers::PrimitivesTransformer do
     end
 
     it 'raises an exception if non-boolean values passed to a boolean field' do
-      [nil, 'test', Object.new, 2, {}, []].each do |bad_value|
+      ['test', Object.new, 2, {}, []].each do |bad_value|
         assert_raises TypeError do
           transformer.to_message(bad_value, field)
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: protip
 version: !ruby/object:Gem::Version
-  version: 0.32.2
+  version: 0.35.3
 platform: ruby
 authors:
 - AngelList
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-18 00:00:00.000000000 Z
+date: 2020-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 4.2.10
     - - "<"
       - !ruby/object:Gem::Version
         version: '6.0'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 4.2.10
     - - "<"
       - !ruby/object:Gem::Version
         version: '6.0'
@@ -36,7 +36,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 4.2.10
     - - "<"
       - !ruby/object:Gem::Version
         version: '6.0'
@@ -46,24 +46,10 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 4.2.10
     - - "<"
       - !ruby/object:Gem::Version
         version: '6.0'
-- !ruby/object:Gem::Dependency
-  name: google-protobuf
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: money
   requirement: !ruby/object:Gem::Requirement
@@ -84,20 +70,34 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '7.0'
+- !ruby/object:Gem::Dependency
+  name: google-protobuf
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.6.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.6.1
 - !ruby/object:Gem::Dependency
   name: grpc-tools
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.3.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.3.4
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -118,84 +118,84 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.11'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.18'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.18'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.3.0
+        version: '3'
 description: 
 email:
 - team@angel.co
@@ -255,6 +255,7 @@ files:
 - lib/protip/transformers/enum_transformer.rb
 - lib/protip/transformers/primitives_transformer.rb
 - lib/protip/transformers/timestamp_transformer.rb
+- lib/protip/version.rb
 - test/functional/protip/decorator_test.rb
 - test/functional/protip/resource_test.rb
 - test/test_helper.rb
@@ -291,8 +292,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Resources backed by protobuf messages