protip 0.30.3 → 0.30.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7767f62af66d64b4120e373355995027070a6278
-  data.tar.gz: 4b1e516325941982f8c619af5d7efc66a8c4b814
+  metadata.gz: 60f4f6ab18acf00fa48b6470c88de46102dddece
+  data.tar.gz: bd54eb88c9e5cb05eb9b1d786a49bd698b10fac8
 SHA512:
-  metadata.gz: 767c87e9f58f602f06b25266d21327df7525b334a0abb310723ac42d4d4505113b30926ab2a087cf395240a384553620f7df033f5ebd0c2e39283bc118eddb35
-  data.tar.gz: 4a80c5588cc6fbb5b9ba466ee3da25ade548dcdab5329b388b0a92ff58546d4916a7fac2a2483542ae2d4a8b8d3e95fc70ebd330fc3803e24e77e8a80c04f43f
+  metadata.gz: 4a99f855daf4836fbad234c9c3a61f30b449003451c3de41631b04fd24e9458726ff11251bc9409b50175f8e6b459e7dbed4ccf25c17ba716191c40ecc794d99
+  data.tar.gz: c01896ba4aa0b9094e1fe90f0ea2f3b70570b0592c42b0d06228181e0dcf79ebbc522cff40c3db24c634ffbb61b14f2f5f267821b4ad89c90a2a5afb4208109b

data/lib/protip/transformers/deprecated_transformer.rb

@@ -35,10 +35,10 @@ module Protip
           ::Money.new(message.amount_cents, message.currency.currency_code)
         end
         def to_message(object, field)
-          raise ArgumentError unless object.is_a?(::Money)
-          currency = Protip::Messages::Currency.new(currency_code: object.currency.iso_code.to_sym)
+          money = object.to_money
+          currency = Protip::Messages::Currency.new(currency_code: money.currency.iso_code.to_sym)
           field.subtype.msgclass.new(
-            amount_cents: object.fractional,
+            amount_cents: money.fractional,
             currency: currency,
           )
         end

data/test/unit/protip/transformers/big_decimal_transformer_test.rb

@@ -16,15 +16,32 @@ describe Protip::Transformers::BigDecimalTransformer do
   # Since we're just serializing/deserializing values, we test both
   # transformer methods in tandem.
   describe 'transformation' do
-    def self.it_transforms(name, value)
+    # Assumes expected_value = value unless it is explicitly provided
+    def self.it_transforms(name, value, expected_value = nil)
+      expected_value ||= value
       it "transforms #{name} values" do
         message = transformer.to_message(value, field)
-        assert_equal value, transformer.to_object(message, field)
+        assert_equal expected_value, transformer.to_object(message, field)
+      end
+    end
+    describe 'for BigDecimal arguments' do
+      it_transforms 'integer', BigDecimal.new(104, 1)
+      it_transforms 'infinity', (BigDecimal.new(1, 1) / 0)
+      it_transforms 'fractions', BigDecimal.new(100.5, 5)
+      it_transforms 'rational numbers', BigDecimal.new(Rational(2, 3), 3)
+    end
+
+    describe 'for non-BigDecimal arguments' do
+      it_transforms 'integer', 3, BigDecimal.new(3, 1)
+      it_transforms 'string', '3.3', BigDecimal.new(3.3, 2)
+
+      # Match standard BigDecimal behavior for floats
+      it 'raises an argument error for floats' do
+        exception = assert_raises ArgumentError do
+          transformer.to_message(5.5, field)
+        end
+        assert_equal "can't omit precision for a Float.", exception.message
       end
     end
-    it_transforms 'integer', BigDecimal.new(104, 1)
-    it_transforms 'infinity', (BigDecimal.new(1, 1) / 0)
-    it_transforms 'fractions', BigDecimal.new(100.5, 5)
-    it_transforms 'rational numbers', BigDecimal.new(Rational(2, 3), 3)
   end
 end

data/test/unit/protip/transformers/deprecated_transformer_test.rb

@@ -109,6 +109,18 @@ describe Protip::Transformers::DeprecatedTransformer do
           )),
           message
       end
+
+      it 'converts other objects via #to_money' do
+        obj = mock
+        obj.stubs(:to_money).returns ::Money.new(250, 'CAD')
+        message = transformer.to_message(obj, field)
+        assert_equal message_class.new(
+          amount_cents: 250,
+          currency: Protip::Messages::Currency.new(
+            currency_code: :CAD
+          )),
+          message
+      end
     end
 
     describe 'ActiveSupport::TimeWithZone' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: protip
 version: !ruby/object:Gem::Version
-  version: 0.30.3
+  version: 0.30.4
 platform: ruby
 authors:
 - AngelList
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-22 00:00:00.000000000 Z
+date: 2016-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel