protip 0.19.0 → 0.19.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 476db8dfd984fed8f163c6bb7c1fbd90263edf66
-  data.tar.gz: 38baca64b99c979275fdc99c42d9d0465bb3be3c
+  metadata.gz: c710d883e4cf3fb67e30f0038db21c584a17bacb
+  data.tar.gz: ae3837edd3f0c189bdc6e7d913b6fef0b545d303
 SHA512:
-  metadata.gz: b5d0986cd5e3467ec7f73990b26a6e53cc13a848348d4e679fa8624c2427194d09033a6d95416db8204724663ebccd140ea09401ed681c1017be86c5cdb5b0e9
-  data.tar.gz: 203784715d0d75c2a5a9f7d933e2e836a85e837a4dd68277f42f98a827698e18d829d92533e7bed254e6cd429729f6b1148bd0c58d6097d6ef8a379fcfac331f
+  metadata.gz: 01c9c0534123cc276cf12ccfcb20fb43901ae947091168d726797ea1a8951bbff0b437168fef560fd69f74077baac8e0063ac1edc958ca567c5c5760e094d67b
+  data.tar.gz: 2f30d7481ba416358e644b0073653b2af239c1e911483e758104a60df7f6779c8993486244061b17c5dc14b40ed39d0257ea5ce185089ff4ed2582b2cdab5c59

data/definitions/protip/messages/repeated.proto

@@ -0,0 +1,39 @@
+syntax = "proto3";
+
+package protip.messages;
+
+message RepeatedDouble {
+  repeated double values = 1;
+}
+
+message RepeatedFloat {
+  repeated float values = 1;
+}
+
+message RepeatedInt64 {
+  repeated int64 values = 1;
+}
+
+message RepeatedUInt64 {
+  repeated uint64 values = 1;
+}
+
+message RepeatedInt32 {
+  repeated int32 values = 1;
+}
+
+message RepeatedUInt32 {
+  repeated uint32 values = 1;
+}
+
+message RepeatedBool {
+  repeated bool values = 1;
+}
+
+message RepeatedString {
+  repeated string values = 1;
+}
+
+message RepeatedBytes {
+  repeated bytes values = 1;
+}

data/lib/protip/messages/repeated.rb

@@ -0,0 +1,48 @@
+# Generated by the protocol buffer compiler.  DO NOT EDIT!
+# source: protip/messages/repeated.proto
+
+require 'google/protobuf'
+
+Google::Protobuf::DescriptorPool.generated_pool.build do
+  add_message "protip.messages.RepeatedDouble" do
+    repeated :values, :double, 1
+  end
+  add_message "protip.messages.RepeatedFloat" do
+    repeated :values, :float, 1
+  end
+  add_message "protip.messages.RepeatedInt64" do
+    repeated :values, :int64, 1
+  end
+  add_message "protip.messages.RepeatedUInt64" do
+    repeated :values, :uint64, 1
+  end
+  add_message "protip.messages.RepeatedInt32" do
+    repeated :values, :int32, 1
+  end
+  add_message "protip.messages.RepeatedUInt32" do
+    repeated :values, :uint32, 1
+  end
+  add_message "protip.messages.RepeatedBool" do
+    repeated :values, :bool, 1
+  end
+  add_message "protip.messages.RepeatedString" do
+    repeated :values, :string, 1
+  end
+  add_message "protip.messages.RepeatedBytes" do
+    repeated :values, :bytes, 1
+  end
+end
+
+module Protip
+  module Messages
+    RepeatedDouble = Google::Protobuf::DescriptorPool.generated_pool.lookup("protip.messages.RepeatedDouble").msgclass
+    RepeatedFloat = Google::Protobuf::DescriptorPool.generated_pool.lookup("protip.messages.RepeatedFloat").msgclass
+    RepeatedInt64 = Google::Protobuf::DescriptorPool.generated_pool.lookup("protip.messages.RepeatedInt64").msgclass
+    RepeatedUInt64 = Google::Protobuf::DescriptorPool.generated_pool.lookup("protip.messages.RepeatedUInt64").msgclass
+    RepeatedInt32 = Google::Protobuf::DescriptorPool.generated_pool.lookup("protip.messages.RepeatedInt32").msgclass
+    RepeatedUInt32 = Google::Protobuf::DescriptorPool.generated_pool.lookup("protip.messages.RepeatedUInt32").msgclass
+    RepeatedBool = Google::Protobuf::DescriptorPool.generated_pool.lookup("protip.messages.RepeatedBool").msgclass
+    RepeatedString = Google::Protobuf::DescriptorPool.generated_pool.lookup("protip.messages.RepeatedString").msgclass
+    RepeatedBytes = Google::Protobuf::DescriptorPool.generated_pool.lookup("protip.messages.RepeatedBytes").msgclass
+  end
+end

data/lib/protip/standard_converter.rb

@@ -7,6 +7,7 @@ require 'protip/converter'
 require 'protip/messages/currency'
 require 'protip/messages/money'
 require 'protip/messages/range'
+require 'protip/messages/repeated'
 require 'protip/messages/types'
 require 'google/protobuf'
 module Protip
@@ -57,13 +58,19 @@ module Protip
     }
 
     ## Standard wrappers
-    %w(Int64 Int32 UInt64 UInt32 Double Float String Bytes).map{|type| "google.protobuf.#{type}Value"}.each do |name|
-      @conversions[name] = {
+    %w(Int64 Int32 UInt64 UInt32 Double Float String Bytes).each do |type|
+      @conversions["google.protobuf.#{type}Value"] = {
         to_object: ->(message) { message.value },
         to_message: lambda do |value, message_class|
           message_class.new value: value
         end
       }
+      @conversions["protip.messages.Repeated#{type}"] = {
+        to_object: ->(message) { message.values.to_a.freeze },
+        to_message: lambda do |value, message_class|
+          message_class.new values: (value.is_a?(Enumerable) ? value : [value])
+        end
+      }
     end
 
     conversions['google.protobuf.BoolValue'] = {
@@ -73,6 +80,14 @@ module Protip
       end
     }
 
+    conversions['protip.messages.RepeatedBool'] = {
+      to_object: ->(message) { message.values.to_a.freeze },
+      to_message: lambda do |value, message_class|
+        message_class.new values: (value.is_a?(Enumerable) ? value : [value]).map{|v| value_to_boolean(v)}
+      end
+
+    }
+
     ## ActiveSupport objects
     conversions['protip.messages.ActiveSupport.TimeWithZone'] = {
       to_object: ->(message) {

data/test/unit/protip/standard_converter_test.rb

@@ -17,6 +17,15 @@ describe Protip::StandardConverter do
     ]
   end
 
+  let(:repeated_integer_types) do
+    [
+      Protip::Messages::RepeatedInt64,
+      Protip::Messages::RepeatedInt32,
+      Protip::Messages::RepeatedUInt64,
+      Protip::Messages::RepeatedUInt32,
+    ]
+  end
+
   let(:float_types) do
     [
       Google::Protobuf::FloatValue,
@@ -24,18 +33,37 @@ describe Protip::StandardConverter do
     ]
   end
 
+  let(:repeated_float_types) do
+    [
+      Protip::Messages::RepeatedFloat,
+      Protip::Messages::RepeatedDouble,
+    ]
+  end
+
   let(:bool_types) do
     [Google::Protobuf::BoolValue]
   end
 
+  let(:repeated_bool_types) do
+    [Protip::Messages::RepeatedBool]
+  end
+
   let(:string_types) do
     [Google::Protobuf::StringValue]
   end
 
+  let(:repeated_string_types) do
+    [Protip::Messages::RepeatedString]
+  end
+
   let(:bytes_types) do
     [Google::Protobuf::BytesValue]
   end
 
+  let(:repeated_bytes_types) do
+    [Protip::Messages::RepeatedBytes]
+  end
+
   let(:protip_types) do
     [
       Protip::Messages::Range,
@@ -45,9 +73,16 @@ describe Protip::StandardConverter do
     ]
   end
 
+  let(:integer_value) { 6 }
+  let(:float_value) { 5.5 }
+  let(:bool_value) { true }
+  let(:string_value) { 'asdf' }
+  let(:bytes_value) { Base64.decode64("U2VuZCByZWluZm9yY2VtZW50cw==\n") }
+
   describe '#convertible?' do
     it 'converts all standard types' do
-      (integer_types + float_types + string_types + bool_types + protip_types).each do |message_class|
+      (integer_types + float_types + string_types + bool_types + protip_types + repeated_integer_types +
+        repeated_float_types + repeated_string_types + repeated_bool_types).each do |message_class|
         assert converter.convertible?(message_class), "expected type #{message_class.descriptor.name} not convertible"
       end
     end
@@ -62,11 +97,11 @@ describe Protip::StandardConverter do
   describe '#to_object' do
     it 'converts wrapper types' do
       {
-        6                                                 => integer_types,
-        5.5                                               => float_types,
-        false                                             => bool_types,
-        'asdf'                                            => string_types,
-        Base64.decode64("U2VuZCByZWluZm9yY2VtZW50cw==\n") => bytes_types,
+        integer_value => integer_types,
+        float_value   => float_types,
+        bool_value    => bool_types,
+        string_value  => string_types,
+        bytes_value   => bytes_types,
       }.each do |value, message_types|
         message_types.each do |message_class|
           assert_equal value, converter.to_object(message_class.new value: value)
@@ -74,6 +109,25 @@ describe Protip::StandardConverter do
       end
     end
 
+    it 'converts repeated types to an immutable array' do
+      {
+        integer_value => repeated_integer_types,
+        float_value   => repeated_float_types,
+        bool_value    => repeated_bool_types,
+        string_value  => repeated_string_types,
+        bytes_value   => repeated_bytes_types,
+      }.each do |value, message_types|
+        message_types.each do |message_class|
+          result = converter.to_object(message_class.new values: [value])
+          assert_equal [value], result
+          exception = assert_raises RuntimeError do
+            result << value
+          end
+          assert_equal 'can\'t modify frozen Array', exception.message
+        end
+      end
+    end
+
     it 'converts dates' do
       date = converter.to_object(::Protip::Messages::Date.new year: 2015, month: 2, day: 9)
       assert_instance_of ::Date, date
@@ -114,11 +168,11 @@ describe Protip::StandardConverter do
   describe '#to_message' do
     it 'converts wrapper types' do
       {
-        6                                                 => integer_types,
-        5.5                                               => float_types,
-        false                                             => bool_types,
-        'asdf'                                            => string_types,
-        Base64.decode64("U2VuZCByZWluZm9yY2VtZW50cw==\n") => bytes_types,
+        integer_value => integer_types,
+        float_value   => float_types,
+        bool_value    => bool_types,
+        string_value  => string_types,
+        bytes_value   => bytes_types,
       }.each do |value, message_types|
         message_types.each do |message_class|
           assert_equal message_class.new(value: value), converter.to_message(value, message_class)
@@ -126,6 +180,34 @@ describe Protip::StandardConverter do
       end
     end
 
+    it 'converts repeated types when set with a scalar value' do
+      {
+        integer_value => repeated_integer_types,
+        float_value   => repeated_float_types,
+        bool_value    => repeated_bool_types,
+        string_value  => repeated_string_types,
+        bytes_value   => repeated_bytes_types,
+      }.each do |value, message_types|
+        message_types.each do |message_class|
+          assert_equal message_class.new(values: [value]), converter.to_message(value, message_class)
+        end
+      end
+    end
+
+    it 'converts repeated types when set with an enumerable value' do
+      {
+        integer_value => repeated_integer_types,
+        float_value   => repeated_float_types,
+        bool_value    => repeated_bool_types,
+        string_value  => repeated_string_types,
+        bytes_value   => repeated_bytes_types,
+      }.each do |value, message_types|
+        message_types.each do |message_class|
+          assert_equal message_class.new(values: [value, value]), converter.to_message([value, value], message_class)
+        end
+      end
+    end
+
     it 'converts dates' do
       date = ::Date.new(2012, 5, 7)
       assert_equal 7, date.day # Sanity check argument order

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: protip
 version: !ruby/object:Gem::Version
-  version: 0.19.0
+  version: 0.19.1
 platform: ruby
 authors:
 - AngelList
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-04 00:00:00.000000000 Z
+date: 2016-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -199,6 +199,7 @@ files:
 - definitions/protip/messages/errors.proto
 - definitions/protip/messages/money.proto
 - definitions/protip/messages/range.proto
+- definitions/protip/messages/repeated.proto
 - definitions/protip/messages/types.proto
 - lib/google/protobuf/wrappers.rb
 - lib/protip.rb
@@ -211,6 +212,7 @@ files:
 - lib/protip/messages/errors.rb
 - lib/protip/messages/money.rb
 - lib/protip/messages/range.rb
+- lib/protip/messages/repeated.rb
 - lib/protip/messages/types.rb
 - lib/protip/resource.rb
 - lib/protip/resource/associations/association.rb