protip 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59a49ea006074b202ebfd0e2efff1c73aed317c9
-  data.tar.gz: fbd024d6595d62474d21154c00b9a91987ba3f6c
+  metadata.gz: f2bcfe95ab05331d80a72680b824507b1183e50d
+  data.tar.gz: d5bc2008b39cbc556793156b50d92dc455673860
 SHA512:
-  metadata.gz: 53ee5dabef500a1987f28573379483168fa1a2ebe1872fc2e5e4cce49be7d3ee867138bfe8076b4ab9ce28fd79c808b6680951fa602783973d8d149b153de9c0
-  data.tar.gz: 5ba932bebcb02f060babaaa8c4afe58e2e722a7f3816adddc61aeae93d632d0702f2e243f9ca0d98ea7b452fb49a0a1b5d088de67e98705bb2d00d58f7e936cc
+  metadata.gz: d5d2a3761f37f72cb7fef48d87195f286ad3da0ae7cd725c3a04c2fbf57fdff9ccde25f64a8eca5f9c36e85f3088cbd34d080d046ccd72da8ff7f96c47c66477
+  data.tar.gz: 4b9f94b329d0c8f16c5ef2eba2b7a82dfbf5ae1d4bbdaf15c6a26f5cac24370b89d1dc4a5725003f9d22781306e7a8b5d47f396e3886d550a55d38a55b529360

data/lib/protip/standard_converter.rb

@@ -2,11 +2,13 @@ require 'protip/converter'
 
 require 'protip/messages/types'
 require 'google/protobuf'
-
 module Protip
   class StandardConverter
     include Protip::Converter
 
+    TRUE_VALUES = [true, 1, '1', 't', 'T', 'true', 'TRUE', 'on', 'ON']
+    FALSE_VALUES = [false, 0, '0', 'f', 'F', 'false', 'FALSE', 'off', 'OFF']
+
     class << self
       attr_reader :conversions
     end
@@ -22,7 +24,7 @@ module Protip
     }
 
     ## Standard wrappers
-    %w(Int64 Int32 UInt64 UInt32 Double Float Bool String Bytes).map{|type| "google.protobuf.#{type}Value"}.each do |name|
+    %w(Int64 Int32 UInt64 UInt32 Double Float String Bytes).map{|type| "google.protobuf.#{type}Value"}.each do |name|
       @conversions[name] = {
         to_object: ->(message) { message.value },
         to_message: lambda do |value, message_class|
@@ -31,6 +33,13 @@ module Protip
       }
     end
 
+    conversions['google.protobuf.BoolValue'] = {
+      to_object: ->(message) { message.value },
+      to_message: lambda do |value, message_class|
+      message_class.new value: value_to_boolean(value)
+    end
+    }
+
     def convertible?(message_class)
       self.class.conversions.has_key?(message_class.descriptor.name)
     end
@@ -42,5 +51,16 @@ module Protip
     def to_message(object, message_class)
       self.class.conversions[message_class.descriptor.name][:to_message].call(object, message_class)
     end
+
+    class << self
+      # Similar to Rails 3 value_to_boolean
+      def value_to_boolean(value)
+        return true if TRUE_VALUES.include?(value)
+        return false if FALSE_VALUES.include?(value)
+        # If we don't get a truthy/falsey value, use the original value (which should raise an
+        # exception)
+        value
+      end
+    end
   end
 end

data/test/unit/protip/standard_converter_test.rb

@@ -83,5 +83,28 @@ describe Protip::StandardConverter do
       assert_equal 7, date.day # Sanity check argument order
       assert_equal ::Protip::Messages::Date.new(year: 2012, month: 5, day: 7), converter.to_message(date, ::Protip::Messages::Date)
     end
+
+    it 'converts truthy values to booleans' do
+      [true, 1, '1', 't', 'T', 'true', 'TRUE', 'on', 'ON'].each do |truth_value|
+        assert_equal Google::Protobuf::BoolValue.new(value: true),
+                     converter.to_message(truth_value, Google::Protobuf::BoolValue)
+      end
+    end
+
+    it 'converts falsey values to booleans' do
+      [false, 0, '0', 'f', 'F', 'false', 'FALSE', 'off', 'OFF'].each do |false_value|
+        assert_equal Google::Protobuf::BoolValue.new(value: false),
+                     converter.to_message(false_value, Google::Protobuf::BoolValue)
+      end
+    end
+
+    it 'raises an exception if non-boolean values passed to boolean field' do
+      [nil, 'test', Object.new, 2, {}, []].each do |bad_value|
+        assert_raises TypeError do
+          converter.to_message(bad_value, Google::Protobuf::BoolValue)
+        end
+      end
+    end
+
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: protip
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - AngelList
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-15 00:00:00.000000000 Z
+date: 2015-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -138,6 +138,8 @@ description:
 email:
 - team@angel.co
 - k2@angel.co
+- brian@angel.co
+- paul@angel.co
 executables: []
 extensions: []
 extra_rdoc_files: []