protip 0.13.0 → 0.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1170fab1e59f11eaf4e5d9fa6180d7086e5fe5fc
-  data.tar.gz: dece3a11f6abd2f216e78ee7df65245b03dd1c55
+  metadata.gz: 23c197f44c8f1c1812859e1e7567fb8d0dde9ffb
+  data.tar.gz: 45a759374549ebbe818e89fc958adaf47d199a8c
 SHA512:
-  metadata.gz: 07f0f92583e771802269412f33d383bcf878d35939b97906db016fa8c3af12500bdcffe9a5eb6545233f4cbfc878c2a842a01db66d54a8463ec2b18a45080684
-  data.tar.gz: dfaf66f2608d722e89b64bbbf144c12d36e788205e69431c528e7678507f487419a50c90e061a6fadc55d1eee5163e02e5a0acb5eb5a6675cc77c7f458e6cdf6
+  metadata.gz: 7e384ce1be77a5c0eb22052762da2ae105f3b0748025017ed4045db83a663e8ec3620b473a7ca2176b82e1d18685d075d5145bb8d99f17e7705f9d01c0a63f0c
+  data.tar.gz: 1cd15cd584f2d42d8fd5f44205157a6e933dfebda42758ff8ea0c9e2892d2fdec147e397c007763474b9a3a73277a075a978a51e9ed7cef51a5810c4c73aec20

data/lib/protip/wrapper.rb

@@ -32,8 +32,15 @@ module Protip
         assign_attributes attributes
         args[0] # return the input value (to match ActiveRecord behavior)
       elsif (name =~ /\?$/ && field = message.class.descriptor.detect{|field| self.class.matchable?(field) && :"#{field.name}?" == name})
-        raise ArgumentError unless args.length == 1
-        matches? field, args[0]
+        if args.length == 1
+          # this is an enum query, e.g. `state?(:CREATED)`
+          matches? field, args[0]
+        elsif args.length == 0
+          # this is a boolean query, e.g. `approved?`
+          get field
+        else
+          raise ArgumentError
+        end
       elsif (field = message.class.descriptor.detect{|field| field.name.to_sym == name})
         raise ArgumentError unless args.length == 0
         get field
@@ -146,7 +153,11 @@ module Protip
       # Semi-private check for whether a field should have an associated query method (e.g. +field_name?+).
       # @return [Boolean] Whether the field should have an associated query method on wrappers.
       def matchable?(field)
-        field.type == :enum && field.label != :repeated
+        return false if field.label == :repeated
+
+        field.type == :enum ||
+            field.type == :bool ||
+            field.type == :message && (field.subtype.name == "google.protobuf.BoolValue")
       end
     end
 

data/test/unit/protip/resource_test.rb

@@ -16,6 +16,9 @@ module Protip::ResourceTest # Namespace for internal constants
         add_message 'nested_message' do
           optional :number, :int64, 1
         end
+        add_message "google.protobuf.BoolValue" do
+          optional :value, :bool, 1
+        end
         add_message 'resource_message' do
           optional :id, :int64, 1
           optional :string, :string, 2
@@ -23,6 +26,10 @@ module Protip::ResourceTest # Namespace for internal constants
           optional :nested_message, :message, 4, 'nested_message'
           optional :number, :enum, 5, 'number'
           repeated :numbers, :enum, 6, 'number'
+          optional :boolean, :bool, 8
+          repeated :booleans, :bool, 9
+          optional :google_bool_value, :message, 10, "google.protobuf.BoolValue"
+          repeated :google_bool_values, :message, 11, "google.protobuf.BoolValue"
         end
 
         add_message 'resource_query' do
@@ -139,6 +146,16 @@ module Protip::ResourceTest # Namespace for internal constants
           refute resource.number?(:ONE)
         end
 
+        it 'defines query methods for the booleans on its message' do
+          assert_respond_to resource, :boolean?
+          refute resource.boolean?
+        end
+
+        it 'defines query methods for the google.protobuf.BoolValues on its message' do
+          assert_respond_to resource, :google_bool_value?
+          refute resource.google_bool_value?
+        end
+
         it 'does not define query methods for repeated enums' do
           refute_respond_to resource, :numbers?
           assert_raises NoMethodError do

data/test/unit/protip/wrapper_test.rb

@@ -23,6 +23,9 @@ module Protip::WrapperTest # namespace for internal constants
           optional :value, :int64, 1
           optional :note, :string, 2
         end
+        add_message "google.protobuf.BoolValue" do
+          optional :value, :bool, 1
+        end
 
         add_message 'message' do
           optional :inner, :message, 1, 'inner_message'
@@ -35,6 +38,12 @@ module Protip::WrapperTest # namespace for internal constants
 
           optional :number, :enum, 6, 'number'
           repeated :numbers, :enum, 7, 'number'
+
+          optional :boolean, :bool, 8
+          repeated :booleans, :bool, 9
+
+          optional :google_bool_value, :message, 10, "google.protobuf.BoolValue"
+          repeated :google_bool_values, :message, 11, "google.protobuf.BoolValue"
         end
       end
       pool
@@ -65,13 +74,17 @@ module Protip::WrapperTest # namespace for internal constants
         assert_respond_to wrapper, :inner
         assert_respond_to wrapper, :inner_blank
       end
-      it 'adds queries for scalar enum fields' do
-        assert_respond_to wrapper, :number?
+      it 'adds queries for scalar matchable fields' do
+        assert_respond_to wrapper, :number?, 'enum field should respond to query'
+        assert_respond_to wrapper, :boolean?, 'bool field should respond to query'
+        assert_respond_to wrapper, :google_bool_value?, 'google.protobuf.BoolValue field should respond to query'
       end
-      it 'does not add queries for repeated enum fields' do
-        refute_respond_to wrapper, :numbers?
+      it 'does not add queries for repeated fields' do
+        refute_respond_to wrapper, :numbers?, 'repeated enum field should not respond to query'
+        refute_respond_to wrapper, :booleans?, 'repeated bool field should not respond to query'
+        refute_respond_to wrapper, :google_bool_values?, 'repeated google.protobuf.BoolValue field should not respond to query'
       end
-      it 'does not add queries for non-enum fields' do
+      it 'does not add queries for non-matchable fields' do
         refute_respond_to wrapper, :inner?
       end
       it 'responds to standard defined methods' do
@@ -300,7 +313,7 @@ module Protip::WrapperTest # namespace for internal constants
         end
 
         it 'contains keys for all fields of the parent message' do
-          assert_equal %i(string strings inner inners inner_blank number numbers).sort, wrapper.to_h.keys.sort
+          assert_equal %i(string strings inner inners inner_blank number numbers boolean booleans google_bool_value google_bool_values).sort, wrapper.to_h.keys.sort
         end
         it 'assigns nil for missing nested messages' do
           hash = wrapper.to_h

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: protip
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.13.1
 platform: ruby
 authors:
 - AngelList
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-22 00:00:00.000000000 Z
+date: 2015-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel