protip 0.10.5 → 0.10.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 50e4538f142042bcdbcc5c29e46b3a268b9fef04
-  data.tar.gz: 7aaf2a518c3d4c1653f1abba85f7e2edda56dd90
+  metadata.gz: bbafb63f09c98b4e08843c2d8766bed6fec8aebe
+  data.tar.gz: bef3aa7d77fca8a813e3fba56194303ae626b7b1
 SHA512:
-  metadata.gz: 5bed8237bc75b66a1b95189945e9e567efa83d335a4f18f8329052202a3851f32198617e7baa67a514a2e57190ce15a699f97f2726db3cf538c12d38581de7e9
-  data.tar.gz: 06aeb09d06e2596c604c8234381963838b69ea4e7594821cdc86324f9111c0479cb481533f746085ee74efc673f8bf4055bec9f2e7f18b4306bb79fda812f941
+  metadata.gz: 35b8f01c76f8ddb6cbd7342a6043ea1d590b9753fe74067da416602593289ceeecb869fbebd5d31df1b50b7c97eb5f91941b99e2b643da4d40fbfdc799d59ec3
+  data.tar.gz: 1d7464462a49f72d1d77745e808f60ddae60b126c1ab75f302f1ffb0fe4dba7a30969353c6b6c9d9458d80af601c19a3e4ee3e797a1a0e6833b6564295fa348b

data/lib/protip/wrapper.rb

@@ -110,7 +110,7 @@ module Protip
     end
 
     def ==(wrapper)
-      message == wrapper.message && converter == wrapper.converter
+      wrapper.is_a?(self.class) && message == wrapper.message && converter == wrapper.converter
     end
 
     private

data/test/unit/protip/wrapper_test.rb

@@ -133,6 +133,34 @@ module Protip::WrapperTest # namespace for internal constants
       end
     end
 
+    describe '#==' do
+      it 'returns false for non-wrapper objects' do
+        refute_equal 1, wrapper
+        refute_equal wrapper, 1 # Sanity check, make sure we're testing both sides of equality
+      end
+
+      it 'returns false when messages are not equal' do
+        alternate_message = Message.new
+        refute_equal alternate_message, wrapped_message # Sanity check
+        refute_equal wrapper, Protip::Wrapper.new(alternate_message, converter)
+      end
+
+      it 'returns false when converters are not equal' do
+        alternate_converter = Class.new do
+          include Protip::Converter
+        end.new
+        refute_equal alternate_converter, converter # Sanity check
+        refute_equal wrapper, Protip::Wrapper.new(wrapped_message, alternate_converter)
+      end
+
+      it 'returns true when the message and converter are equal' do
+        # Stub converter equality so we aren't relying on actual equality behavior there
+        alternate_converter = converter.clone
+        converter.expects(:==).at_least_once.with(alternate_converter).returns(true)
+        assert_equal wrapper, Protip::Wrapper.new(wrapped_message.clone, converter)
+      end
+    end
+
     describe '#get' do
       it 'does not convert simple fields' do
         converter.expects(:convertible?).never

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: protip
 version: !ruby/object:Gem::Version
-  version: 0.10.5
+  version: 0.10.6
 platform: ruby
 authors:
 - AngelList
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-03 00:00:00.000000000 Z
+date: 2015-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -54,16 +54,22 @@ dependencies:
   name: protobuf
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: 3.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: 3.5.0
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement