prosopite 1.2.2 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7579093e51b4e3b1cf5c3ca8d5b5a072fcc7cc92750a2f2daa263eb937e091ae
-  data.tar.gz: 77314c08c37d6c0bde6fe68143ab9c0520a3e36eb9046565a962379a743f1bd4
+  metadata.gz: 3620722495a4f378b76f94846d24104ec2b8bda051243246070fe9a8ab0e9e35
+  data.tar.gz: 455827914e23b7714efe0c1851050699cabb2210d494e2cdba9102afb8ab329b
 SHA512:
-  metadata.gz: 463ffb84a224f48d143c2fc5867342ae83db230b742ed35e722069aa12c988fa04c1c4377eabbaa3e1ee3574c51c505ba303c36b18b43408c62f8861209e5ef5
-  data.tar.gz: b6adbcf4b7785c90c4f937f10eb51429bf50d09a98420ccc7836ef7467abfbe8a59ac5247e9fb369fe876ecec1311d25db637566ec72f8421ea4db2f21ef261d
+  metadata.gz: 4f31607760d147b9df2323d9b6032d3290a7467918a5ae2b8abfe60657b2befa322c91cd7a3d9ab62b1b7dee113c4db5bee3066a4afeb2e0691b5f24d96fd956
+  data.tar.gz: 5c49dd603ea2720cd3c60846d0d63a9a1e818be3be287f050fc33ccf5654e619f7ee6fb9378e3f36ae07b6c3b5d5f2791e7f72078b6f6606346700587667449c

data/.github/workflows/ci.yml

@@ -4,10 +4,10 @@ jobs:
   test:
     strategy:
       matrix:
-        ruby: [2.5, 2.6, 2.7, '3.0', 3.1, head]
+        ruby: [2.7, '3.0', 3.1, 3.2]
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: ruby/setup-ruby@v1
         with:
           bundler-cache: true

data/Gemfile.lock

@@ -1,11 +1,24 @@
 PATH
   remote: .
   specs:
-    prosopite (1.2.2)
+    prosopite (1.3.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    actionpack (6.1.3)
+      actionview (= 6.1.3)
+      activesupport (= 6.1.3)
+      rack (~> 2.0, >= 2.0.9)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actionview (6.1.3)
+      activesupport (= 6.1.3)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
     activemodel (6.1.3)
       activesupport (= 6.1.3)
     activerecord (6.1.3)
@@ -17,20 +30,55 @@ GEM
       minitest (>= 5.1)
       tzinfo (~> 2.0)
       zeitwerk (~> 2.3)
+    ansi (1.5.0)
+    builder (3.2.4)
     coderay (1.1.3)
     concurrent-ruby (1.1.8)
+    crass (1.0.6)
+    erubi (1.12.0)
     factory_bot (6.1.0)
       activesupport (>= 5.0.0)
     i18n (1.8.9)
       concurrent-ruby (~> 1.0)
+    loofah (2.19.1)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
     method_source (1.0.0)
+    mini_portile2 (2.8.1)
     minitest (5.14.3)
+    minitest-reporters (1.5.0)
+      ansi
+      builder
+      minitest (>= 5.0)
+      ruby-progressbar
+    nokogiri (1.14.1)
+      mini_portile2 (~> 2.8.0)
+      racc (~> 1.4)
+    nokogiri (1.14.1-x86_64-linux)
+      racc (~> 1.4)
     pg_query (1.3.0)
     pry (0.14.0)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    rake (13.0.3)
+    racc (1.6.2)
+    rack (2.2.6.2)
+    rack-test (2.0.2)
+      rack (>= 1.3)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.5.0)
+      loofah (~> 2.19, >= 2.19.1)
+    railties (6.1.3)
+      actionpack (= 6.1.3)
+      activesupport (= 6.1.3)
+      method_source
+      rake (>= 0.8.7)
+      thor (~> 1.0)
+    rake (13.0.6)
+    ruby-progressbar (1.11.0)
     sqlite3 (1.4.2)
+    thor (1.2.1)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
     zeitwerk (2.4.2)
@@ -43,9 +91,11 @@ DEPENDENCIES
   activerecord
   factory_bot
   minitest
+  minitest-reporters
   pg_query
   prosopite!
   pry
+  railties
   rake (~> 13.0)
   sqlite3
 

data/README.md

@@ -120,6 +120,7 @@ The preferred type of notifications can be configured with:
 * `Prosopite.rails_logger = true`: Send warnings to the Rails log
 * `Prosopite.prosopite_logger = true`: Send warnings to `log/prosopite.log`
 * `Prosopite.stderr_logger = true`: Send warnings to STDERR
+* `Prosopite.backtrace_cleaner = my_custom_backtrace_cleaner`: use a different [ActiveSupport::BacktraceCleaner](https://api.rubyonrails.org/classes/ActiveSupport/BacktraceCleaner.html). Defaults to `Rails.backtrace_cleaner`.
 * `Prosopite.custom_logger = my_custom_logger`:
 
 ### Custom Logging Configuration

data/lib/prosopite/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Prosopite
-  VERSION = "1.2.2"
+  VERSION = "1.3.1"
 end

data/lib/prosopite.rb

@@ -1,6 +1,9 @@
 
 module Prosopite
-  DEFAULT_ALLOW_LIST = %w(active_record/associations/preloader active_record/validations/uniqueness)
+  DEFAULT_ALLOW_LIST = [
+    /active_record\/relation.rb.*preload_associations/,
+    'active_record/validations/uniqueness'
+  ].freeze
 
   class NPlusOneQueriesError < StandardError; end
   class << self
@@ -12,7 +15,8 @@ module Prosopite
                 :allow_stack_paths,
                 :ignore_queries,
                 :ignore_pauses,
-                :min_n_queries
+                :min_n_queries,
+                :backtrace_cleaner
 
     def allow_list=(value)
       puts "Prosopite.allow_list= is deprecated. Use Prosopite.allow_stack_paths= instead."
@@ -20,6 +24,10 @@ module Prosopite
       self.allow_stack_paths = value
     end
 
+    def backtrace_cleaner
+      @backtrace_cleaner ||= Rails.backtrace_cleaner
+    end
+
     def scan
       tc[:prosopite_scan] ||= false
       return if scan?
@@ -193,11 +201,15 @@ module Prosopite
 
       tc[:prosopite_notifications].each do |queries, kaller|
         notifications_str << "N+1 queries detected:\n"
+
         queries.each { |q| notifications_str << "  #{q}\n" }
+
         notifications_str << "Call stack:\n"
+        kaller = backtrace_cleaner.clean(kaller)
         kaller.each do |f|
-          notifications_str << "  #{f}\n" unless f.include?(Bundler.bundle_path.to_s)
+          notifications_str << "  #{f}\n"
         end
+
         notifications_str << "\n"
       end
 

data/prosopite.gemspec

@@ -28,5 +28,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "factory_bot"
   spec.add_development_dependency "activerecord"
+  spec.add_development_dependency "railties"
   spec.add_development_dependency "sqlite3"
+  spec.add_development_dependency "minitest-reporters"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: prosopite
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.3.1
 platform: ruby
 authors:
 - Mpampis Kostas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-02 00:00:00.000000000 Z
+date: 2023-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: railties
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest-reporters
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: N+1 auto-detection for Rails with zero false positives / false negatives
 email:
 - charkost.rb@gmail.com
@@ -118,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.4.6
 signing_key: 
 specification_version: 4
 summary: N+1 auto-detection for Rails with zero false positives / false negatives