proscenium 0.5.1-arm64-darwin → 0.6.0-arm64-darwin

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fdb9396daf1d49bf6e967f21fc835cbaecb5e8ce8b11c791b2a3c965f8b64e0f
-  data.tar.gz: a7093def0fd1dea81d1b86ce9b54491e1669e74a1ac1923ff95d2acbcce24e1d
+  metadata.gz: 51e993c0b5a75f94b338565ac692cbbb4a06956fe70267616ef4913c7c571d3b
+  data.tar.gz: d9087b47c6476c7401cd236ed978a0763140c6cb623a294659afc056d4295352
 SHA512:
-  metadata.gz: dec5e37a5fed831e2b6e300fc7c4449197e138bb239c51cf3dc7b6fa8dfa5fe139fa17f800ac6c3023ec63c8a14eb5f1c8ad9738eb6db8fae6bd81164cd7cf0b
-  data.tar.gz: 914124903b064f0a17f904ad74e6f87bd45955981436253b4543fc01c1717fa56d2a53582f1b1ce377d57aa23f2d0e9ce8ab75e0c65675a84c4683ca27ca2fc6
+  metadata.gz: 7b6e1239cbf2fb37873f8d60a2d45d6dcc64c94fab0695a89bab657032bd83bde1dd4fa07babdbf4678582cf98b656b7f533ccf582bba24fb97ff4b1a7782d2e
+  data.tar.gz: f05e18bc66174cdf1e3fe18db21cac545f811652ecffcfc199429af60b9e1718aa25756e973dea80e7ec9392e6084e96f390ab46d722753fff23c421147d23cf

data/README.md

@@ -117,7 +117,10 @@ as you could end up swallowing everything, resulting in a very large file.
 ## Import Map
 
 Import map for both JS and CSS is supported out of the box, and works with no regard to the browser
-version being used. Just create `config/import_map.json`:
+version being used. This is because the import map is parsed and resolved by Proscenium on the
+server.
+
+Just create `config/import_map.json`:
 
 ```json
 {
@@ -157,6 +160,18 @@ env => ({
 })
 ```
 
+### Aliasing
+
+You can also use the import map to define aliases:
+
+```json
+{
+  "imports": {
+    "react": "preact/compact",
+  }
+}
+```
+
 ## Side Loading
 
 Proscenium has built in support for automatically side loading JS and CSS with your views and

data/lib/proscenium/compilers/esbuild/import_map/parser.js

@@ -0,0 +1,178 @@
+import { tryURLParse, tryURLLikeSpecifierParse } from './utils.js'
+
+/**
+ * @param {ImportMap} input
+ * @param {URL} baseURL
+ * @returns {ParsedImportMap}
+ */
+export function parse(input, baseURL) {
+  if (!isJSONObject(input)) {
+    throw new TypeError('Import map JSON must be an object.')
+  }
+
+  if (!(baseURL instanceof URL)) {
+    throw new TypeError('Missing base URL or base URL is not a URL')
+  }
+
+  let sortedAndNormalizedImports = {}
+  if ('imports' in input) {
+    if (!input.imports || !isJSONObject(input.imports)) {
+      throw new TypeError("Import map's imports value must be an object.")
+    }
+    sortedAndNormalizedImports = sortAndNormalizeSpecifierMap(input.imports, baseURL)
+  }
+
+  let sortedAndNormalizedScopes = {}
+  if ('scopes' in input) {
+    if (!input.scopes || !isJSONObject(input.scopes)) {
+      throw new TypeError("Import map's scopes value must be an object.")
+    }
+    sortedAndNormalizedScopes = sortAndNormalizeScopes(input.scopes, baseURL)
+  }
+
+  const badTopLevelKeys = new Set(Object.keys(input))
+  badTopLevelKeys.delete('imports')
+  badTopLevelKeys.delete('scopes')
+
+  for (const badKey of badTopLevelKeys) {
+    throw new TypeError(
+      `Invalid top-level key "${badKey}". Only "imports" and "scopes" can be present.`
+    )
+  }
+
+  // Always have these two keys, and exactly these two keys, in the result.
+  return {
+    imports: sortedAndNormalizedImports,
+    scopes: sortedAndNormalizedScopes
+  }
+}
+
+/**
+ * @param {string} input
+ * @param {URL} baseURL
+ * @returns {ParsedImportMap}
+ */
+export function parseFromString(input, baseURL) {
+  const importMap = JSON.parse(input)
+  return parse(importMap, baseURL)
+}
+
+/**
+ * @param {string} a
+ * @param {string} b
+ */
+function codeUnitCompare(a, b) {
+  if (a > b) {
+    return 1
+  }
+
+  if (b > a) {
+    return -1
+  }
+
+  throw new Error('This should never be reached because this is only used on JSON object keys')
+}
+
+/**
+ * @param {string} specifierKey
+ * @param {URL} baseURL
+ * @returns {string | undefined}
+ */
+function normalizeSpecifierKey(specifierKey, baseURL) {
+  // Ignore attempts to use the empty string as a specifier key
+  if (specifierKey === '') {
+    throw new TypeError(`Invalid empty string specifier key.`)
+  }
+
+  const url = tryURLLikeSpecifierParse(specifierKey, baseURL)
+  if (url) return url.href
+
+  return specifierKey
+}
+
+/**
+ * @param {SpecifierMap} obj
+ * @param {URL} baseURL
+ * @returns {ParsedSpecifierMap}
+ */
+function sortAndNormalizeSpecifierMap(obj, baseURL) {
+  if (!isJSONObject(obj)) {
+    throw new TypeError('Expect map to be a JSON object.')
+  }
+
+  const normalized = {}
+
+  for (const [specifierKey, value] of Object.entries(obj)) {
+    const normalizedSpecifierKey = normalizeSpecifierKey(specifierKey, baseURL)
+    if (!normalizedSpecifierKey) continue
+
+    if (typeof value !== 'string') {
+      throw new TypeError(
+        `Invalid address ${JSON.stringify(value)} for the specifier key "${specifierKey}". ` +
+          `Addresses must be strings.`
+      )
+    }
+
+    const addressURL = tryURLLikeSpecifierParse(value, baseURL)
+    if (!addressURL) {
+      // Support aliases.
+      // console.warn(`Invalid address "${value}" for the specifier key "${specifierKey}".`)
+      normalized[normalizedSpecifierKey] = value
+      continue
+    }
+
+    if (specifierKey.endsWith('/') && !addressURL.href.endsWith('/')) {
+      throw new TypeError(
+        `Invalid address "${addressURL.href}" for package specifier key "${specifierKey}". ` +
+          `Package addresses must end with "/".`
+      )
+    }
+
+    normalized[normalizedSpecifierKey] = addressURL
+  }
+
+  const sortedAndNormalized = {}
+  const sortedKeys = Object.keys(normalized).sort((a, b) => codeUnitCompare(b, a))
+  for (const key of sortedKeys) {
+    sortedAndNormalized[key] = normalized[key]
+  }
+
+  return sortedAndNormalized
+}
+
+/**
+ * @param {ScopesMap} obj
+ * @param {URL} baseURL
+ */
+function sortAndNormalizeScopes(obj, baseURL) {
+  const normalized = {}
+  for (const [scopePrefix, potentialSpecifierMap] of Object.entries(obj)) {
+    if (!isJSONObject(potentialSpecifierMap)) {
+      throw new TypeError(`The value for the "${scopePrefix}" scope prefix must be an object.`)
+    }
+
+    const scopePrefixURL = tryURLParse(scopePrefix, baseURL)
+    if (!scopePrefixURL) {
+      throw new TypeError(`Invalid scope "${scopePrefix}" (parsed against base URL "${baseURL}").`)
+    }
+
+    const normalizedScopePrefix = scopePrefixURL.href
+    normalized[normalizedScopePrefix] = sortAndNormalizeSpecifierMap(potentialSpecifierMap, baseURL)
+  }
+
+  const sortedAndNormalized = {}
+  const sortedKeys = Object.keys(normalized).sort((a, b) => codeUnitCompare(b, a))
+  for (const key of sortedKeys) {
+    sortedAndNormalized[key] = normalized[key]
+  }
+
+  return sortedAndNormalized
+}
+
+/**
+ * @param {*} value
+ * @returns {value is object}
+ */
+function isJSONObject(value) {
+  return typeof value === 'object' && value != null && !Array.isArray(value)
+}

data/lib/proscenium/compilers/esbuild/{import_map.js → import_map/read.js}

@@ -1,5 +1,10 @@
+//
+// Taken almost verbatim from https://github.com/open-wc/open-wc/tree/master/packages/import-maps-resolve
+// Slightly modified to support aliases.
+//
+
 import { join } from 'std/path/mod.ts'
-import { parseFromString } from 'import-maps/resolve'
+import { parseFromString } from './parser.js'
 
 const baseURL = new URL('file://')
 
@@ -16,7 +21,7 @@ class ImportMapError extends Error {
   }
 }
 
-export function readImportMap(fileName, rootDir) {
+export default function (fileName, rootDir) {
   let importMap
 
   if (fileName) {

data/lib/proscenium/compilers/esbuild/import_map/resolver.js

@@ -0,0 +1,95 @@
+import { tryURLLikeSpecifierParse, tryURLParse } from './utils.js'
+
+/**
+ * @param {string} specifier
+ * @param {ParsedImportMap} parsedImportMap
+ * @param {URL} scriptURL
+ * @returns {{ resolvedImport: URL | null, matched: boolean }}
+ */
+export default function (specifier, parsedImportMap, scriptURL) {
+  const asURL = tryURLLikeSpecifierParse(specifier, scriptURL)
+  const normalizedSpecifier = asURL ? asURL.href : specifier
+  const scriptURLString = scriptURL.href
+
+  for (const [scopePrefix, scopeImports] of Object.entries(parsedImportMap.scopes || {})) {
+    if (
+      scopePrefix === scriptURLString ||
+      (scopePrefix.endsWith('/') && scriptURLString.startsWith(scopePrefix))
+    ) {
+      const scopeImportsMatch = resolveImportsMatch(normalizedSpecifier, scopeImports)
+
+      if (scopeImportsMatch) {
+        return { resolvedImport: scopeImportsMatch, matched: true }
+      }
+    }
+  }
+
+  const topLevelImportsMatch = resolveImportsMatch(
+    normalizedSpecifier,
+    parsedImportMap.imports || {}
+  )
+
+  if (topLevelImportsMatch) {
+    return { resolvedImport: topLevelImportsMatch, matched: true }
+  }
+
+  // The specifier was able to be turned into a URL, but wasn't remapped into anything.
+  if (asURL) {
+    return { resolvedImport: asURL, matched: false }
+  }
+
+  return { resolvedImport: null, matched: false }
+}
+
+/**
+ * @param {string} normalizedSpecifier
+ * @param {ParsedSpecifierMap} specifierMap
+ */
+function resolveImportsMatch(normalizedSpecifier, specifierMap) {
+  for (const [specifierKey, resolutionResult] of Object.entries(specifierMap)) {
+    // Exact-match case
+    if (specifierKey === normalizedSpecifier) {
+      if (!resolutionResult) {
+        throw new TypeError(`Blocked by a null entry for "${specifierKey}"`)
+      }
+
+      if (!(resolutionResult instanceof URL)) {
+        // Support aliases.
+        // throw new TypeError(`Expected ${resolutionResult} to be a URL.`)
+      }
+
+      return resolutionResult
+    }
+
+    // Package prefix-match case
+    if (specifierKey.endsWith('/') && normalizedSpecifier.startsWith(specifierKey)) {
+      if (!resolutionResult) {
+        throw new TypeError(`Blocked by a null entry for "${specifierKey}"`)
+      }
+
+      if (!(resolutionResult instanceof URL)) {
+        throw new TypeError(`Expected ${resolutionResult} to be a URL.`)
+      }
+
+      const afterPrefix = normalizedSpecifier.substring(specifierKey.length)
+
+      // Enforced by parsing
+      if (!resolutionResult.href.endsWith('/')) {
+        throw new TypeError(`Expected ${resolutionResult.href} to end with a '/'.`)
+      }
+
+      const url = tryURLParse(afterPrefix, resolutionResult)
+      if (!url) {
+        throw new TypeError(`Failed to resolve prefix-match relative URL for "${specifierKey}"`)
+      }
+
+      if (!(url instanceof URL)) {
+        throw new TypeError(`Expected ${url} to be a URL.`)
+      }
+
+      return url
+    }
+  }
+
+  return undefined
+}

data/lib/proscenium/compilers/esbuild/import_map/utils.js

@@ -0,0 +1,25 @@
+/**
+ * @param {string} string
+ * @param {URL} [baseURL]
+ * @returns {URL | undefined}
+ */
+export function tryURLParse(string, baseURL) {
+  try {
+    return new URL(string, baseURL)
+  } catch (e) {
+    return undefined
+  }
+}
+
+/**
+ * @param {string} specifier
+ * @param {URL} baseURL
+ * @returns {URL | undefined}
+ */
+export function tryURLLikeSpecifierParse(specifier, baseURL) {
+  if (specifier.startsWith('/') || specifier.startsWith('./') || specifier.startsWith('../')) {
+    return tryURLParse(specifier, baseURL)
+  }
+
+  return tryURLParse(specifier)
+}

data/lib/proscenium/compilers/esbuild/resolve_plugin.js

@@ -1,8 +1,9 @@
 import { join, resolve } from 'std/path/mod.ts'
-import { resolve as resolveFromImportMap } from 'import-maps/resolve'
+import resolveFromImportMap from './import_map/resolver.js'
 import { cache } from 'cache'
 
 import setup from './setup_plugin.js'
+import { isBareModule } from '../../utils.js'
 
 const importKinds = ['import-statement', 'dynamic-import', 'require-call', 'import-rule']
 
@@ -108,16 +109,21 @@ export default setup('resolve', (build, options) => {
       }
 
       const { matched, resolvedImport } = resolveFromImportMap(params.path, importMap, baseURL)
+      // console.log({ importMap, matched, resolvedImport })
 
       if (matched) {
-        if (resolvedImport.protocol === 'file:') {
-          params.path = resolvedImport.pathname
-        } else {
-          if (params.importer.endsWith('.css')) {
-            return { path: resolvedImport.href, external: true }
+        if (resolvedImport instanceof URL) {
+          if (resolvedImport.protocol === 'file:') {
+            params.path = resolvedImport.pathname
+          } else {
+            if (params.importer.endsWith('.css')) {
+              return { path: resolvedImport.href, external: true }
+            }
+
+            return { path: `/url:${encodeURIComponent(resolvedImport.href)}`, external: true }
           }
-
-          return { path: `/url:${encodeURIComponent(resolvedImport.href)}`, external: true }
+        } else {
+          result.path = resolvedImport
         }
       }
     }
@@ -199,7 +205,3 @@ export default setup('resolve', (build, options) => {
     return result
   }
 })
-
-function isBareModule(mod) {
-  return !mod.startsWith('/') && !mod.startsWith('.')
-}

data/lib/proscenium/compilers/esbuild.js

@@ -4,7 +4,7 @@ import { expandGlob } from 'std/fs/mod.ts'
 import { join, isGlob, resolve, dirname, fromFileUrl } from 'std/path/mod.ts'
 import { build, stop } from 'esbuild'
 
-import { readImportMap } from './esbuild/import_map.js'
+import readImportMap from './esbuild/import_map/read.js'
 import envPlugin from './esbuild/env_plugin.js'
 import cssPlugin from './esbuild/css_plugin.js'
 import resolvePlugin from './esbuild/resolve_plugin.js'

data/lib/proscenium/utils.js

@@ -6,3 +6,7 @@ export async function fileExists(path) {
     return false
   }
 }
+
+export function isBareModule(mod) {
+  return !mod.startsWith('/') && !mod.startsWith('.')
+}

data/lib/proscenium/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Proscenium
-  VERSION = '0.5.1'
+  VERSION = '0.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: proscenium
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: arm64-darwin
 authors:
 - Joel Moss
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-08 00:00:00.000000000 Z
+date: 2022-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actioncable
@@ -167,7 +167,10 @@ files:
 - lib/proscenium/compilers/esbuild/css_plugin.js
 - lib/proscenium/compilers/esbuild/env_plugin.js
 - lib/proscenium/compilers/esbuild/http_bundle_plugin.js
-- lib/proscenium/compilers/esbuild/import_map.js
+- lib/proscenium/compilers/esbuild/import_map/parser.js
+- lib/proscenium/compilers/esbuild/import_map/read.js
+- lib/proscenium/compilers/esbuild/import_map/resolver.js
+- lib/proscenium/compilers/esbuild/import_map/utils.js
 - lib/proscenium/compilers/esbuild/resolve_plugin.js
 - lib/proscenium/compilers/esbuild/setup_plugin.js
 - lib/proscenium/compilers/esbuild/solidjs_plugin.js