proscenium 0.10.0-arm64-darwin → 0.11.0-arm64-darwin

data/lib/proscenium/phlex/{resolve_css_modules.rb → css_modules.rb}

@@ -1,15 +1,32 @@
 # frozen_string_literal: true
 
 module Proscenium
-  module Phlex::ResolveCssModules
-    extend ActiveSupport::Concern
+  module Phlex::CssModules
+    include Proscenium::CssModule
 
-    class_methods do
-      attr_accessor :side_load_cache
+    def self.included(base)
+      base.extend CssModule::Path
+      base.extend ClassMethods
+    end
+
+    module ClassMethods
+      # Set of CSS module paths that have been resolved after being transformed from 'class' HTML
+      # attributes. See #process_attributes. This is here because Phlex caches attributes. Which
+      # means while the CSS class names will be transformed, any resolved paths will be lost in
+      # subsequent requests.
+      attr_accessor :resolved_css_module_paths
     end
 
     def before_template
-      self.class.side_load_cache ||= Set.new
+      self.class.resolved_css_module_paths ||= Concurrent::Set.new
+      super
+    end
+
+    def after_template
+      self.class.resolved_css_module_paths.each do |path|
+        Proscenium::Importer.import path
+      end
+
       super
     end
 
@@ -44,24 +61,19 @@ module Proscenium
     #     end
     #   end
     #
-    # The given class name should be underscored, and the resulting CSS module name will be
-    # `camelCased` with a lower case first character.
-    #
     # @raise [Proscenium::CssModule::Resolver::NotFound] If a CSS module file is not found for the
     #   Phlex class file path.
     def process_attributes(**attributes)
       if attributes.key?(:class) && (attributes[:class] = tokens(attributes[:class])).include?('@')
-        resolver = CssModule::ClassNamesResolver.new(attributes[:class], path)
-        self.class.side_load_cache.merge resolver.stylesheets
-        attributes[:class] = resolver.class_names
+        names = attributes[:class].is_a?(Array) ? attributes[:class] : attributes[:class].split
+
+        attributes[:class] = cssm.class_names(*names).map do |name, path|
+          self.class.resolved_css_module_paths << path if path
+          name
+        end
       end
 
       attributes
     end
-
-    def after_template
-      super
-      self.class.side_load_cache&.each { |path| SideLoad.append! path, :css }
-    end
   end
 end

data/lib/proscenium/phlex/react_component.rb

@@ -1,33 +1,32 @@
 # frozen_string_literal: true
 
-#
-# Renders a <div> for use with React components, with data attributes specifying the component path
-# and props.
-#
-# If a block is given, it will be yielded within the div, allowing for a custom "loading" UI. If no
-# block is given, then a "loading..." text will be rendered. It is intended that the component is
-# mounted to this div, and the loading UI will then be replaced with the component's rendered
-# output.
-#
-# You can pass props to the component in the `:props` keyword argument.
-#
-class Proscenium::Phlex::ReactComponent < Proscenium::Phlex
-  self.abstract_class = true
-
-  include Proscenium::Componentable
-  include Proscenium::Phlex::ComponentConcerns::CssModules
-
-  # Override this to provide your own loading UI.
+module Proscenium
+  # Renders a <div> for use with React components, with data attributes specifying the component
+  # path and props.
   #
-  # @example
-  #   def template(**attributes, &block)
-  #     super do
-  #       'Look at me! I am loading now...'
-  #     end
-  #   end
+  # If a block is given, it will be yielded within the div, allowing for a custom "loading" UI. If
+  # no block is given, then a "loading..." text will be rendered. It is intended that the component
+  # is mounted to this div, and the loading UI will then be replaced with the component's rendered
+  # output.
   #
-  # @yield the given block to a `div` within the top level component div.
-  def template(**attributes, &block)
-    send root_tag, **{ data: data_attributes }.deep_merge(attributes), &block
+  # You can pass props to the component in the `:props` keyword argument.
+  class Phlex::ReactComponent < Phlex
+    self.abstract_class = true
+
+    include ReactComponentable
+
+    # Override this to provide your own loading UI.
+    #
+    # @example
+    #   def template(**attributes, &block)
+    #     super do
+    #       'Look at me! I am loading now...'
+    #     end
+    #   end
+    #
+    # @yield the given block to a `div` within the top level component div.
+    def template(**attributes, &block)
+      send root_tag, **{ data: data_attributes }.deep_merge(attributes), &block
+    end
   end
 end

data/lib/proscenium/phlex.rb

@@ -5,54 +5,35 @@ require 'phlex-rails'
 module Proscenium
   class Phlex < ::Phlex::HTML
     extend ActiveSupport::Autoload
-    include Proscenium::CssModule
 
-    autoload :Page
+    autoload :CssModules
     autoload :ReactComponent
-    autoload :ResolveCssModules
-    autoload :ComponentConcerns
 
     extend ::Phlex::Rails::HelperMacros
     include ::Phlex::Rails::Helpers::JavaScriptIncludeTag
     include ::Phlex::Rails::Helpers::StyleSheetLinkTag
+    include Proscenium::SourcePath
+    include CssModules
 
-    define_output_helper :side_load_stylesheets
-    define_output_helper :side_load_javascripts
+    define_output_helper :side_load_stylesheets # deprecated
+    define_output_helper :include_stylesheets
+    define_output_helper :side_load_javascripts # deprecated
+    define_output_helper :include_javascripts
+    define_output_helper :declare_lazy_scripts
 
-    # Side loads the class, and its super classes that respond to `.path`. Assign the
-    # `abstract_class` class variable to any abstract class, and it will not be side loaded.
-    # Additionally, if the class responds to `side_load`, then that method is called.
     module Sideload
       def before_template
-        klass = self.class
-
-        if !klass.abstract_class && respond_to?(:side_load, true)
-          side_load
-          klass = klass.superclass
-        end
-
-        while !klass.abstract_class && klass.respond_to?(:path) && klass.path
-          Proscenium::SideLoad.append klass.path
-          klass = klass.superclass
-        end
+        Proscenium::SideLoad.sideload_inheritance_chain self
 
         super
       end
     end
 
     class << self
-      attr_accessor :path, :abstract_class
+      attr_accessor :abstract_class
 
       def inherited(child)
-        unless child.path
-          child.path = if caller_locations(1, 1).first.label == 'inherited'
-                         Pathname.new caller_locations(2, 1).first.path
-                       else
-                         Pathname.new caller_locations(1, 1).first.path
-                       end
-        end
-
-        child.prepend Sideload if Rails.application.config.proscenium.side_load
+        child.prepend Sideload
 
         super
       end

data/lib/proscenium/railtie.rb

@@ -6,14 +6,6 @@ require 'proscenium/log_subscriber'
 ENV['RAILS_ENV'] = Rails.env
 
 module Proscenium
-  FILE_EXTENSIONS = ['js', 'mjs', 'ts', 'jsx', 'tsx', 'css', 'js.map', 'mjs.map', 'jsx.map',
-                     'ts.map', 'tsx.map', 'css.map'].freeze
-
-  APPLICATION_INCLUDE_PATHS = ['config', 'app/assets', 'app/views', 'lib', 'node_modules'].freeze
-
-  # Environment variables that should always be passed to the builder.
-  DEFAULT_ENV_VARS = Set['RAILS_ENV', 'NODE_ENV'].freeze
-
   class << self
     def config
       @config ||= Railtie.config.proscenium
@@ -26,66 +18,72 @@ module Proscenium
     config.proscenium = ActiveSupport::OrderedOptions.new
     config.proscenium.debug = false
     config.proscenium.side_load = true
-    config.proscenium.code_splitting = false
+    config.proscenium.code_splitting = true
+
+    # TODO: implement!
     config.proscenium.cache_query_string = Rails.env.production? && ENV.fetch('REVISION', nil)
     config.proscenium.cache_max_age = 2_592_000 # 30 days
-    config.proscenium.include_paths = Set.new(APPLICATION_INCLUDE_PATHS)
 
     # List of environment variable names that should be passed to the builder, which will then be
     # passed to esbuild's `Define` option. Being explicit about which environment variables are
     # defined means a faster build, as esbuild will have less to do.
     config.proscenium.env_vars = Set.new
 
-    # A hash of gems that can be side loaded. Assets from gems listed here can be side loaded.
-    #
-    # Because side loading uses URL paths, any gem dependencies that side load assets will fail,
-    # because the URL path will be relative to the application's root, and not the gem's root. By
-    # specifying a list of gems that can be side loaded, Proscenium will be able to resolve the URL
-    # path to the gem's root, and side load the asset.
+    # Rails engines to expose and allow Proscenium to serve their assets.
     #
-    # Side loading gems rely on NPM and a package.json file in the gem root. This ensures that any
-    # dependencies are resolved correctly. This is required even if your gem has no package
-    # dependencies.
+    # A Rails engine that has assets, can add Proscenium as a gem dependency, and then add itself
+    # to this list. Proscenium will then serve the engine's assets at the URL path beginning with
+    # the engine name.
     #
     # Example:
-    #   config.proscenium.side_load_gems['mygem'] = {
-    #     root: gem_root,
-    #     package_name: 'mygem'
-    #   }
-    config.proscenium.side_load_gems = {}
-
-    initializer 'proscenium.configuration' do |app|
-      options = app.config.proscenium
-      options.include_paths = Set.new(APPLICATION_INCLUDE_PATHS) if options.include_paths.blank?
+    #   class Gem1::Engine < ::Rails::Engine
+    #     config.proscenium.engines << self
+    #   end
+    config.proscenium.engines = Set.new
+
+    config.action_dispatch.rescue_templates = {
+      'Proscenium::Builder::BuildError' => 'build_error'
+    }
+
+    initializer 'proscenium.debugging' do
+      if Rails.gem_version >= Gem::Version.new('7.1.0')
+        tpl_path = root.join('lib', 'proscenium', 'templates').to_s
+        ActionDispatch::DebugView::RESCUES_TEMPLATE_PATHS << tpl_path
+      end
     end
 
     initializer 'proscenium.middleware' do |app|
-      app.middleware.insert_after ActionDispatch::Static, Proscenium::Middleware
-      app.middleware.insert_after ActionDispatch::Static, Rack::ETag, 'no-cache'
-      app.middleware.insert_after ActionDispatch::Static, Rack::ConditionalGet
+      app.middleware.insert_after ActionDispatch::Static, Middleware
+      # app.middleware.insert_after ActionDispatch::Static, Rack::ETag, 'no-cache'
+      # app.middleware.insert_after ActionDispatch::Static, Rack::ConditionalGet
     end
 
-    initializer 'proscenium.side_loading' do |app|
-      if app.config.proscenium.side_load
-        Proscenium::Current.loaded ||= SideLoad::EXTENSIONS.to_h { |e| [e, Set.new] }
-
-        ActiveSupport.on_load(:action_view) do
-          ActionView::Base.include Proscenium::SideLoad::Helper
-
-          ActionView::TemplateRenderer.prepend SideLoad::Monkey::TemplateRenderer
-          ActionView::PartialRenderer.prepend SideLoad::Monkey::PartialRenderer
-        end
-
-        ActiveSupport.on_load(:action_controller) do
-          ActionController::Base.include Proscenium::SideLoad::EnsureLoaded
-        end
+    initializer 'proscenium.monkey_patches' do
+      ActiveSupport.on_load(:action_view) do
+        ActionView::TemplateRenderer.prepend Monkey::TemplateRenderer
+        ActionView::PartialRenderer.prepend Monkey::PartialRenderer
       end
     end
 
     initializer 'proscenium.helper' do
       ActiveSupport.on_load(:action_view) do
-        ActionView::Base.include Proscenium::Helper
+        ActionView::Base.include Helper
+      end
+
+      ActiveSupport.on_load(:action_controller) do
+        ActionController::Base.include EnsureLoaded
       end
     end
   end
 end
+
+if Rails.gem_version < Gem::Version.new('7.1.0')
+  class ActionDispatch::DebugView
+    def initialize(assigns)
+      tpl_path = Proscenium::Railtie.root.join('lib', 'proscenium', 'templates').to_s
+      paths = [RESCUES_TEMPLATE_PATH, tpl_path]
+      lookup_context = ActionView::LookupContext.new(paths)
+      super(lookup_context, assigns, nil)
+    end
+  end
+end

data/lib/proscenium/react_componentable.rb

@@ -0,0 +1,95 @@
+# frozen_string_literal: true
+
+module Proscenium
+  module ReactComponentable
+    extend ActiveSupport::Concern
+
+    included do
+      # @return [Hash] the props to pass to the React component.
+      attr_writer :props
+
+      # The HTML tag to use as the wrapping element for the component. You can reassign this in your
+      # component class to use a different tag:
+      #
+      #   class MyComponent < Proscenium::ViewComponent::ReactComponent
+      #     self.root_tag = :span
+      #   end
+      #
+      # @return [Symbol]
+      class_attribute :root_tag, instance_predicate: false, default: :div
+
+      # By default, the template block (content) of the component will be server rendered as normal.
+      # However, when React hydrates and takes control of the component, it's content will be
+      # replaced by React with the JavaScript rendered content. Enabling this option will forward
+      # the server rendered content as the `children` prop passed to the React component.
+      #
+      # @example
+      #
+      #   const Component = ({ children }) => {
+      #     return <div dangerouslySetInnerHTML={{ __html: children }} />
+      #   }
+      #
+      # @return [Boolean]
+      class_attribute :forward_children, default: false
+
+      # Lazy load the component using IntersectionObserver?
+      #
+      # @return [Boolean]
+      class_attribute :lazy, default: false
+
+      class_attribute :loader
+
+      # @return [String] the URL path to the component manager.
+      class_attribute :manager, default: '/@proscenium/react-manager/index.jsx'
+    end
+
+    class_methods do
+      def sideload
+        Importer.import manager
+        Importer.sideload source_path, lazy: true
+      end
+    end
+
+    # @param props: [Hash]
+    def initialize(lazy: self.class.lazy, loader: self.class.loader, props: {})
+      self.lazy = lazy
+      self.loader = loader
+      @props = props
+    end
+
+    # The absolute URL path to the javascript component.
+    def virtual_path
+      @virtual_path ||= Resolver.resolve self.class.source_path.sub_ext('.jsx').to_s
+    end
+
+    def props
+      @props ||= {}
+    end
+
+    private
+
+    def data_attributes
+      {
+        proscenium_component_path: Pathname.new(virtual_path).to_s,
+        proscenium_component_props: prepared_props,
+        proscenium_component_lazy: lazy
+      }.tap do |x|
+        x[:proscenium_component_forward_children] = true if forward_children?
+      end
+    end
+
+    def prepared_props
+      props.deep_transform_keys do |term|
+        # This ensures that the first letter after a slash is not capitalized.
+        string = term.to_s.split('/').map { |str| str.camelize :lower }.join('/')
+
+        # Reverses the effect of ActiveSupport::Inflector.camelize converting slashes into `::`.
+        string.gsub '::', '/'
+      end.to_json
+    end
+
+    def loader_component
+      render Loader::Component.new(loader, @html_class, data_attributes, tag: @html_tag)
+    end
+  end
+end

data/lib/proscenium/resolver.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+require 'active_support/current_attributes'
+
+module Proscenium
+  class Resolver < ActiveSupport::CurrentAttributes
+    # TODO: cache this across requests in production.
+    attribute :resolved
+
+    # Resolve the given `path` to a URL path.
+    #
+    # @param path [String] Can be URL path, file system path, or bare specifier (ie. NPM package).
+    # @return [String] URL path.
+    #
+    # rubocop:disable Metrics/*
+    def self.resolve(path)
+      self.resolved ||= {}
+
+      self.resolved[path] ||= begin
+        if path.start_with?('./', '../')
+          raise ArgumentError, 'path must be an absolute file system or URL path'
+        end
+
+        if path.start_with?('@proscenium/')
+          "/#{path}"
+        elsif (engine = Proscenium.config.engines.find { |e| path.start_with? "#{e.root}/" })
+          path.sub(/^#{engine.root}/, "/#{engine.engine_name}")
+        elsif path.start_with?("#{Rails.root}/")
+          path.delete_prefix Rails.root.to_s
+        else
+          Builder.resolve path
+        end
+      end
+    end
+    # rubocop:enable Metrics/*
+  end
+end

data/lib/proscenium/side_load.rb

@@ -2,84 +2,24 @@
 
 module Proscenium
   class SideLoad
-    extend ActiveSupport::Autoload
-
-    NotIncludedError = Class.new(StandardError)
-
-    autoload :Monkey
-    autoload :Helper
-    autoload :EnsureLoaded
-
-    EXTENSIONS = %i[js css].freeze
-    EXTENSION_MAP = {
-      '.module.css' => :css,
-      '.css' => :css,
-      '.tsx' => :js,
-      '.ts' => :js,
-      '.jsx' => :js,
-      '.js' => :js
-    }.freeze
-
-    attr_reader :path
-
     class << self
-      # Side load the given asset `path`, by appending it to `Proscenium::Current.loaded`, which is
-      # a Set of 'js' and 'css' asset paths. This is idempotent, so side loading will never include
-      # duplicates.
+      # Side loads the class, and its super classes that respond to `.source_path`.
       #
-      # @return [Array] appended URL paths
-      def append(path, extension_map = EXTENSION_MAP)
-        new(path, extension_map).append
-      end
-
-      # Side load the given `path` at `type`, without first resolving the path. This still respects
-      # idempotency of `Proscenium::Current.loaded`.
+      # Assign the `abstract_class` class variable to any abstract class, and it will not be side
+      # loaded. Additionally, if the class responds to `#sideload?`, and it returns false, it will
+      # not be side loaded.
       #
-      # @param path [String]
-      # @param type [Symbol] :js or :css
-      def append!(path, type)
-        return if Proscenium::Current.loaded[type].include?(path)
-
-        Proscenium::Current.loaded[type] << log(path)
-      end
-
-      def log(value)
-        ActiveSupport::Notifications.instrument('sideload.proscenium', identifier: value)
-
-        value
-      end
-    end
-
-    # @param path [Pathname, String] The path of the file to be side loaded.
-    # @param extension_map [Hash] File extensions to side load.
-    def initialize(path, extension_map = EXTENSION_MAP)
-      @path = (path.is_a?(Pathname) ? path : Rails.root.join(path)).sub_ext('')
-      @extension_map = extension_map
-
-      Proscenium::Current.loaded ||= EXTENSIONS.index_with { |_e| Set.new }
-    end
-
-    def append
-      @extension_map.filter_map do |ext, type|
-        next unless (resolved_path = resolve_path(path.sub_ext(ext)))
-
-        # Make sure path is not already side loaded.
-        unless Proscenium::Current.loaded[type].include?(resolved_path)
-          Proscenium::Current.loaded[type] << log(resolved_path)
+      # If the class responds to `.sideload`, it will be called instead of the regular side loading.
+      # You can use this to customise what is side loaded.
+      def sideload_inheritance_chain(obj)
+        return if !Proscenium.config.side_load || (obj.respond_to?(:sideload?) && !obj.sideload?)
+
+        klass = obj.class
+        while klass.respond_to?(:source_path) && klass.source_path && !klass.abstract_class
+          klass.respond_to?(:sideload) ? klass.sideload : Importer.sideload(klass.source_path)
+          klass = klass.superclass
         end
-
-        resolved_path
       end
     end
-
-    private
-
-    def log(...)
-      self.class.log(...)
-    end
-
-    def resolve_path(path)
-      path.exist? ? Utils.resolve_path(path.to_s) : nil
-    end
   end
 end

data/lib/proscenium/source_path.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+# Include this into any class to expose a `source_path` class and instance method, which will return
+# the absolute file system path to the current object.
+module Proscenium::SourcePath
+  def self.included(base)
+    base.extend ClassMethods
+  end
+
+  module ClassMethods
+    def source_path
+      @source_path ||= name.nil? ? nil : Pathname.new(const_source_location(name).first)
+    end
+  end
+end

data/lib/proscenium/templates/rescues/build_error.html.erb

@@ -0,0 +1,30 @@
+<header>
+  <h1>
+    <%= Rails.gem_version >= Gem::Version.new('7.1.0') ? @exception_wrapper.exception_class_name : @exception.class.to_s %>
+    <% if params_valid? && @request.parameters['controller'] %>
+      in <%= @request.parameters['controller'].camelize %>Controller<% if @request.parameters['action'] %>#<%= @request.parameters['action'] %><% end %>
+    <% end %>
+  </h1>
+</header>
+
+<main role="main" id="container">
+  <%= render "rescues/message_and_suggestions", exception: @exception, exception_wrapper: Rails.gem_version >= Gem::Version.new('7.1.0') ? @exception_wrapper : nil %>
+
+  <% if @exception.error['location'] %>
+    <div class="source">
+      <div class="data">
+<pre>
+
+    <%= @exception.error['location']['file'] %>:<%= @exception.error['location']['line'] %>:<%= @exception.error['location']['column'] %>
+
+<%= @exception.error['location']['line'].to_s.rjust 5 %> │    <%= @exception.error['location']['line_text'] %>
+      │    <%= (@exception.error['location']['length'] > 1 ? "~" * @exception.error['location']['length'] : "^").rjust(@exception.error['location']['column'] + @exception.error['location']['length']) %>
+<%- if @exception.error['location']['suggestion'].present? -%>    + │    <%= @exception.error['location']['suggestion'].rjust(@exception.error['location']['column'] + 1) %>
+<% else %> <%- end -%>
+</pre>
+      </div>
+    </div>
+  <% end %>
+
+  <%= render template: "rescues/_request_and_response" %>
+</main>

data/lib/proscenium/utils.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Proscenium
+  module Utils
+    module_function
+
+    # @param value [#to_s] The value to create the digest from. This will usually be a `Pathname`.
+    # @return [String] digest of the given value.
+    def digest(value)
+      Digest::SHA1.hexdigest(value.to_s)[..7]
+    end
+  end
+end

data/lib/proscenium/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Proscenium
-  VERSION = '0.10.0'
+  VERSION = '0.11.0'
 end

data/lib/proscenium/view_component/css_modules.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module Proscenium
+  module ViewComponent::CssModules
+    include Proscenium::CssModule
+
+    def self.included(base)
+      base.extend CssModule::Path
+    end
+  end
+end