propshaft 0.1.1 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b03a78a54847aa4fb74c996259230818db5262c8c246367f4826dd222f763d62
-  data.tar.gz: c393121a10fcb3cd1b151077869673260afdf99d4a7294dd88b8f600e3debe55
+  metadata.gz: e0c1e97b63b0b9fe76fa0a65a143ff7c705287fb342d1c414aedbb5cd4388b1c
+  data.tar.gz: 30c367753aa1ff0bdedacea3a5ac07b9c21a04f6da4610eb1a0336444c0a305b
 SHA512:
-  metadata.gz: f2807deda69e1f1ddb336985b69c4f2f617398450402ca60de1917599f5e6a8ad5b483386ffcd85cd62f3729ff9fb16d7a2d487e39e15de160c29342d03d4ba1
-  data.tar.gz: d16949bc2e7b81634d310413ea0f29065dfbe9eb4e421fb2321b9709ef460c82eaf93b2ab73d07de23dbd8111730d7755a1995081d8986d96ed28916940b8e94
+  metadata.gz: 9150cdb2117a008edb02f77426479bc7deeb2ce8bf6d4ba0541716862d2c49c17c3765e138dced1495b12bd25deb1f4f68e45fda78311d4acb9a720ba3ffaac4
+  data.tar.gz: af02249eceeefd87057bf69aca1780c04f74b31b705b61e0b4696f7b3a9e7ed363759612f85e1d5e0fe53a02659ff77e9769c3b375b16cfd9fa7b3ae93cdb4cb

data/README.md

@@ -1,8 +1,8 @@
 # Propshaft
 
-Propshaft is an asset pipeline library for Rails. It's built for era where bundling assets to save on HTTP connections is no longer urgent, where JavaScript and CSS is either compiled by dedicated Node.js bundlers or served directly to the browsers, and where increases in bandwidth has made the need for minification less pressing. These factors allow for a dramatically simpler and faster asset pipeline compared to previous options, like Sprockets.
+Propshaft is an asset pipeline library for Rails. It's built for an era where bundling assets to save on HTTP connections is no longer urgent, where JavaScript and CSS are either compiled by dedicated Node.js bundlers or served directly to the browsers, and where increases in bandwidth have made the need for minification less pressing. These factors allow for a dramatically simpler and faster asset pipeline compared to previous options, like Sprockets.
 
-So that's what Propshaft doesn't do. Here's what it actually does provide:
+So that's what Propshaft doesn't do. Here's what it does provide:
 
 1. **Configurable load path**: You can register directories from multiple places in your app and gems, and reference assets from all of these paths as though they were one.
 1. **Digest stamping**: All assets in the load path will be copied (or compiled) in a precompilation step for production that also stamps all of them with a digest hash, so you can use long-expiry cache headers for better performance. The digested assets can be referred to through their logical path because the processing leaves a manifest file that provides a way to translate.
@@ -17,16 +17,16 @@ With Rails 7+, you can start a new application with propshaft using `rails new m
 
 ## Usage
 
-Propshaft makes all the assets from all the paths its been configured with through `config.assets.paths` available for serving and will copy all of them into `public/assets` when precompiling. This is unlike Sprockets, which did not copy over assets that hadn't been explicitly included in one of bundled assets.
+Propshaft makes all the assets from all the paths it's been configured with through `config.assets.paths` available for serving and will copy all of them into `public/assets` when precompiling. This is unlike Sprockets, which did not copy over assets that hadn't been explicitly included in one of the bundled assets.
 
-These assets can be referenced through their logical path using the normal helpers like `asset_path`, `image_tag`, `javascript_include_tag`, and all the other asset helper tags. These logical references are automatically converted into digest-aware paths in production when `assets:precompile` has been run (through a json mapping file found in `public/assets/.manifest.json`).
+These assets can be referenced through their logical path using the normal helpers like `asset_path`, `image_tag`, `javascript_include_tag`, and all the other asset helper tags. These logical references are automatically converted into digest-aware paths in production when `assets:precompile` has been run (through a JSON mapping file found in `public/assets/.manifest.json`).
 
 Additionally, Propshaft ships with a CSS function called `asset-path("image.svg")` that'll be compiled into `url("/assets/image-f2e1ec14d6856e1958083094170ca6119c529a73.svg")` when doing `assets:precompile`. This function is applied to all `.css` files.
 
 
 ## Migrating from Sprockets
 
-Propshaft does a lot less than Sprockets, by design, so it might well be a fair bit of work to migrate, if it's even desirable. This is particularly true if you rely on Sprockets to provide any form of transpiling, like CoffeeScript or Sass, or if you rely on any gems that do. You'll need to either stop transpiling or use a Node-based transpiler, like those in `jsbundling-rails` and `cssbundling-rails`.
+Propshaft does a lot less than Sprockets, by design, so it might well be a fair bit of work to migrate if it's even desirable. This is particularly true if you rely on Sprockets to provide any form of transpiling, like CoffeeScript or Sass, or if you rely on any gems that do. You'll need to either stop transpiling or use a Node-based transpiler, like those in `jsbundling-rails` and `cssbundling-rails`.
 
 On the other hand, if you're already bundling JavaScript and CSS through a Node-based setup, then Propshaft is going to slot in easily. Since you don't need another tool to bundle or transpile. Just to digest and serve.
 

data/lib/propshaft/load_path.rb

@@ -11,8 +11,12 @@ class Propshaft::LoadPath
     assets_by_path[asset_name]
   end
 
-  def assets
-    assets_by_path.values
+  def assets(content_types: nil)
+    if content_types
+      assets_by_path.values.select { |asset| asset.content_type.in?(content_types) }
+    else
+      assets_by_path.values
+    end
   end
 
   def manifest

data/lib/propshaft/processor.rb

@@ -1,5 +1,6 @@
 class Propshaft::Processor
   MANIFEST_FILENAME = ".manifest.json"
+  COMPRESSABLE_CONTENT_TYPES = %i[ js css text json xml html svg otf ttf ].collect { |t| Mime[t] }
 
   attr_reader :load_path, :output_path, :compilers
 
@@ -41,10 +42,6 @@ class Propshaft::Processor
       compile_asset(asset) || copy_asset(asset)
     end
 
-    def copy_asset(asset)
-      FileUtils.copy asset.path, output_path.join(asset.digested_path)
-    end
-
     def compile_asset(asset)
       File.open(output_path.join(asset.digested_path), "w+") do |file|
         begin
@@ -56,10 +53,13 @@ class Propshaft::Processor
       end if compilers.compilable?(asset)
     end
 
+    def copy_asset(asset)
+      FileUtils.copy asset.path, output_path.join(asset.digested_path)
+    end
+
 
     def compress_assets
-      # FIXME: Only try to compress text assets with brotli
-      load_path.assets.each do |asset|
+      load_path.assets(content_types: COMPRESSABLE_CONTENT_TYPES).each do |asset|
         compress_asset output_path.join(asset.digested_path)
       end if compressor_available?
     end

data/lib/propshaft/railtie.rb

@@ -4,7 +4,7 @@ require "active_support/ordered_options"
 
 # FIXME: There's gotta be a better way than this hack?
 class Rails::Engine < Rails::Railtie
-  initializer :append_assets_path, group: :all do |app|
+  initializer "propshaft.append_assets_path", group: :all do |app|
     app.config.assets.paths.unshift(*paths["vendor/assets"].existent_directories)
     app.config.assets.paths.unshift(*paths["lib/assets"].existent_directories)
     app.config.assets.paths.unshift(*paths["app/assets"].existent_directories)

data/lib/propshaft/version.rb

@@ -1,3 +1,3 @@
 module Propshaft
-  VERSION = "0.1.1"
+  VERSION = "0.1.5"
 end

data/lib/propshaft.rb

@@ -1,3 +1,6 @@
+module Propshaft
+end
+
 require "propshaft/assembly"
 require "propshaft/helper"
 require "propshaft/railtie"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: propshaft
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.5
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-21 00:00:00.000000000 Z
+date: 2021-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails