propono 1.1.1 → 1.1.2

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ZGQ0ZmZhODMxNGNmOWFjMTBmY2VjYjU4MmFhNzg5MWY4ZTVlYTAxMg==
-  data.tar.gz: !binary |-
-    MDE3Y2I1ZmVkYjMxNzJlZTgwYmEwZWI2YmIzZWFkZWNkYWJiNDZmMA==
+SHA1:
+  metadata.gz: 1917ef51173b438968c6c9a9453d710a48158312
+  data.tar.gz: fe799f2582f1b5180e21d0567e0d9657f3322a02
 SHA512:
-  metadata.gz: !binary |-
-    ZTk2YjgxYmYzOGVhYmY1YWMxYzM3NzI4OTYxNzFiNDQ3ZTUzNmY5MTU2NDEy
-    ZDdiMTFkODJiYWU2ODI3YTY4NzM1NWVhNTBiZGNmNWMyOTM0ZjYwODBlZTE2
-    ODRmOGUxYzMxYmIwNzRjMjAyYmViYjQxZGNhNTkxZWRkMjhlYTU=
-  data.tar.gz: !binary |-
-    MWIwMTk3NjEzODI0YWIxZTZkOGJkMTZiMzFmMjdmODg4NWMxOTg2ZTM3MTk0
-    NmI4ZWYwM2M0ODNjY2E5NDE3NGJjY2I1YTlmZjVhNWNiYjlmNmNhNzQzM2Uz
-    YzZlMmQ1NjFiZmI4MTE0Zjk5YjAzZjY2MzhmYmQ2NGI4ODc3ZmE=
+  metadata.gz: 526f52cb4a183d3a1dbed6048e12899abcd20eace75f017a80ea26d2753c5f1d061b222bf57b0a0c631ad81d6b78229c6b812e9fb652f3b390bedf34330631d2
+  data.tar.gz: f8060edb37e58dddd21b23778a111229dc5f84c3ccea43f286c93aaf32c475a0f426b28582ef5098cf6732845fa2f18aad2334772963871a28933b7fb87f494a

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 1.1.2 / 2014-03-31
+* [BUGFIX] Move topic lookup into publishing thread.
+
 # 1.1.1 / 2014-02-22
 * [BUGFIX] Logger.error only takes (0..1) arguments.
 

data/lib/propono/services/publisher.rb

@@ -34,12 +34,19 @@ module Propono
     private
 
     def publish_via_sns
-      topic = TopicCreator.find_or_create(topic_id)
       Thread.new do
+        begin
+          topic = TopicCreator.find_or_create(topic_id)
+        rescue => e
+          Propono.config.logger.error "Propono [#{id}]: Failed to create topic #{topic_id}: #{e}"
+          raise
+        end
+
         begin
           sns.publish(topic.arn, body.to_json)
         rescue => e
-          Propono.config.logger.error "Propono [#{id}]: Failed to send via sns : #{e}"
+          Propono.config.logger.error "Propono [#{id}]: Failed to send via sns: #{e}"
+          raise
         end
       end
     end

data/lib/propono/version.rb

@@ -1,3 +1,3 @@
 module Propono
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/test/services/publisher_test.rb

@@ -112,7 +112,8 @@ module Propono
 
       assert_raises(TopicCreatorError) do
         publisher = Publisher.new("topic", "message")
-        publisher.send(:publish_via_sns)
+        thread = publisher.send(:publish_via_sns)
+        thread.join
       end
     end
 
@@ -126,8 +127,10 @@ module Propono
       sns = mock()
       sns.stubs(:publish)
       publisher = Publisher.new(topic_id, "Foobar")
+      publisher.stubs(sns: sns)
 
-      publisher.send(:publish_via_sns)
+      thread = publisher.send(:publish_via_sns)
+      thread.join
     end
 
     def test_udp_uses_correct_message_host_and_port

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: propono
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - MalcyL
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-24 00:00:00.000000000 Z
+date: 2014-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog
@@ -43,42 +43,42 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -169,12 +169,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []