property_sets 2.3.0 → 2.4.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: e4e1f51f9567dd18fa291875731e3a41c9772461
+  data.tar.gz: e97629c249e9dd6632892f377b55d551587e1dbb
+SHA512:
+  metadata.gz: 754e8fe910199e3e80a80bfd138c69b2c1dcc81b744095fd1f091442df5ee186bda98c3c57f8de8a485172e2bc2d8a338509af34662e775f8d4fe8cd6710b5bc
+  data.tar.gz: eb122494452754f9f09b1826fbf653c7eafa730232cda1db6a3462db828d0a0830277396ad38d61e50e5233c37b05f18b6aa5e272f011b38c2b5f0d7bf1b3eee

data/.travis.yml

@@ -2,17 +2,17 @@ rvm:
   - ree
   - 1.9.3
   - 2.0.0
+  - 2.1.0
   - jruby
 script: "bundle exec rake test"
 gemfile:
   - gemfiles/rails2.3.gemfile
-  - gemfiles/rails3.0.gemfile
   - gemfiles/rails3.2.gemfile
 matrix:
   exclude:
     - rvm: 2.0.0
       gemfile: gemfiles/rails2.3.gemfile
-    - rvm: 2.0.0
-      gemfile: gemfiles/rails3.0.gemfile
+    - rvm: 2.1.0
+      gemfile: gemfiles/rails2.3.gemfile
     - rvm: ree
       gemfile: gemfiles/rails3.2.gemfile

data/Appraisals

@@ -8,14 +8,6 @@ appraise "rails2.3" do
   gem "test-unit", "< 2.5.5"
 end
 
-appraise "rails3.0" do
-  gem "activerecord", "~> 3.0.15"
-  gem "activesupport", "~> 3.0.15"
-  gem "shoulda", "~> 2.11"
-  gem "mysql2", "~> 0.2.0", :platforms => :ruby
-  gem "activerecord-mysql2-adapter", :platforms => :ruby
-end
-
 appraise "rails3.2" do
   gem "activerecord", "~> 3.2.6"
   gem "activesupport", "~> 3.2.6"

data/Gemfile

@@ -3,6 +3,7 @@ source 'https://rubygems.org'
 gem 'activerecord-jdbcmysql-adapter', '1.2.2', :platforms => :jruby
 gem 'mysql2', :platforms => :ruby
 
+gem 'bump'
 gem 'rake'
 gem 'bundler'
 gem 'shoulda'

data/Rakefile

@@ -1,5 +1,7 @@
+require 'bundler/setup'
 require 'bundler/gem_tasks'
 require 'appraisal'
+require 'bump/tasks'
 
 require 'rake/testtask'
 Rake::TestTask.new do |test|

data/lib/property_sets/delegator.rb

@@ -0,0 +1,45 @@
+module PropertySets
+  module Delegator
+    # methods for moving what was once a literal column on
+    # to a property_set table.
+    #
+    # delegates read, write and query methods to the property record or the property default
+    #
+    # Examples
+    #
+    #   # Migrate :is_open to the :settings property set, and rename it :open,
+    #   # and migrate :same to property set :same
+    #   include PropertySets::Delegator
+    #   delegate_to_property_set :settings, :is_open => :open, :same => :same
+    #
+    def self.included(base)
+      base.extend(ClassMethods)
+    end
+
+    module ClassMethods
+      def delegate_to_property_set(setname, mappings)
+        raise "Second argument must be a Hash" unless mappings.is_a?(Hash)
+
+        mappings.each do |old_attr, new_attr|
+          define_method(old_attr) { send(setname).send(new_attr) }
+          alias_method "#{old_attr}_before_type_cast", old_attr
+          define_method("#{old_attr}?") { send(setname).send("#{new_attr}?") }
+          define_method("#{old_attr}=") { |value| send(setname).send("#{new_attr}=", value) }
+
+          define_method("#{old_attr}_changed?") do
+            assoc = send(setname)
+            setting = assoc.lookup_without_default(new_attr)
+
+            if !setting
+              false # Nothing has been set which means that the attribute hasn't changed
+            elsif setting.new_record?
+              assoc.default(new_attr) != setting.value
+            else
+              setting.value_changed?
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/property_sets/version.rb

@@ -1,3 +1,3 @@
 module PropertySets
-  VERSION = "2.3.0"
+  VERSION = "2.4.0"
 end

data/test/helper.rb

@@ -5,7 +5,7 @@ Bundler.setup
 require 'test/unit'
 
 begin
-  require 'mocha/setup'
+  require 'mocha/setup' # Rails 2
 rescue LoadError
   require 'mocha'
 end
@@ -24,10 +24,13 @@ if ActiveRecord::VERSION::MAJOR > 2 && ActiveRecord::VERSION::MAJOR < 4
   ActiveRecord::Base.attr_accessible
 end
 
+I18n.enforce_available_locales = false if ActiveRecord::VERSION::MAJOR > 2
+
 require File.expand_path "../database", __FILE__
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'property_sets'
+require 'property_sets/delegator'
 
 class ActiveSupport::TestCase
   include ActiveRecord::TestFixtures
@@ -54,6 +57,9 @@ class ActsLikeAnInteger
 end
 
 class Account < ActiveRecord::Base
+  include PropertySets::Delegator
+  delegate_to_property_set :settings, :old => :hep
+
   if ActiveRecord::VERSION::MAJOR < 4
     attr_accessible :name
     attr_accessible :texts_attributes

data/test/test_delegator.rb

@@ -0,0 +1,78 @@
+require File.expand_path(File.dirname(__FILE__) + '/helper')
+
+class TestDelegator < ActiveSupport::TestCase
+  context PropertySets::Delegator do
+    fixtures :accounts, :account_settings, :account_texts
+
+    setup do
+      @account = Account.create(:name => "Name")
+      @default = 'skep'
+    end
+
+    context "read" do
+      should "not add a property" do
+        @account.old
+        assert_equal 0, @account.settings.size
+      end
+
+      should "delegate read to default" do
+        assert_equal @default, @account.old
+      end
+
+      should "delegate read to property value" do
+        @account.settings.hep = 'new'
+        assert_equal 'new', @account.old
+      end
+    end
+
+    context "write" do
+      should "add a property" do
+        @account.old = 'new'
+        assert_equal 1, @account.settings.size
+      end
+
+      should "delegate write" do
+        @account.old = 'new'
+        assert_equal 'new', @account.settings.hep
+        assert_equal 'new', @account.old
+      end
+    end
+
+    context "changed?" do
+      should "not add a property" do
+        @account.old_changed?
+        assert_equal 0, @account.settings.size
+      end
+
+      should "not be changed" do
+        assert_equal false, @account.old_changed?
+      end
+
+      should "be changed with new value" do
+        @account.old = "new"
+        assert_equal true, @account.old_changed?
+      end
+
+      should "not be changed with default value" do
+        @account.old = @default
+        assert_equal false, @account.old_changed?
+      end
+    end
+
+    context "before_type_case" do
+      should "not add a property" do
+        @account.old_before_type_cast
+        assert_equal 0, @account.settings.size
+      end
+
+      should "return default" do
+        assert_equal @default, @account.old_before_type_cast
+      end
+
+      should "return setting" do
+        @account.old = "new"
+        assert_equal "new", @account.old_before_type_cast
+      end
+    end
+  end
+end

metadata

@@ -1,22 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: property_sets
 version: !ruby/object:Gem::Version
-  version: 2.3.0
-  prerelease: 
+  version: 2.4.0
 platform: ruby
 authors:
 - Morten Primdahl
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-02 00:00:00.000000000 Z
+date: 2014-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.3.14
     - - <
@@ -25,9 +23,8 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.3.14
     - - <
@@ -36,9 +33,8 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.3.14
     - - <
@@ -47,9 +43,8 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.3.14
     - - <
@@ -58,17 +53,15 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: This gem is an ActiveRecord extension which provides a convenient interface
@@ -88,12 +81,12 @@ files:
 - Rakefile
 - benchmark/read.rb
 - gemfiles/rails2.3.gemfile
-- gemfiles/rails3.0.gemfile
 - gemfiles/rails3.2.gemfile
 - lib/property_sets.rb
 - lib/property_sets/action_view_extension.rb
 - lib/property_sets/active_record_extension.rb
 - lib/property_sets/casting.rb
+- lib/property_sets/delegator.rb
 - lib/property_sets/property_set_model.rb
 - lib/property_sets/version.rb
 - property_sets.gemspec
@@ -103,32 +96,31 @@ files:
 - test/fixtures/accounts.yml
 - test/helper.rb
 - test/test_casting.rb
+- test/test_delegator.rb
 - test/test_property_sets.rb
 - test/test_view_extensions.rb
 homepage: http://github.com/zendesk/property_sets
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.14
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Property sets for ActiveRecord.
 test_files: []
-has_rdoc: 

data/gemfiles/rails3.0.gemfile

@@ -1,19 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activerecord-jdbcmysql-adapter", "1.2.2", :platforms=>:jruby
-gem "rake"
-gem "bundler"
-gem "mocha"
-gem "appraisal"
-gem "test-unit", ">= 2.5.2"
-gem "actionpack", ">= 2.3.14", "< 3.3"
-gem "iconv", :platforms=>:ruby_20
-gem "activerecord", "~> 3.0.15"
-gem "activesupport", "~> 3.0.15"
-gem "shoulda", "~> 2.11"
-gem "mysql2", "~> 0.2.0", :platforms=>:ruby
-gem "activerecord-mysql2-adapter", :platforms=>:ruby
-
-gemspec :path=>"../"