property_sets 0.3.6 → 0.4.0

data/VERSION

@@ -1 +1 @@
-0.3.6
+0.4.0

data/lib/property_sets/active_record_extension.rb

@@ -63,8 +63,8 @@ module PropertySets
 
             # The finder method which returns the property if present, otherwise a new instance with defaults
             define_method "lookup" do |arg|
-              instance   = detect { |property| property.name.to_sym == arg }
-              instance ||= property_class.new(@owner.class.name.underscore.to_sym => @owner, :name => arg.to_s, :value => property_class.default(arg))
+              instance   = detect { |property| property.name.to_sym == arg.to_sym }
+              instance ||= @owner.send(association).build(:name => arg.to_s, :value => property_class.default(arg))
             end
           end
         end

data/property_sets.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{property_sets}
-  s.version = "0.3.6"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Morten Primdahl"]
-  s.date = %q{2011-03-04}
+  s.date = %q{2011-03-07}
   s.description = %q{This gem is an ActiveRecord extension which provides a convenient interface for managing per row properties}
   s.email = %q{morten@zendesk.com}
   s.extra_rdoc_files = [

data/test/test_property_sets.rb

@@ -29,6 +29,11 @@ class TestPropertySets < ActiveSupport::TestCase
       assert !@account.settings.hep?
       @account.settings.enable(:hep)
       assert @account.settings.hep?
+
+      account = Account.new
+      assert !account.settings.foo?
+      account.settings.enable(:foo)
+      assert account.settings.foo?
     end
 
     should "be empty on a new account" do
@@ -104,6 +109,12 @@ class TestPropertySets < ActiveSupport::TestCase
         assert @account.settings.bar?
       end
 
+      should "convert string keys to symbols to ensure consistent lookup" do
+        @account.settings.set(:foo => "123")
+        @account.settings.set("foo" => "456")
+        assert @account.save!
+      end
+
       should "work identically for new and existing owner objects" do
         [ @account, Account.new(:name => "Mibble") ].each do |account|
           account.settings.set(:foo => "123", :bar => "456")

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: property_sets
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 15
   prerelease: false
   segments: 
   - 0
-  - 3
-  - 6
-  version: 0.3.6
+  - 4
+  - 0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Morten Primdahl
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-04 00:00:00 -08:00
+date: 2011-03-07 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency