proper_active_record_uniqueness_validations 0.1.1

data/test/db/migrate/20130608160945_create_widgets.rb

@@ -0,0 +1,11 @@
+class CreateWidgets < ActiveRecord::Migration
+  def change
+    create_table :widgets do |t|
+      t.integer :some_id
+      t.string :name
+      t.string :description
+
+      t.timestamps
+    end
+  end
+end

data/test/db/schema.rb

@@ -0,0 +1,37 @@
+# encoding: UTF-8
+# This file is auto-generated from the current state of the database. Instead
+# of editing this file, please use the migrations feature of Active Record to
+# incrementally modify your database, and then regenerate this schema definition.
+#
+# Note that this schema.rb definition is the authoritative source for your
+# database schema. If you need to create the application database on another
+# system, you should be using db:schema:load, not running all the migrations
+# from scratch. The latter is a flawed and unsustainable approach (the more migrations
+# you'll amass, the slower it'll run and the greater likelihood for issues).
+#
+# It's strongly recommended to check this file into your version control system.
+
+ActiveRecord::Schema.define(:version => 20130608160945) do
+
+  create_table "things", :force => true do |t|
+    t.integer  "some_id"
+    t.text     "name"
+    t.text     "description"
+    t.text     "unregistered"
+    t.datetime "created_at",   :null => false
+    t.datetime "updated_at",   :null => false
+  end
+
+  add_index "things", ["name", "description"], :name => "index_things_on_name_and_description", :unique => true
+  add_index "things", ["some_id"], :name => "index_things_on_some_id", :unique => true
+  add_index "things", ["unregistered"], :name => "index_things_on_unregistered", :unique => true
+
+  create_table "widgets", :force => true do |t|
+    t.integer  "some_id"
+    t.string   "name"
+    t.string   "description"
+    t.datetime "created_at",  :null => false
+    t.datetime "updated_at",  :null => false
+  end
+
+end

data/test/db/seeds.rb

@@ -0,0 +1,7 @@
+# This file should contain all the record creation needed to seed the database with its default values.
+# The data can then be loaded with the rake db:seed (or created alongside the db with db:setup).
+#
+# Examples:
+#
+#   cities = City.create([{ :name => 'Chicago' }, { :name => 'Copenhagen' }])
+#   Mayor.create(:name => 'Emanuel', :city => cities.first)

data/test/script/rails

@@ -0,0 +1,6 @@
+#!/usr/bin/env ruby
+# This command will automatically be run when you run "rails" with Rails 3 gems installed from the root of your application.
+
+APP_PATH = File.expand_path('../../config/application',  __FILE__)
+require File.expand_path('../../config/boot',  __FILE__)
+require 'rails/commands'

data/test/spec/models/thing_spec.rb

@@ -0,0 +1,250 @@
+require 'spec_helper'
+
+describe Thing do
+  let( :a_valid_thing ) do
+    Thing.new( :some_id     => 1,
+               :name        => "foo",
+               :description => "bar",
+               :unregistered => "fubar" )
+  end
+
+  let( :another_thing ) do
+    Thing.new( :some_id     => 10,
+               :name        => "foo_2000",
+               :description => "binford_9000",
+               :unregistered => "snafu" )
+  end
+
+  let( :a_widget_with_a_uniqueness_violation ) do
+    Widget.create( :some_id => 1, :name => "foo", :description => "bar" )
+    w = Widget.new( :some_id => 1, :name => "baz", :description => "quux"  )
+    w.save
+    w
+  end
+
+  let( :a_widget_with_a_multi_column_uniqueness_violation ) do
+    Widget.create( :some_id => 1, :name => "foo", :description => "bar" )
+    w = Widget.new( :some_id => 2, :name => "foo", :description => "bar"  )
+    w.save
+    w
+  end
+
+  describe "creating with #save" do
+    context "without violating a uniqueness constraint" do
+      subject { a_valid_thing }
+
+      it "should not raise an exception" do
+        expect { subject.save }.to_not raise_error
+      end
+
+      it "should return true" do
+        subject.save.should be_true
+      end
+
+      it "should have stored the value in the database" do
+        expect { subject.save }.to change { Thing.count }.by(1)
+      end
+
+      it "should not have inserted anything to the errors" do
+        subject.save
+        subject.errors.should be_empty
+      end
+    end
+
+    context "when violating an unregistered index" do
+      subject do
+        another_thing.unregistered = a_valid_thing.unregistered
+        another_thing
+      end
+
+      before( :each ) do
+        a_valid_thing.save
+      end
+
+      it "should raise an exception" do
+        expect { subject.save }.to raise_error( ActiveRecord::RecordNotUnique )
+      end
+
+      it "should not have stored the value in the database" do
+        expect do
+          subject.save rescue nil
+        end.to_not change { Thing.count }
+      end
+    end
+
+    context "when violating a single column uniqueness constraint" do
+      subject do
+        another_thing.some_id = a_valid_thing.some_id
+        another_thing
+      end
+
+      before( :each ) do
+        a_valid_thing.save
+      end
+
+      it "should not raise an exception" do
+        expect { subject.save }.to_not raise_error
+      end
+
+      it "should return false" do
+        subject.save.should be_false
+      end
+
+      it "should not have stored the value in the database" do
+        expect { subject.save }.to_not change { Thing.count }
+      end
+
+      it "should have added an errors entry for the attribute" do
+        subject.save
+        subject.errors.messages.should eq( a_widget_with_a_uniqueness_violation.errors.messages )
+      end
+    end
+
+    context "when violating a multi-column uniqueness constraint" do
+      subject do
+        another_thing.name = a_valid_thing.name
+        another_thing.description = a_valid_thing.description
+        another_thing
+      end
+
+      before( :each ) do
+        a_valid_thing.save
+      end
+
+      it "should not raise an exception" do
+        expect { subject.save }.to_not raise_error
+      end
+
+      it "should return false" do
+        subject.save.should be_false
+      end
+
+      it "should not have stored the value in the database" do
+        expect { subject.save }.to_not change { Thing.count }
+      end
+
+      it "should have added an errors entry for the scoped attributes" do
+        subject.save
+        subject.errors.messages.should eq( a_widget_with_a_multi_column_uniqueness_violation.errors.messages )
+      end
+    end
+  end
+
+  describe "updating with #save" do
+    context "without violating a uniqueness constraint" do
+      subject { a_valid_thing }
+
+      before( :each ) do
+        subject.save 
+        subject.some_id = 3
+      end
+
+      it "should not raise an exception" do
+        expect { subject.save }.to_not raise_error
+      end
+
+      it "should return true" do
+        subject.save.should be_true
+      end
+
+      it "should have stored the value in the database" do
+        expect do
+          subject.save 
+          subject.reload
+        end.to change { subject.updated_at }
+      end
+
+      it "should not have inserted anything to the errors" do
+        subject.save
+        subject.errors.should be_empty
+      end
+    end
+
+    context "when violating an unregistered index" do
+      subject { another_thing }
+
+      before( :each ) do
+        a_valid_thing.save
+        subject.save
+        subject.reload # grab new updated_at
+        subject.unregistered = a_valid_thing.unregistered
+      end
+
+      it "should raise an exception" do
+        expect { subject.save }.to raise_error( ActiveRecord::RecordNotUnique )
+      end
+
+      it "should not have stored the value in the database" do
+        expect do
+          subject.save rescue nil
+          subject.reload
+        end.to_not change { subject.updated_at }
+      end
+    end
+
+    context "when violating a single column uniqueness constraint" do
+      subject { another_thing }
+
+      before( :each ) do
+        a_valid_thing.save
+        subject.save
+        subject.reload # grab new updated_at
+        subject.some_id = a_valid_thing.some_id
+      end
+
+      it "should not raise an exception" do
+        expect { subject.save }.to_not raise_error
+      end
+
+      it "should return false" do
+        subject.save.should be_false
+      end
+
+      it "should not have stored the value in the database" do
+        expect do
+          subject.save
+          subject.reload
+        end.to_not change { subject.updated_at }
+      end
+
+      it "should have added an errors entry for the attribute" do
+        subject.save
+        subject.errors.messages.should eq( a_widget_with_a_uniqueness_violation.errors.messages )
+      end
+    end
+
+    context "when violating a multi-column uniqueness constraint" do
+      subject { another_thing }
+
+      before( :each ) do
+        a_valid_thing.save
+        subject.save
+        subject.reload # grab new updated_at
+        subject.name = a_valid_thing.name
+        subject.description = a_valid_thing.description
+      end
+
+      it "should not raise an exception" do
+        expect { subject.save }.to_not raise_error
+      end
+
+      it "should return false" do
+        subject.save.should be_false
+      end
+
+      it "should not have stored the value in the database" do
+        expect do
+          subject.save
+          subject.reload
+        end.to_not change { subject.updated_at }
+      end
+
+      it "should have added an errors entry for the scoped attributes" do
+        subject.save
+        subject.errors.messages.should eq( a_widget_with_a_multi_column_uniqueness_violation.errors.messages )
+      end
+    end
+
+  end
+
+end

data/test/spec/models/widget_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Widget do
+  describe "the validations" do
+    it "should validate the uniqueness of some_id" do
+      Widget.create( :some_id => 1, :name => "foo", :description => "bar" )
+
+      another_widget = Widget.new( :some_id => 1, :name => "baz", :description => "quux" )
+      another_widget.should_not be_valid
+      another_widget.should have(1).error_on( :some_id )
+    end
+
+    it "should validate the uniqueness of the (name, description) tuple" do
+      Widget.create( :some_id => 1, :name => "foo", :description => "bar" )
+      another_widget = Widget.new( :some_id => 2, :name => "foo", :description => "bar" )
+      another_widget.should_not be_valid
+      another_widget.should have(1).error_on( :name )
+    end
+  end
+end

data/test/spec/spec_helper.rb

@@ -0,0 +1,46 @@
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+ENV["RAILS_ENV"] ||= 'test'
+require File.expand_path("../../config/environment", __FILE__)
+require 'rspec/rails'
+require 'database_cleaner'
+
+DatabaseCleaner.strategy = :deletion
+
+require 'rspec/autorun'
+
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[Rails.root.join("spec/support/**/*.rb")].each {|f| require f}
+
+RSpec.configure do |config|
+  # ## Mock Framework
+  #
+  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
+  #
+  # config.mock_with :mocha
+  # config.mock_with :flexmock
+  # config.mock_with :rr
+
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = false
+
+  # If true, the base class of anonymous controllers will be inferred
+  # automatically. This will be the default behavior in future versions of
+  # rspec-rails.
+  config.infer_base_class_for_anonymous_controllers = false
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = "random"
+
+  config.after( :each ) do
+    DatabaseCleaner.clean
+  end
+end

metadata

@@ -0,0 +1,110 @@
+--- !ruby/object:Gem::Specification
+name: proper_active_record_uniqueness_validations
+version: !ruby/object:Gem::Version
+  version: 0.1.1
+platform: ruby
+authors:
+- Sven Riedel
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2013-06-08 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.2.13
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.2.13
+- !ruby/object:Gem::Dependency
+  name: pg
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.14.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.14.1
+description: ActiveRecord uniqueness validations without raceconditions
+email: sr@gimp.org
+executables: []
+extensions: []
+extra_rdoc_files:
+- README.rdoc
+files:
+- .gitignore
+- README.rdoc
+- lib/proper_uniqueness_validation.rb
+- proper_active_record_uniqueness_validations.gemspec
+- test/Gemfile
+- test/Gemfile.lock
+- test/README.rdoc
+- test/Rakefile
+- test/app/models/.gitkeep
+- test/app/models/thing.rb
+- test/app/models/widget.rb
+- test/config.ru
+- test/config/application.rb
+- test/config/boot.rb
+- test/config/database.yml
+- test/config/environment.rb
+- test/config/environments/development.rb
+- test/config/environments/production.rb
+- test/config/environments/test.rb
+- test/config/initializers/backtrace_silencers.rb
+- test/config/initializers/inflections.rb
+- test/config/initializers/mime_types.rb
+- test/config/initializers/secret_token.rb
+- test/config/initializers/session_store.rb
+- test/config/initializers/wrap_parameters.rb
+- test/config/locales/en.yml
+- test/config/routes.rb
+- test/db/migrate/20130608153311_create_things.rb
+- test/db/migrate/20130608160945_create_widgets.rb
+- test/db/schema.rb
+- test/db/seeds.rb
+- test/log/.gitkeep
+- test/script/rails
+- test/spec/models/thing_spec.rb
+- test/spec/models/widget_spec.rb
+- test/spec/spec_helper.rb
+homepage: http://github.com/sriedel/proper_active_record_uniqueness_validations
+licenses: []
+metadata: {}
+post_install_message: 
+rdoc_options:
+- --charset=UTF-8
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: 1.9.3
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.0.0
+signing_key: 
+specification_version: 4
+summary: Uses unique indexes on the database level to see and deal with uniqueness
+  constraint violations. No raceconditions and less database calls required to save
+  or update a record.
+test_files: []