propel_api 0.3.1.3 → 0.3.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0bce938f1d94ec21c630795fd3732dc295d3555cb9b3907d9db74cfeac8ee59b
-  data.tar.gz: 15e9bec7ffc083869da29a883af7e5e9bdccbcf1e17c96a8ab8288f4dc7d37e6
+  metadata.gz: 57d463a766fd115825dccf217caabd982bf849c9aac5a9dfafc7ef11b2a75c04
+  data.tar.gz: 171026f0732372a319fb79946d3c7991293542a7b080bda4559b28427017b741
 SHA512:
-  metadata.gz: f76dd64b8ab5f5e6ec831f0e920e6b3d19502694a3c51ef8d01ef82524692c869c37bce68df5b813d5ebb64d24c5eb37cddca62608ae7edcd8ecbac06c247b21
-  data.tar.gz: c6a464ff6524bdcd2943dfbde5ee6f4624f9acac724ef9f508a22e66f4225d1b216259953a76e12f5a326b57f996873f8ba98225bfd85f182b23e36c108b9349
+  metadata.gz: 0576b9c86f00a1dde3691dfafc7049d6ffcc58c0717c98cab5739b3bee7c354046f711f3eaf061caa11f6c43c29f43008e988c55d706e84dfaa57e8ca0266de4
+  data.tar.gz: fd24e624bd103eb1bdd96c4e85701198b77964716ebf35d267b1d08f75ee7fc8f6016b85c5374eedc111bb7371af8210779874050db707c906290129fdc1d828

data/CHANGELOG.md

@@ -10,6 +10,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Planned Features
 - GraphQL adapter support
 
+## [0.3.1.4] - 2025-09-11
+
+### 🐛 Critical Bug Fixes
+- **Polymorphic Parents Parsing Regression**: Fixed `NoMethodError: undefined method 'strip' for Array` 
+  - Reverted to original, working `parse_polymorphic_parent_types` implementation
+  - Fixed overcomplicated parsing logic that incorrectly assumed Thor gives Arrays
+  - Thor consistently provides comma-separated String values that need simple `.split(',')` handling
+  - Resolves crash when using `--parents` option with polymorphic generators
+
+### 📖 Documentation Improvements
+- **--parents Flag Usage Guide**: Added comprehensive documentation for correct --parents syntax
+  - Fixed misleading error messages that suggested unsupported syntax
+  - Added clear examples of correct vs incorrect --parents usage
+  - Enhanced README with detailed usage guide and common pitfalls
+  - Updated all generator descriptions to show required field_name:Parent1,Parent2 syntax
+
 ## [0.3.1.3] - 2025-09-11
 
 ### 🐛 Bug Fixes
@@ -91,7 +107,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **Integration Test Templates**: Enhanced error handling and parameter validation in generated integration tests
 
 ### ⚠️ Breaking Changes
-- **REQUIRED --parents for Polymorphic**: Polymorphic associations now require explicit `--parents Parent1,Parent2` declaration. Auto-discovery fallback has been removed. Generator will block with confirmation if --parents is missing.
+- **REQUIRED --parents for Polymorphic**: Polymorphic associations now require explicit `--parents field_name:Parent1,Parent2` declaration. Auto-discovery fallback has been removed. Generator will block with confirmation if --parents is missing.
 
 ## [0.3.0] - 2025-01-15
 

data/README.md

@@ -55,10 +55,10 @@ rails generate propel_api:resource User name:string email:string role:string
 rails generate propel_api:resource Article title:string content:text user:references category:references
 
 # 🎉 NEW: Polymorphic associations (v0.3.0) - REQUIRES --parents flag
-rails generate propel_api:resource Comment content:text commentable:references{polymorphic} --parents Post,Video,Product
+rails generate propel_api:resource Comment content:text commentable:references{polymorphic} --parents commentable:Post,Video,Product
 
 # Polymorphic with tenancy
-rails generate propel_api:resource Review rating:integer comment:text review_parent:polymorphic --parents Product,Agency
+rails generate propel_api:resource Review rating:integer comment:text review_parent:polymorphic --parents review_parent:Product,Agency
 
 # With Graphiti adapter
 rails generate propel_api Product name:string price:decimal --adapter=graphiti
@@ -81,10 +81,10 @@ PropelApi now provides comprehensive support for polymorphic associations with a
 
 ```bash
 # Generate a Comment that can belong to Posts, Videos, or Products
-rails generate propel_api:resource Comment body:text commentable:references{polymorphic} --parents Post,Video,Product
+rails generate propel_api:resource Comment body:text commentable:references{polymorphic} --parents commentable:Post,Video,Product
 
-# Generate a Review with full tenancy support
-rails generate propel_api:resource Review rating:integer comment:text review_parent:references{polymorphic} --parents Product,Agency
+# Generate a Review with full tenancy support  
+rails generate propel_api:resource Review rating:integer comment:text review_parent:references{polymorphic} --parents review_parent:Product,Agency
 ```
 
 ### Key Features
@@ -94,7 +94,8 @@ rails generate propel_api:resource Review rating:integer comment:text review_par
 - No need for complex quote escaping or nested syntax
 
 #### 🎯 Required Parent Specification
-- `--parents Parent1,Parent2,Parent3` defines valid parent models (REQUIRED for polymorphic associations)
+- `--parents field_name:Parent1,Parent2,Parent3` defines valid parent models (REQUIRED for polymorphic associations)
+- Field name must match the polymorphic association name (e.g., `commentable`, `schedule_parent`)
 - Automatically generates varied test data using different parent types
 - Generator will block with confirmation if --parents is not provided
 
@@ -139,6 +140,58 @@ class Api::V1::CommentsController < Api::V1::ApiController
 end
 ```
 
+### --parents Flag Usage Guide
+
+⚠️ **IMPORTANT**: The `--parents` flag requires specific syntax to work correctly.
+
+#### ✅ **Correct Syntax:**
+```bash
+# Single polymorphic field
+--parents field_name:Parent1,Parent2,Parent3
+
+# Real examples:
+--parents commentable:Post,Photo,Video
+--parents schedule_parent:User,Room,MeetingLink
+--parents review_parent:Product,Agency
+
+# Multiple polymorphic fields  
+--parents commentable:Post,Photo schedule_parent:User,Room
+```
+
+#### ❌ **Incorrect Syntax (Will Fail):**
+```bash
+# Missing field name (Thor can't parse this)
+--parents Post,Photo,Video
+
+# Array brackets (not supported)
+--parents commentable:[Post,Photo,Video]
+
+# JSON-like syntax (not supported)  
+--parents "{commentable: [Post,Photo,Video]}"
+```
+
+#### 🔑 **Key Rules:**
+1. **Always include field name**: `field_name:Parent1,Parent2`
+2. **Field name must match polymorphic association**: If your field is `commentable:polymorphic`, use `--parents commentable:...`
+3. **Use commas to separate parent types**: `Post,Photo,Video` not `Post Photo Video`
+4. **Whitespace is automatically cleaned**: `Post, Photo, Video` works fine
+
+### Complete Usage Examples
+
+```bash
+# Standard resource with polymorphic association
+rails generate propel_api:resource Comment content:text commentable:polymorphic --parents commentable:Post,Photo,Video
+
+# Multi-tenant polymorphic resource
+rails generate propel_api:resource Review rating:integer organization:references agency:references review_parent:polymorphic --parents review_parent:Product,Agency,User
+
+# Schedule system with polymorphic parent
+rails generate propel_api:resource Schedule name:string start_time:datetime schedule_parent:polymorphic --parents schedule_parent:User,Room,MeetingLink
+
+# Multiple polymorphic associations in one resource
+rails generate propel_api:resource Attachment file_name:string attachable:polymorphic owner:polymorphic --parents attachable:Post,Comment,Email owner:User,Agency
+```
+
 ### Breaking Changes from v0.2.x
 
 ⚠️ **Migration Required**: The polymorphic syntax and test generation has been completely rewritten for better reliability and Rails compatibility.
@@ -148,7 +201,7 @@ end
 
 The new approach provides:
 - More reliable test generation
-- Better fixture management
+- Better fixture management  
 - Cleaner, more maintainable code
 - Full Rails compatibility
 

data/lib/generators/propel_api/controller/controller_generator.rb

@@ -52,7 +52,7 @@ module PropelApi
     class_option :parents,
                  type: :hash,
                  default: {},
-                 desc: "Specify parent types for polymorphic associations (e.g., --parents commentable:Post,Photo,Video)"
+                 desc: "Specify parent types for polymorphic associations. REQUIRED syntax: --parents model_polymorphic_name:Parent1,Parent2,Parent3 (e.g., --parents commentable:Post,Photo,Video)"
 
     def validate_model_exists
       # Ensure attributes are parsed before validation

data/lib/generators/propel_api/core/named_base.rb

@@ -549,7 +549,7 @@ module PropelApi
           # Fallback to User if no parent types specified and no models auto-discovered
           if parent_types.empty?
             say "Warning: No parent types specified for polymorphic association '#{attr.name}' and no models found to auto-discover.", :yellow
-            say "Falling back to 'User' as parent type. Use --parents ModelA,ModelB,ModelC to specify different parent types.", :yellow
+            say "Falling back to 'User' as parent type. Use --parents #{attr.name}:Parent1,Parent2,Parent3 to specify parent types.", :yellow
             parent_types = ['User']
           end
           
@@ -599,28 +599,12 @@ module PropelApi
     private
 
     def parse_polymorphic_parent_types
-      return {} unless defined?(options) && options[:parents] && !options[:parents].empty?
+      return {} unless defined?(options) && options[:parents]
       
-      # With the simplified syntax, we apply the same parent types to all polymorphic associations
-      parent_types = options[:parents].map(&:strip).map(&:camelize)
-      
-      # Debug: Show what we parsed
-      say "Debug: Parsed parent types from --parents: #{parent_types.inspect}", :cyan if parent_types.any?
-      
-      # Find all polymorphic associations and apply the same parent types to each
       parsed_types = {}
-      attrs = respond_to?(:attributes) ? attributes : (@attributes || [])
-      
-      if attrs && !attrs.empty?
-        polymorphic_attrs = attrs.select { |attr| attr.type == :references && attr.respond_to?(:polymorphic?) && attr.polymorphic? }
-        polymorphic_attrs.each do |attr|
-          parsed_types[attr.name.to_s] = parent_types
-          say "Debug: Applied parent types #{parent_types.inspect} to polymorphic field '#{attr.name}'", :cyan
-        end
-      else
-        say "Debug: No attributes found when parsing polymorphic parent types", :yellow
+      options[:parents].each do |field_name, parent_list|
+        parsed_types[field_name] = parent_list.split(',').map(&:strip).map(&:camelize)
       end
-      
       parsed_types
     end
 

data/lib/generators/propel_api/resource/resource_generator.rb

@@ -74,7 +74,7 @@ module PropelApi
   class_option :parents,
                type: :hash,
                default: {},
-               desc: "Specify parent types for polymorphic associations (e.g., --parents commentable:Post,Photo,Video)"
+               desc: "Specify parent types for polymorphic associations. REQUIRED syntax: --parents field_name:Parent1,Parent2,Parent3 (e.g., --parents commentable:Post,Photo,Video)"
 
   def create_migration
     initialize_propel_api_settings

data/lib/propel_api.rb

@@ -1,3 +1,3 @@
 module PropelApi
-  VERSION = "0.3.1.3"
+  VERSION = "0.3.1.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: propel_api
 version: !ruby/object:Gem::Version
-  version: 0.3.1.3
+  version: 0.3.1.4
 platform: ruby
 authors:
 - Ryan Martin, Rafael Pivato, Chi Putera