prop_check 0.17.0 → 0.18.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e59cf670bcc8cf9720d6278e984925c50e75ca65023459174f8b511d6421fb71
-  data.tar.gz: '088e0eb8d2d301bc3c03cc63bf68196969e8653cad37ff0b9d5d10f9b417a1ae'
+  metadata.gz: 117dfaa6197dcb53fd6619ae414452a277d668a34736331169407361dbdcb0bc
+  data.tar.gz: 86a17a6070762151d0e84010c3bdf75569df962c1428fb7008f46cfe685f312c
 SHA512:
-  metadata.gz: de5808bced970e0c474367bf125837ac0eefa4aa752acb31cd74e884fea858b98fb518e9fe15493c81f8238e5e0490f3cbc855eda3a9b687196ca7830daad0aa
-  data.tar.gz: 312957d1ab0f990985f43ae7e4b0793df583ff2d3d8bb95573c11fe3e4d9c5f964d91050fe9bafb98ceb92dd6790d2ffce04257b02b0c152d75d9b4772b7423a
+  metadata.gz: 1d00f635551fc17b870a0f3065040662b85565a19a498d84dbdb76de106f0138d905f2da0fdb89f5ee25e666411abdc7d4d7b61831114d99ed80451471f450f0
+  data.tar.gz: 8ec326b8e39ceed7d587de59c6fac591e91d4429bdef0a9770542643e7a1d5323667f59cf196611cac42324288994096054afc72ea6eb2722640a68c3cc745b6

data/.github/workflows/run_tests.yaml

@@ -2,9 +2,9 @@ name: Ruby RSpec tests
 
 on:
   push:
-    branches: [ master ]
+    branches: [ main ]
   pull_request:
-    branches: [ master ]
+    branches: [ main ]
 
 permissions:
   contents: read
@@ -15,7 +15,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.5', '2.6', '2.7', '3.0']
+        # NOTE: Ruby 3.2 is not in here, as `doctest-core` first needs to be updated to support it
+        ruby-version: ['2.6', '2.7', '3.0', '3.1']
 
     steps:
     - uses: actions/checkout@v3
@@ -27,5 +28,9 @@ jobs:
       with:
         ruby-version: ${{ matrix.ruby-version }}
         bundler-cache: true # runs 'bundle install' and caches installed gems automatically
-    - name: Run tests
-      run: bundle exec rake
+    - name: Run tests & push test coverage to Codeclimate
+      uses: paambaati/codeclimate-action@v3.2.0
+      env:
+        CC_TEST_REPORTER_ID: '9d18f5b43e49eecd6c3da64d85ea9c765d3606c129289d7c8cadf6d448713311'
+      with:
+        coverageCommand: bundle exec rake

data/.tool-versions

@@ -1 +1 @@
-ruby 2.7.1
+ruby 3.1.3

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+- 0.18.1
+  - Fixes:
+    - Compatibility with Ruby 3.2:
+      - Use `Random` instead of no-longer-available `Random::DEFAULT` on Ruby 3.x.
+      - Ensure when a hash is passed (such as in `PropCheck.forall(hash_of(integer, string)) { |hash| ... }` that when an empty hash is generated, `hash` is still `{}` and not `nil`. ([Ruby 3.x treats `fun(**{})` differently than Ruby 2.x](https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/#other-minor-changes-empty-hash))
+- 0.18.0
+  - Features:
+    - Allows calling `PropCheck::Property#check` without a block, which will just return `self`. This is useful for writing wrapper functions that use `before/after/around/with_config` etc hooks which might themselves optionally want a block so they can be chained. (See the `forall_with_db` snippet in the README for an example)
 - 0.17.0
   - Features:
     - Recursive generation using `PropCheck::Generators.tree`.

data/README.md

@@ -40,9 +40,9 @@ It works by generating arbitrary data matching your specification and checking t
 
 Writing these kinds of tests usually consists of deciding on guarantees that your code should have -- properties that should always hold true, regardless of wat the world throws at you. Some examples are:
 
-- Your code should not throw an exception, or only a particular type of exception.
+- Your code should never crash.
 - If you remove an object, you can no longer see it
-- If you serialize and then deserializea value, you get the same value back.
+- If you serialize and then deserialize a value, you get the same value back.
 
 
 ## Implemented and still missing features
@@ -107,7 +107,7 @@ PropCheck.forall(G.array(G.integer)) do |numbers|
   
   # Check that no number is smaller than the previous number
   sorted_numbers.each_cons(2) do |former, latter| 
-    raise "Elements are not sorted! #{latter} is < #{former}" if latter < former
+    raise "Elements are not sorted! #{latter} is < #{former}" if latter > former
   end
 end
 ```
@@ -122,32 +122,53 @@ def naive_average(array)
   array.sum / array.length
 end
 ```
-```ruby
-# And then in a test case:
-G = PropCheck::Generators
-PropCheck.forall(numbers: G.array(G.integer)) do |numbers:|
-  result = naive_average(numbers)
-  unless result.is_a?(Integer) do
-    raise "Expected the average to be an integer!"
-  end
-end
 
-# Or if you e.g. are using RSpec:
-describe "#naive_average" do
-  include PropCheck
+The test case, using RSpec:
+``` ruby
+require 'rspec'
+
+RSpec.describe "#naive_average" do
   G = PropCheck::Generators
 
   it "returns an integer for any input" do
-    forall(numbers: G.array(G.integer)) do |numbers:|
-      result = naive_average(numbers)      
+    PropCheck.forall(G.array(G.integer)) do |numbers|
+      result = naive_average(numbers)
+
       expect(result).to be_a(Integer)
     end
   end
 end
 ```
 
-When running this particular example PropCheck very quickly finds out that we have made a programming mistake:
+The test case, using MiniTest:
+``` ruby
+require 'minitest/autorun'
+class NaiveAverageTest < MiniTest::Unit::TestCase
+  G = PropCheck::Generators
+
+  def test_that_it_returns_an_integer_for_any_input()
+    PropCheck.forall(G.array(G.integer)) do |numbers|
+      result = naive_average(numbers)
+
+      assert_instance_of(Integer, result)
+    end
+  end
+end
+```
 
+The test case, using only vanilla Ruby:
+```ruby
+# And then in a test case:
+G = PropCheck::Generators
+
+PropCheck.forall(G.array(G.integer)) do |numbers|
+  result = naive_average(numbers)
+
+  raise "Expected the average to be an integer!" unless result.is_a?(Integer)
+end
+```
+
+When running this particular example PropCheck very quickly finds out that we have made a programming mistake:
 ```ruby
 ZeroDivisionError: 
 (after 6 successful property test runs)
@@ -270,6 +291,26 @@ although above are the most generally useful ones.
 [PropCheck::Generator documentation](https://www.rubydoc.info/github/Qqwy/ruby-prop_check/master/PropCheck/Generator)
 [PropCheck::Generators documentation](https://www.rubydoc.info/github/Qqwy/ruby-prop_check/master/PropCheck/Generators)
 
+
+## Usage within Rails / with a database
+
+Using PropCheck for unit tests in a Rails, Sinatra, Hanami, etc. project is very easy.
+Here are some simple recommendations for the best results:
+- Tests that do not need to use the DB at all are usually 10x-100x faster. Faster tests means that you can configure PropCheck to do more test runs.
+- If you do need to use the database, use the [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner) gem, preferibly with the fast `:transaction` strategy if your RDBMS supports it. To make sure the DB is cleaned around each generated example, you can write the following helper:
+``` ruby
+  # Version of PropCheck.forall
+  # which ensures records persisted to the DB in one generated example
+  # do not affect any other
+  def forall_with_db(*args, **kwargs, &block)
+      PropCheck.forall(*args, **kwargs)
+               .before { DatabaseCleaner.start }
+               .after { DatabaseCleaner.clean }
+               .check(&block)
+  end
+```
+- Other setup/cleanup should also usually happen around each generated example rather than around the whole test: Instead of using the hooks exposed by RSpec/MiniTest/etc., use the before/after/around hooks exposed by PropCheck.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
@@ -286,7 +327,7 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the PropCheck project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/prop_check/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the PropCheck project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/Qqwy/ruby-prop_check/blob/master/CODE_OF_CONDUCT.md).
 
 ## Attribution and Thanks
 
@@ -294,7 +335,7 @@ I want to thank the original creators of QuickCheck (Koen Claessen, John Hughes)
 I also want to greatly thank Thomasz Kowal who made me excited about property based testing [with his great talk about stateful property testing](https://www.youtube.com/watch?v=q0wZzFUYCuM), 
 as well as Fred Herbert for his great book [Property-Based Testing with PropEr, Erlang and Elixir](https://propertesting.com/) which is really worth the read (regardless of what language you are using).
 
-The implementation and API of PropCheck takes a lot of inspiration from the following pre-existing libraries:
+The implementation and API of PropCheck takes a lot of inspiration from the following projects:
 
 - Haskell's [QuickCheck](https://hackage.haskell.org/package/QuickCheck) and [Hedgehog](https://hackage.haskell.org/package/hedgehog);
 - Erlang's [PropEr](https://hex.pm/packages/proper);

data/lib/prop_check/generator.rb

@@ -9,7 +9,14 @@ module PropCheck
   # to be used during the shrinking phase.
   class Generator
     @@default_size = 10
-    @@default_rng = Random.new
+    @@default_rng =
+      # Backwards compatibility: Random::DEFAULT is deprecated in Ruby 3.x
+      # but required in Ruby 2.x and 1.x
+      if RUBY_VERSION.to_i >= 3
+        Random
+      else
+        Random::DEFAULT
+      end
     @@max_consecutive_attempts = 100
     @@default_kwargs = { size: @@default_size, rng: @@default_rng,
                          max_consecutive_attempts: @@max_consecutive_attempts }
@@ -115,8 +122,10 @@ module PropCheck
     # This can be used to inspect the configuration inside a `#map` or `#where`
     # and act on it.
     #
-    #  >> Generators.choose(0..100).with_config.map { |int, conf| Date.jd(conf[:default_epoch].jd + int) }.call(size: 10, rng: Random.new(42), config: PropCheck::Property::Configuration.new)
-    #  => Date.new(2023, 01, 10)
+    #  >> example_config = PropCheck::Property::Configuration.new(default_epoch: Date.new(2022, 11, 22))
+    #  >> generator = Generators.choose(0..100).with_config.map { |int, conf| Date.jd(conf[:default_epoch].jd + int) }
+    #  >> generator.call(size: 10, rng: Random.new(42), config: example_config)
+    #  => Date.new(2023, 01, 12)
     def with_config
       Generator.new do |**kwargs|
         result = generate(**kwargs)

data/lib/prop_check/generators.rb

@@ -769,7 +769,7 @@ module PropCheck
     # DateTimes start around the given `epoch:`  and deviate more when `size` increases.
     # when no epoch is set, `PropCheck::Property::Configuration.default_epoch` is used, which defaults to `DateTime.now`.
     #
-    #   >> PropCheck::Generators.datetime.sample(2, rng: Random.new(42), config: PropCheck::Property::Configuration.new)
+    #   >> PropCheck::Generators.datetime(epoch: Date.new(2022, 11, 20)).sample(2, rng: Random.new(42), config: PropCheck::Property::Configuration.new)
     #   => [DateTime.parse("2022-11-17 07:11:59.999983907 +0000"), DateTime.parse("2022-11-19 05:27:16.363618076 +0000")]
     def datetime(epoch: nil)
       datetime_from_offset(real_float, epoch: epoch)
@@ -785,7 +785,7 @@ module PropCheck
     ##
     # Variant of `#datetime` that only generates datetimes in the future (relative to `:epoch`).
     #
-    #   >> PropCheck::Generators.future_datetime.sample(2, rng: Random.new(42), config: PropCheck::Property::Configuration.new).map(&:inspect)
+    #   >> PropCheck::Generators.future_datetime(epoch: Date.new(2022, 11, 20)).sample(2, rng: Random.new(42), config: PropCheck::Property::Configuration.new).map(&:inspect)
     #   => ["#<DateTime: 2022-11-21T16:48:00+00:00 ((2459905j,60480s,16093n),+0s,2299161j)>", "#<DateTime: 2022-11-19T18:32:43+00:00 ((2459903j,66763s,636381924n),+0s,2299161j)>"]
     def future_datetime(epoch: nil)
       datetime_from_offset(real_positive_float, epoch: epoch)
@@ -794,7 +794,7 @@ module PropCheck
     ##
     # Variant of `#datetime` that only generates datetimes in the past (relative to `:epoch`).
     #
-    #   >> PropCheck::Generators.past_datetime.sample(2, rng: Random.new(42), config: PropCheck::Property::Configuration.new)
+    #   >> PropCheck::Generators.past_datetime(epoch: Date.new(2022, 11, 20)).sample(2, rng: Random.new(42), config: PropCheck::Property::Configuration.new)
     #   => [DateTime.parse("2022-11-17 07:11:59.999983907 +0000"), DateTime.parse("2022-11-19 05:27:16.363618076 +0000")]
     def past_datetime(epoch: nil)
       datetime_from_offset(real_negative_float, epoch: epoch)
@@ -805,7 +805,7 @@ module PropCheck
     # Times start around the given `epoch:`  and deviate more when `size` increases.
     # when no epoch is set, `PropCheck::Property::Configuration.default_epoch` is used, which defaults to `DateTime.now`.
     #
-    #   >> PropCheck::Generators.time.sample(2, rng: Random.new(42), config: PropCheck::Property::Configuration.new)
+    #   >> PropCheck::Generators.time(epoch: Date.new(2022, 11, 20)).sample(2, rng: Random.new(42), config: PropCheck::Property::Configuration.new)
     #   => [DateTime.parse("2022-11-17 07:11:59.999983907 +0000").to_time, DateTime.parse("2022-11-19 05:27:16.363618076 +0000").to_time]
     def time(epoch: nil)
       datetime(epoch: epoch).map(&:to_time)

data/lib/prop_check/helper.rb

@@ -33,6 +33,9 @@ module PropCheck
     end
 
     def call_splatted(val, &block)
+      # Handle edge case where Ruby >= 3 behaves differently than Ruby <= 2
+      # c.f. https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/#other-minor-changes-empty-hash
+      return block.call({}) if val.is_a?(Hash) && val.empty?
       return block.call(**val) if val.is_a?(Hash) && val.keys.all? { |k| k.is_a?(Symbol) }
 
       block.call(val)

data/lib/prop_check/property.rb

@@ -42,11 +42,8 @@ module PropCheck
     # of this class on before finally passing a block to it using `#check`.
     # (so `forall(Generators.integer) do |val| ... end` and forall(Generators.integer).check do |val| ... end` are the same)
     def self.forall(*bindings, **kwbindings, &block)
-      property = new(*bindings, **kwbindings)
-
-      return property.check(&block) if block_given?
-
-      property
+      new(*bindings, **kwbindings)
+        .check(&block)
     end
 
     ##
@@ -106,9 +103,7 @@ module PropCheck
       duplicate.instance_variable_set(:@config, @config.merge(config))
       duplicate.freeze
 
-      return duplicate.check(&block) if block_given?
-
-      duplicate
+      duplicate.check(&block)
     end
 
     ##
@@ -248,6 +243,8 @@ module PropCheck
     ##
     # Checks the property (after settings have been altered using the other instance methods in this class.)
     def check(&block)
+      return self unless block_given?
+
       n_runs = 0
       n_successful = 0
 
@@ -335,7 +332,7 @@ c.f. https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-k
     end
 
     private def raw_attempts_enum(binding_generator)
-      rng = Random::DEFAULT
+      rng = Random.new
       size = 1
       (0...@config.max_generate_attempts)
         .lazy

data/lib/prop_check/version.rb

@@ -1,3 +1,3 @@
 module PropCheck
-  VERSION = '0.17.0'
+  VERSION = '0.18.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: prop_check
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.18.1
 platform: ruby
 authors:
 - Qqwy/Wiebe-Marten Wijnja
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-11-20 00:00:00.000000000 Z
+date: 2023-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: amazing_print
@@ -83,7 +83,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: PropCheck allows you to do property-based testing, including shrinking.