pronto-undercover 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 23a9e88cb350120dd32a0d30c92e6cf3dd5c015413c0ee3c16a700b6a4ada53d
-  data.tar.gz: fa21ebfb5b108a702c33d4677e9dfa6d073123bce9f2f2c5181f3d6a03a72de9
+  metadata.gz: 3de1d2e492a7103e77d719748a7271d48bb3030413bc226ff9d709fb10bbd198
+  data.tar.gz: 35a280e62e729d415cb8763ad10671dce35db4127da44319c8be6d51e146a8f1
 SHA512:
-  metadata.gz: 868fd2ee69c581041f33be5adce989896df204bad5fb48a263b4938cb303dffc0e03064670eefb055729fcea6c0dc62e7ce3d9199f9f3a00a2b2dd36bbd12656
-  data.tar.gz: fd26c906d8e29db5ba13962f2833e8aa30146d237a946c2b87882314a4dbae839be40c3ab7e7f21debf0907dd45eb8c2baf4bc9c4085f446c9c416d47f2f6228
+  metadata.gz: d468fe8c175ecbe4ded4431e8f0102258166f1dbadaa33ed28b93d0f8c88fcface1ca4c4f3c8c21b3063f6c6844fb565067824f0133a99482289e126cbecaedc
+  data.tar.gz: 7f3472e588da2f7f3028cde205a903a7e7d3d64e8ec1e83f59542df2d4c2aa0a70ee4829789719c7817d01ad5fb8d2e7272e5f7cb8224f68ef00a2d6a34fe0e1

data/.rubocop.yml

@@ -12,6 +12,10 @@ Layout/SpaceInsideHashLiteralBraces:
   Enabled: true
   EnforcedStyle: no_space
 
+Metrics/LineLength:
+  Enabled: True
+  Max: 100
+
 Metrics/BlockLength:
   Enabled: true
   Exclude:

data/lib/pronto/undercover.rb

@@ -17,11 +17,12 @@ module Pronto
 
     # @return Array[Pronto::Message]
     def run
-      return [] unless @patches.first
-      report = ::Undercover::Report.new(
-        @patch_changeset, undercover_options
-      ).build
-      report.build_warnings.map(&method(:undercover_warning_to_message))
+      return [] if !@patches || @patches.count.zero?
+
+      @patches
+        .select { |patch| patch.additions.positive? }
+        .map { |patch| patch_to_undercover_message(patch) }
+        .flatten.compact
     rescue Errno::ENOENT => e
       warn("Could not open file! #{e}")
       []
@@ -29,20 +30,40 @@ module Pronto
 
     private
 
-    # rubocop:disable Metrics/AbcSize
-    def undercover_warning_to_message(warning)
-      lines = untested_lines_for(warning)
-      msg = "#{warning.node.human_name} #{warning.node.name} missing tests" \
-        " for line#{'s' if lines.size > 1} #{lines.join(', ')}" \
-        " (coverage: #{warning.coverage_f})"
-
-      line = @patches.find_line(
-        Pathname.new(File.expand_path(warning.file_path)),
-        warning.first_line
-      )
-      Message.new(warning.file_path, line, DEFAULT_LEVEL, msg)
+    # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+    def patch_to_undercover_message(patch)
+      offending_line_numbers(patch).map do |warning, msg_line_no|
+        patch
+          .added_lines
+          .select { |line| line.new_lineno == msg_line_no }
+          .map do |line|
+            lines = untested_lines_for(warning)
+            path = line.patch.delta.new_file[:path]
+            msg = "#{warning.node.human_name} #{warning.node.name} missing tests" \
+                  " for line#{'s' if lines.size > 1} #{lines.join(', ')}" \
+                  " (coverage: #{warning.coverage_f})"
+            Message.new(path, line, DEFAULT_LEVEL, msg)
+          end
+      end
+    end
+    # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
+
+    def undercover_warnings
+      @undercover_warnings ||= ::Undercover::Report.new(
+        @patch_changeset, undercover_options
+      ).build.build_warnings
+    end
+
+    def offending_line_numbers(patch)
+      patch_lines = patch.added_lines.map(&:position)
+      path = patch.new_file_full_path.to_s
+      undercover_warnings
+        .select { |warning| File.expand_path(warning.file_path) == path }
+        .map do |warning|
+          first_line_no = patch_lines.find { |l| warning.uncovered?(l) }
+          [warning, first_line_no] if first_line_no
+        end.compact
     end
-    # rubocop:enable Metrics/AbcSize
 
     def untested_lines_for(warning)
       warning.coverage.map do |ln, _cov|

data/lib/version.rb

@@ -2,6 +2,6 @@
 
 module Pronto
   module UndercoverVersion
-    VERSION = '0.1.0'
+    VERSION = '0.1.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto-undercover
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Jan Grodowski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-07 00:00:00.000000000 Z
+date: 2018-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pronto