pronto-standardrb 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4e4b4304698c68c845e872a1984761ff26e1629e46630bce79ab54543559975
-  data.tar.gz: 0ddfeae532c9be9482c23942a94a4304daddf1d9781c8a3c73f854f34266a6bf
+  metadata.gz: 15be9f0ad83e1ae0d6e288bed884843ba464611a93d0cf53f261a11ba77de96b
+  data.tar.gz: f228a57341f34541aa9ff06e329db838dc5e8b237b48613acc41a67c55f457ac
 SHA512:
-  metadata.gz: c2fa0f6b4bff7d31bf3dc1569f1157c4481c70b46a6a5fb2d0211cbe8a8a31841edc00b8a06953c6c1a8f5a87c9f7b3ab0acea1a15473468c6c87be625e63119
-  data.tar.gz: 7c468cbfd6e552dd618ef939f2da8003db8dbf1764e3246ee2dabf1b0c78949ccee09932b8848603643e0553e4a37964aa63f37df1c3c576bb9612734e18f3dd
+  metadata.gz: d7fedd511885d1db14646a26bfe6600a31922354f42f8bdb86c20347578181ae323353968ffbb3c9c9350d6cb06a63614de53af73fc23bccfe04c21b1b4037ac
+  data.tar.gz: 866ba7d0ccffef82c6cde636b672e50854e20f3060c5ebd7e44cd2ddf59460562d7bc9ad61cf2596bc83283ecdc0235f91da59f9e8f203cc4dd4701277865fa4

data/README.md

@@ -1,8 +1,14 @@
-# Pronto::Standardrb
+# Attention!
+
+TLDR: at the moment doesn't work as expected. please wait for bugfix :-)
+
+Due to the inner workings of `pronto`, it seems it's not possible to simply subclass a runner, as I have done here. `require`ing a runner will add it to the runners list, IIUC, thus firing it. Since standard's opinionated config is quite different from rubocops standard config, you'll get inconclusive results.
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/pronto/standardrb`. To experiment with that code, run `bin/console` for an interactive prompt.
+I'm sorry about the premature release.
+
+# Pronto::Standardrb
 
-TODO: Delete this and the text above, and describe your gem
+[Pronto](https://github.com/prontolabs/pronto) runner for [Standardrb](https://github.com/prontolabs/pronto)
 
 ## Installation
 

data/lib/pronto/standardrb.rb

@@ -1,18 +1,82 @@
 require "pronto/standardrb/version"
 require "pronto"
-require "pronto/rubocop"
+require "rubocop"
 require "pry"
 require "standard"
 
 module Pronto
-  class Standardrb < Rubocop
-    def initialize(patches, _ = nil)
-      super(patches)
+  class Standardrb < Runner
+    def run
+      ruby_patches
+        .select { |patch| patch.additions > 0 }
+        .flat_map do |patch|
+        offenses(patch).flat_map do |offense|
+          patch
+            .added_lines
+            .select { |line| line.new_lineno == offense.line }
+            .map { |line| new_message(offense, line) }
+        end
+      end
+    end
+
+    def rubocop_config(patch)
+      builds_config = Standard::BuildsConfig.new
+      config = builds_config.call([])
+
+      @rubocop_config ||= begin
+                            store = config.rubocop_config_store 
+                            store.for(path(patch))
+                          end
+    end
+
+    private
 
-      @builds_config = Standard::BuildsConfig.new
+    def processed_source(patch)
+      ::RuboCop::ProcessedSource.from_file(
+        path(patch),
+        rubocop_config(patch).target_ruby_version
+      )
+    end
+
+    def new_message(offense, line)
+      path = line.patch.delta.new_file[:path]
+      level = level(offense.severity.name)
+      Message.new(path, line, level, offense.message, nil, self.class)
+    end
+
+    def offenses(patch)
+      team(patch)
+        .inspect_file(processed_source(patch))
+        .sort
+        .reject(&:disabled?)
+    end
 
-      config = @builds_config.call([])
-      @inspector = ::RuboCop::Runner.new(config.rubocop_options, @config_store)
+    def path(patch)
+      patch.new_file_full_path.to_s
     end
+
+    def team(patch)
+      @team ||= ::RuboCop::Cop::Team.new(registry, rubocop_config(patch))
+    end
+
+    def registry
+      @registry ||= ::RuboCop::Cop::Registry.new(RuboCop::Cop::Cop.all)
+    end
+
+    def level(severity)
+      severities.fetch(severity)
+    end
+
+    def severities
+      DEFAULT_SEVERITIES
+    end
+
+    DEFAULT_SEVERITIES = {
+      refactor: :warning,
+      convention: :warning,
+      warning: :warning,
+      error: :error,
+      fatal: :fatal
+    }.freeze
   end
 end

data/lib/pronto/standardrb/version.rb

@@ -1,5 +1,5 @@
 module Pronto
   module StandardrbVersion
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/pronto-standardrb.gemspec

@@ -25,9 +25,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "standard"
   spec.add_runtime_dependency "pronto"
-  spec.add_runtime_dependency "pronto-rubocop"
+  spec.add_runtime_dependency "rubocop"
+  spec.add_runtime_dependency "standard"
   spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rake", "~> 10.0"

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: pronto-standardrb
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Julian Rubisch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-13 00:00:00.000000000 Z
+date: 2019-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: standard
+  name: pronto
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,7 +25,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pronto
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,7 +39,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pronto-rubocop
+  name: standard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="