pronto-rubocop 0.9.1 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6213d26b3332b2dfebd43d4ee54afd1f8bd06de03ee73526216ba50ca75fcaf1
-  data.tar.gz: a3426fcfdc4265953fcae3008489dbcd1d619ccc8e0471f566117ddad3c2e7cd
+  metadata.gz: '061479d3c9326adbd73af0ee8e79c5a1f46ed3aa8f8ea8dfa7b7946a899e4aff'
+  data.tar.gz: 22ab34372429508f391103d663cb462650fac8c08110771ff897400a22662a42
 SHA512:
-  metadata.gz: eae06e126fb1c8b181a2e0e87d21ff25a65f89dc06d84d4b2d405a6ade8f557d16c8fbe642457cea5dd2093d4e7617f42c24f2839725744357f8ba76fd11e09f
-  data.tar.gz: b901eb7b9ad51b67bee5606bc5b7e5943c11b22686ba06a4fbf5d4a45ea3850e100e26ba2705962bc0880e94190d571cb5f9f9770218dd1830d3e13a8d51859a
+  metadata.gz: c921d367340e6b725fd6f5c057c0d7ba3fbdab8b03f1ea5a56a559a6336ca646fca67f0f4f6467822db4c300779a015565fb48cf099bf22a38a549f6af8f846e
+  data.tar.gz: f1711fd2fb7c1bdd9c2374307879eb91e3af059928668a92864def3fea788f3f884075c08b9416623e770aa6309b13a6088d0308a4451047ee5ef529dea55647

data/README.md

@@ -1,11 +1,10 @@
 # Pronto runner for Rubocop
 
-[![Code Climate](https://codeclimate.com/github/mmozuras/pronto-rubocop.png)](https://codeclimate.com/github/mmozuras/pronto-rubocop)
-[![Build Status](https://travis-ci.org/mmozuras/pronto-rubocop.png)](https://travis-ci.org/mmozuras/pronto-rubocop)
+[![Code Climate](https://codeclimate.com/github/prontolabs/pronto-rubocop.png)](https://codeclimate.com/github/prontolabs/pronto-rubocop)
+[![Build Status](https://travis-ci.org/prontolabs/pronto-rubocop.svg?branch=master)](https://travis-ci.org/prontolabs/pronto-rubocop)
 [![Gem Version](https://badge.fury.io/rb/pronto-rubocop.png)](http://badge.fury.io/rb/pronto-rubocop)
-[![Dependency Status](https://gemnasium.com/mmozuras/pronto-rubocop.png)](https://gemnasium.com/mmozuras/pronto-rubocop)
 
-Pronto runner for [Rubocop](https://github.com/bbatsov/rubocop), ruby code analyzer. [What is Pronto?](https://github.com/mmozuras/pronto)
+Pronto runner for [Rubocop](https://github.com/bbatsov/rubocop), ruby code analyzer. [What is Pronto?](https://github.com/prontolabs/pronto)
 
 ## Configuration
 

data/lib/pronto/rubocop.rb

@@ -1,71 +1,14 @@
 require 'pronto'
 require 'rubocop'
+require 'pronto/rubocop/patch_cop'
 
 module Pronto
   class Rubocop < Runner
-    def initialize(_, _ = nil)
-      super
-
-      @config_store = ::RuboCop::ConfigStore.new
-      @config_store.options_config = ENV['RUBOCOP_CONFIG'] if ENV['RUBOCOP_CONFIG']
-      @inspector = ::RuboCop::Runner.new({}, @config_store)
-    end
-
     def run
-      return [] unless @patches
-
-      @patches.select { |patch| valid_patch?(patch) }
-        .map { |patch| inspect(patch) }
-        .flatten.compact
-    end
-
-    def valid_patch?(patch)
-      return false if patch.additions < 1
-
-      config_store = config_store_for(patch)
-      path = patch.new_file_full_path
-
-      return false if config_store.file_to_exclude?(path.to_s)
-      return true if config_store.file_to_include?(path.to_s)
-
-      ruby_file?(path)
-    end
-
-    def inspect(patch)
-      processed_source = processed_source_for(patch)
-      offences = @inspector.send(:inspect_file, processed_source).first
-
-      offences.sort.reject(&:disabled?).map do |offence|
-        patch.added_lines
-          .select { |line| line.new_lineno == offence.line }
-          .map { |line| new_message(offence, line) }
-      end
-    end
-
-    def new_message(offence, line)
-      path = line.patch.delta.new_file[:path]
-      level = level(offence.severity.name)
-
-      Message.new(path, line, level, offence.message, nil, self.class)
-    end
-
-    def config_store_for(patch)
-      path = patch.new_file_full_path.to_s
-      @config_store.for(path)
-    end
-
-    def processed_source_for(patch)
-      path = patch.new_file_full_path.to_s
-      ::RuboCop::ProcessedSource.from_file(path, RUBY_VERSION[0..2].to_f)
-    end
-
-    def level(severity)
-      case severity
-      when :refactor, :convention
-        :warning
-      when :warning, :error, :fatal
-        severity
-      end
+      ruby_patches
+        .select { |patch| patch.additions > 0 }
+        .map { |patch| PatchCop.new(patch, self).messages }
+        .flatten
     end
   end
 end

data/lib/pronto/rubocop/patch_cop.rb

@@ -0,0 +1,79 @@
+module Pronto
+  class Rubocop < Runner
+    class PatchCop
+      def initialize(patch, runner)
+        @patch = patch
+        @runner = runner
+      end
+
+      def messages
+        return [] unless valid?
+
+        offences.map do |offence|
+          patch
+            .added_lines
+            .select { |line| line.new_lineno == offence.line }
+            .map { |line| new_message(offence, line) }
+        end
+      end
+
+      private
+
+      attr_reader :patch, :runner
+
+      def valid?
+        return false if config.file_to_exclude?(path)
+        return true if config.file_to_include?(path)
+        true
+      end
+
+      def path
+        @path ||= patch.new_file_full_path.to_s
+      end
+
+      def config
+        @config ||= begin
+          store = ::RuboCop::ConfigStore.new
+          store.options_config = ENV['RUBOCOP_CONFIG'] if ENV['RUBOCOP_CONFIG']
+          store.for(path)
+        end
+      end
+
+      def offences
+        team
+          .inspect_file(processed_source)
+          .sort
+          .reject(&:disabled?)
+      end
+
+      def team
+        @team ||= ::RuboCop::Cop::Team.new(registry, config)
+      end
+
+      def registry
+        @registry ||= ::RuboCop::Cop::Registry.new(RuboCop::Cop::Cop.all)
+      end
+
+      def processed_source
+        @processed_source ||=
+          ::RuboCop::ProcessedSource.from_file(path, config.target_ruby_version)
+      end
+
+      def new_message(offence, line)
+        path = line.patch.delta.new_file[:path]
+        level = level(offence.severity.name)
+
+        Message.new(path, line, level, offence.message, nil, runner.class)
+      end
+
+      def level(severity)
+        case severity
+        when :refactor, :convention
+          :warning
+        when :warning, :error, :fatal
+          severity
+        end
+      end
+    end
+  end
+end

data/lib/pronto/rubocop/version.rb

@@ -1,5 +1,5 @@
 module Pronto
   module RubocopVersion
-    VERSION = '0.9.1'.freeze
+    VERSION = '0.10.0'.freeze
   end
 end

data/pronto-rubocop.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
   s.summary = 'Pronto runner for Rubocop, ruby code analyzer'
 
   s.licenses = ['MIT']
-  s.required_ruby_version = '>= 2.0.0'
+  s.required_ruby_version = '>= 2.3.0'
   s.rubygems_version = '1.8.23'
 
   s.files = `git ls-files`.split($RS).reject do |file|
@@ -33,7 +33,7 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
 
   s.add_runtime_dependency('rubocop', '~> 0.50', '>= 0.49.1')
-  s.add_runtime_dependency('pronto', '~> 0.9.0')
+  s.add_runtime_dependency('pronto', '~> 0.10.0')
   s.add_development_dependency('rake', '~> 12.0')
   s.add_development_dependency('rspec', '~> 3.4')
   s.add_development_dependency('rspec-its', '~> 1.2')

metadata

@@ -1,49 +1,49 @@
 --- !ruby/object:Gem::Specification
 name: pronto-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.10.0
 platform: ruby
 authors:
 - Mindaugas Mozūras
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-15 00:00:00.000000000 Z
+date: 2019-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.50'
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.49.1
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.50'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.50'
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.49.1
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.50'
 - !ruby/object:Gem::Dependency
   name: pronto
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -97,6 +97,7 @@ files:
 - LICENSE
 - README.md
 - lib/pronto/rubocop.rb
+- lib/pronto/rubocop/patch_cop.rb
 - lib/pronto/rubocop/version.rb
 - pronto-rubocop.gemspec
 homepage: http://github.com/mmozuras/pronto-rubocop
@@ -111,15 +112,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Pronto runner for Rubocop, ruby code analyzer