pronto-rubocop 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0588bd2b9b7d1c7a702dba2d9a5cdfc74e4d5df1eaa893557aa13445ab82c9d7'
-  data.tar.gz: 6bd89ce4bcec0647adc3c62abe770c8f43aff21d77b96a6c9679f6e35ffc84c2
+  metadata.gz: 9d5cd91a500a54c1184c0850685fd32ca72a832a82fd9c3a57b840d5b8eca6b2
+  data.tar.gz: 3b41e6777620b40b9d7e3d0d20946294c24acf8b081b32667e5adc69e2f03810
 SHA512:
-  metadata.gz: 2177a1cdf31387028a4dac6aed07b0df8379c33e84d80ac3b1329187beb99ad6b3bb490d1c70b4c098345b5cfac538463beff2767fe0bb28c094e78cbdcd14f1
-  data.tar.gz: 48856034490369353ed28755decda13d3e0f225468c8600a2706257ec2a119b88516de1757e7b5a5969ebd76e00e16fd908ca2b0e642901c1f51389a6ce483fc
+  metadata.gz: 7e440e9d28f6ef2b46ba4b6556164dcf97298e7926a972f5997417275dc4b2611e434ecdca32ccf8dc4550daa2d3561ae66871404b1773a306b3d93a8eb90a90
+  data.tar.gz: 81f24db46df5d142535c545c3943514ebcb5b138f08171e17a5c8e72178ae014fc1d67b206a425e7e34d04fc6dad7f0839ba56b4a5ea9e3291434ebaf809e74f

data/.github/workflows/checks.yml

@@ -7,13 +7,25 @@ on:
     branches: [ master ]
 
 jobs:
-  ruby:
+  unit_tests:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: ['2.3', '2.4', '2.5', '2.6', '2.7', '3.0']
+        ruby: ['2.4', '2.5', '2.6', '2.7', '3.0']
+        rubocop: ['0.63.1', '0.81.0', '0.84.0', '0.85.0', '0.86.0', '0.87.0', '< 1.0', '1.0.0', '< 2.0']
+        include:
+          - ruby: '2.3'
+            rubocop: '0.63.1'
+          - ruby: '2.3'
+            rubocop: '0.81.0'
+      fail-fast: false
     steps:
     - uses: actions/checkout@v2
+    - name: use specific rubocop version
+      run: echo "gem 'rubocop', '${{ matrix.rubocop }}'" > Gemfile.local
+    - name: use specific rubocop-ast version (if required)
+      if: matrix.rubocop == '0.84.0' || matrix.rubocop == '0.85.0'
+      run: echo "gem 'rubocop-ast', '< 0.7.0'" >> Gemfile.local
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}

data/README.md

@@ -38,3 +38,17 @@ the Pull Request.
 For example:
 
 ![GitHub screenshot with suggestion](https://user-images.githubusercontent.com/132/50402757-1bd75b80-0799-11e9-809f-8b8a23ed33f6.png)
+
+## RuboCop versions
+
+If you need to use RuboCop v0.84.0 or v0.85.x, you'll need to ensure that
+you've also need to add `gem 'rubocop-ast', '< 0.7.0'` to your Gemfile as
+these were the first versions to use rubocop-ast, and unfortunately the
+dependency was loose enough that rubocop-ast versions >= 0.7.0 were allowed,
+which causes `require 'rubocop'` to fail with
+```
+  NoMethodError:
+    undefined method `join' for #<Set: {:==, :===, :!=, :<=, :>=, :>, :<}>
+  in rubocop-0.84.0/lib/rubocop/cop/style/redundant_conditional.rb:57:in `<class:RedundantConditional>'
+```
+This is due to https://github.com/rubocop-hq/rubocop-ast/issues/22

data/lib/pronto/rubocop.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pronto'
 require 'rubocop'
 require 'pronto/rubocop/patch_cop'
@@ -7,7 +9,7 @@ module Pronto
   class Rubocop < Runner
     def run
       ruby_patches
-        .select { |patch| patch.additions > 0 }
+        .select { |patch| patch.additions.positive? }
         .flat_map { |patch| PatchCop.new(patch, self).messages }
     end
 

data/lib/pronto/rubocop/offense_line.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pronto
   class Rubocop < Runner
     class OffenseLine
@@ -31,7 +33,7 @@ module Pronto
 
       def suggestion_text
         return unless patch_cop.runner.pronto_rubocop_config['suggestions']
-        return if corrections_count == 0
+        return if corrections_count.zero?
         return if differing_lines_count != corrections_count
 
         @suggestion_text ||= corrected_lines[offense.line - 1]
@@ -51,7 +53,8 @@ module Pronto
         processed_source.lines.join("\n").lines
       end
 
-      if ::RuboCop::Cop::Team.respond_to?(:mobilize)
+      if ::RuboCop::Cop::Team.respond_to?(:mobilize) && ::RuboCop::Cop::Team.public_method_defined?(:investigate)
+        # rubocop >= 0.87.0 has both mobilize and public investigate method
         MOBILIZE = :mobilize
 
         def report
@@ -66,8 +69,8 @@ module Pronto
           report.offenses.size
         end
       else
-        # rubocop < v0.85.0
-        MOBILIZE = :new
+        # rubocop 0.85.x and 0.86.0 have mobilize, older versions don't
+        MOBILIZE = ::RuboCop::Cop::Team.respond_to?(:mobilize) ? :mobilize : :new
 
         def corrector
           @corrector ||= begin
@@ -86,11 +89,10 @@ module Pronto
       def autocorrect_team
         @autocorrect_team ||=
           ::RuboCop::Cop::Team.send(MOBILIZE,
-            ::RuboCop::Cop::Registry.new([cop_class]),
-            patch_cop.rubocop_config,
-            auto_correct: true,
-            stdin: true,
-          )
+                                    ::RuboCop::Cop::Registry.new([cop_class]),
+                                    patch_cop.rubocop_config,
+                                    auto_correct: true,
+                                    stdin: true)
       end
 
       def cop_class

data/lib/pronto/rubocop/patch_cop.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Pronto
   class Rubocop < Runner
     class PatchCop

data/lib/pronto/rubocop/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Pronto
   module RubocopVersion
-    VERSION = '0.11.0'.freeze
+    VERSION = '0.11.1'
   end
 end

data/pronto-rubocop.gemspec

@@ -1,6 +1,6 @@
-# -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 
-$LOAD_PATH.push File.expand_path('../lib', __FILE__)
+$LOAD_PATH.push File.expand_path('lib', __dir__)
 require 'pronto/rubocop/version'
 require 'English'
 
@@ -33,7 +33,7 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
 
   s.add_runtime_dependency('pronto', '~> 0.11.0')
-  s.add_runtime_dependency('rubocop', '>= 0.49.1', '< 1.0')
+  s.add_runtime_dependency('rubocop', '>= 0.63.1', '< 2.0')
   s.add_development_dependency('rake', '~> 12.0')
   s.add_development_dependency('rspec', '~> 3.4')
   s.add_development_dependency('rspec-its', '~> 1.2')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Mindaugas Mozūras
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-31 00:00:00.000000000 Z
+date: 2021-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pronto
@@ -30,20 +30,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 0.63.1
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 0.63.1
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement