pronto-reek 0.10.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eadce1e9e58eb90475deae3fa584a826b5c63920a69e38f63eaabb76ac9872bf
-  data.tar.gz: 82a4e5da5d45eefaa35684b135dc9da07d54e1b707703816cef13b1ee8286b3e
+  metadata.gz: 8b5dfd4b3e1094f4e66c8f3d371f9663b3c140dc810c3ec7e1600ba1e08fe797
+  data.tar.gz: 86dbfdb203ea9d8740ddbea37e2af155c71f789d86874424d132c1668df24e8e
 SHA512:
-  metadata.gz: c14b0917f7a72f27439ca7a9dbd875688eb7ba4b1509a257f4649c9ee8e0f60305e28d36e89d88c9eae047b3edf60c50e2f8d9e73411c3737e9b5a2247beb82a
-  data.tar.gz: 15c4524ae596a6780df9b8bc10b9ed7cf380a1ca7dfbb7a3bfbc244c75ba5011b3a2cafac5cf726bcb478f51a0603914a5bd248295120d97d5b625b64c9f6a23
+  metadata.gz: c54258b02c26d857678243b6deca4d8381ca1bb0ca8a9d55dcf75889a546b810c0402ef6014551302befe5b7153251484f60ad6b9ca91a2548d78c8fe7e80a8c
+  data.tar.gz: 3e3603f8c8ad72bc23bd964f2cb521eb6bb6ab1a982ec8bbd0ecc177e85479e83bcf05cb72fcfa230dcdbf0f54a9bb6d5e5dd4455387049ac888856a1bf4f380

data/.github/CODEOWNERS

@@ -0,0 +1,3 @@
+# Order is important. The last matching pattern takes the most precedence.
+# Default owners for everything in the repo.
+* @prontolabs/core

data/.github/workflows/checks.yml

@@ -0,0 +1,23 @@
+name: Checks
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  ruby:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ['2.3', '2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2']
+      fail-fast: false
+    steps:
+    - uses: actions/checkout@v3
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+    - name: rake spec
+      run: bundle exec rake spec

data/README.md

@@ -10,3 +10,12 @@ Pronto runner for [Reek](https://github.com/troessner/reek), code smell detector
 ## Configuration
 
 Configuring Reek via [config.reek](https://github.com/troessner/reek#configuration-file), or any file ending with .reek, will work just fine with pronto-reek.
+
+You can also specify a custom severity level for the reek smells with the environment variable PRONTO_REEK_SEVERITY_LEVEL.
+
+Or if you prefer provide it on your `.pronto.yml` (environment variable has precedence over file):
+
+```yaml
+reek:
+  severity_level: warning # default is info
+```

data/lib/pronto/reek/version.rb

@@ -1,5 +1,5 @@
 module Pronto
   module ReekVersion
-    VERSION = '0.10.0'.freeze
+    VERSION = '0.11.1'.freeze
   end
 end

data/lib/pronto/reek.rb

@@ -1,10 +1,15 @@
+# frozen_string_literal: true
+
 require 'pronto'
 require 'reek'
 
 module Pronto
   class Reek < Runner
     def run
-      files = ruby_patches.map(&:new_file_full_path)
+      files = ruby_patches.map do |patch|
+        patch.new_file_full_path.relative_path_from(Pathname.pwd)
+      end
+
       configuration = ::Reek::Configuration::AppConfiguration.from_path(nil)
 
       smells = files.flat_map do |file|
@@ -30,15 +35,21 @@ module Pronto
 
     def new_message(line, error)
       path = line.patch.delta.new_file[:path]
-      message = "#{error.message.capitalize} (#{error.smell_type})"
+      message = "#{error.message.capitalize} - [#{error.smell_type}](#{error.explanatory_link})"
 
-      Message.new(path, line, :info, message, nil, self.class)
+      Message.new(path, line, severity_level, message, nil, self.class)
     end
 
     def patch_for_error(error)
       ruby_patches.find do |patch|
-        patch.new_file_full_path.to_s == error.source
+        patch.new_file_full_path.relative_path_from(Pathname.pwd).to_s == error.source
       end
     end
+
+    def severity_level
+      @severity_level ||= begin
+        ENV['PRONTO_REEK_SEVERITY_LEVEL'] || Pronto::ConfigFile.new.to_h.dig('reek', 'severity_level') || :info
+      end.to_sym
+    end
   end
 end

data/pronto-reek.gemspec

@@ -32,8 +32,8 @@ Gem::Specification.new do |s|
   s.extra_rdoc_files = ['LICENSE', 'README.md']
   s.require_paths = ['lib']
 
-  s.add_dependency('pronto', '~> 0.10.0')
-  s.add_dependency('reek', '>= 4.2', '< 6.0')
+  s.add_dependency('pronto', '~> 0.11.0')
+  s.add_dependency('reek', '>= 4.2', '< 7.0')
   s.add_development_dependency('rake', '~> 12.0')
   s.add_development_dependency('rspec', '~> 3.4')
   s.add_development_dependency('rspec-its', '~> 1.2')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto-reek
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Mindaugas Mozūras
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-02-03 00:00:00.000000000 Z
+date: 2023-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pronto
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.0
+        version: 0.11.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.0
+        version: 0.11.0
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
@@ -33,7 +33,7 @@ dependencies:
         version: '4.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,7 +43,7 @@ dependencies:
         version: '4.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -86,7 +86,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
-description: 
+description:
 email: mindaugas.mozuras@gmail.com
 executables: []
 extensions: []
@@ -94,6 +94,8 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
+- ".github/CODEOWNERS"
+- ".github/workflows/checks.yml"
 - LICENSE
 - README.md
 - lib/pronto/reek.rb
@@ -103,7 +105,7 @@ homepage: http://github.com/mmozuras/pronto-reek
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -118,8 +120,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
-signing_key: 
+rubygems_version: 3.0.9
+signing_key:
 specification_version: 4
 summary: Pronto runner for Reek, code smell detector for Ruby
 test_files: []