pronto-rails_migrations_annotated 0.0.3 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88430fc4dc1457f81ee58ddbb791363370cb6e85fcd6ffe17b504717a637d5de
-  data.tar.gz: e7f1c20a1f124f27506cb1494d756d1ab314cd9217ce075e68e7a42842380030
+  metadata.gz: e35554920a786374696461d01c168c4ca1402367fac9a70a5b7773d0319fdaea
+  data.tar.gz: 58b72c0c38bd9c18c10d336ebb71da9571f6cb04e728ef4c1eabeddb7a321c83
 SHA512:
-  metadata.gz: 0f56e324b56c92ef3e2957bd39a6dba969e6fa4748bf8acadc1e077288cf0abb882b6e30b9c7c1f9a6d4d0a73b2be713a344e66c8c2d5aee667e7e6dd379f21d
-  data.tar.gz: a9f3ebffd0dd50bc1549d669069cc27a0f3cd67dc0064d428c03f1adffcd0d58df885485e4b9458dbb0c95a8a244e4dc479fbffbb7b2ea169742a73e7b7db5ad
+  metadata.gz: f2b895e654cf9b9b170d344093615014760d9fe377fedf8ccadf65c13817a5ce7fb7d9ea0a4d2e2ff9343e3ba366b53555614a6f36405ec1ff1f16ed652142d6
+  data.tar.gz: 86b29d8e6fc2783fdb70311d0613ce673db46af9f0934cbcb7ec321665f0651ccef4b673f0d059c043a2574ebe5d349be379b2d417aa6f04b8826d1f8bd1ef77

data/Gemfile.lock

@@ -1,49 +1,33 @@
 PATH
   remote: .
   specs:
-    pronto-rails_migrations_annotated (0.0.3)
+    pronto-rails_migrations_annotated (0.0.5)
       pronto (~> 0.11)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.8.0)
-      public_suffix (>= 2.0.2, < 5.0)
+    addressable (2.8.1)
+      public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
     diff-lcs (1.4.4)
-    faraday (1.8.0)
-      faraday-em_http (~> 1.0)
-      faraday-em_synchrony (~> 1.0)
-      faraday-excon (~> 1.1)
-      faraday-httpclient (~> 1.0.1)
-      faraday-net_http (~> 1.0)
-      faraday-net_http_persistent (~> 1.1)
-      faraday-patron (~> 1.0)
-      faraday-rack (~> 1.0)
-      multipart-post (>= 1.2, < 3)
+    faraday (2.5.2)
+      faraday-net_http (>= 2.0, < 3.1)
       ruby2_keywords (>= 0.0.4)
-    faraday-em_http (1.0.0)
-    faraday-em_synchrony (1.0.0)
-    faraday-excon (1.1.0)
-    faraday-httpclient (1.0.1)
-    faraday-net_http (1.0.1)
-    faraday-net_http_persistent (1.2.0)
-    faraday-patron (1.0.0)
-    faraday-rack (1.0.0)
-    gitlab (4.17.0)
-      httparty (~> 0.18)
-      terminal-table (~> 1.5, >= 1.5.1)
+    faraday-net_http (3.0.0)
+    gitlab (4.19.0)
+      httparty (~> 0.20)
+      terminal-table (>= 1.5.1)
     httparty (0.20.0)
       mime-types (~> 3.0)
       multi_xml (>= 0.5.2)
     mime-types (3.4.1)
       mime-types-data (~> 3.2015)
-    mime-types-data (3.2021.1115)
+    mime-types-data (3.2022.0105)
     multi_xml (0.6.0)
-    multipart-post (2.1.1)
-    octokit (4.21.0)
-      faraday (>= 0.9)
-      sawyer (~> 0.8.0, >= 0.5.3)
+    octokit (4.25.1)
+      faraday (>= 1, < 3)
+      sawyer (~> 0.9)
     parallel (1.21.0)
     parser (3.0.2.0)
       ast (~> 2.4.1)
@@ -55,7 +39,7 @@ GEM
       rexml (~> 3.2)
       rugged (>= 0.23.0, < 1.1.0)
       thor (>= 0.20.3, < 2.0)
-    public_suffix (4.0.6)
+    public_suffix (5.0.0)
     rainbow (3.0.0)
     rake (13.0.6)
     regexp_parser (2.1.1)
@@ -94,12 +78,12 @@ GEM
     ruby-progressbar (1.11.0)
     ruby2_keywords (0.0.5)
     rugged (1.0.1)
-    sawyer (0.8.2)
+    sawyer (0.9.2)
       addressable (>= 2.3.5)
-      faraday (> 0.8, < 2.0)
-    terminal-table (1.8.0)
-      unicode-display_width (~> 1.1, >= 1.1.1)
-    thor (1.1.0)
+      faraday (>= 0.17.3, < 3)
+    terminal-table (3.0.2)
+      unicode-display_width (>= 1.1.1, < 3)
+    thor (1.2.1)
     unicode-display_width (1.8.0)
 
 PLATFORMS
@@ -115,4 +99,4 @@ DEPENDENCIES
   rubocop-rspec
 
 BUNDLED WITH
-   2.2.31
+   2.3.10

data/lib/pronto/rails_migrations_annotated/version.rb

@@ -2,6 +2,6 @@
 
 module Pronto
   module RailsMigrationsAnnotatedVersion
-    VERSION = "0.0.3"
+    VERSION = "0.0.5"
   end
 end

data/lib/pronto/rails_migrations_annotated.rb

@@ -97,7 +97,7 @@ module Pronto
     end
 
     def check_structure_migration_version_numbers
-      return unless migration_patches.any?
+      # return unless migration_patches.any?
 
       structure_file_name = "db/structure.sql"
       return if !File.exist?(structure_file_name) || gitignored?(structure_file_name)
@@ -108,7 +108,7 @@ module Pronto
       check_structure_versions_present(versions_from_schema)
       check_structure_migration_missing
 
-      check_structure_versions_syntax(versions_from_schema)
+      check_structure_versions_syntax(versions_from_schema) if versions_from_schema.any?
       check_structure_versions_sorted(versions_from_schema)
       check_structure_ending(structure_file_lines)
     end
@@ -129,14 +129,22 @@ module Pronto
 
     def check_structure_migration_missing
       structure_patches.each do |patch|
+        next if patch.delta.old_file[:oid] == "0000000000000000000000000000000000000000" # new structure.sql file
+
+        triggered = false
         patch.added_lines.select { |line| line.content.match?(migration_line_regex) }.each do |line|
           version = line.content.match(migration_line_regex)[:version]
           next if migration_version_numbers.include?(version)
-          next if line.content.end_with?(",") &&
+          next if line.content.end_with?(",\n") &&
                   patch.deleted_lines.any? { |del| del.content.include?("#{version}');") }
 
+          triggered = true
           add_message_at_patch(patch, "Migration #{version} is not present in this changeset", :error, line: line)
         end
+
+        if !triggered && migration_version_numbers.none?
+          add_message_at_patch(patch, "structure.sql changed without migrations", :error, line: patch.lines.first)
+        end
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto-rails_migrations_annotated
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.5
 platform: ruby
 authors:
 - Vasily Fedoseyev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-15 00:00:00.000000000 Z
+date: 2022-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pronto
@@ -64,7 +64,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.9
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Pronto runner to check rails migrations to be separate from other code, but