pronto-rails_migrations 0.10.0 → 0.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c14def6d1a703c9074387da0c4398291c423d1094cb2a47772fc6da38772962b
-  data.tar.gz: 57bd0237d5f8bc2c66386afbaaca71be7bb8aca1e7c292008f1c62245558c939
+  metadata.gz: 8759567be612ea98f5a55432236144a570fb0d577a94669a97544b214e21cd56
+  data.tar.gz: 70de473bffef3c43636888990c98c4d7089d09a7b7afc88dc1ecb97ffda11a39
 SHA512:
-  metadata.gz: 5d1f9576333d4384d6b9c4604effe89df5d760ffe5bf023fa71615d84e277692c525df86826eb37afbefe09df997d93291d39b8e162bf669153da9dd4117f6ab
-  data.tar.gz: da86a5d3346f79af9cd556f93974b3f8e3138477a770ec9b79f2192732f19a218ea3a46902b47a316004699084748b3b89206f4f4a4df418b53ff29a40331fbf
+  metadata.gz: 0b8298cff6bffcbe03b1d9dbe07e7927bca866dbfebb879a793da4c141ebf04ace7d11b6a5da506d2747368292de7c64a42cb81305f5199feb73832d756f1f25
+  data.tar.gz: 80a5db5dd0a0f7f6abee5724902142179b5104ff49c13eaf4c7ab8ce02e13e63c0dd6499ff597ec9aa316af467aa615803eb718df8a51f1529029b7201a533ca

data/.ruby-version

@@ -0,0 +1 @@
+2.6.3

data/lib/pronto/rails_migrations.rb

@@ -1,20 +1,19 @@
 module Pronto
   class RailsMigrations < Runner
     def run
-      if migration_patches? && other_patches?
-        migration_patches.take(1).map do |patch|
-          Message.new(
-            patch.delta.new_file[:path],
-            nil,
-            :warning,
-            "Run migrations in a separate PR from application code changes.",
-            nil,
-            self.class
-          )
-        end
-      else
-        []
+      return [] unless migration_patches?
+
+      messages = []
+
+      if other_patches?
+        patch = migration_patches.first
+        messages << message(
+          patch.delta.new_file[:path],
+          'Run migrations in a separate PR from application code changes.'
+        )
       end
+
+      messages + bad_structure_sql_messages
     end
 
     private
@@ -31,6 +30,48 @@ module Pronto
       @patches.reject { |patch| migration_patch?(patch) }.any?
     end
 
+    def bad_structure_sql_messages
+      patch = structure_sql_patches.first
+      return false unless patch
+
+      path = patch.delta.new_file[:path]
+      structure_sql = File.read(patch.new_file_full_path)
+      inserts = structure_sql.split("\n").grep(/\('\d+'\)/)
+      unordered_inserts = (inserts.sort != inserts)
+
+      *all_but_tail, tail = inserts
+      bad_semicolons = all_but_tail.any? { |line| line.end_with?(';') } || !tail.end_with?(';')
+
+      bad_ending = structure_sql[-4, 4] !~ /[^\n]\n\n\n/
+
+      messages = []
+
+      if unordered_inserts
+        messages << message(
+          path,
+          '`schema_migrations` insert values are not ordered by timestamp.'
+        )
+      end
+      if bad_semicolons
+        messages << message(
+          path,
+          '`schema_migrations` inserts must end with comma (`,`), ' \
+          'last insert must end with semicolon (`;`).'
+        )
+      end
+      messages << message(path, '`db/structure.sql` must end with 2 empty lines.') if bad_ending
+
+      messages
+    end
+
+    def message(path, text)
+      Message.new(path, nil, :warning, text, nil, self.class)
+    end
+
+    def structure_sql_patches
+      @patches.select { |patch| patch.new_file_full_path.to_s =~ /structure\.sql/ }
+    end
+
     def migration_patch?(patch)
       path = patch.new_file_full_path.to_s
       /db.(schema.rb|structure.sql|migrate)/ =~ path

data/pronto-rails_migrations.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "pronto-rails_migrations"
-  spec.version       = '0.10.0'
+  spec.version       = '0.10.1'
   spec.authors       = ["Tomas Varneckas"]
   spec.email         = ["t.varneckas@gmail.com"]
 
@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency('pronto', '~> 0.10.0')
+  spec.add_dependency('pronto', '>= 0.10.0')
 
   spec.add_development_dependency "bundler", ">= 1.15"
   spec.add_development_dependency "rake", "~> 12.0"

metadata

@@ -1,27 +1,27 @@
 --- !ruby/object:Gem::Specification
 name: pronto-rails_migrations
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.10.1
 platform: ruby
 authors:
 - Tomas Varneckas
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-01-08 00:00:00.000000000 Z
+date: 2020-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pronto
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.10.0
 - !ruby/object:Gem::Dependency
@@ -61,6 +61,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".ruby-version"
 - Gemfile
 - LICENSE.txt
 - README.md