pronto-rails_migrations 0.1.0 → 0.10.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5e850ca57e2901b7fc788ca92285c2449a219f48
-  data.tar.gz: dc8e697c7d853da449f687a70ae88b9742f46129
+SHA256:
+  metadata.gz: 5cefbfc63cd234afd1eb5341b765f25b716d95e4b219abd8cada9591bdf5d885
+  data.tar.gz: 76f016c3ddc9f11e8d18a13f4056babdcbb65a734290e4399e765711bfb02697
 SHA512:
-  metadata.gz: 7c65b3edc2a96696fe15e5d242b0cbf7415da394630a983d9204335b21e20469a8ed565bfa813dc6d3ef0323a7913db9f677b6d85f6a06cdd2b34844938f666d
-  data.tar.gz: 6b3414d5a73f6707ec690ad7b78db2ce176eb5a3e52c1f809d993f6785b39404b6dc8e3e2600da1fae508bd7c1d40c231347ebae13fd79d9063101cf66756e5c
+  metadata.gz: 6a9c17485cc28c461c0a3d9be9050c34c39e3a4b9d61eac3fd24980458f4deb3c26af69ad32efdecb62418c4fb389232149cfdf515dad17d383f39b6f873e547
+  data.tar.gz: 9233b1af3c14348186ebd2fdeffde3805fe011a65ce8df4894c639770fb895ba66f3bc2c0b1ff0c1a9f3dee0cb066d5854854df4be4db91ac36f285ff45972c6

data/.github/workflows/build_release_pipeline.yaml

@@ -0,0 +1,51 @@
+name: Build and release ruby gem
+
+on:
+  pull_request: 
+    branches: [ master ]
+  push:
+  workflow_dispatch:
+
+jobs:
+  build-release-pipeline:
+    runs-on: ubuntu-latest
+    container: ruby:2.7.2
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup
+        run: |
+          apt-get update -y && apt-get install -y --no-install-recommends cmake=3.13.4-1
+          gem install bundler
+          bundle install
+
+      - name: Build
+        id: build
+        if: success() && github.ref == 'refs/heads/master'
+        run: |
+          bundle exec rake build
+          echo "::set-output name=gem_version::v$(bundle exec rake version)"
+
+      - name: Release
+        if: success() && github.ref == 'refs/heads/master'
+        run: |
+          mkdir -p $HOME/.gem
+          touch $HOME/.gem/credentials
+          chmod 600 $HOME/.gem/credentials
+          printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+          gem push pkg/*
+        env:
+          GEM_HOST_API_KEY: "${{ secrets.RUBYGEMS_AUTH_TOKEN }}"
+
+      - name: Tag repo with new gem version
+        if: success() && github.ref == 'refs/heads/master'
+        uses: actions/github-script@v3
+        with:
+          github-token: ${{ github.token }}
+          script: |
+            github.git.createRef({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              ref: "refs/tags/${{ steps.build.outputs.gem_version }}",
+              sha: context.sha
+            })
+            

data/.ruby-version

@@ -0,0 +1 @@
+2.7.2

data/Gemfile

@@ -1,6 +1,4 @@
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
-
 # Specify your gem's dependencies in pronto-rails_migrations.gemspec
 gemspec

data/README.md

@@ -1,39 +1,19 @@
 # Pronto::RailsMigrations
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/pronto/rails_migrations`. To experiment with that code, run `bin/console` for an interactive prompt.
-
-TODO: Delete this and the text above, and describe your gem
+This pronto runner warns when migrations are run and application code is changed at the same time.
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'pronto-rails_migrations'
+gem 'pronto-rails_migrations', require: false
 ```
 
 And then execute:
 
     $ bundle
 
-Or install it yourself as:
-
-    $ gem install pronto-rails_migrations
-
-## Usage
-
-TODO: Write usage instructions here
-
-## Development
-
-After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
-
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
-
-## Contributing
-
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/pronto-rails_migrations.
-
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/Rakefile

@@ -1,2 +1,7 @@
 require "bundler/gem_tasks"
+
 task :default => :spec
+
+task :version do |t|
+  puts Pronto::RailsMigrations::VERSION
+end

data/lib/pronto/rails_migrations.rb

@@ -1,20 +1,19 @@
 module Pronto
   class RailsMigrations < Runner
     def run
-      if migration_patches? && other_patches?
-        migration_patches.take(1).map do |patch|
-          Message.new(
-            patch.delta.new_file[:path],
-            nil,
-            :warning,
-            "Run migrations in a separate PR from application code changes.",
-            nil,
-            self.class
-          )
-        end
-      else
-        []
+      return [] unless migration_patches?
+
+      messages = []
+
+      if other_patches?
+        patch = migration_patches.first
+        messages << message(
+          patch,
+          'Run migrations in a separate PR from application code changes.'
+        )
       end
+
+      messages + bad_structure_sql_messages
     end
 
     private
@@ -31,6 +30,49 @@ module Pronto
       @patches.reject { |patch| migration_patch?(patch) }.any?
     end
 
+    def bad_structure_sql_messages
+      patch = structure_sql_patches.first
+      return [] unless patch
+
+      structure_sql = File.read(patch.new_file_full_path)
+      inserts = structure_sql.split("\n").grep(/\('\d+'\)/)
+      unordered_inserts = (inserts.sort != inserts)
+
+      *all_but_tail, tail = inserts
+      bad_semicolons = all_but_tail.any? { |line| line.end_with?(';') } || !tail.end_with?(';')
+
+      bad_ending = structure_sql[-4, 4] !~ /[^\n]\n\n\n/
+
+      messages = []
+
+      if unordered_inserts
+        messages << message(
+          patch,
+          '`schema_migrations` insert values are not ordered by timestamp.'
+        )
+      end
+      if bad_semicolons
+        messages << message(
+          patch,
+          '`schema_migrations` inserts must end with comma (`,`), ' \
+          'last insert must end with semicolon (`;`).'
+        )
+      end
+      messages << message(patch, '`db/structure.sql` must end with 2 empty lines.') if bad_ending
+
+      messages
+    end
+
+    def message(patch, text)
+      path = patch.delta.new_file[:path]
+      line = patch.added_lines.first
+      Message.new(path, line, :warning, text, nil, self.class)
+    end
+
+    def structure_sql_patches
+      @patches.select { |patch| patch.new_file_full_path.to_s =~ /structure\.sql/ }
+    end
+
     def migration_patch?(patch)
       path = patch.new_file_full_path.to_s
       /db.(schema.rb|structure.sql|migrate)/ =~ path

data/lib/pronto/version.rb

@@ -0,0 +1,5 @@
+module Pronto
+  class RailsMigrations
+    VERSION = '0.10.4'
+  end
+end

data/pronto-rails_migrations.gemspec

@@ -1,12 +1,13 @@
 # coding: utf-8
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'pronto/version'
 
 Gem::Specification.new do |spec|
   spec.name          = "pronto-rails_migrations"
-  spec.version       = '0.1.0'
-  spec.authors       = ["Tomas Varneckas"]
-  spec.email         = ["t.varneckas@gmail.com"]
+  spec.version       = Pronto::RailsMigrations::VERSION
+  spec.authors       = ["Vinted"]
+  spec.email         = ["backend@vinted.com"]
 
   spec.summary       = %q{Validate migration and application code change seperation}
   spec.description   = %q{This pronto runner warns when migrations are run and application code is changed at the same time}
@@ -20,8 +21,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency('pronto', '~> 0.9.0')
+  spec.add_dependency('pronto', '>= 0.10.0')
 
-  spec.add_development_dependency "bundler", "~> 1.15"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rake", "~> 12.0"
 end

metadata

@@ -1,66 +1,68 @@
 --- !ruby/object:Gem::Specification
 name: pronto-rails_migrations
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.10.4
 platform: ruby
 authors:
-- Tomas Varneckas
+- Vinted
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-10-03 00:00:00.000000000 Z
+date: 2021-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pronto
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
 description: This pronto runner warns when migrations are run and application code
   is changed at the same time
 email:
-- t.varneckas@gmail.com
+- backend@vinted.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/build_release_pipeline.yaml"
 - ".gitignore"
+- ".ruby-version"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -68,6 +70,7 @@ files:
 - bin/console
 - bin/setup
 - lib/pronto/rails_migrations.rb
+- lib/pronto/version.rb
 - pronto-rails_migrations.gemspec
 homepage: https://github.com/tomasv/pronto-rails_migrations
 licenses:
@@ -88,8 +91,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Validate migration and application code change seperation