pronto-foodcritic 0.8.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 07bb1e1cdb144351e9fb41dc93b6946e9929b68c
-  data.tar.gz: f3585a275cd2eb7807572be6d086537402f9ac0f
+SHA256:
+  metadata.gz: 705d781bf92a42d5435cfd6b81ba1c7e6a1a84cdab215388ce65d18554a1c213
+  data.tar.gz: 4352eb684c8a4f778334f3bce543df239319f126a53d6254b69939ee73ef2afc
 SHA512:
-  metadata.gz: fd8ddde07b604f3b71f7db50be73493e765d9f4046a8d98d09466b6e4b69f353d255e363c766608be73ee1211a8747193219a206cdc95fccf3b4167599094e48
-  data.tar.gz: bb2b70f79b59efdeeda024954231dc990d8d868f6293a843d298559ddf72b47ca01e0b07d9ab70c7c0de721072e5911e3ea5050ec58f16550b86910a1e800665
+  metadata.gz: 5167e5cbca5bc798efb4f472b3f43a435bd1272edfeb1cc19d04065f2872e2afb83d46e097c79d569ebc09295eea059195a6c626618a24f9d60ae2e858fac99a
+  data.tar.gz: a635b03ed8878b0ebf828e7a27e7039563f5a6b380782bcc958a40b8235d969c72977b113c39bf9f4bf88ec33de8887157be62d06641c5de266f2614b60112a1

data/.github/CODEOWNERS

@@ -0,0 +1,3 @@
+# Order is important. The last matching pattern takes the most precedence.
+# Default owners for everything in the repo.
+* @prontolabs/core

data/.github/workflows/checks.yml

@@ -0,0 +1,22 @@
+name: Checks
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  ruby:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ['2.3', '2.4', '2.5', '2.6', '2.7', '3.0']
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+    - name: rake spec
+      run: bundle exec rake spec

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+
+## 0.11.0
+
+### Changes
+
+* Add Foodcritic options rule_file, search_gems and include_rules, allows to customize CI with custom ignores and Foodcritic rules.
+* Add exclude option to ignore Foodcritic linter.
+
 ## 0.2.2
 
 ### Bugs fixed

data/README.md

@@ -1,12 +1,33 @@
 # Pronto runner for Food Critic
 
 [![Code Climate](https://codeclimate.com/github/mmozuras/pronto-foodcritic.png)](https://codeclimate.com/github/mmozuras/pronto-foodcritic)
-[![Build Status](https://travis-ci.org/mmozuras/pronto-foodcritic.png)](https://travis-ci.org/mmozuras/pronto-foodcritic)
+[![Build Status](https://secure.travis-ci.org/mmozuras/pronto-foodcritic.svg)](http://travis-ci.org/mmozuras/pronto-foodcritic)
 [![Gem Version](https://badge.fury.io/rb/pronto-foodcritic.png)](http://badge.fury.io/rb/pronto-foodcritic)
 [![Dependency Status](https://gemnasium.com/mmozuras/pronto-foodcritic.png)](https://gemnasium.com/mmozuras/pronto-foodcritic)
 
 Pronto runner for [Food Critic](https://github.com/acrmp/foodcritic), lint tool for chef. [What is Pronto?](https://github.com/mmozuras/pronto)
 
+## Configuration
+
+You can provide several Food Critic options via `.pronto.yml`:
+
+```yml
+foodcritic:
+  # Like CLI option --search-gems
+  search_gems: true
+
+  # Like CLI option --include, add custom rules to your CI
+  include_rules:
+    - lib/foodcritic/rules
+
+  # Like CLI option --rule-file
+  rule_file: .foodcritic-ci
+
+  # File GLOBs to ignore, matching files won't be passed to Food Critic
+  exclude:
+    - '**/test/integration/**/*_spec.rb'
+```
+
 ## Note
 
 Currently, naively uses path to determine if a file is a cookbook or a role configuration.

data/lib/pronto/foodcritic.rb

@@ -7,7 +7,7 @@ module Pronto
       return [] if paths[:cookbook_paths].none? && paths[:role_paths].none?
 
       @linter = ::FoodCritic::Linter.new
-      @linter.check(paths).warnings.flat_map do |warning|
+      @linter.check(options).warnings.flat_map do |warning|
         ruby_patches.select { |patch| patch.new_file_full_path.to_s == warning.match[:filename] }
           .flat_map(&:added_lines)
           .select { |line| line.new_lineno == warning.match[:line] }
@@ -15,11 +15,22 @@ module Pronto
       end
     end
 
+    def options
+      @options ||= begin
+        result = {}.merge(paths)
+        result[:rule_file] = foodcritic_rule_file if foodcritic_rule_file
+        result[:search_gems] = foodcritic_search_gems if foodcritic_search_gems
+        result[:include_rules] = Array(foodcritic_include_rules)
+        result
+      end
+    end
+
     def paths
       @paths ||= begin
         result = { cookbook_paths: [], role_paths: [] }
         ruby_patches.each do |patch|
           path = patch.new_file_full_path.to_s
+          next if foodcritic_exclude.any? { |r| File.fnmatch(r, path) }
           if path.include?('cookbook')
             result[:cookbook_paths] << path
           elsif path.include?('role')
@@ -35,5 +46,26 @@ module Pronto
       message = "#{warning.rule.code} - #{warning.rule.name}"
       Message.new(path, line, :warning, message, nil, self.class)
     end
+
+    def pronto_foodcritic_config
+      @pronto_foodcritic_config ||= Pronto::ConfigFile.new.to_h['foodcritic'] || {}
+    end
+
+    def foodcritic_search_gems
+      pronto_foodcritic_config.fetch('search_gems', nil)
+    end
+
+    def foodcritic_rule_file
+      pronto_foodcritic_config.fetch('rule_file', nil)
+    end
+
+    def foodcritic_include_rules
+      pronto_foodcritic_config.fetch('include_rules', [])
+    end
+
+    def foodcritic_exclude
+      Array(pronto_foodcritic_config.fetch('exclude', []))
+    end
+
   end
 end

data/lib/pronto/foodcritic/version.rb

@@ -1,5 +1,5 @@
 module Pronto
   module FoodCriticVersion
-    VERSION = '0.8.0'.freeze
+    VERSION = '0.11.0'.freeze
   end
 end

data/pronto-foodcritic.gemspec

@@ -10,11 +10,11 @@ Gem::Specification.new do |s|
   s.platform = Gem::Platform::RUBY
   s.author = 'Mindaugas Mozūras'
   s.email = 'mindaugas.mozuras@gmail.com'
-  s.homepage = 'http://github.org/mmozuras/pronto-foodcritic'
+  s.homepage = 'http://github.com/mmozuras/pronto-foodcritic'
   s.summary = 'Pronto runner for Food Critic, lint tool for chef'
 
   s.licenses = ['MIT']
-  s.required_ruby_version = '>= 2.0.0'
+  s.required_ruby_version = '>= 2.3.0'
   s.rubygems_version = '1.8.23'
 
   s.files = `git ls-files`.split($RS).reject do |file|
@@ -32,9 +32,9 @@ Gem::Specification.new do |s|
   s.extra_rdoc_files = ['LICENSE', 'README.md']
   s.require_paths = ['lib']
 
-  s.add_dependency('foodcritic', '~> 5', '>= 5.0.0')
-  s.add_dependency('pronto', '~> 0.8.0')
-  s.add_development_dependency('rake', '~> 11.0')
+  s.add_dependency('foodcritic', '~> 15', '>= 10.0.0')
+  s.add_dependency('pronto', '~> 0.11.0')
+  s.add_development_dependency('rake', '~> 12.0')
   s.add_development_dependency('rspec', '~> 3.4')
   s.add_development_dependency('rspec-its', '~> 1.2')
 end

metadata

@@ -1,63 +1,63 @@
 --- !ruby/object:Gem::Specification
 name: pronto-foodcritic
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Mindaugas Mozūras
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-12 00:00:00.000000000 Z
+date: 2021-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foodcritic
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 10.0.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 10.0.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '15'
 - !ruby/object:Gem::Dependency
   name: pronto
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.11.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: 0.11.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +94,8 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
+- ".github/CODEOWNERS"
+- ".github/workflows/checks.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - LICENSE
@@ -101,7 +103,7 @@ files:
 - lib/pronto/foodcritic.rb
 - lib/pronto/foodcritic/version.rb
 - pronto-foodcritic.gemspec
-homepage: http://github.org/mmozuras/pronto-foodcritic
+homepage: http://github.com/mmozuras/pronto-foodcritic
 licenses:
 - MIT
 metadata: {}
@@ -113,15 +115,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Pronto runner for Food Critic, lint tool for chef