pronto-foodcritic 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6e5598d30e1988f2b14ce5d02cbab0f0a410a8762821dfdf6536735a44429d2
-  data.tar.gz: d3daaa8307ba8e71bfa61be8444992f670c231c92926f1fbcbe13f6990111adc
+  metadata.gz: 705d781bf92a42d5435cfd6b81ba1c7e6a1a84cdab215388ce65d18554a1c213
+  data.tar.gz: 4352eb684c8a4f778334f3bce543df239319f126a53d6254b69939ee73ef2afc
 SHA512:
-  metadata.gz: f871a8dcf599975811b344b2d4effe1e4ed1ee9e4c31f31974b51d8699de3bb05b5dc93879147f833db7ad54b7a60b61d20909c56cf865b5e5e89bda3aea3af9
-  data.tar.gz: 132e9c8861597cbf7b778d455b351df2bb37e8ea37d56943c2c1395f2e1d81166ab21c917023196db87e21381851483fd9d1b58798c4852dd0b855a039d39629
+  metadata.gz: 5167e5cbca5bc798efb4f472b3f43a435bd1272edfeb1cc19d04065f2872e2afb83d46e097c79d569ebc09295eea059195a6c626618a24f9d60ae2e858fac99a
+  data.tar.gz: a635b03ed8878b0ebf828e7a27e7039563f5a6b380782bcc958a40b8235d969c72977b113c39bf9f4bf88ec33de8887157be62d06641c5de266f2614b60112a1

data/.github/CODEOWNERS

@@ -0,0 +1,3 @@
+# Order is important. The last matching pattern takes the most precedence.
+# Default owners for everything in the repo.
+* @prontolabs/core

data/.github/workflows/checks.yml

@@ -0,0 +1,22 @@
+name: Checks
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  ruby:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ['2.3', '2.4', '2.5', '2.6', '2.7', '3.0']
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+    - name: rake spec
+      run: bundle exec rake spec

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+
+## 0.11.0
+
+### Changes
+
+* Add Foodcritic options rule_file, search_gems and include_rules, allows to customize CI with custom ignores and Foodcritic rules.
+* Add exclude option to ignore Foodcritic linter.
+
 ## 0.2.2
 
 ### Bugs fixed

data/README.md

@@ -7,6 +7,27 @@
 
 Pronto runner for [Food Critic](https://github.com/acrmp/foodcritic), lint tool for chef. [What is Pronto?](https://github.com/mmozuras/pronto)
 
+## Configuration
+
+You can provide several Food Critic options via `.pronto.yml`:
+
+```yml
+foodcritic:
+  # Like CLI option --search-gems
+  search_gems: true
+
+  # Like CLI option --include, add custom rules to your CI
+  include_rules:
+    - lib/foodcritic/rules
+
+  # Like CLI option --rule-file
+  rule_file: .foodcritic-ci
+
+  # File GLOBs to ignore, matching files won't be passed to Food Critic
+  exclude:
+    - '**/test/integration/**/*_spec.rb'
+```
+
 ## Note
 
 Currently, naively uses path to determine if a file is a cookbook or a role configuration.

data/lib/pronto/foodcritic.rb

@@ -7,7 +7,7 @@ module Pronto
       return [] if paths[:cookbook_paths].none? && paths[:role_paths].none?
 
       @linter = ::FoodCritic::Linter.new
-      @linter.check(paths).warnings.flat_map do |warning|
+      @linter.check(options).warnings.flat_map do |warning|
         ruby_patches.select { |patch| patch.new_file_full_path.to_s == warning.match[:filename] }
           .flat_map(&:added_lines)
           .select { |line| line.new_lineno == warning.match[:line] }
@@ -15,11 +15,22 @@ module Pronto
       end
     end
 
+    def options
+      @options ||= begin
+        result = {}.merge(paths)
+        result[:rule_file] = foodcritic_rule_file if foodcritic_rule_file
+        result[:search_gems] = foodcritic_search_gems if foodcritic_search_gems
+        result[:include_rules] = Array(foodcritic_include_rules)
+        result
+      end
+    end
+
     def paths
       @paths ||= begin
         result = { cookbook_paths: [], role_paths: [] }
         ruby_patches.each do |patch|
           path = patch.new_file_full_path.to_s
+          next if foodcritic_exclude.any? { |r| File.fnmatch(r, path) }
           if path.include?('cookbook')
             result[:cookbook_paths] << path
           elsif path.include?('role')
@@ -35,5 +46,26 @@ module Pronto
       message = "#{warning.rule.code} - #{warning.rule.name}"
       Message.new(path, line, :warning, message, nil, self.class)
     end
+
+    def pronto_foodcritic_config
+      @pronto_foodcritic_config ||= Pronto::ConfigFile.new.to_h['foodcritic'] || {}
+    end
+
+    def foodcritic_search_gems
+      pronto_foodcritic_config.fetch('search_gems', nil)
+    end
+
+    def foodcritic_rule_file
+      pronto_foodcritic_config.fetch('rule_file', nil)
+    end
+
+    def foodcritic_include_rules
+      pronto_foodcritic_config.fetch('include_rules', [])
+    end
+
+    def foodcritic_exclude
+      Array(pronto_foodcritic_config.fetch('exclude', []))
+    end
+
   end
 end

data/lib/pronto/foodcritic/version.rb

@@ -1,5 +1,5 @@
 module Pronto
   module FoodCriticVersion
-    VERSION = '0.10.0'.freeze
+    VERSION = '0.11.0'.freeze
   end
 end

data/pronto-foodcritic.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
 
   s.add_dependency('foodcritic', '~> 15', '>= 10.0.0')
-  s.add_dependency('pronto', '~> 0.10.0')
+  s.add_dependency('pronto', '~> 0.11.0')
   s.add_development_dependency('rake', '~> 12.0')
   s.add_development_dependency('rspec', '~> 3.4')
   s.add_development_dependency('rspec-its', '~> 1.2')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pronto-foodcritic
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Mindaugas Mozūras
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-03 00:00:00.000000000 Z
+date: 2021-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foodcritic
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.0
+        version: 0.11.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.0
+        version: 0.11.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +94,8 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
+- ".github/CODEOWNERS"
+- ".github/workflows/checks.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - LICENSE
@@ -120,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Pronto runner for Food Critic, lint tool for chef