pronto-clang_tidy 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 912e8cbd46b44243e4e4b8826fdd92a3b5188bd34a7308249182546e317df741
-  data.tar.gz: 3f01a9758d7c41795a9dcc92bbd340399eeef9fa582fa40151721fcc4828e26d
+  metadata.gz: d865f961b636a9321c454a5718344dad214de056235732b3f4f828c1bcec9774
+  data.tar.gz: 0cb9023bc1eca7ae743da51b6456c0b856f256df28def4e683384c899dde7880
 SHA512:
-  metadata.gz: 6e80c9ea8d9eb51df711ed959709e7354b31067222e4016ee332657a2143a729839f93de88571d71f7a147362d2f02fd7a99a6ea8d2822f5b8376ef5eaaff6c0
-  data.tar.gz: 94faf438e390e41c506535442307631b1e39219e42708875cd9422440ad6ffee3fbd200685a1fcd9af6239c919e2d58ba8f099e0481da0e0e2280c38de062178
+  metadata.gz: ffe3a8d8e97596c6f0b78c0955464f3cb77178b467291c949594ad1c6e444117a70de2f44231f28f462a60dd49f58c71268599bd4a844bb6b2c3081694c1a4b0
+  data.tar.gz: '095f28f9fed2eda0669cc6dd5d6a56d5476253ea7e31df1457a86a46852ae7648467402ba300a2914be0e666d07f5fede3c1c8ff23126e91809dc5cf3012147f'

data/lib/pronto/clang_tidy/version.rb

@@ -1,5 +1,5 @@
 module Pronto
   module ClangTidy
-    VERSION = '0.1.0'.freeze
+    VERSION = '0.1.1'.freeze
   end
 end

data/lib/pronto/clang_tidy.rb

@@ -4,23 +4,31 @@ require 'pronto'
 module Pronto
   class ClangTidyRunner < Runner
     def run
-      return [] if !@patches || @patches.count.zero?
-      # loop through all offences in clang-tidy output
       offences = read_clang_tidy_output
-      return [] if !offences || offences.length.zero?
+      return [] if no_patches? || offences.length.zero?
+      # loop through all offences in clang-tidy output
       offences.map do |offence|
         # find the patch that corresponds to the current offence
         patch = patch_for(offence.file)
         next if patch.nil?
         # generate a message for the corresponding added_line in the patch
-        patch.added_lines
-             .select { |added_line| added_line.new_lineno == offence.lineno }
-             .map { |line| new_message(offence, line) }
+        message_for(patch, offence)
       end.flatten.compact
     end
 
     private
 
+    def message_for(patch, offence)
+      line = patch.added_lines.find do |added_line|
+        added_line.new_lineno == offence.lineno
+      end
+      new_message(offence, line) unless line.nil?
+    end
+
+    def no_patches?
+      !@patches || @patches.count.zero?
+    end
+
     def patch_for(filename)
       @patches.find do |p|
         p.new_file_full_path == Pathname.new(filename)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pronto-clang_tidy
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Michael Jabbour