promoted-ruby-client 2.0.0 → 2.0.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/Gemfile.lock +1 -1
- data/dev.md +1 -1
- data/lib/promoted/ruby/client/version.rb +1 -1
- data/lib/promoted/ruby/client.rb +5 -4
- metadata +1 -1
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 05e28ca6fd30469a610359aa335a16e57f936855fc2db54b8a134fa14a5b8119
|
4
|
+
data.tar.gz: 1a9761eef161f0fb6ff6fe34be49490e99b814bc977530ef1586cdcc52c33a48
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: 171e24016958cd1319d0dce62de4a4f46e9571c40db7085745f0f7d967930947f3b1c6eda31793a98c827cc08837eb19f4a3e26f32a3bde9bb1a31a18d052f6b
|
7
|
+
data.tar.gz: 92589062b4f45c5e93589edd0ff8402027520b0d95c65e86138ec671e04f9d6604d7c3de3d8c58e1ecbf6e2c2f93ec9fe66f4e9208cda47fffee4c7c41514bc8
|
data/Gemfile.lock
CHANGED
data/dev.md
CHANGED
@@ -10,5 +10,5 @@ bundle exec rspec
|
|
10
10
|
2. Get credentials for deployment from 1password.
|
11
11
|
3. Modify `promoted-ruby-client.gemspec`'s push block.
|
12
12
|
4. Run `gem build promoted-ruby-client.gemspec` to generate `gem`.
|
13
|
-
5. Run (using new output) `gem push promoted-ruby-client-2.0.
|
13
|
+
5. Run (using new output) `gem push promoted-ruby-client-2.0.1.gem`
|
14
14
|
6. Update README with new version.
|
data/lib/promoted/ruby/client.rb
CHANGED
@@ -177,22 +177,23 @@ module Promoted
|
|
177
177
|
if should_apply_treatment(cohort_membership_to_log)
|
178
178
|
# Call Delivery API to get insertions to use
|
179
179
|
delivery_request_params = delivery_request_builder.delivery_request_params
|
180
|
+
# Don't send shadow traffic if we've already tried normal traffic.
|
181
|
+
should_send_shadow_traffic = false
|
180
182
|
begin
|
181
183
|
response = send_request(delivery_request_params, @delivery_endpoint, @delivery_timeout_millis, @delivery_api_key, headers)
|
182
184
|
@validator.validate_response!(response)
|
185
|
+
raise ValidationError.new("Response shoul be a Hash") if !response.is_a?(Hash)
|
186
|
+
response_insertions = response && response[:insertion] || []
|
187
|
+
insertions_from_delivery = (response != nil && !deliver_err);
|
183
188
|
rescue StandardError => err
|
184
189
|
# Currently we don't propagate errors to the SDK caller, but rather default to returning
|
185
190
|
# the request insertions.
|
186
191
|
deliver_err = true
|
187
192
|
@logger.error("Error calling delivery: " + err.message) if @logger
|
188
193
|
end
|
189
|
-
should_send_shadow_traffic = false
|
190
194
|
else
|
191
195
|
should_send_shadow_traffic &&= @send_shadow_traffic_for_control
|
192
196
|
end
|
193
|
-
|
194
|
-
insertions_from_delivery = (response != nil && !deliver_err);
|
195
|
-
response_insertions = response && response[:insertion] || []
|
196
197
|
end
|
197
198
|
|
198
199
|
should_send_shadow_traffic &&= should_send_as_shadow_traffic?
|