promoted-ruby-client 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e743a5f01479b23e4e68d12262e93549d58a11540c0cf448fe4316c277422373
-  data.tar.gz: 65b9c38eab75a844783f3595c05bd1ea6f1f668596f46be2ecd3e370b61a551f
+  metadata.gz: 05e28ca6fd30469a610359aa335a16e57f936855fc2db54b8a134fa14a5b8119
+  data.tar.gz: 1a9761eef161f0fb6ff6fe34be49490e99b814bc977530ef1586cdcc52c33a48
 SHA512:
-  metadata.gz: 68c1e692e7e5af9a3deb344fde3cbc0049e8aa6f775d524bc0a6196646e9736cbfdb269fedf4ae83a07ad24cdab94c7140e555709bf046d72530e2f151c252e1
-  data.tar.gz: d0ef6502f473fb279a5a1379234c88f1263d7448d66e7d56cc65794d9d6692826f86e8d4934a69f80aececdf8752c993c96044f9b4146bc02d8721ae2d9dc626
+  metadata.gz: 171e24016958cd1319d0dce62de4a4f46e9571c40db7085745f0f7d967930947f3b1c6eda31793a98c827cc08837eb19f4a3e26f32a3bde9bb1a31a18d052f6b
+  data.tar.gz: 92589062b4f45c5e93589edd0ff8402027520b0d95c65e86138ec671e04f9d6604d7c3de3d8c58e1ecbf6e2c2f93ec9fe66f4e9208cda47fffee4c7c41514bc8

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    promoted-ruby-client (2.0.0)
+    promoted-ruby-client (2.0.1)
       concurrent-ruby (~> 1)
       faraday (>= 0.9.0)
       faraday_middleware (>= 0.9.0)

data/dev.md

@@ -10,5 +10,5 @@ bundle exec rspec
 2. Get credentials for deployment from 1password.
 3. Modify `promoted-ruby-client.gemspec`'s push block.
 4. Run `gem build promoted-ruby-client.gemspec` to generate `gem`.
-5. Run (using new output) `gem push promoted-ruby-client-2.0.0.gem`
+5. Run (using new output) `gem push promoted-ruby-client-2.0.1.gem`
 6. Update README with new version.

data/lib/promoted/ruby/client/version.rb

@@ -1,7 +1,7 @@
 module Promoted
   module Ruby
     module Client
-      VERSION = "2.0.0"
+      VERSION = "2.0.1"
       SERVER_VERSION = "rb." + VERSION
     end
   end

data/lib/promoted/ruby/client.rb

@@ -177,22 +177,23 @@ module Promoted
             if should_apply_treatment(cohort_membership_to_log)
               # Call Delivery API to get insertions to use
               delivery_request_params = delivery_request_builder.delivery_request_params  
+              # Don't send shadow traffic if we've already tried normal traffic.
+              should_send_shadow_traffic = false
               begin
                 response = send_request(delivery_request_params, @delivery_endpoint, @delivery_timeout_millis, @delivery_api_key, headers)
                 @validator.validate_response!(response)
+                raise ValidationError.new("Response shoul be a Hash") if !response.is_a?(Hash)
+                response_insertions = response && response[:insertion] || []
+                insertions_from_delivery = (response != nil && !deliver_err);
               rescue  StandardError => err
                 # Currently we don't propagate errors to the SDK caller, but rather default to returning
                 # the request insertions.
                 deliver_err = true
                 @logger.error("Error calling delivery: " + err.message) if @logger
               end
-              should_send_shadow_traffic = false
             else
               should_send_shadow_traffic &&= @send_shadow_traffic_for_control
             end
-
-            insertions_from_delivery = (response != nil && !deliver_err);
-            response_insertions = response && response[:insertion] || []
           end
 
           should_send_shadow_traffic &&= should_send_as_shadow_traffic?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: promoted-ruby-client
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - scottmcmaster