promoted-ruby-client 2.0.0 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e743a5f01479b23e4e68d12262e93549d58a11540c0cf448fe4316c277422373
-  data.tar.gz: 65b9c38eab75a844783f3595c05bd1ea6f1f668596f46be2ecd3e370b61a551f
+  metadata.gz: 11ce5ae07d4a391a8e052befa249acf77a5e1c2b8bd27af1cc5abb24d011551f
+  data.tar.gz: b2526b7a4b3f2940283c27930a85bcd8e9b469e63c3276271e1ef1d9ffafb096
 SHA512:
-  metadata.gz: 68c1e692e7e5af9a3deb344fde3cbc0049e8aa6f775d524bc0a6196646e9736cbfdb269fedf4ae83a07ad24cdab94c7140e555709bf046d72530e2f151c252e1
-  data.tar.gz: d0ef6502f473fb279a5a1379234c88f1263d7448d66e7d56cc65794d9d6692826f86e8d4934a69f80aececdf8752c993c96044f9b4146bc02d8721ae2d9dc626
+  metadata.gz: ca464c620e04043e7998bc12d9792931fd220b00d8fcfc9a777149a27c6b5b42710409ce48bf43787da346743837f6934df11ce56070bb725ba021c6de1c1908
+  data.tar.gz: 0c3a880b7aa8b8b16523cbe60f75af5ef89849ce5de16a7d19a907aad1429e27a873136d95194fa3b21c4fdc01b663087000e10ae05cb713b638f7b8cbb980b0

data/.github/workflows/push-pull-requests_check.yml

@@ -9,7 +9,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.5.1
+        ruby-version: 3.2.2
         bundler-cache: true
 
     - name: Build and test with rspec

data/Gemfile

@@ -6,7 +6,6 @@ git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 gemspec
 
 group :development do
-    gem 'ruby-debug-ide', group: :development
     gem 'debase', '>= 0.2.5.beta2', group: :development
     gem 'jaro_winkler', group: :development
     gem 'solargraph', group: :development

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    promoted-ruby-client (2.0.0)
+    promoted-ruby-client (2.0.2)
       concurrent-ruby (~> 1)
       faraday (>= 0.9.0)
       faraday_middleware (>= 0.9.0)
@@ -12,113 +12,123 @@ GEM
   specs:
     ast (2.4.2)
     backport (1.2.0)
-    benchmark (0.1.1)
-    concurrent-ruby (1.1.9)
-    connection_pool (2.2.5)
+    benchmark (0.2.1)
+    concurrent-ruby (1.2.2)
+    connection_pool (2.4.1)
     debase (0.2.5.beta2)
       debase-ruby_core_source (>= 0.10.12)
-    debase-ruby_core_source (0.10.12)
-    diff-lcs (1.4.4)
+    debase-ruby_core_source (3.2.1)
+    diff-lcs (1.5.0)
     docile (1.4.0)
     e2mmap (0.1.0)
-    faraday (1.4.3)
+    faraday (1.10.3)
       faraday-em_http (~> 1.0)
       faraday-em_synchrony (~> 1.0)
       faraday-excon (~> 1.1)
+      faraday-httpclient (~> 1.0)
+      faraday-multipart (~> 1.0)
       faraday-net_http (~> 1.0)
-      faraday-net_http_persistent (~> 1.1)
-      multipart-post (>= 1.2, < 3)
+      faraday-net_http_persistent (~> 1.0)
+      faraday-patron (~> 1.0)
+      faraday-rack (~> 1.0)
+      faraday-retry (~> 1.0)
       ruby2_keywords (>= 0.0.4)
     faraday-em_http (1.0.0)
     faraday-em_synchrony (1.0.0)
     faraday-excon (1.1.0)
+    faraday-httpclient (1.0.1)
+    faraday-multipart (1.0.4)
+      multipart-post (~> 2)
     faraday-net_http (1.0.1)
     faraday-net_http_persistent (1.2.0)
-    faraday_middleware (1.0.0)
+    faraday-patron (1.0.0)
+    faraday-rack (1.0.0)
+    faraday-retry (1.0.3)
+    faraday_middleware (1.2.0)
       faraday (~> 1.0)
-    jaro_winkler (1.5.4)
-    kramdown (2.3.1)
+    jaro_winkler (1.5.6)
+    json (2.6.3)
+    kramdown (2.4.0)
       rexml
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
-    mini_portile2 (2.5.3)
-    multipart-post (2.1.1)
-    net-http-persistent (4.0.1)
+    language_server-protocol (3.17.0.3)
+    multipart-post (2.3.0)
+    net-http-persistent (4.0.2)
       connection_pool (~> 2.2)
-    nokogiri (1.11.7)
-      mini_portile2 (~> 2.5.0)
+    nokogiri (1.15.2-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.11.7-x86_64-darwin)
+    nokogiri (1.15.2-x86_64-linux)
       racc (~> 1.4)
-    nokogiri (1.11.7-x86_64-linux)
-      racc (~> 1.4)
-    parallel (1.20.1)
-    parser (3.0.2.0)
+    parallel (1.23.0)
+    parser (3.2.2.3)
       ast (~> 2.4.1)
-    racc (1.5.2)
-    rainbow (3.0.0)
+      racc
+    racc (1.7.1)
+    rainbow (3.1.1)
     rake (10.5.0)
-    regexp_parser (2.1.1)
-    reverse_markdown (2.0.0)
+    rbs (2.8.4)
+    regexp_parser (2.8.1)
+    reverse_markdown (2.1.1)
       nokogiri
     rexml (3.2.5)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
+    rspec (3.12.0)
+      rspec-core (~> 3.12.0)
+      rspec-expectations (~> 3.12.0)
+      rspec-mocks (~> 3.12.0)
+    rspec-core (3.12.2)
+      rspec-support (~> 3.12.0)
+    rspec-expectations (3.12.3)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
+      rspec-support (~> 3.12.0)
+    rspec-mocks (3.12.5)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
-    rubocop (1.18.4)
+      rspec-support (~> 3.12.0)
+    rspec-support (3.12.1)
+    rubocop (1.53.1)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.8.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.8.0)
-      parser (>= 3.0.1.1)
-    ruby-debug-ide (0.7.2)
-      rake (>= 0.8.1)
-    ruby-progressbar (1.11.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.29.0)
+      parser (>= 3.2.1.0)
+    ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
-    simplecov (0.21.2)
+    simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
-    simplecov_json_formatter (0.1.3)
-    solargraph (0.42.4)
+    simplecov_json_formatter (0.1.4)
+    solargraph (0.49.0)
       backport (~> 1.2)
       benchmark
-      bundler (>= 1.17.2)
+      bundler (~> 2.0)
       diff-lcs (~> 1.4)
       e2mmap
       jaro_winkler (~> 1.5)
       kramdown (~> 2.3)
       kramdown-parser-gfm (~> 1.1)
       parser (~> 3.0)
-      reverse_markdown (>= 1.0.5, < 3)
-      rubocop (>= 0.52)
+      rbs (~> 2.0)
+      reverse_markdown (~> 2.0)
+      rubocop (~> 1.38)
       thor (~> 1.0)
       tilt (~> 2.0)
       yard (~> 0.9, >= 0.9.24)
-    thor (1.1.0)
-    tilt (2.0.10)
-    unicode-display_width (2.0.0)
-    yard (0.9.26)
+    thor (1.2.2)
+    tilt (2.2.0)
+    unicode-display_width (2.4.2)
+    yard (0.9.34)
 
 PLATFORMS
-  ruby
-  x86_64-darwin-20
+  arm64-darwin-21
   x86_64-linux
 
 DEPENDENCIES
@@ -128,9 +138,8 @@ DEPENDENCIES
   promoted-ruby-client!
   rake (~> 10.0)
   rspec (~> 3.0)
-  ruby-debug-ide
   simplecov
   solargraph
 
 BUNDLED WITH
-   2.2.24
+   2.4.9

data/dev.md

@@ -10,5 +10,5 @@ bundle exec rspec
 2. Get credentials for deployment from 1password.
 3. Modify `promoted-ruby-client.gemspec`'s push block.
 4. Run `gem build promoted-ruby-client.gemspec` to generate `gem`.
-5. Run (using new output) `gem push promoted-ruby-client-2.0.0.gem`
+5. Run (using new output) `gem push promoted-ruby-client-2.0.2.gem`
 6. Update README with new version.

data/lib/promoted/ruby/client/version.rb

@@ -1,7 +1,7 @@
 module Promoted
   module Ruby
     module Client
-      VERSION = "2.0.0"
+      VERSION = "2.0.2"
       SERVER_VERSION = "rb." + VERSION
     end
   end

data/lib/promoted/ruby/client.rb

@@ -177,22 +177,23 @@ module Promoted
             if should_apply_treatment(cohort_membership_to_log)
               # Call Delivery API to get insertions to use
               delivery_request_params = delivery_request_builder.delivery_request_params  
+              # Don't send shadow traffic if we've already tried normal traffic.
+              should_send_shadow_traffic = false
               begin
                 response = send_request(delivery_request_params, @delivery_endpoint, @delivery_timeout_millis, @delivery_api_key, headers)
                 @validator.validate_response!(response)
+                raise ValidationError.new("Response shoul be a Hash") if !response.is_a?(Hash)
+                response_insertions = response && response[:insertion] || []
+                insertions_from_delivery = (response != nil && !deliver_err);
               rescue  StandardError => err
                 # Currently we don't propagate errors to the SDK caller, but rather default to returning
                 # the request insertions.
                 deliver_err = true
                 @logger.error("Error calling delivery: " + err.message) if @logger
               end
-              should_send_shadow_traffic = false
             else
               should_send_shadow_traffic &&= @send_shadow_traffic_for_control
             end
-
-            insertions_from_delivery = (response != nil && !deliver_err);
-            response_insertions = response && response[:insertion] || []
           end
 
           should_send_shadow_traffic &&= should_send_as_shadow_traffic?
@@ -337,7 +338,9 @@ module Promoted
           response = nil
           begin
             response = send_request(delivery_request_params, @delivery_endpoint, @delivery_timeout_millis, @delivery_api_key, headers, @async_shadow_traffic)
-            @validator.validate_response!(response)
+            if response != nil
+              @validator.validate_response!(response)
+            end
           rescue StandardError => err
             @logger.warn("Shadow traffic call failed with #{err}") if @logger
             return

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: promoted-ruby-client
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.2
 platform: ruby
 authors:
 - scottmcmaster
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-03-27 00:00:00.000000000 Z
+date: 2023-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday