promocode_generator 0.0.1 → 0.0.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Mjg4Y2M2NTJlZmI2MjVmNzczMDk5NDc1ZjdkZTRhNDRmYTYxNDI2Zg==
+    ZWY2NzRkYjAwZDVjODhiMjU2OTA3ODc4YTIyMjcwOTNmOWM1MTJlNw==
   data.tar.gz: !binary |-
-    ZTU3ZjgwZWQ0ZmI1ZWY3ZjBkOTkzYmYzZjZlMjJmN2ZjNzkxZGNmZQ==
+    YzViMDVjMWU1ZmE3NGRiZGE0NWJhZTAxYjI1ZmQxNTgwZmM0YWJkMA==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    YzM2YWI5ZTQzZjE1YjgwMmI2NGJhMTEzOWUxNWU4MmE0NWQ2NWRkNmQ5NDJk
-    MDhhOGNkNTY1NjMxOGI5YmY0N2UzYTQ0NGU4MTk2YjFlN2ExOTRkODQ0Mjlh
-    MWJhY2JiMmE5OGQ5MDI1N2I2YmEyNGMwMWJlN2MyNzExYzRjODU=
+    OWY5ZjdkZjhkNGNmMWUxZDhkOGFkOTNkNWNjNzEwZGE4ZDJmOWY3NjdiZmJi
+    ZTc1ODgwNGE0MGMzMjE3N2ZmZDc0MmZmMGE4NzJkOGY4ZmUwYTMwYWYzNzk3
+    ZTM0MzI5Y2U2YjYwMTBhNTVmZGQ5ZGMzNjQzNzJjNWRmYjM0NDg=
   data.tar.gz: !binary |-
-    ZjY3MWNkZTIxMzM5ZjAwNmY2Yjg1MDY5MjYwMGExZjBhOTQwM2E5MTJmN2Vm
-    MGUxNzRlOTgwZDhkMmYyMjVmZjRhM2IwYjNjYjA0ZWFlZTZiODZlZjVkNWU3
-    YmZkZjgyZjc3YzgyNjJlNDc2N2M2Yjg1ZWQ2MzUxY2I2OGMwMTc=
+    ZGU5MjhlMWU3Nzg3MDliNmIwMjA3N2E0MzgzZGYyMDZjYWIyNzdlOTAxMDI1
+    ZDFlZmYyYmRhY2Q1ODVkNDgxNjg4MjZiZDMzYjE4ODc1Yzg3NDJkNWUwZDMz
+    ZjZmYTdjN2RiNDY4M2M2Njk2NmFlMWM0NjlmOTMyOWE4YjI5OWI=

data/README.md

@@ -24,7 +24,7 @@ Without Rails:
 
 With Rails:
 
-  In your model, use the promocode_attribute method to automatically generate a promotional code of length 8 in the before_save hook:
+  In your model, use the promocode_attribute method to automatically generate a promotional code of length 8 in the before_create hook:
   
   ```ruby
   class Campaign < ActiveRecord::Base

data/lib/promocode_generator/model_additions.rb

@@ -3,7 +3,7 @@ module PromocodeGenerator
     def promocode_attribute(attribute, options = {})
       options[:reject_if] ||= Proc.new { |code| self.where(attribute => code).any? }
 
-      before_save do
+      before_create do
         # Make sure not to generate the same code twice!
         begin
           self.code = PromocodeGenerator.generate

data/lib/promocode_generator/version.rb

@@ -1,3 +1,3 @@
 module PromocodeGenerator
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/promocode_generator/model_additions_spec.rb

@@ -16,7 +16,7 @@ end
 describe PromocodeGenerator::ModelAdditions do
   let(:campaign) { Campaign.new(:name => "foo") }
 
-  context "when the model is saved" do
+  context "when a new model is saved" do
     it "generates a code" do
       expect(PromocodeGenerator).to receive(:generate).once.and_return('ABCDEFG')
       campaign.save!
@@ -28,6 +28,16 @@ describe PromocodeGenerator::ModelAdditions do
     end
   end
 
+  context "when an existing model is saved" do
+    it "does not touch the code" do
+      campaign.save!
+      code = campaign.code
+      
+      campaign.name = "blubb"
+      expect { campaign.save! }.not_to change { campaign.code }
+    end
+  end
+
   context "when the reject_if block returns false" do
     before { RejectCondition.stub(:check).and_return(true, false) }
     after { RejectCondition.unstub(:check) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: promocode_generator
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Pascal Ehlert