prometheus_exporter 2.1.1 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5381fb78e6440d77a61269f3bf7c40a84b44a53594d687db4a683be3cb82725
-  data.tar.gz: 18216fbeae6978d5427fa9f97a67bbf3f0ee36e92091a2606b2dadcaa6497d83
+  metadata.gz: e8f8c9307f755aa00e95f323d2be11cdf6830f7e420c9bf70d90260e9bc81a85
+  data.tar.gz: 216bedbba838f0a84391ef2e85b290aa596cf3c42d27b4cc6bce7a9fae8be01d
 SHA512:
-  metadata.gz: 626d1f7c05e5bf21bc499e69fd1ab0d73c94c5a565ac7eae81ec9d43fc93f6cf96b83a6fd72b25846e49371079a9c87a497e719d74c20dfa57c0fb5cbe4507e5
-  data.tar.gz: b43a57442d6326648cbc3539c50400556575e425756358d45ad39832e099671ca617ea66b6754d16d66693b9fbdf9045b96a95713b36f1f135ab8ab0e38a6d0b
+  metadata.gz: 3ad534e47314779c76eb9e80d5de23619cd0865c2337147188d7f2ddba3bff9a6c9cf630e20720899c4e7ef9c95bf1db317a719d08fc241850f902aceae1b5cf
+  data.tar.gz: 6e71eab8cf6cdb049612c5afc404d6e399a142ee3eb5bbb3ae897e374ac6474d09f1b6c3ad94ab31f8d12fc52fc9e609a8b066051c89e44ea84be0fa0ec2cf0e

data/.github/workflows/ci.yml

@@ -27,7 +27,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['3.1', '3.2', '3.3']
+        ruby: ["3.1", "3.2", "3.3"]
         activerecord: [61, 70, 71]
 
     steps:
@@ -42,6 +42,9 @@ jobs:
       - name: Rubocop
         run: bundle exec rubocop
 
+      - name: Syntax tree
+        run: bundle exec stree check Gemfile $(git ls-files '*.rb') $(git ls-files '*.rake') $(git ls-files '*.thor')
+
       - name: Run tests
         run: bundle exec rake
 

data/.streerc

@@ -0,0 +1,2 @@
+--print-width=100
+--plugins=plugin/trailing_comma,disable_ternary

data/CHANGELOG

@@ -1,3 +1,8 @@
+2.2.0 - 2024-12-05
+
+- FIX: Ensure socket is closed when error is raised while opening socket
+- Feature: Add Dalli::Client memcache metrics for web_collector
+
 2.1.1 - 2024-06-19
 
 - FEATURE: improve good_job instrumentation

data/README.md

@@ -213,13 +213,14 @@ Rails.application.middleware.unshift PrometheusExporter::Middleware, instrument:
 
 #### Metrics collected by Rails integration middleware
 
-| Type    | Name                                   | Description                                                 |
-| ---     | ---                                    | ---                                                         |
-| Counter | `http_requests_total`                  | Total HTTP requests from web app                            |
-| Summary | `http_request_duration_seconds`        | Time spent in HTTP reqs in seconds                          |
-| Summary | `http_request_redis_duration_seconds`¹ | Time spent in HTTP reqs in Redis, in seconds                |
-| Summary | `http_request_sql_duration_seconds`²   | Time spent in HTTP reqs in SQL in seconds                   |
-| Summary | `http_request_queue_duration_seconds`³ | Time spent queueing the request in load balancer in seconds |
+| Type    | Name                                      | Description                                                 |
+| ---     | ---                                       | ---                                                         |
+| Counter | `http_requests_total`                     | Total HTTP requests from web app                            |
+| Summary | `http_request_duration_seconds`           | Time spent in HTTP reqs in seconds                          |
+| Summary | `http_request_redis_duration_seconds`¹    | Time spent in HTTP reqs in Redis, in seconds                |
+| Summary | `http_request_sql_duration_seconds`²      | Time spent in HTTP reqs in SQL in seconds                   |
+| Summary | `http_request_queue_duration_seconds`³    | Time spent queueing the request in load balancer in seconds |
+| Summary | `http_request_memcache_duration_seconds`⁴ | Time spent in HTTP reqs in Memcache in seconds              |
 
 All metrics have a `controller` and an `action` label.
 `http_requests_total` additionally has a (HTTP response) `status` label.
@@ -268,6 +269,7 @@ ruby_http_request_duration_seconds{path="/api/v1/teams/:id",method="GET",status=
 ¹) Only available when Redis is used.
 ²) Only available when Mysql or PostgreSQL are used.
 ³) Only available when [Instrumenting Request Queueing Time](#instrumenting-request-queueing-time) is set up.
+⁴) Only available when Dalli is used.
 
 #### Activerecord Connection Pool Metrics
 

data/bench/bench.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require_relative '../lib/prometheus_exporter'
-require_relative '../lib/prometheus_exporter/client'
-require_relative '../lib/prometheus_exporter/server'
+require_relative "../lib/prometheus_exporter"
+require_relative "../lib/prometheus_exporter/client"
+require_relative "../lib/prometheus_exporter/server"
 
 # test how long it takes a custom collector to process 10k messages
 
@@ -26,18 +26,19 @@ end
 @client = nil
 @runs = 1000
 
-done = lambda do
-  puts "Elapsed for 10k messages is #{Time.now - @start}"
-  if (@runs -= 1) > 0
-    @start = Time.now
-    10_000.times { @client.send_json(hello: "world") }
+done =
+  lambda do
+    puts "Elapsed for 10k messages is #{Time.now - @start}"
+    if (@runs -= 1) > 0
+      @start = Time.now
+      10_000.times { @client.send_json(hello: "world") }
+    end
   end
-end
 
 collector = Collector.new(done)
-server = PrometheusExporter::Server::WebServer.new port: 12349, collector: collector
+server = PrometheusExporter::Server::WebServer.new port: 12_349, collector: collector
 server.start
-@client = PrometheusExporter::Client.new port: 12349, max_queue_size: 100_000
+@client = PrometheusExporter::Client.new port: 12_349, max_queue_size: 100_000
 
 @start = Time.now
 10_000.times { @client.send_json(hello: "world") }

data/examples/custom_collector.rb

@@ -20,8 +20,6 @@ class MyCustomCollector < PrometheusExporter::Server::BaseCollector
   end
 
   def prometheus_metrics_text
-    @mutex.synchronize do
-      "#{@gauge1.to_prometheus_text}\n#{@gauge2.to_prometheus_text}"
-    end
+    @mutex.synchronize { "#{@gauge1.to_prometheus_text}\n#{@gauge2.to_prometheus_text}" }
   end
 end

data/lib/prometheus_exporter/client.rb

@@ -17,13 +17,7 @@ module PrometheusExporter
       end
 
       def standard_values(value, keys, prometheus_exporter_action = nil)
-        values = {
-          type: @type,
-          help: @help,
-          name: @name,
-          keys: keys,
-          value: value
-        }
+        values = { type: @type, help: @help, name: @name, keys: keys, value: value }
         values[
           :prometheus_exporter_action
         ] = prometheus_exporter_action if prometheus_exporter_action
@@ -59,16 +53,14 @@ module PrometheusExporter
 
     def initialize(
       host: ENV.fetch("PROMETHEUS_EXPORTER_HOST", "localhost"),
-      port: ENV.fetch(
-        "PROMETHEUS_EXPORTER_PORT",
-        PrometheusExporter::DEFAULT_PORT
-      ),
+      port: ENV.fetch("PROMETHEUS_EXPORTER_PORT", PrometheusExporter::DEFAULT_PORT),
       max_queue_size: nil,
       thread_sleep: 0.5,
       json_serializer: nil,
       custom_labels: nil,
       logger: Logger.new(STDERR),
-      log_level: Logger::WARN
+      log_level: Logger::WARN,
+      process_queue_once_and_stop: false
     )
       @logger = logger
       @logger.level = log_level
@@ -83,9 +75,7 @@ module PrometheusExporter
       max_queue_size ||= MAX_QUEUE_SIZE
       max_queue_size = max_queue_size.to_i
 
-      if max_queue_size <= 0
-        raise ArgumentError, "max_queue_size must be larger than 0"
-      end
+      raise ArgumentError, "max_queue_size must be larger than 0" if max_queue_size <= 0
 
       @max_queue_size = max_queue_size
       @host = host
@@ -94,10 +84,10 @@ module PrometheusExporter
       @mutex = Mutex.new
       @thread_sleep = thread_sleep
 
-      @json_serializer =
-        json_serializer == :oj ? PrometheusExporter::OjCompat : JSON
+      @json_serializer = json_serializer == :oj ? PrometheusExporter::OjCompat : JSON
 
       @custom_labels = custom_labels
+      @process_queue_once_and_stop = process_queue_once_and_stop
     end
 
     def custom_labels=(custom_labels)
@@ -105,14 +95,7 @@ module PrometheusExporter
     end
 
     def register(type, name, help, opts = nil)
-      metric =
-        RemoteMetric.new(
-          type: type,
-          name: name,
-          help: help,
-          client: self,
-          opts: opts
-        )
+      metric = RemoteMetric.new(type: type, name: name, help: help, client: self, opts: opts)
       @metrics << metric
       metric
     end
@@ -163,7 +146,7 @@ module PrometheusExporter
           @socket.write("\r\n")
         rescue => e
           logger.warn "Prometheus Exporter is dropping a message: #{e}"
-          @socket = nil
+          close_socket!
           raise
         end
       end
@@ -189,6 +172,11 @@ module PrometheusExporter
     end
 
     def ensure_worker_thread!
+      if @process_queue_once_and_stop
+        worker_loop
+        return
+      end
+
       unless @worker_thread&.alive?
         @mutex.synchronize do
           return if @worker_thread&.alive?
@@ -253,8 +241,7 @@ module PrometheusExporter
 
       nil
     rescue StandardError
-      @socket = nil
-      @socket_started = nil
+      close_socket!
       @socket_pid = nil
       raise
     end
@@ -262,10 +249,7 @@ module PrometheusExporter
     def wait_for_empty_queue_with_timeout(timeout_seconds)
       start_time = ::Process.clock_gettime(::Process::CLOCK_MONOTONIC)
       while @queue.length > 0
-        if start_time + timeout_seconds <
-             ::Process.clock_gettime(::Process::CLOCK_MONOTONIC)
-          break
-        end
+        break if start_time + timeout_seconds < ::Process.clock_gettime(::Process::CLOCK_MONOTONIC)
         sleep(0.05)
       end
     end

data/lib/prometheus_exporter/instrumentation/active_record.rb

@@ -3,14 +3,16 @@
 # collects stats from currently running process
 module PrometheusExporter::Instrumentation
   class ActiveRecord < PeriodicStats
-    ALLOWED_CONFIG_LABELS = %i(database username host port)
+    ALLOWED_CONFIG_LABELS = %i[database username host port]
 
     def self.start(client: nil, frequency: 30, custom_labels: {}, config_labels: [])
       client ||= PrometheusExporter::Client.default
 
       # Not all rails versions support connection pool stats
       unless ::ActiveRecord::Base.connection_pool.respond_to?(:stat)
-        client.logger.error("ActiveRecord connection pool stats not supported in your rails version")
+        client.logger.error(
+          "ActiveRecord connection pool stats not supported in your rails version",
+        )
         return
       end
 
@@ -29,7 +31,9 @@ module PrometheusExporter::Instrumentation
 
     def self.validate_config_labels(config_labels)
       return if config_labels.size == 0
-      raise "Invalid Config Labels, available options #{ALLOWED_CONFIG_LABELS}" if (config_labels - ALLOWED_CONFIG_LABELS).size > 0
+      if (config_labels - ALLOWED_CONFIG_LABELS).size > 0
+        raise "Invalid Config Labels, available options #{ALLOWED_CONFIG_LABELS}"
+      end
     end
 
     def initialize(metric_labels, config_labels)
@@ -55,7 +59,7 @@ module PrometheusExporter::Instrumentation
           pid: pid,
           type: "active_record",
           hostname: ::PrometheusExporter.hostname,
-          metric_labels: labels(pool)
+          metric_labels: labels(pool),
         }
         metric.merge!(pool.stat)
         metrics << metric
@@ -66,12 +70,20 @@ module PrometheusExporter::Instrumentation
 
     def labels(pool)
       if ::ActiveRecord.version < Gem::Version.new("6.1.0.rc1")
-        @metric_labels.merge(pool_name: pool.spec.name).merge(pool.spec.config
-          .select { |k, v| @config_labels.include? k }
-          .map { |k, v| [k.to_s.dup.prepend("dbconfig_"), v] }.to_h)
+        @metric_labels.merge(pool_name: pool.spec.name).merge(
+          pool
+            .spec
+            .config
+            .select { |k, v| @config_labels.include? k }
+            .map { |k, v| [k.to_s.dup.prepend("dbconfig_"), v] }
+            .to_h,
+        )
       else
         @metric_labels.merge(pool_name: pool.db_config.name).merge(
-          @config_labels.each_with_object({}) { |l, acc| acc["dbconfig_#{l}"] = pool.db_config.public_send(l) })
+          @config_labels.each_with_object({}) do |l, acc|
+            acc["dbconfig_#{l}"] = pool.db_config.public_send(l)
+          end,
+        )
       end
     end
   end

data/lib/prometheus_exporter/instrumentation/delayed_job.rb

@@ -2,24 +2,33 @@
 
 module PrometheusExporter::Instrumentation
   class DelayedJob
-    JOB_CLASS_REGEXP = %r{job_class: ((\w+:{0,2})+)}.freeze
+    JOB_CLASS_REGEXP = /job_class: ((\w+:{0,2})+)/.freeze
 
     class << self
       def register_plugin(client: nil, include_module_name: false)
         instrumenter = self.new(client: client)
         return unless defined?(Delayed::Plugin)
 
-        plugin = Class.new(Delayed::Plugin) do
-          callbacks do |lifecycle|
-            lifecycle.around(:invoke_job) do |job, *args, &block|
-              max_attempts = Delayed::Worker.max_attempts
-              enqueued_count = Delayed::Job.where(queue: job.queue).count
-              pending_count = Delayed::Job.where(attempts: 0, locked_at: nil, queue: job.queue).count
-              instrumenter.call(job, max_attempts, enqueued_count, pending_count, include_module_name,
-                                *args, &block)
+        plugin =
+          Class.new(Delayed::Plugin) do
+            callbacks do |lifecycle|
+              lifecycle.around(:invoke_job) do |job, *args, &block|
+                max_attempts = Delayed::Worker.max_attempts
+                enqueued_count = Delayed::Job.where(queue: job.queue).count
+                pending_count =
+                  Delayed::Job.where(attempts: 0, locked_at: nil, queue: job.queue).count
+                instrumenter.call(
+                  job,
+                  max_attempts,
+                  enqueued_count,
+                  pending_count,
+                  include_module_name,
+                  *args,
+                  &block
+                )
+              end
             end
           end
-        end
 
         Delayed::Worker.plugins << plugin
       end
@@ -50,7 +59,7 @@ module PrometheusExporter::Instrumentation
         attempts: attempts,
         max_attempts: max_attempts,
         enqueued: enqueued_count,
-        pending: pending_count
+        pending: pending_count,
       )
     end
   end

data/lib/prometheus_exporter/instrumentation/good_job.rb

@@ -7,9 +7,7 @@ module PrometheusExporter::Instrumentation
       good_job_collector = new
       client ||= PrometheusExporter::Client.default
 
-      worker_loop do
-        client.send_json(good_job_collector.collect)
-      end
+      worker_loop { client.send_json(good_job_collector.collect) }
 
       super
     end
@@ -23,7 +21,7 @@ module PrometheusExporter::Instrumentation
         running: ::GoodJob::Job.running.size,
         finished: ::GoodJob::Job.finished.size,
         succeeded: ::GoodJob::Job.succeeded.size,
-        discarded: ::GoodJob::Job.discarded.size
+        discarded: ::GoodJob::Job.discarded.size,
       }
     end
   end

data/lib/prometheus_exporter/instrumentation/hutch.rb

@@ -19,7 +19,7 @@ module PrometheusExporter::Instrumentation
         type: "hutch",
         name: @klass.class.to_s,
         success: success,
-        duration: duration
+        duration: duration,
       )
     end
   end

data/lib/prometheus_exporter/instrumentation/method_profiler.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
 # see https://samsaffron.com/archive/2017/10/18/fastest-way-to-profile-a-method-in-ruby
-module PrometheusExporter::Instrumentation; end
+module PrometheusExporter::Instrumentation
+end
 
 class PrometheusExporter::Instrumentation::MethodProfiler
   def self.patch(klass, methods, name, instrument:)
@@ -21,9 +22,8 @@ class PrometheusExporter::Instrumentation::MethodProfiler
   end
 
   def self.start(transfer = nil)
-    Thread.current[:_method_profiler] = transfer || {
-      __start: Process.clock_gettime(Process::CLOCK_MONOTONIC)
-    }
+    Thread.current[:_method_profiler] = transfer ||
+      { __start: Process.clock_gettime(Process::CLOCK_MONOTONIC) }
   end
 
   def self.clear
@@ -42,8 +42,8 @@ class PrometheusExporter::Instrumentation::MethodProfiler
 
   def self.define_methods_on_module(klass, methods, name)
     patch_source_line = __LINE__ + 3
-    patches = methods.map do |method_name|
-      <<~RUBY
+
+    patches = methods.map { |method_name| <<~RUBY }.join("\n")
         def #{method_name}(...)
           unless prof = Thread.current[:_method_profiler]
             return super
@@ -58,9 +58,8 @@ class PrometheusExporter::Instrumentation::MethodProfiler
           end
         end
       RUBY
-    end.join("\n")
 
-    klass.module_eval patches, __FILE__, patch_source_line
+    klass.module_eval(patches, __FILE__, patch_source_line)
   end
 
   def self.patch_using_prepend(klass, methods, name)
@@ -71,14 +70,16 @@ class PrometheusExporter::Instrumentation::MethodProfiler
 
   def self.patch_using_alias_method(klass, methods, name)
     patch_source_line = __LINE__ + 3
-    patches = methods.map do |method_name|
-      <<~RUBY
+
+    patches = methods.map { |method_name| <<~RUBY }.join("\n")
       unless defined?(#{method_name}__mp_unpatched)
         alias_method :#{method_name}__mp_unpatched, :#{method_name}
+
         def #{method_name}(...)
           unless prof = Thread.current[:_method_profiler]
             return #{method_name}__mp_unpatched(...)
           end
+
           begin
             start = Process.clock_gettime(Process::CLOCK_MONOTONIC)
             #{method_name}__mp_unpatched(...)
@@ -90,8 +91,7 @@ class PrometheusExporter::Instrumentation::MethodProfiler
         end
       end
       RUBY
-    end.join("\n")
 
-    klass.class_eval patches, __FILE__, patch_source_line
+    klass.class_eval(patches, __FILE__, patch_source_line)
   end
 end

data/lib/prometheus_exporter/instrumentation/periodic_stats.rb

@@ -2,21 +2,14 @@
 
 module PrometheusExporter::Instrumentation
   class PeriodicStats
-
     def self.start(*args, frequency:, client: nil, **kwargs)
       client ||= PrometheusExporter::Client.default
 
-      if !(Numeric === frequency)
-        raise ArgumentError.new("Expected frequency to be a number")
-      end
+      raise ArgumentError.new("Expected frequency to be a number") if !(Numeric === frequency)
 
-      if frequency < 0
-        raise ArgumentError.new("Expected frequency to be a positive number")
-      end
+      raise ArgumentError.new("Expected frequency to be a positive number") if frequency < 0
 
-      if !@worker_loop
-        raise ArgumentError.new("Worker loop was not set")
-      end
+      raise ArgumentError.new("Worker loop was not set") if !@worker_loop
 
       klass = self
 
@@ -24,18 +17,18 @@ module PrometheusExporter::Instrumentation
 
       @stop_thread = false
 
-      @thread = Thread.new do
-        while !@stop_thread
-          begin
-            @worker_loop.call
-          rescue => e
-            client.logger.error("#{klass} Prometheus Exporter Failed To Collect Stats #{e}")
-          ensure
-            sleep frequency
+      @thread =
+        Thread.new do
+          while !@stop_thread
+            begin
+              @worker_loop.call
+            rescue => e
+              client.logger.error("#{klass} Prometheus Exporter Failed To Collect Stats #{e}")
+            ensure
+              sleep frequency
+            end
           end
         end
-      end
-
     end
 
     def self.started?
@@ -57,6 +50,5 @@ module PrometheusExporter::Instrumentation
       end
       @thread = nil
     end
-
   end
 end

data/lib/prometheus_exporter/instrumentation/process.rb

@@ -3,9 +3,7 @@
 # collects stats from currently running process
 module PrometheusExporter::Instrumentation
   class Process < PeriodicStats
-
     def self.start(client: nil, type: "ruby", frequency: 30, labels: nil)
-
       metric_labels =
         if labels && type
           labels.merge(type: type)
@@ -46,14 +44,22 @@ module PrometheusExporter::Instrumentation
     end
 
     def rss
-      @pagesize ||= `getconf PAGESIZE`.to_i rescue 4096
-      File.read("/proc/#{pid}/statm").split(' ')[1].to_i * @pagesize rescue 0
+      @pagesize ||=
+        begin
+          `getconf PAGESIZE`.to_i
+        rescue StandardError
+          4096
+        end
+      begin
+        File.read("/proc/#{pid}/statm").split(" ")[1].to_i * @pagesize
+      rescue StandardError
+        0
+      end
     end
 
     def collect_process_stats(metric)
       metric[:pid] = pid
       metric[:rss] = rss
-
     end
 
     def collect_gc_stats(metric)
@@ -68,7 +74,7 @@ module PrometheusExporter::Instrumentation
     end
 
     def collect_v8_stats(metric)
-      return if !defined? MiniRacer
+      return if !defined?(MiniRacer)
 
       metric[:v8_heap_count] = metric[:v8_heap_size] = 0
       metric[:v8_heap_size] = metric[:v8_physical_size] = 0

data/lib/prometheus_exporter/instrumentation/puma.rb

@@ -26,7 +26,7 @@ module PrometheusExporter::Instrumentation
         pid: pid,
         type: "puma",
         hostname: ::PrometheusExporter.hostname,
-        metric_labels: @metric_labels
+        metric_labels: @metric_labels,
       }
       collect_puma_stats(metric)
       metric

data/lib/prometheus_exporter/instrumentation/resque.rb

@@ -7,9 +7,7 @@ module PrometheusExporter::Instrumentation
       resque_collector = new
       client ||= PrometheusExporter::Client.default
 
-      worker_loop do
-        client.send_json(resque_collector.collect)
-      end
+      worker_loop { client.send_json(resque_collector.collect) }
 
       super
     end

data/lib/prometheus_exporter/instrumentation/shoryuken.rb

@@ -2,7 +2,6 @@
 
 module PrometheusExporter::Instrumentation
   class Shoryuken
-
     def initialize(client: nil)
       @client = client || PrometheusExporter::Client.default
     end
@@ -19,12 +18,12 @@ module PrometheusExporter::Instrumentation
     ensure
       duration = ::Process.clock_gettime(::Process::CLOCK_MONOTONIC) - start
       @client.send_json(
-          type: "shoryuken",
-          queue: queue,
-          name: worker.class.name,
-          success: success,
-          shutdown: shutdown,
-          duration: duration
+        type: "shoryuken",
+        queue: queue,
+        name: worker.class.name,
+        success: success,
+        shutdown: shutdown,
+        duration: duration,
       )
     end
   end

data/lib/prometheus_exporter/instrumentation/sidekiq.rb

@@ -3,8 +3,7 @@
 require "yaml"
 
 module PrometheusExporter::Instrumentation
-  JOB_WRAPPER_CLASS_NAME =
-    "ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper"
+  JOB_WRAPPER_CLASS_NAME = "ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper"
   DELAYED_CLASS_NAMES = %w[
     Sidekiq::Extensions::DelayedClass
     Sidekiq::Extensions::DelayedModel
@@ -24,7 +23,7 @@ module PrometheusExporter::Instrumentation
             type: "sidekiq",
             name: get_name(job["class"], job),
             dead: true,
-            custom_labels: worker_custom_labels
+            custom_labels: worker_custom_labels,
           )
         end
       end
@@ -44,8 +43,7 @@ module PrometheusExporter::Instrumentation
     end
 
     def initialize(options = { client: nil })
-      @client =
-        options.fetch(:client, nil) || PrometheusExporter::Client.default
+      @client = options.fetch(:client, nil) || PrometheusExporter::Client.default
     end
 
     def call(worker, msg, queue)
@@ -67,7 +65,7 @@ module PrometheusExporter::Instrumentation
         success: success,
         shutdown: shutdown,
         duration: duration,
-        custom_labels: self.class.get_worker_custom_labels(worker.class, msg)
+        custom_labels: self.class.get_worker_custom_labels(worker.class, msg),
       )
     end