progressrus 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9b39a0c76542e10e41e85fd7054b5dab25a8c77
-  data.tar.gz: b009a97188d3e5f310a812d032a7a968b8456350
+  metadata.gz: e9443b1b626649e1d9e17aa2ed9ef9354312bc78
+  data.tar.gz: 4e9bd7b04d2f47975bfc9bbfa96f36ced10e3ccf
 SHA512:
-  metadata.gz: 50103f860e60a3556e324947be3358fd1d3239a78e83847b7d0f1177452932f5523dc76a2718ea3ab94228e3884f3520e69b3bc0d76473eb451a7dc19cc73827
-  data.tar.gz: 2217d65aa3758df8cf690486163ab8f761a3b3a91687bcbef3c38a659c2099c2e3188d5b1358d404cd4cdfe987036e7a4258b9b0764bccf1654fda867c8f94df
+  metadata.gz: f8093bed5b344ff65be4f5bc8b0ec207eb1984c4fb7f45ea629e0c6d7306f2a6fbfc0cf645bd7d73940b3ec8368ffb87235edac040c2805fe28c0113d70b9908
+  data.tar.gz: 71e0a98fc087451ad400f72c16d3c461873a93c75ba27ec90231dae1610ecc5b724e346603a51b06f6de64889360dc9769e441d3dec69c7130ff7500a8d38b49

data/lib/progressrus.rb

@@ -42,7 +42,7 @@ class Progressrus
     completed_at: nil, started_at: nil, count: 0, failed_at: nil,
     error_count: 0, persist: false, expires_at: nil)
 
-    raise ArgumentError, "Total cannot be zero or negative." if total && total <= 0
+    raise ArgumentError, "Total cannot be negative." if total && total < 0
 
     @name         = name || id
     @scope        = Array(scope).map(&:to_s)
@@ -120,7 +120,7 @@ class Progressrus
   end
 
   def total=(new_total)
-    raise ArgumentError, "Total cannot be zero or negative." if new_total <= 0
+    raise ArgumentError, "Total cannot be negative." if new_total < 0
     @total = new_total
   end
 
@@ -133,7 +133,11 @@ class Progressrus
   end
 
   def percentage
-    count.to_f / total
+    if total > 0
+      count.to_f / total
+    else
+      1.0
+    end
   end
 
   def eta(now: Time.now)

data/lib/progressrus/version.rb

@@ -1,3 +1,3 @@
 class Progressrus
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/test/progressrus_test.rb

@@ -110,10 +110,17 @@ class ProgressrusTest < Minitest::Test
     assert_equal 1.2, @progress.percentage
   end
 
-  def test_percentage_should_be_0_if_total_0
+  def test_percentage_should_be_0_if_count_0
     assert_equal 0, @progress.percentage
   end
 
+  def test_percentage_should_be_1_if_total_0
+    progress = Progressrus.new(total: 0)
+    assert_equal 1, progress.percentage
+    progress.tick
+    assert_equal 1, progress.percentage
+  end
+
   def test_elapsed_should_return_the_delta_between_now_and_started_at
     time = Time.now
     @progress.tick(10, now: time - 10)
@@ -168,10 +175,9 @@ class ProgressrusTest < Minitest::Test
     assert_equal now.to_i, @progress.completed_at.to_i
   end
 
-  def test_should_not_be_able_to_set_total_to_0
-    assert_raises ArgumentError do
-      @progress.total = 0
-    end
+  def test_should_be_able_to_set_total_to_0
+    @progress.total = 0
+    assert_equal 0, @progress.total
   end
 
   def test_should_not_be_able_to_set_total_to_a_negative_number
@@ -199,10 +205,9 @@ class ProgressrusTest < Minitest::Test
     @progress.complete
   end
 
-  def test_should_not_be_able_to_initialize_with_total_0
-    assert_raises ArgumentError do
-      Progressrus.new(total: 0)
-    end
+  def test_should_be_able_to_initialize_with_total_0
+    progress = Progressrus.new(total: 0)
+    assert_equal 0, progress.total
   end
 
   def test_should_not_be_able_to_initialize_with_total_as_a_negative_number

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: progressrus
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Simon Eskildsen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-26 00:00:00.000000000 Z
+date: 2016-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -186,7 +186,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.2.3
 signing_key: 
 specification_version: 4
 summary: Monitor the progress of remote, long-running jobs.