production_log_analyzer 1.3.0 → 1.5.0

data/lib/production_log/parser.rb

@@ -9,154 +9,150 @@
 
 module LogParser
 
-    ##
-    # LogEntry contains a summary of log data for a single request.
-
-    class LogEntry
-
-        ##
-        # Controller and action for this request
+  ##
+  # LogEntry contains a summary of log data for a single request.
 
-        attr_reader :page
+  class LogEntry
 
-        ##
-        # Requesting IP
+    ##
+    # Controller and action for this request
 
-        attr_reader :ip
+    attr_reader :page
 
-        ##
-        # Time the request was made
+    ##
+    # Requesting IP
 
-        attr_reader :time
+    attr_reader :ip
 
-        ##
-        # Array of SQL queries containing query type and time taken.  The
-        # complete text of the SQL query is not saved to reduct memory usage.
+    ##
+    # Time the request was made
 
-        attr_reader :queries
+    attr_reader :time
 
-        ##
-        # Total request time, including database, render and other.
+    ##
+    # Array of SQL queries containing query type and time taken.  The
+    # complete text of the SQL query is not saved to reduct memory usage.
 
-        attr_reader :request_time
+    attr_reader :queries
 
-        ##
-        # Total render time.
+    ##
+    # Total request time, including database, render and other.
 
-        attr_reader :render_time
+    attr_reader :request_time
 
-        ##
-        # Total database time
+    ##
+    # Total render time.
 
-        attr_reader :db_time
-        
-        ##
-        # Creates a new LogEntry from the log data in +entry+.
+    attr_reader :render_time
 
-        def initialize(entry)
-            @page = nil
-            @ip = nil
-            @time = nil
-            @queries = []
-            @request_time = 0
-            @render_time = 0
-            @db_time = 0
-            @in_component = 0
+    ##
+    # Total database time
 
-            parse entry
-        end
+    attr_reader :db_time
 
-        ##
-        # Extracts log data from +entry+, which is an Array of lines from the
-        # same request.
-
-        def parse(entry)
-            entry.each do |line|
-                case line
-                when /^Parameters/, /^Cookie set/, /^Rendering/,
-                     /^Redirected/ then
-                    # nothing
-                when /^Processing ([\S]+) \(for (.+) at (.*)\)/ then
-                    next if @in_component > 0
-                    @page = $1
-                    @ip   = $2
-                    @time = $3
-                when /^Completed in ([\S]+) .+ Rendering: ([\S]+) .+ DB: ([\S]+)/ then
-                    next if @in_component > 0
-                    @request_time = $1.to_f
-                    @render_time = $2.to_f
-                    @db_time = $3.to_f
-                when /^Completed in ([\S]+) .+ DB: ([\S]+)/ then # Redirect
-                    next if @in_component > 0
-                    @request_time = $1.to_f
-                    @render_time = 0
-                    @db_time = $2.to_f
-                when /(.+?) \(([^)]+)\)   / then
-                    @queries << [$1, $2.to_f]
-                when /^Start rendering component / then
-                    @in_component += 1
-                when /^End of component rendering$/ then
-                    @in_component -= 1
-                when /^Fragment hit: / then
-                else
-                    raise "Can't handle #{line.inspect}" if $TESTING
-                end
-            end
-        end
+    ##
+    # Creates a new LogEntry from the log data in +entry+.
+
+    def initialize(entry)
+      @page = nil
+      @ip = nil
+      @time = nil
+      @queries = []
+      @request_time = 0
+      @render_time = 0
+      @db_time = 0
+      @in_component = 0
+
+      parse entry
+    end
 
-        def ==(other) # :nodoc:
-            other.class == self.class and
-            other.page == self.page and
-            other.ip == self.ip and
-            other.time == self.time and
-            other.queries == self.queries and
-            other.request_time == self.request_time and
-            other.render_time == self.render_time and
-            other.db_time == self.db_time
+    ##
+    # Extracts log data from +entry+, which is an Array of lines from the
+    # same request.
+
+    def parse(entry)
+      entry.each do |line|
+        case line
+        when /^Parameters/, /^Cookie set/, /^Rendering/,
+          /^Redirected/ then
+          # nothing
+        when /^Processing ([\S]+) \(for (.+) at (.*)\)/ then
+          next if @in_component > 0
+          @page = $1
+          @ip   = $2
+          @time = $3
+        when /^Completed in ([\S]+) .+ Rendering: ([\S]+) .+ DB: ([\S]+)/ then
+          next if @in_component > 0
+          @request_time = $1.to_f
+          @render_time = $2.to_f
+          @db_time = $3.to_f
+        when /^Completed in ([\S]+) .+ DB: ([\S]+)/ then # Redirect
+          next if @in_component > 0
+          @request_time = $1.to_f
+          @render_time = 0
+          @db_time = $2.to_f
+        when /(.+?) \(([^)]+)\)   / then
+          @queries << [$1, $2.to_f]
+        when /^Start rendering component / then
+          @in_component += 1
+        when /^End of component rendering$/ then
+          @in_component -= 1
+        when /^Fragment hit: / then
+        else # noop
+#          raise "Can't handle #{line.inspect}" if $TESTING
         end
+      end
+    end
 
+    def ==(other) # :nodoc:
+      other.class == self.class and
+      other.page == self.page and
+      other.ip == self.ip and
+      other.time == self.time and
+      other.queries == self.queries and
+      other.request_time == self.request_time and
+      other.render_time == self.render_time and
+      other.db_time == self.db_time
     end
 
-    ##
-    # Parses IO stream +stream+, creating a LogEntry for each recognizable log
-    # entry.
-    #
-    # Log entries are recognised as starting with Processing, continuing with
-    # the same process id through Completed.
-
-    def self.parse(stream) # :yields: log_entry
-        in_component = 0
-        buckets = Hash.new { |h,k| h[k] = [] }
-        comp_count = Hash.new 0
-
-        stream.each_line do |line|
-            line =~ / ([^ ]+) ([^ ]+)\[(\d+)\]: (.*)/
-            next if $2.nil? or $2 == 'newsyslog'
-            bucket = "#{$1}-#{$3}"
-            data = $4
-
-            buckets[bucket] << data
-
-            case data
-            when /^Start rendering component / then
-                comp_count[bucket] += 1
-            when /^End of component rendering$/ then
-                comp_count[bucket] -= 1
-            when /^Completed/ then
-                next unless comp_count[bucket] == 0
-                entry = buckets.delete bucket
-                if entry.first =~ /^Processing/ then
-                    yield LogEntry.new(entry)
-                end
-            end
-        end
+  end
+
+  ##
+  # Parses IO stream +stream+, creating a LogEntry for each recognizable log
+  # entry.
+  #
+  # Log entries are recognised as starting with Processing, continuing with
+  # the same process id through Completed.
+
+  def self.parse(stream) # :yields: log_entry
+    buckets = Hash.new { |h,k| h[k] = [] }
+    comp_count = Hash.new 0
+
+    stream.each_line do |line|
+      line =~ / ([^ ]+) ([^ ]+)\[(\d+)\]: (.*)/
+      next if $2.nil? or $2 == 'newsyslog'
+      bucket = [$1, $2, $3].join '-'
+      data = $4
+
+      buckets[bucket] << data
+
+      case data
+      when /^Start rendering component / then
+        comp_count[bucket] += 1
+      when /^End of component rendering$/ then
+        comp_count[bucket] -= 1
+      when /^Completed/ then
+        next unless comp_count[bucket] == 0
+        entry = buckets.delete bucket
+        next unless entry.any? { |l| l =~ /^Processing/ }
+        yield LogEntry.new(entry)
+      end
+    end
 
-        buckets.each do |bucket, data|
-            yield LogEntry.new(data)
-        end
+    buckets.each do |bucket, data|
+      yield LogEntry.new(data)
     end
+  end
 
 end
 
-# vim: ts=4 sts=4 sw=4
-

data/test/test.syslog.0.14.x.log

@@ -1,3 +1,4 @@
+//src/production_log_analyzer/dev/test/test.syslog.0.14.x.log#1 - add change 3135 (text)
 Nov  7 12:14:02 192.168.1.71 43things[24950]: Processing RssController#entries (for 10.43.199.12 at 2005-11-07 12:14:02) [GET]
 Nov  7 12:14:02 192.168.1.71 43things[24950]: Parameters: {"rss/entries/goal.html/entries/goal"=>nil, "action"=>"entries", "id"=>"goal", "controller"=>"rss", "goal_id"=>"86381"}
 Nov  7 12:14:02 192.168.1.71 43things[24950]: Rendering rss/rss2.0

data/test/test.syslog.1.2.shortname.log

@@ -0,0 +1,5 @@
+//src/production_log_analyzer/dev/test/test.syslog.1.2.shortname.log#1 - add change 3135 (text)
+Jan 17 16:19:22 tlucas rails[2265]: Processing Short#a (for 127.0.0.1 at 2007-01-17 16:19:22) [GET]
+Jan 17 16:19:22 tlucas rails[2265]: Parameters: {"action"=>"a", "controller"=>"short"}
+Jan 17 16:19:22 tlucas rails[2265]: Rendering short/a
+Jan 17 16:19:22 tlucas rails[2265]: Completed in 0.02666 (37 reqs/sec) | Rendering: 0.02261 (84%) | DB: 0.00222 (8%) | 200 OK [http://127.0.0.1/short]

data/test/test.syslog.empty.log

@@ -0,0 +1,2 @@
+//src/production_log_analyzer/dev/test/test.syslog.empty.log#1 - add change 3135 (text)
+

data/test/test.syslog.log

@@ -1,3 +1,4 @@
+//src/production_log_analyzer/dev/test/test.syslog.log#1 - add change 3135 (text)
 Mar  7 00:00:00 online1 newsyslog[61307]: logfile turned over
 Mar  7 00:00:20 online1 rails[59600]: Goal Load (0.002112)   SELECT g.*, gs.score as score FROM goals g, goal_similarities gs WHERE g.id = gs.similar_goal_id AND g.num_active_people > 0 AND gs.goal_similarity_type_id = 1 AND gs.goal_id = 59133 ORDER BY score DESC LIMIT 3
 Mar  7 00:00:20 online1 rails[59600]: Tag Load (0.001527)   SELECT tags.*, count(*) as num_goals FROM tags_teams, tags, teams WHERE tags_teams.tag_id = tags.id AND tags_teams.team_id = teams.id AND teams.num_members > 0 AND teams.goal_id = 59133 GROUP BY tags.id ORDER BY num_goals DESC LIMIT 5
@@ -6,6 +7,7 @@ Mar  7 00:00:20 online1 rails[59600]: Person Load (0.001884)   SELECT * FROM peo
 Mar  7 00:00:20 online1 rails[59600]: Person Load (0.001159)   SELECT * FROM people WHERE id = 10519 LIMIT 1
 Mar  7 00:00:20 online1 rails[59600]: Rendering layouts/default (200 OK)
 Mar  7 00:00:20 online1 rails[59600]: Completed in 0.300741 (3 reqs/sec) | Rendering: 0.049924 (16%) | DB: 0.092428 (30%)
+Mar  7 00:00:25 online2 rails[59628]: -> vsize: 83628032 rssize: 79933440 runtime: 1151489566)
 Mar  7 00:00:25 online2 rails[59628]: Processing RssController#uber (for 67.18.200.5 at Mon Mar 07 00:00:25 CST 2005)
 Mar  7 00:00:25 online2 rails[59628]: Parameters: {:id=>"author", :"rss/uber/author.html/uber/author"=>nil, :action=>"uber", :username=>"looch", :controller=>"rss"}
 Mar  7 00:00:25 online2 rails[59628]: Cookie set: auth=STUFF; path=/; expires=Thu, 05 Mar 2015 06:00:25 GMT
@@ -24,6 +26,7 @@ Mar  7 00:00:25 online1 rails[59628]: ProfileImage Load (0.001554)   SELECT * FR
 Mar  7 00:00:25 online1 rails[59628]: Rendering rss/rss2.0 (200 OK)
 Mar  7 00:00:25 online1 rails[59628]: Completed in 0.034519 (28 reqs/sec) | Rendering: 0.011770 (34%) | DB: 0.007962 (23%)
 Mar  7 00:00:25 online2 rails[59628]: Completed in 0.034519 (28 reqs/sec) | Rendering: 0.011770 (34%) | DB: 0.007962 (23%)
+Mar  7 00:00:25 online2 rails[59628]: <- vsize: 83628032 rssize: 79933440 runtime: 1151487080
 Mar  7 00:00:27 online1 rails[59645]: Processing ThingsController#view (for 67.18.200.5 at Mon Mar 07 00:00:27 CST 2005)
 Mar  7 00:00:27 online1 rails[59645]: Parameters: {:id=>"11891", :"things/view/11891.html/view/11891"=>nil, :action=>"view", :controller=>"things"}
 Mar  7 00:00:27 online1 rails[59645]: Cookie set: auth=STUFF; path=/; expires=Thu, 05 Mar 2015 06:00:27 GMT

data/test/test_action_grep.rb

@@ -24,7 +24,7 @@ class TestActionGrep < Test::Unit::TestCase
 
     lines = stdout.readlines
 
-    assert_equal 18, lines.length
+    assert_equal 19, lines.length
 
   ensure
     $stdout = old_stdout

data/test/test_analyzer.rb

@@ -8,89 +8,89 @@ require 'production_log/analyzer'
 
 class TestEnumerable < Test::Unit::TestCase
 
-    def test_sum
-        assert_equal 45, (1..9).sum
-    end
+  def test_sum
+    assert_equal 45, (1..9).sum
+  end
 
-    def test_average
-        # Ranges don't have a length
-        assert_in_delta 5.0, (1..9).to_a.average, 0.01
-    end
+  def test_average
+    # Ranges don't have a length
+    assert_in_delta 5.0, (1..9).to_a.average, 0.01
+  end
 
-    def test_sample_variance
-        assert_in_delta 6.6666, (1..9).to_a.sample_variance, 0.0001
-    end
+  def test_sample_variance
+    assert_in_delta 6.6666, (1..9).to_a.sample_variance, 0.0001
+  end
 
-    def test_standard_deviation
-        assert_in_delta 2.5819, (1..9).to_a.standard_deviation, 0.0001
-    end
+  def test_standard_deviation
+    assert_in_delta 2.5819, (1..9).to_a.standard_deviation, 0.0001
+  end
 
 end
 
 class TestSizedList < Test::Unit::TestCase
 
-    def setup
-        @list = SizedList.new 10 do |arr,|
-            arr.delete_at 0
-            true
-        end
+  def setup
+    @list = SizedList.new 10 do |arr,|
+      arr.delete_at 0
+    true
     end
+  end
 
-    def test_append
-        assert_equal [], @list.entries
+  def test_append
+    assert_equal [], @list.entries
 
-        (1..10).each { |i| @list << i }
-        assert_equal 10, @list.length
-        assert_equal((1..10).to_a, @list.entries)
+    (1..10).each { |i| @list << i }
+    assert_equal 10, @list.length
+    assert_equal((1..10).to_a, @list.entries)
 
-        @list << 11
-        assert_equal 10, @list.length
-        assert_equal((2..11).to_a, @list.entries)
-    end
+    @list << 11
+    assert_equal 10, @list.length
+    assert_equal((2..11).to_a, @list.entries)
+  end
 
 end
 
 class TestSlowestTimes < Test::Unit::TestCase
 
-    def setup
-        @list = SlowestTimes.new 10
-    end
+  def setup
+    @list = SlowestTimes.new 10
+  end
 
-    def test_that_it_works
-        expected = []
+  def test_that_it_works
+    expected = []
 
-        10.downto(1) do |i|
-            @list << [i, nil]
-            expected << [i, nil]
-        end
+    10.downto(1) do |i|
+      @list << [i, nil]
+      expected << [i, nil]
+    end
 
-        assert_equal expected, @list.entries
+    assert_equal expected, @list.entries
 
-        @list << [11, nil]
-        expected.pop
-        expected.push [11, nil]
+    @list << [11, nil]
+    expected.pop
+    expected.push [11, nil]
 
-        assert_equal 10, @list.length
-        assert_equal expected, @list.entries
+    assert_equal 10, @list.length
+    assert_equal expected, @list.entries
 
-        @list << [0, nil]
+    @list << [0, nil]
 
-        assert_equal expected, @list.entries
-    end
+    assert_equal expected, @list.entries
+  end
 
 end
 
 class TestAnalyzer < Test::Unit::TestCase
 
-    def setup
-        @analyzer = Analyzer.new 'test/test.syslog.log'
-        @analyzer.process
-    end
+  def setup
+    @analyzer = Analyzer.new 'test/test.syslog.log'
+    @analyzer.process
+  end
 
-    def test_self_email
-      email = Analyzer.email('test/test.syslog.log', 'devnull@robotcoop.com',
-                             nil, 1)
-      expected = <<-EOF
+  def test_self_email
+    email = Analyzer.email('test/test.syslog.log', 'devnull@robotcoop.com',
+                           nil, 1)
+    expected = <<-EOF
 Subject: pl_analyze
 To: devnull@robotcoop.com
 Content-Type: text/html
@@ -105,7 +105,7 @@ PeopleController#progress:	2	0.489	0.489	0.000	0.977
 PeopleController#view:    	2	0.731	0.371	0.360	1.102
 
 Slowest Request Times:
-	TeamsController#progress took 1.470s
+\tTeamsController#progress took 1.470s
 
 ------------------------------------------------------------------------
 
@@ -119,7 +119,7 @@ PeopleController#progress:	2	0.415	0.415	0.000	0.830
 PeopleController#view:    	2	0.338	0.149	0.189	0.486
 
 Slowest Total DB Times:
-	TeamsController#progress took 1.144s
+\tTeamsController#progress took 1.144s
 
 ------------------------------------------------------------------------
 
@@ -133,52 +133,52 @@ PeopleController#progress:	2	0.302	0.302	0.000	0.604
 PeopleController#view:    	2	0.487	0.209	0.278	0.695
 
 Slowest Total Render Times:
-	PeopleController#view took 0.695s
+\tPeopleController#view took 0.695s
 </pre>
       EOF
 
-      assert_equal expected, email
-    end
+    assert_equal expected, email
+  end
 
-    def test_self_envelope
-      expected = [
-        "Subject: pl_analyze",
-        "To: devnull@example.com",
-        "Content-Type: text/html"
-      ]
+  def test_self_envelope
+    expected = [
+      "Subject: pl_analyze",
+      "To: devnull@example.com",
+      "Content-Type: text/html"
+    ]
 
-      assert_equal expected, Analyzer.envelope('devnull@example.com')
-    end
+    assert_equal expected, Analyzer.envelope('devnull@example.com')
+  end
 
-    def test_self_envelope_subject
-      expected = [
-        "Subject: happy fancy boom",
-        "To: devnull@example.com",
-        "Content-Type: text/html"
-      ]
+  def test_self_envelope_subject
+    expected = [
+      "Subject: happy fancy boom",
+      "To: devnull@example.com",
+      "Content-Type: text/html"
+    ]
 
-      assert_equal(expected,
-                   Analyzer.envelope('devnull@example.com', 'happy fancy boom'))
-    end
+    assert_equal(expected,
+                 Analyzer.envelope('devnull@example.com', 'happy fancy boom'))
+  end
 
-    def test_average_db_time
-        assert_in_delta 0.4023761, @analyzer.average_db_time, 0.0000001
-    end
+  def test_average_db_time
+    assert_in_delta 0.4023761, @analyzer.average_db_time, 0.0000001
+  end
 
-    def test_average_render_time
-        assert_in_delta 0.3015584, @analyzer.average_render_time, 0.0000001
-    end
+  def test_average_render_time
+    assert_in_delta 0.3015584, @analyzer.average_render_time, 0.0000001
+  end
 
-    def test_average_request_time
-        assert_in_delta 0.6338176, @analyzer.average_request_time, 0.0000001
-    end
+  def test_average_request_time
+    assert_in_delta 0.6338176, @analyzer.average_request_time, 0.0000001
+  end
 
-    def test_db_time_std_dev
-        assert_in_delta 0.3941380, @analyzer.db_time_std_dev, 0.0000001
-    end
+  def test_db_time_std_dev
+    assert_in_delta 0.3941380, @analyzer.db_time_std_dev, 0.0000001
+  end
 
-    def test_db_times_summary
-      expected = <<EOF.strip
+  def test_db_times_summary
+    expected = <<EOF.strip
 DB Times Summary:         	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.366	0.393	0.000	1.144
 
@@ -189,80 +189,95 @@ PeopleController#progress:	2	0.415	0.415	0.000	0.830
 PeopleController#view:    	2	0.338	0.149	0.189	0.486
 EOF
 
-      assert_equal expected, @analyzer.db_times_summary
-    end
-
-    def test_logfile_name
-        assert_equal 'test/test.syslog.log', @analyzer.logfile_name
-    end
-
-    def test_longest_request_name
-      assert_equal false, @analyzer.instance_variables.include?('@longest_req')
+    assert_equal expected, @analyzer.db_times_summary
+  end
 
-      request_times = {
-          "ThingsController#view"     => [0],
-          "TeamsController#progress"  => [1],
-          "RssController#uber"        => [0],
-          "PeopleController#progress" => [0],
-          nil                         => [0],
-      }
-
-      @analyzer.instance_variable_set('@request_times', request_times)
-
-      assert_equal 26, @analyzer.longest_request_name
-    end
-
-    def test_pad_request_name
-      assert_equal 26, @analyzer.longest_request_name
-      assert_equal("PeopleController#view:    ",
-                   @analyzer.pad_request_name("PeopleController#view"))
-    end
-
-    def test_pad_request_name_nil
-      assert_equal 26, @analyzer.longest_request_name
-      assert_equal("Unknown:                  ",
-                   @analyzer.pad_request_name(nil))
+  def test_empty_syslog
+    analyzer = Analyzer.new 'test/test.syslog.empty.log'
+    assert_nothing_raised do
+      analyzer.process
+      analyzer.report(1)
     end
-
-    def test_process
-        expected_request_times = {
-            "PeopleController#view"     => [1.102098, 0.36021],
-            "ThingsController#view"     => [0.396183, 0.49176, 1.259728],
-            "TeamsController#progress"  => [1.469788, 0.211973],
-            "RssController#uber"        => [0.034519, 0.034519],
-            "PeopleController#progress" => [0.977398, 0]
-        }
-        assert_equal expected_request_times, @analyzer.request_times
-
-        expected_db_times = {
-            "PeopleController#view"     => [0.486258, 0.189119],
-            "ThingsController#view"     => [0.122158, 0.172767, 0.914192],
-            "TeamsController#progress"  => [1.143577, 0.149357],
-            "RssController#uber"        => [0.007962, 0.007962],
-            "PeopleController#progress" => [0.830409, 0]
-        }
-        assert_equal expected_db_times, @analyzer.db_times
-
-        expected_render_times = {
-            "PeopleController#view"     => [0.695476, 0.277921],
-            "ThingsController#view"     => [0.107987, 0.197126, 0.505973],
-            "TeamsController#progress"  => [0, 0],
-            "RssController#uber"        => [0.01177, 0.01177],
-            "PeopleController#progress" => [0.604444, 0]
-        }
-        assert_equal expected_render_times, @analyzer.render_times
-
-#        expected_query_times = {
-#        }
-#        assert_equal expected_query_times, @analyzer.query_times
+    assert_equal "No requests to analyze", analyzer.report(1)
+  end
+
+  def test_logfile_name
+    assert_equal 'test/test.syslog.log', @analyzer.logfile_name
+  end
+
+  def test_longest_request_name
+    assert_equal false, @analyzer.instance_variables.include?('@longest_req')
+
+    request_times = {
+      "ThingsController#view"     => [0],
+      "TeamsController#progress"  => [1],
+      "RssController#uber"        => [0],
+      "PeopleController#progress" => [0],
+      nil                         => [0],
+    }
+
+    @analyzer.instance_variable_set('@request_times', request_times)
+
+    assert_equal 26, @analyzer.longest_request_name
+  end
+
+  def test_pad_request_name
+    assert_equal 26, @analyzer.longest_request_name
+    assert_equal("PeopleController#view:    ",
+                 @analyzer.pad_request_name("PeopleController#view"))
+  end
+
+  def test_pad_request_name_nil
+    assert_equal 26, @analyzer.longest_request_name
+    assert_equal("Unknown:                  ",
+                 @analyzer.pad_request_name(nil))
+  end
+
+  def test_pad_request_name_short
+    analyzer = Analyzer.new 'test/test.syslog.1.2.shortname.log'
+    analyzer.process
+    longer_request_name_value = " " * (analyzer.longest_request_name + 1)
+    assert_nothing_raised do
+      analyzer.pad_request_name(longer_request_name_value)
     end
-
-    def test_render_time_std_dev
-        assert_in_delta 0.2513925, @analyzer.render_time_std_dev, 0.0000001
-    end
-
-    def test_render_times_summary
-      expected = <<EOF.strip
+    assert_equal longer_request_name_value + ":", analyzer.pad_request_name(longer_request_name_value)
+  end
+
+  def test_process
+    expected_request_times = {
+      "PeopleController#view"     => [1.102098, 0.36021],
+      "ThingsController#view"     => [0.396183, 0.49176, 1.259728],
+      "TeamsController#progress"  => [1.469788, 0.211973],
+      "RssController#uber"        => [0.034519, 0.034519],
+      "PeopleController#progress" => [0.977398, 0]
+    }
+    assert_equal expected_request_times, @analyzer.request_times
+
+    expected_db_times = {
+      "PeopleController#view"     => [0.486258, 0.189119],
+      "ThingsController#view"     => [0.122158, 0.172767, 0.914192],
+      "TeamsController#progress"  => [1.143577, 0.149357],
+      "RssController#uber"        => [0.007962, 0.007962],
+      "PeopleController#progress" => [0.830409, 0]
+    }
+    assert_equal expected_db_times, @analyzer.db_times
+
+    expected_render_times = {
+      "PeopleController#view"     => [0.695476, 0.277921],
+      "ThingsController#view"     => [0.107987, 0.197126, 0.505973],
+      "TeamsController#progress"  => [0, 0],
+      "RssController#uber"        => [0.01177, 0.01177],
+      "PeopleController#progress" => [0.604444, 0]
+    }
+    assert_equal expected_render_times, @analyzer.render_times
+  end
+
+  def test_render_time_std_dev
+    assert_in_delta 0.2513925, @analyzer.render_time_std_dev, 0.0000001
+  end
+
+  def test_render_times_summary
+    expected = <<EOF.strip
 Render Times Summary:     	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.219	0.253	0.000	0.695
 
@@ -273,11 +288,11 @@ PeopleController#progress:	2	0.302	0.302	0.000	0.604
 PeopleController#view:    	2	0.487	0.209	0.278	0.695
 EOF
 
-      assert_equal expected, @analyzer.render_times_summary
-    end
+    assert_equal expected, @analyzer.render_times_summary
+  end
 
-    def test_report
-      expected = <<-EOF
+  def test_report
+    expected = <<-EOF
 Request Times Summary:    	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.576	0.508	0.000	1.470
 
@@ -288,16 +303,16 @@ PeopleController#progress:	2	0.489	0.489	0.000	0.977
 PeopleController#view:    	2	0.731	0.371	0.360	1.102
 
 Slowest Request Times:
-	TeamsController#progress took 1.470s
-	ThingsController#view took 1.260s
-	PeopleController#view took 1.102s
-	PeopleController#progress took 0.977s
-	ThingsController#view took 0.492s
-	ThingsController#view took 0.396s
-	PeopleController#view took 0.360s
-	TeamsController#progress took 0.212s
-	RssController#uber took 0.035s
-	RssController#uber took 0.035s
+\tTeamsController#progress took 1.470s
+\tThingsController#view took 1.260s
+\tPeopleController#view took 1.102s
+\tPeopleController#progress took 0.977s
+\tThingsController#view took 0.492s
+\tThingsController#view took 0.396s
+\tPeopleController#view took 0.360s
+\tTeamsController#progress took 0.212s
+\tRssController#uber took 0.035s
+\tRssController#uber took 0.035s
 
 ------------------------------------------------------------------------
 
@@ -311,16 +326,16 @@ PeopleController#progress:	2	0.415	0.415	0.000	0.830
 PeopleController#view:    	2	0.338	0.149	0.189	0.486
 
 Slowest Total DB Times:
-	TeamsController#progress took 1.144s
-	ThingsController#view took 0.914s
-	PeopleController#progress took 0.830s
-	PeopleController#view took 0.486s
-	PeopleController#view took 0.189s
-	ThingsController#view took 0.173s
-	TeamsController#progress took 0.149s
-	ThingsController#view took 0.122s
-	RssController#uber took 0.008s
-	RssController#uber took 0.008s
+\tTeamsController#progress took 1.144s
+\tThingsController#view took 0.914s
+\tPeopleController#progress took 0.830s
+\tPeopleController#view took 0.486s
+\tPeopleController#view took 0.189s
+\tThingsController#view took 0.173s
+\tTeamsController#progress took 0.149s
+\tThingsController#view took 0.122s
+\tRssController#uber took 0.008s
+\tRssController#uber took 0.008s
 
 ------------------------------------------------------------------------
 
@@ -334,27 +349,27 @@ PeopleController#progress:	2	0.302	0.302	0.000	0.604
 PeopleController#view:    	2	0.487	0.209	0.278	0.695
 
 Slowest Total Render Times:
-	PeopleController#view took 0.695s
-	PeopleController#progress took 0.604s
-	ThingsController#view took 0.506s
-	PeopleController#view took 0.278s
-	ThingsController#view took 0.197s
-	ThingsController#view took 0.108s
-	RssController#uber took 0.012s
-	RssController#uber took 0.012s
-	TeamsController#progress took 0.000s
-	TeamsController#progress took 0.000s
+\tPeopleController#view took 0.695s
+\tPeopleController#progress took 0.604s
+\tThingsController#view took 0.506s
+\tPeopleController#view took 0.278s
+\tThingsController#view took 0.197s
+\tThingsController#view took 0.108s
+\tRssController#uber took 0.012s
+\tRssController#uber took 0.012s
+\tTeamsController#progress took 0.000s
+\tTeamsController#progress took 0.000s
       EOF
 
-      assert_equal expected, @analyzer.report(10)
-    end
+    assert_equal expected, @analyzer.report(10)
+  end
 
-    def test_request_time_std_dev
-        assert_in_delta 0.4975667, @analyzer.request_time_std_dev, 0.0000001
-    end
+  def test_request_time_std_dev
+    assert_in_delta 0.4975667, @analyzer.request_time_std_dev, 0.0000001
+  end
 
-    def test_request_times_summary
-      expected = <<EOF.strip
+  def test_request_times_summary
+    expected = <<EOF.strip
 Request Times Summary:    	Count	Avg	Std Dev	Min	Max
 ALL REQUESTS:             	11	0.576	0.508	0.000	1.470
 
@@ -365,41 +380,41 @@ PeopleController#progress:	2	0.489	0.489	0.000	0.977
 PeopleController#view:    	2	0.731	0.371	0.360	1.102
 EOF
 
-      assert_equal expected, @analyzer.request_times_summary
-    end
-
-    def test_slowest_db_times
-        times = @analyzer.slowest_db_times 3
-        assert_equal 3, times.length
-        expected = [
-            [1.143577, "TeamsController#progress"],
-            [0.914192, "ThingsController#view"],
-            [0.830409, "PeopleController#progress"]
-        ]
-        assert_equal expected, times
-    end
-
-    def test_slowest_request_times
-        times = @analyzer.slowest_request_times 3
-        assert_equal 3, times.length
-        expected = [
-            [1.469788, "TeamsController#progress"],
-            [1.259728, "ThingsController#view"],
-            [1.102098, "PeopleController#view"]
-        ]
-        assert_equal expected, times
-    end
-
-    def test_slowest_render_times
-        times = @analyzer.slowest_render_times 3
-        assert_equal 3, times.length
-        expected = [
-            [0.695476, "PeopleController#view"],
-            [0.604444, "PeopleController#progress"],
-            [0.505973, "ThingsController#view"]
-        ]
-        assert_equal expected, times
-    end
+    assert_equal expected, @analyzer.request_times_summary
+  end
+
+  def test_slowest_db_times
+    times = @analyzer.slowest_db_times 3
+    assert_equal 3, times.length
+    expected = [
+      [1.143577, "TeamsController#progress"],
+      [0.914192, "ThingsController#view"],
+      [0.830409, "PeopleController#progress"]
+    ]
+    assert_equal expected, times
+  end
+
+  def test_slowest_request_times
+    times = @analyzer.slowest_request_times 3
+    assert_equal 3, times.length
+    expected = [
+      [1.469788, "TeamsController#progress"],
+      [1.259728, "ThingsController#view"],
+      [1.102098, "PeopleController#view"]
+    ]
+    assert_equal expected, times
+  end
+
+  def test_slowest_render_times
+    times = @analyzer.slowest_render_times 3
+    assert_equal 3, times.length
+    expected = [
+      [0.695476, "PeopleController#view"],
+      [0.604444, "PeopleController#progress"],
+      [0.505973, "ThingsController#view"]
+    ]
+    assert_equal expected, times
+  end
 
 end