procrastinator 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 355845de0042676644aa4fd14ba5c37bc173b1f0cac9c73889dbb36aa8e5cd9c
-  data.tar.gz: f4faa2e3644557027c8fc08f88c973deb19cf16e43fb3312106d8d25a3c61054
+  metadata.gz: dc44a4968d52be8482c61e47a86cd1773cd160e827f4ac8a6e4ac5fd3bbe6b8f
+  data.tar.gz: 8e3494bfa1a6494f16736c2937a20385cd8231b7615194c8f3b52dbf1d16a4e5
 SHA512:
-  metadata.gz: 3f59116b21f6218d3ef3059e5f5532b1ef23a95e7a5f0b82a1d21a041ff84e64795e2fd7181bd277cba19e6c8fd01fa04146103ec2de9703169e9db7072a817f
-  data.tar.gz: 235b273d6f07e21f492e82083ea89b0f67eb4275233dddbb04d52e25a5a2f3b6a0674e5d0b8dda9b5c43359ea257b081c4d7bf1b7561b4c1a7242f24660b932c
+  metadata.gz: c0644921316f9db7ef0d1d3ee24fab20a5cf458077b16636e42d793387c9f9198e122ca959f113e777b82eb7d61983229f6a3afb09aab0931dce0fa507c6a13b
+  data.tar.gz: 4a2a86a807672c8b9335f1c835f90a80440045b787b75ff51d2e791e2f7075abb50be8e42362419742573ef1b160f262dae6eebb1d73b6377a635f5f805d85eb

data/.rubocop.yml

@@ -1,10 +1,10 @@
-inherit_from: ../.rubocop.yml
+inherit_from: ~/.config/rubocop/config.yml
 
 AllCops:
   Exclude:
     - 'bin/*'
 
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.7
 
 Layout/LineLength:
   Exclude:
@@ -23,4 +23,3 @@ Metrics/BlockLength:
 Metrics/ModuleLength:
   Exclude:
     - 'spec/**/*.rb'
-

data/.ruby-version

@@ -1 +1 @@
-ruby-2.4.2
+ruby-2.7.8

data/Gemfile

@@ -2,5 +2,17 @@
 
 source 'https://rubygems.org'
 
+group :development do
+   gem 'bundler', '~> 2.3'
+   gem 'fakefs', '~> 1.8'
+   gem 'rake', '~> 13.0'
+   gem 'rspec', '~> 3.9'
+   gem 'rubocop', '~> 1.12'
+   gem 'rubocop-performance', '~> 1.10'
+   gem 'simplecov', '~> 0.18.0'
+   gem 'timecop', '~> 0.9'
+   gem 'yard', '~> 0.9'
+end
+
 # Specify your gem's dependencies in procrastinator.gemspec
 gemspec

data/RELEASE_NOTES.md

@@ -1,5 +1,19 @@
 # Release Notes
 
+## 1.2.0 (         )
+
+### Major Changes
+
+* none
+
+### Minor Changes
+
+* Updated minimum ruby to 2.7
+
+### Bugfixes
+
+* When logging is disabled, it points to `File::NULL` instead of a dead-end StringIO
+
 ## 1.1.0 (2022-10-16)
 
 ### Major Changes

data/lib/procrastinator/queue_worker.rb

@@ -13,6 +13,8 @@ module Procrastinator
       # expected methods for all persistence strategies
       PERSISTER_METHODS = [:read, :update, :delete].freeze
 
+      NULL_FILE = File.open(File::NULL, File::WRONLY)
+
       def initialize(queue:, config:)
          raise ArgumentError, ':queue cannot be nil' if queue.nil?
          raise ArgumentError, ':config cannot be nil' if config.nil?
@@ -26,13 +28,13 @@ module Procrastinator
                   end
 
          @scheduler = Scheduler.new(config)
-         @logger    = Logger.new(StringIO.new)
+         @logger    = Logger.new(File::NULL)
       end
 
       # Works on jobs forever
       def work!
          @logger = open_log!("#{ name }-queue-worker", @config)
-         @logger.info("Started worker thread to consume queue: #{ name }")
+         @logger.info "Started worker thread to consume queue: #{ name }"
 
          loop do
             sleep(@queue.update_period)
@@ -72,12 +74,14 @@ module Procrastinator
 
       # Starts a log file and returns the created Logger
       def open_log!(name, config)
-         return @logger unless config.log_level
-
-         log_path = config.log_dir / "#{ name }.log"
+         if config.log_level
+            log_path = config.log_dir / "#{ name }.log"
 
-         config.log_dir.mkpath
-         FileUtils.touch(log_path)
+            config.log_dir.mkpath
+            FileUtils.touch(log_path)
+         else
+            log_path = NULL_FILE
+         end
 
          Logger.new(log_path.to_path,
                     config.log_shift_age, config.log_shift_size,
@@ -90,6 +94,6 @@ module Procrastinator
    # Raised when a Task Storage strategy is missing a required part of the API.
    #
    # @see TaskStore
-   class MalformedTaskPersisterError < StandardError
+   class MalformedTaskPersisterError < RuntimeError
    end
 end

data/lib/procrastinator/version.rb

@@ -2,5 +2,5 @@
 
 module Procrastinator
    # Version number of this release
-   VERSION = '1.1.0'
+   VERSION = '1.2.0'
 end

data/procrastinator.gemspec

@@ -23,15 +23,5 @@ Gem::Specification.new do |spec|
    spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
    spec.require_paths = ['lib']
 
-   spec.required_ruby_version = '>= 2.4'
-
-   spec.add_development_dependency 'bundler', '~> 2.3'
-   spec.add_development_dependency 'fakefs', '~> 1.8'
-   spec.add_development_dependency 'rake', '~> 13.0'
-   spec.add_development_dependency 'rspec', '~> 3.9'
-   spec.add_development_dependency 'rubocop', '~> 1.12'
-   spec.add_development_dependency 'rubocop-performance', '~> 1.10'
-   spec.add_development_dependency 'simplecov', '~> 0.18.0'
-   spec.add_development_dependency 'timecop', '~> 0.9'
-   spec.add_development_dependency 'yard', '~> 0.9'
+   spec.required_ruby_version = '>= 2.7'
 end

metadata

@@ -1,141 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: procrastinator
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Robin Miller
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-10-16 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
-- !ruby/object:Gem::Dependency
-  name: fakefs
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.12'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.12'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.10'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.18.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.18.0
-- !ruby/object:Gem::Dependency
-  name: timecop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
+date: 2023-06-17 00:00:00.000000000 Z
+dependencies: []
 description: A flexible pure Ruby job queue. Tasks are reschedulable after failures.
 email:
 - robin@tenjin.ca
@@ -184,14 +58,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.4.10
 signing_key: 
 specification_version: 4
 summary: For apps to put off work until later